[LTP] [PATCH] acct02: make explicit kernel config requirement

[LTP] [PATCH] acct02: make explicit kernel config requirement

[Po-Hsu Lin]

With commit eeed458492cc ("lib/tst_kconfig: Validate variables"), the
kernel config check is now more strict.

In this acct02 test, it will fail on an ARM64 system running with
Ubuntu Bionic 4.15 kernel:
  tag=acct02 stime=1605709219 dur=0 exit=exited stat=2 core=no cu=0 cs=0
  startup='Wed Nov 18 14:20:19 2020'
  CONFIG_BSD_PROCESS_ACCT
  ^
  Missing value

  tst_kconfig.c:475: TBROK: Invalid kconfig variables!

While the kernel config shows:
  $ grep CONFIG_BSD_PROCESS_ACCT /boot/config-4.15.0-1087-aws
  CONFIG_BSD_PROCESS_ACCT=y
  CONFIG_BSD_PROCESS_ACCT_V3=y

Change the kernel config requirement to CONFIG_BSD_PROCESS_ACCT=y
to solve this issue.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 testcases/kernel/syscalls/acct/acct02.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/acct/acct02.c b/testcases/kernel/syscalls/acct/acct02.c
index fbcde0bcb..bd0427848 100644
--- a/testcases/kernel/syscalls/acct/acct02.c
+++ b/testcases/kernel/syscalls/acct/acct02.c
@@ -255,7 +255,7 @@ static void cleanup(void)
 }
 
 static const char *kconfigs[] = {
-	"CONFIG_BSD_PROCESS_ACCT",
+	"CONFIG_BSD_PROCESS_ACCT=y",
 	NULL
 };
 
-- 
2.25.1

[LTP] [PATCH] acct02: make explicit kernel config requirement

[Cyril Hrubis]

Hi!
> With commit eeed458492cc ("lib/tst_kconfig: Validate variables"), the
> kernel config check is now more strict.
> 
> In this acct02 test, it will fail on an ARM64 system running with
> Ubuntu Bionic 4.15 kernel:
>   tag=acct02 stime=1605709219 dur=0 exit=exited stat=2 core=no cu=0 cs=0
>   startup='Wed Nov 18 14:20:19 2020'
>   CONFIG_BSD_PROCESS_ACCT
>   ^
>   Missing value
> 
>   tst_kconfig.c:475: TBROK: Invalid kconfig variables!

Sigh, I will fix this so that we can have config variables without
values again.

> While the kernel config shows:
>   $ grep CONFIG_BSD_PROCESS_ACCT /boot/config-4.15.0-1087-aws
>   CONFIG_BSD_PROCESS_ACCT=y
>   CONFIG_BSD_PROCESS_ACCT_V3=y
> 
> Change the kernel config requirement to CONFIG_BSD_PROCESS_ACCT=y
> to solve this issue.

But I guess that we should change the kconfig into:

"CONFIG_BSD_PROCESS_ACCT | CONFIG_BSD_PROCESS_ACCT_V3"

> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  testcases/kernel/syscalls/acct/acct02.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/acct/acct02.c b/testcases/kernel/syscalls/acct/acct02.c
> index fbcde0bcb..bd0427848 100644
> --- a/testcases/kernel/syscalls/acct/acct02.c
> +++ b/testcases/kernel/syscalls/acct/acct02.c
> @@ -255,7 +255,7 @@ static void cleanup(void)
>  }
>  
>  static const char *kconfigs[] = {
> -	"CONFIG_BSD_PROCESS_ACCT",
> +	"CONFIG_BSD_PROCESS_ACCT=y",
>  	NULL
>  };
>  
> -- 
> 2.25.1
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] [PATCH] acct02: make explicit kernel config requirement

[Po-Hsu Lin]

On Thu, Nov 19, 2020 at 6:37 PM Cyril Hrubis <chrubis@suse.cz> wrote:
>
> Hi!
> > With commit eeed458492cc ("lib/tst_kconfig: Validate variables"), the
> > kernel config check is now more strict.
> >
> > In this acct02 test, it will fail on an ARM64 system running with
> > Ubuntu Bionic 4.15 kernel:
> >   tag=acct02 stime=1605709219 dur=0 exit=exited stat=2 core=no cu=0 cs=0
> >   startup='Wed Nov 18 14:20:19 2020'
> >   CONFIG_BSD_PROCESS_ACCT
> >   ^
> >   Missing value
> >
> >   tst_kconfig.c:475: TBROK: Invalid kconfig variables!
>
> Sigh, I will fix this so that we can have config variables without
> values again.
>
> > While the kernel config shows:
> >   $ grep CONFIG_BSD_PROCESS_ACCT /boot/config-4.15.0-1087-aws
> >   CONFIG_BSD_PROCESS_ACCT=y
> >   CONFIG_BSD_PROCESS_ACCT_V3=y
> >
> > Change the kernel config requirement to CONFIG_BSD_PROCESS_ACCT=y
> > to solve this issue.
>
> But I guess that we should change the kconfig into:
>
> "CONFIG_BSD_PROCESS_ACCT | CONFIG_BSD_PROCESS_ACCT_V3"

Hello,
from the help text it says:
"If you say Y here, the process accounting information is written in a
new file format that also logs the process IDs of each process and its
parent. Note that this file format is incompatible with previous
v0/v1/v2 file formats, so you will need updated tools for processing
it."

I am not sure if this test can work with a kernel that just has
CONFIG_BSD_PROCESS_ACCT_V3 enabled.
Thanks

>
> > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> > ---
> >  testcases/kernel/syscalls/acct/acct02.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/testcases/kernel/syscalls/acct/acct02.c b/testcases/kernel/syscalls/acct/acct02.c
> > index fbcde0bcb..bd0427848 100644
> > --- a/testcases/kernel/syscalls/acct/acct02.c
> > +++ b/testcases/kernel/syscalls/acct/acct02.c
> > @@ -255,7 +255,7 @@ static void cleanup(void)
> >  }
> >
> >  static const char *kconfigs[] = {
> > -     "CONFIG_BSD_PROCESS_ACCT",
> > +     "CONFIG_BSD_PROCESS_ACCT=y",
> >       NULL
> >  };
> >
> > --
> > 2.25.1
> >
> >
> > --
> > Mailing list info: https://lists.linux.it/listinfo/ltp
>
> --
> Cyril Hrubis
> chrubis@suse.cz

[LTP] [PATCH] acct02: make explicit kernel config requirement

[Cyril Hrubis]

Hi!
> from the help text it says:
> "If you say Y here, the process accounting information is written in a
> new file format that also logs the process IDs of each process and its
> parent. Note that this file format is incompatible with previous
> v0/v1/v2 file formats, so you will need updated tools for processing
> it."
> 
> I am not sure if this test can work with a kernel that just has
> CONFIG_BSD_PROCESS_ACCT_V3 enabled.

Ah, that's right, the CONFIG_BSD_PROCESS_ACCT has to be on and the *_V3
is enabled if the format is V3.

So everything is fine and sorry for breaking the test with buggy
validation code.

-- 
Cyril Hrubis
chrubis@suse.cz