All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package
@ 2020-11-19 22:01 Angelo Compagnucci
  2020-11-19 22:01 ` [Buildroot] [PATCH v2 2/3] package/qt5/qt5mqtt: " Angelo Compagnucci
                   ` (3 more replies)
  0 siblings, 4 replies; 7+ messages in thread
From: Angelo Compagnucci @ 2020-11-19 22:01 UTC (permalink / raw)
  To: buildroot

The Qt CoAP module implements the client side of CoAP defined by RFC
7252.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changelog
v1 -> v2:
 fixed hash file (suggested by Peter)
 
 DEVELOPERS                       |  1 +
 package/qt5/Config.in            |  1 +
 package/qt5/qt5coap/Config.in    | 11 +++++++++++
 package/qt5/qt5coap/qt5coap.hash |  6 ++++++
 package/qt5/qt5coap/qt5coap.mk   | 19 +++++++++++++++++++
 5 files changed, 38 insertions(+)
 create mode 100644 package/qt5/qt5coap/Config.in
 create mode 100644 package/qt5/qt5coap/qt5coap.hash
 create mode 100644 package/qt5/qt5coap/qt5coap.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 9ab1e125f4..3f5fa20ebc 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -169,6 +169,7 @@ F:	package/python-pillow/
 F:	package/python-pydal/
 F:	package/python-spidev/
 F:	package/python-web2py/
+F:	package/qt5/qt5coap/
 F:	package/sam-ba/
 F:	package/sshguard/
 F:	package/sunwait/
diff --git a/package/qt5/Config.in b/package/qt5/Config.in
index fc0e68e8b7..9431f4980d 100644
--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -40,6 +40,7 @@ if BR2_PACKAGE_QT5
 source "package/qt5/qt53d/Config.in"
 source "package/qt5/qt5base/Config.in"
 source "package/qt5/qt5charts/Config.in"
+source "package/qt5/qt5coap/Config.in"
 source "package/qt5/qt5connectivity/Config.in"
 source "package/qt5/qt5declarative/Config.in"
 source "package/qt5/qt5enginio/Config.in"
diff --git a/package/qt5/qt5coap/Config.in b/package/qt5/qt5coap/Config.in
new file mode 100644
index 0000000000..b5bed342a9
--- /dev/null
+++ b/package/qt5/qt5coap/Config.in
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_QT5COAP
+	bool "qt5coap"
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  CoAP is a protocol for IoT devices, and machine to machine
+	  communication. The Qt CoAP module implements the client side
+	  of CoAP defined by RFC 7252.
+
+	  https://doc.qt.io/QtCoAP/qtcoap-index.html
diff --git a/package/qt5/qt5coap/qt5coap.hash b/package/qt5/qt5coap/qt5coap.hash
new file mode 100644
index 0000000000..3f3390ebd4
--- /dev/null
+++ b/package/qt5/qt5coap/qt5coap.hash
@@ -0,0 +1,6 @@
+# Hash locally calculated
+sha256  f2addd89e94fb3945fc6ee6db795b0736cd3396760b31e04c01cd02558c53e07  qt5coap-5.15.1.tar.gz
+
+# Hashes for license files:
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256  f827ad079686ba92cc94811e35492d0e8966f704008b6da9eeda0b659fb58a8d LICENSE.FDL
diff --git a/package/qt5/qt5coap/qt5coap.mk b/package/qt5/qt5coap/qt5coap.mk
new file mode 100644
index 0000000000..210cebf13a
--- /dev/null
+++ b/package/qt5/qt5coap/qt5coap.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# qt5coap
+#
+################################################################################
+
+QT5COAP_VERSION = $(QT5_VERSION)
+QT5COAP_SITE = $(call github,qt,qtcoap,v$(QT5_VERSION))
+QT5COAP_INSTALL_STAGING = YES
+QT5COAP_LICENSE = GPL-3.0, GFDL-1.3
+QT5COAP_LICENSE_FILES = LICENSE.GPL3 LICENSE.FDL
+QT5COAP_DEPENDENCIES = host-perl
+
+define QT5COAP_FIX_INCLUDE
+	cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtCoap -version $(QT5_VERSION)
+endef
+QT5COAP_PRE_CONFIGURE_HOOKS = QT5COAP_FIX_INCLUDE
+
+$(eval $(qmake-package))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 2/3] package/qt5/qt5mqtt: new package
  2020-11-19 22:01 [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
@ 2020-11-19 22:01 ` Angelo Compagnucci
  2020-11-19 22:01 ` [Buildroot] [PATCH v2 3/3] package/qt5/qt5knx: " Angelo Compagnucci
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Angelo Compagnucci @ 2020-11-19 22:01 UTC (permalink / raw)
  To: buildroot

The Qt MQTT module provides a standard compliant implementation of the
MQTT protocol specification.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changelog
v1 -> v2:
 fixed hash file (suggested by Peter)

 DEVELOPERS                       |  1 +
 package/qt5/Config.in            |  1 +
 package/qt5/qt5mqtt/Config.in    | 12 ++++++++++++
 package/qt5/qt5mqtt/qt5mqtt.hash |  6 ++++++
 package/qt5/qt5mqtt/qt5mqtt.mk   | 19 +++++++++++++++++++
 5 files changed, 39 insertions(+)
 create mode 100644 package/qt5/qt5mqtt/Config.in
 create mode 100644 package/qt5/qt5mqtt/qt5mqtt.hash
 create mode 100644 package/qt5/qt5mqtt/qt5mqtt.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 3f5fa20ebc..d45e584709 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -170,6 +170,7 @@ F:	package/python-pydal/
 F:	package/python-spidev/
 F:	package/python-web2py/
 F:	package/qt5/qt5coap/
+F:	package/qt5/qt5mqtt/
 F:	package/sam-ba/
 F:	package/sshguard/
 F:	package/sunwait/
diff --git a/package/qt5/Config.in b/package/qt5/Config.in
index 9431f4980d..c15d27ba7c 100644
--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -48,6 +48,7 @@ source "package/qt5/qt5graphicaleffects/Config.in"
 source "package/qt5/qt5imageformats/Config.in"
 source "package/qt5/qt5location/Config.in"
 source "package/qt5/qt5lottie/Config.in"
+source "package/qt5/qt5mqtt/Config.in"
 source "package/qt5/qt5multimedia/Config.in"
 source "package/qt5/qt5quickcontrols/Config.in"
 source "package/qt5/qt5quickcontrols2/Config.in"
diff --git a/package/qt5/qt5mqtt/Config.in b/package/qt5/qt5mqtt/Config.in
new file mode 100644
index 0000000000..509b18089d
--- /dev/null
+++ b/package/qt5/qt5mqtt/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_QT5MQTT
+	bool "qt5mqtt"
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  The Qt MQTT module provides a standard compliant implementation
+	  of the MQTT protocol specification. It enables applications to
+	  act as telemetry displays and devices to publish telemetry data.
+	  The supported versions are MQTT 3.1, MQTT 3.1.1, and MQTT 5.0.
+
+	  https://doc.qt.io/QtMQTT/index.html
diff --git a/package/qt5/qt5mqtt/qt5mqtt.hash b/package/qt5/qt5mqtt/qt5mqtt.hash
new file mode 100644
index 0000000000..9d7ec5082e
--- /dev/null
+++ b/package/qt5/qt5mqtt/qt5mqtt.hash
@@ -0,0 +1,6 @@
+# Hash locally calculated
+sha256  603f81095ec837cb28b93189fd26dbbae32ecaedd80f6dd88c85050b51e18008  qt5mqtt-5.15.1.tar.gz
+
+# Hashes for license files:
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256  0dbe024961f6ab5c52689cbd036c977975d0d0f6a67ff97762d96cb819dd5652 LICENSE.GPL3-EXCEPT
diff --git a/package/qt5/qt5mqtt/qt5mqtt.mk b/package/qt5/qt5mqtt/qt5mqtt.mk
new file mode 100644
index 0000000000..2e0093df3a
--- /dev/null
+++ b/package/qt5/qt5mqtt/qt5mqtt.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# qt5mqtt
+#
+################################################################################
+
+QT5MQTT_VERSION = $(QT5_VERSION)
+QT5MQTT_SITE = $(call github,qt,qtmqtt,v$(QT5_VERSION))
+QT5MQTT_INSTALL_STAGING = YES
+QT5MQTT_LICENSE = GPL-3.0 with exception
+QT5MQTT_LICENSE_FILES = LICENSE.GPL3 LICENSE.GPL3-EXCEPT
+QT5MQTT_DEPENDENCIES = host-perl
+
+define QT5MQTT_FIX_INCLUDE
+	cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtMqtt -version $(QT5_VERSION)
+endef
+QT5MQTT_PRE_CONFIGURE_HOOKS = QT5MQTT_FIX_INCLUDE
+
+$(eval $(qmake-package))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 3/3] package/qt5/qt5knx: new package
  2020-11-19 22:01 [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
  2020-11-19 22:01 ` [Buildroot] [PATCH v2 2/3] package/qt5/qt5mqtt: " Angelo Compagnucci
@ 2020-11-19 22:01 ` Angelo Compagnucci
  2020-11-19 22:11 ` [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: " Thomas Petazzoni
  2020-11-19 22:25 ` Peter Seiderer
  3 siblings, 0 replies; 7+ messages in thread
From: Angelo Compagnucci @ 2020-11-19 22:01 UTC (permalink / raw)
  To: buildroot

The Qt KNX module implements the client side of a connection between a
client and a KNXnet/IP server.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Changelog
v1 -> v2:
 fixed hash file (suggested by Peter)

 DEVELOPERS                     |  1 +
 package/qt5/Config.in          |  1 +
 package/qt5/qt5knx/Config.in   | 12 ++++++++++++
 package/qt5/qt5knx/qt5knx.hash |  6 ++++++
 package/qt5/qt5knx/qt5knx.mk   | 19 +++++++++++++++++++
 5 files changed, 39 insertions(+)
 create mode 100644 package/qt5/qt5knx/Config.in
 create mode 100644 package/qt5/qt5knx/qt5knx.hash
 create mode 100644 package/qt5/qt5knx/qt5knx.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index d45e584709..9fadedb4de 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -170,6 +170,7 @@ F:	package/python-pydal/
 F:	package/python-spidev/
 F:	package/python-web2py/
 F:	package/qt5/qt5coap/
+F:	package/qt5/qt5knx/
 F:	package/qt5/qt5mqtt/
 F:	package/sam-ba/
 F:	package/sshguard/
diff --git a/package/qt5/Config.in b/package/qt5/Config.in
index c15d27ba7c..6714c6271d 100644
--- a/package/qt5/Config.in
+++ b/package/qt5/Config.in
@@ -46,6 +46,7 @@ source "package/qt5/qt5declarative/Config.in"
 source "package/qt5/qt5enginio/Config.in"
 source "package/qt5/qt5graphicaleffects/Config.in"
 source "package/qt5/qt5imageformats/Config.in"
+source "package/qt5/qt5knx/Config.in"
 source "package/qt5/qt5location/Config.in"
 source "package/qt5/qt5lottie/Config.in"
 source "package/qt5/qt5mqtt/Config.in"
diff --git a/package/qt5/qt5knx/Config.in b/package/qt5/qt5knx/Config.in
new file mode 100644
index 0000000000..991e93c8cb
--- /dev/null
+++ b/package/qt5/qt5knx/Config.in
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_QT5KNX
+	bool "qt5knx"
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  The Qt KNX module implements the client side of a connection
+	  between a client and a KNXnet/IP server. This connection
+	  can be used to send messages to the KNX bus and to control
+	  the functionalities of the KNX devices.
+
+	  https://doc.qt.io/QtKNX/index.html
diff --git a/package/qt5/qt5knx/qt5knx.hash b/package/qt5/qt5knx/qt5knx.hash
new file mode 100644
index 0000000000..dce7a36870
--- /dev/null
+++ b/package/qt5/qt5knx/qt5knx.hash
@@ -0,0 +1,6 @@
+# Hash locally calculated
+sha256  8ee0df130fad39ef6b9a0bef390b648d3ad6539ffca33e22fb569e889d0bd043  qt5knx-5.15.1.tar.gz
+
+# Hashes for license files:
+sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
+sha256  f827ad079686ba92cc94811e35492d0e8966f704008b6da9eeda0b659fb58a8d LICENSE.FDL
diff --git a/package/qt5/qt5knx/qt5knx.mk b/package/qt5/qt5knx/qt5knx.mk
new file mode 100644
index 0000000000..57cfaa1175
--- /dev/null
+++ b/package/qt5/qt5knx/qt5knx.mk
@@ -0,0 +1,19 @@
+################################################################################
+#
+# qt5knx
+#
+################################################################################
+
+QT5KNX_VERSION = $(QT5_VERSION)
+QT5KNX_SITE = $(call github,qt,qtknx,v$(QT5_VERSION))
+QT5KNX_INSTALL_STAGING = YES
+QT5KNX_LICENSE = GPL-3.0 with exception
+QT5KNX_LICENSE_FILES = LICENSE.GPL3 LICENSE.GPL3-EXCEPT
+QT5KNX_DEPENDENCIES = host-perl
+
+define QT5KNX_FIX_INCLUDE
+	cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtKnx -version $(QT5_VERSION)
+endef
+QT5KNX_PRE_CONFIGURE_HOOKS = QT5KNX_FIX_INCLUDE
+
+$(eval $(qmake-package))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package
  2020-11-19 22:01 [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
  2020-11-19 22:01 ` [Buildroot] [PATCH v2 2/3] package/qt5/qt5mqtt: " Angelo Compagnucci
  2020-11-19 22:01 ` [Buildroot] [PATCH v2 3/3] package/qt5/qt5knx: " Angelo Compagnucci
@ 2020-11-19 22:11 ` Thomas Petazzoni
  2020-11-20  9:36   ` Angelo Compagnucci
  2020-11-19 22:25 ` Peter Seiderer
  3 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2020-11-19 22:11 UTC (permalink / raw)
  To: buildroot

Hello Angelo,

Thanks a lot those three packages, they obviously look good. I only have one question.

On Thu, 19 Nov 2020 23:01:40 +0100
Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> +QT5COAP_VERSION = $(QT5_VERSION)
> +QT5COAP_SITE = $(call github,qt,qtcoap,v$(QT5_VERSION))
> +QT5COAP_INSTALL_STAGING = YES
> +QT5COAP_LICENSE = GPL-3.0, GFDL-1.3
> +QT5COAP_LICENSE_FILES = LICENSE.GPL3 LICENSE.FDL
> +QT5COAP_DEPENDENCIES = host-perl
> +
> +define QT5COAP_FIX_INCLUDE
> +	cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtCoap -version $(QT5_VERSION)
> +endef

Why is this syncqt.pl invocation needed for those 3 packages? What
makes them different from the other Qt5 packages we have?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package
  2020-11-19 22:01 [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
                   ` (2 preceding siblings ...)
  2020-11-19 22:11 ` [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: " Thomas Petazzoni
@ 2020-11-19 22:25 ` Peter Seiderer
  3 siblings, 0 replies; 7+ messages in thread
From: Peter Seiderer @ 2020-11-19 22:25 UTC (permalink / raw)
  To: buildroot

Hello Angelo,

On Thu, 19 Nov 2020 23:01:40 +0100, Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> The Qt CoAP module implements the client side of CoAP defined by RFC
> 7252.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> Changelog
> v1 -> v2:
>  fixed hash file (suggested by Peter)
>
>  DEVELOPERS                       |  1 +
>  package/qt5/Config.in            |  1 +
>  package/qt5/qt5coap/Config.in    | 11 +++++++++++
>  package/qt5/qt5coap/qt5coap.hash |  6 ++++++
>  package/qt5/qt5coap/qt5coap.mk   | 19 +++++++++++++++++++
>  5 files changed, 38 insertions(+)
>  create mode 100644 package/qt5/qt5coap/Config.in
>  create mode 100644 package/qt5/qt5coap/qt5coap.hash
>  create mode 100644 package/qt5/qt5coap/qt5coap.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9ab1e125f4..3f5fa20ebc 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -169,6 +169,7 @@ F:	package/python-pillow/
>  F:	package/python-pydal/
>  F:	package/python-spidev/
>  F:	package/python-web2py/
> +F:	package/qt5/qt5coap/
>  F:	package/sam-ba/
>  F:	package/sshguard/
>  F:	package/sunwait/
> diff --git a/package/qt5/Config.in b/package/qt5/Config.in
> index fc0e68e8b7..9431f4980d 100644
> --- a/package/qt5/Config.in
> +++ b/package/qt5/Config.in
> @@ -40,6 +40,7 @@ if BR2_PACKAGE_QT5
>  source "package/qt5/qt53d/Config.in"
>  source "package/qt5/qt5base/Config.in"
>  source "package/qt5/qt5charts/Config.in"
> +source "package/qt5/qt5coap/Config.in"
>  source "package/qt5/qt5connectivity/Config.in"
>  source "package/qt5/qt5declarative/Config.in"
>  source "package/qt5/qt5enginio/Config.in"
> diff --git a/package/qt5/qt5coap/Config.in b/package/qt5/qt5coap/Config.in
> new file mode 100644
> index 0000000000..b5bed342a9
> --- /dev/null
> +++ b/package/qt5/qt5coap/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_QT5COAP
> +	bool "qt5coap"
> +	help
> +	  Qt is a cross-platform application and UI framework for
> +	  developers using C++.
> +
> +	  CoAP is a protocol for IoT devices, and machine to machine
> +	  communication. The Qt CoAP module implements the client side
> +	  of CoAP defined by RFC 7252.
> +
> +	  https://doc.qt.io/QtCoAP/qtcoap-index.html
> diff --git a/package/qt5/qt5coap/qt5coap.hash b/package/qt5/qt5coap/qt5coap.hash
> new file mode 100644
> index 0000000000..3f3390ebd4
> --- /dev/null
> +++ b/package/qt5/qt5coap/qt5coap.hash
> @@ -0,0 +1,6 @@
> +# Hash locally calculated
> +sha256  f2addd89e94fb3945fc6ee6db795b0736cd3396760b31e04c01cd02558c53e07  qt5coap-5.15.1.tar.gz
> +
> +# Hashes for license files:
> +sha256  8ceb4b9ee5adedde47b31e975c1d90c73ad27b6b165a1dcd80c7c545eb65b903 LICENSE.GPL3
> +sha256  f827ad079686ba92cc94811e35492d0e8966f704008b6da9eeda0b659fb58a8d LICENSE.FDL

---------^ o.k.
---------------------------------------------------------------------------^ not o.k. should be two spaces

Regards,
Peter

> diff --git a/package/qt5/qt5coap/qt5coap.mk b/package/qt5/qt5coap/qt5coap.mk
> new file mode 100644
> index 0000000000..210cebf13a
> --- /dev/null
> +++ b/package/qt5/qt5coap/qt5coap.mk
> @@ -0,0 +1,19 @@
> +################################################################################
> +#
> +# qt5coap
> +#
> +################################################################################
> +
> +QT5COAP_VERSION = $(QT5_VERSION)
> +QT5COAP_SITE = $(call github,qt,qtcoap,v$(QT5_VERSION))
> +QT5COAP_INSTALL_STAGING = YES
> +QT5COAP_LICENSE = GPL-3.0, GFDL-1.3
> +QT5COAP_LICENSE_FILES = LICENSE.GPL3 LICENSE.FDL
> +QT5COAP_DEPENDENCIES = host-perl
> +
> +define QT5COAP_FIX_INCLUDE
> +	cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtCoap -version $(QT5_VERSION)
> +endef
> +QT5COAP_PRE_CONFIGURE_HOOKS = QT5COAP_FIX_INCLUDE
> +
> +$(eval $(qmake-package))

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package
  2020-11-19 22:11 ` [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: " Thomas Petazzoni
@ 2020-11-20  9:36   ` Angelo Compagnucci
  2020-11-21 21:25     ` Peter Seiderer
  0 siblings, 1 reply; 7+ messages in thread
From: Angelo Compagnucci @ 2020-11-20  9:36 UTC (permalink / raw)
  To: buildroot

On Thu, Nov 19, 2020 at 11:11 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Angelo,
>
> Thanks a lot those three packages, they obviously look good. I only have one question.
>
> On Thu, 19 Nov 2020 23:01:40 +0100
> Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
>
> > +QT5COAP_VERSION = $(QT5_VERSION)
> > +QT5COAP_SITE = $(call github,qt,qtcoap,v$(QT5_VERSION))
> > +QT5COAP_INSTALL_STAGING = YES
> > +QT5COAP_LICENSE = GPL-3.0, GFDL-1.3
> > +QT5COAP_LICENSE_FILES = LICENSE.GPL3 LICENSE.FDL
> > +QT5COAP_DEPENDENCIES = host-perl
> > +
> > +define QT5COAP_FIX_INCLUDE
> > +     cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtCoap -version $(QT5_VERSION)
> > +endef
>
> Why is this syncqt.pl invocation needed for those 3 packages? What
> makes them different from the other Qt5 packages we have?

If you open one of the other packages, you can find the "include"
directory already populated, instead when compiling from source the
folder is missing. qmake runs syncqt.pl automatically when you run
qmake from a cloned repo (when there is a .git folder). This is the
way the qt everywhere source packages are built.
Buildroot removes the .git folder and so the script isn't triggered. I
had to choose if adding a fake .git directory or call the script
manually, I choose the latter because I think it's more clear.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com



-- 

Angelo Compagnucci
Amarula Solutions SRL
Embedded Linux Developer
Via Le Canevare 30 31100 Treviso IT
T. +390422435310
[`as] https://www.amarulasolutions.com|

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package
  2020-11-20  9:36   ` Angelo Compagnucci
@ 2020-11-21 21:25     ` Peter Seiderer
  0 siblings, 0 replies; 7+ messages in thread
From: Peter Seiderer @ 2020-11-21 21:25 UTC (permalink / raw)
  To: buildroot

Hello Angelo,

On Fri, 20 Nov 2020 10:36:37 +0100, Angelo Compagnucci <angelo@amarulasolutions.com> wrote:

> On Thu, Nov 19, 2020 at 11:11 PM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > Hello Angelo,
> >
> > Thanks a lot those three packages, they obviously look good. I only have one question.
> >
> > On Thu, 19 Nov 2020 23:01:40 +0100
> > Angelo Compagnucci <angelo@amarulasolutions.com> wrote:
> >
> > > +QT5COAP_VERSION = $(QT5_VERSION)
> > > +QT5COAP_SITE = $(call github,qt,qtcoap,v$(QT5_VERSION))
> > > +QT5COAP_INSTALL_STAGING = YES
> > > +QT5COAP_LICENSE = GPL-3.0, GFDL-1.3
> > > +QT5COAP_LICENSE_FILES = LICENSE.GPL3 LICENSE.FDL
> > > +QT5COAP_DEPENDENCIES = host-perl
> > > +
> > > +define QT5COAP_FIX_INCLUDE
> > > +     cd $(@D); $(HOST_DIR)/bin/syncqt.pl -module QtCoap -version $(QT5_VERSION)
> > > +endef
> >
> > Why is this syncqt.pl invocation needed for those 3 packages? What
> > makes them different from the other Qt5 packages we have?
>
> If you open one of the other packages, you can find the "include"
> directory already populated, instead when compiling from source the
> folder is missing. qmake runs syncqt.pl automatically when you run
> qmake from a cloned repo (when there is a .git folder). This is the
> way the qt everywhere source packages are built.
> Buildroot removes the .git folder and so the script isn't triggered. I
> had to choose if adding a fake .git directory or call the script
> manually, I choose the latter because I think it's more clear.

Thanks for the detailed explanation (I can confirm the build failure without
the syncqt.pl call), maybe worth a short comment, e.g.:

	# needed for build from sources from git (but without .git directory)

and/or enhancement of the commit message?

Regards,
Peter

>
> >
> > Thanks!
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
>
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-11-21 21:25 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19 22:01 [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: new package Angelo Compagnucci
2020-11-19 22:01 ` [Buildroot] [PATCH v2 2/3] package/qt5/qt5mqtt: " Angelo Compagnucci
2020-11-19 22:01 ` [Buildroot] [PATCH v2 3/3] package/qt5/qt5knx: " Angelo Compagnucci
2020-11-19 22:11 ` [Buildroot] [PATCH v2 1/3] package/qt5/qt5coap: " Thomas Petazzoni
2020-11-20  9:36   ` Angelo Compagnucci
2020-11-21 21:25     ` Peter Seiderer
2020-11-19 22:25 ` Peter Seiderer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.