[linux-next:master 1206/7024] drivers/scsi/lpfc/lpfc_sli.c:10459:21: warning: variable 'vport' set but not used

* [linux-next:master 1206/7024] drivers/scsi/lpfc/lpfc_sli.c:10459:21: warning: variable 'vport' set but not used
@ 2020-11-19 14:36 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-11-19 14:36 UTC (permalink / raw)
  To: James Smart
  Cc: kbuild-all, Linux Memory Management List, Martin K. Petersen,
	Dick Kennedy

[-- Attachment #1: Type: text/plain, Size: 5524 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   f8550c0d35df3d027724b250a8c5888dfb2fa749
commit: e7dab164a9aa457f89d4528452bdfc3e15ac98b6 [1206/7024] scsi: lpfc: Fix scheduling call while in softirq context in lpfc_unreg_rpi
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=e7dab164a9aa457f89d4528452bdfc3e15ac98b6
        git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
        git fetch --no-tags linux-next master
        git checkout e7dab164a9aa457f89d4528452bdfc3e15ac98b6
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_abts_err_handler':
>> drivers/scsi/lpfc/lpfc_sli.c:10459:21: warning: variable 'vport' set but not used [-Wunused-but-set-variable]
   10459 |  struct lpfc_vport *vport;
         |                     ^~~~~

vim +/vport +10459 drivers/scsi/lpfc/lpfc_sli.c

cb69f7decc37778 James Smart 2011-12-13  10443  
cb69f7decc37778 James Smart 2011-12-13  10444  /* lpfc_sli4_abts_err_handler - handle a failed ABTS request from an SLI4 port.
cb69f7decc37778 James Smart 2011-12-13  10445   * @phba: pointer to HBA context object.
cb69f7decc37778 James Smart 2011-12-13  10446   * @ndlp: nodelist pointer for the impacted rport.
cb69f7decc37778 James Smart 2011-12-13  10447   * @axri: pointer to the wcqe containing the failed exchange.
cb69f7decc37778 James Smart 2011-12-13  10448   *
cb69f7decc37778 James Smart 2011-12-13  10449   * The driver calls this routine when it receives an ABORT_XRI_FCP CQE from the
cb69f7decc37778 James Smart 2011-12-13  10450   * port.  The port generates this event when an abort exchange request to an
cb69f7decc37778 James Smart 2011-12-13  10451   * rport fails twice in succession with no reply.  The abort could be originated
cb69f7decc37778 James Smart 2011-12-13  10452   * by the driver or by the port.  The ABTS could have been for an ELS or FCP IO.
cb69f7decc37778 James Smart 2011-12-13  10453   */
cb69f7decc37778 James Smart 2011-12-13  10454  void
cb69f7decc37778 James Smart 2011-12-13  10455  lpfc_sli4_abts_err_handler(struct lpfc_hba *phba,
cb69f7decc37778 James Smart 2011-12-13  10456  			   struct lpfc_nodelist *ndlp,
cb69f7decc37778 James Smart 2011-12-13  10457  			   struct sli4_wcqe_xri_aborted *axri)
cb69f7decc37778 James Smart 2011-12-13  10458  {
cb69f7decc37778 James Smart 2011-12-13 @10459  	struct lpfc_vport *vport;
5c1db2accd4b3e2 James Smart 2012-03-01  10460  	uint32_t ext_status = 0;
cb69f7decc37778 James Smart 2011-12-13  10461  
6b5151fd7baec68 James Smart 2012-01-18  10462  	if (!ndlp || !NLP_CHK_NODE_ACT(ndlp)) {
cb69f7decc37778 James Smart 2011-12-13  10463  		lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
cb69f7decc37778 James Smart 2011-12-13  10464  				"3115 Node Context not found, driver "
cb69f7decc37778 James Smart 2011-12-13  10465  				"ignoring abts err event\n");
6b5151fd7baec68 James Smart 2012-01-18  10466  		return;
6b5151fd7baec68 James Smart 2012-01-18  10467  	}
6b5151fd7baec68 James Smart 2012-01-18  10468  
cb69f7decc37778 James Smart 2011-12-13  10469  	vport = ndlp->vport;
cb69f7decc37778 James Smart 2011-12-13  10470  	lpfc_printf_log(phba, KERN_WARNING, LOG_SLI,
cb69f7decc37778 James Smart 2011-12-13  10471  			"3116 Port generated FCP XRI ABORT event on "
5c1db2accd4b3e2 James Smart 2012-03-01  10472  			"vpi %d rpi %d xri x%x status 0x%x parameter x%x\n",
8e668af5c200fe9 James Smart 2013-05-31  10473  			ndlp->vport->vpi, phba->sli4_hba.rpi_ids[ndlp->nlp_rpi],
cb69f7decc37778 James Smart 2011-12-13  10474  			bf_get(lpfc_wcqe_xa_xri, axri),
5c1db2accd4b3e2 James Smart 2012-03-01  10475  			bf_get(lpfc_wcqe_xa_status, axri),
5c1db2accd4b3e2 James Smart 2012-03-01  10476  			axri->parameter);
cb69f7decc37778 James Smart 2011-12-13  10477  
5c1db2accd4b3e2 James Smart 2012-03-01  10478  	/*
5c1db2accd4b3e2 James Smart 2012-03-01  10479  	 * Catch the ABTS protocol failure case.  Older OCe FW releases returned
5c1db2accd4b3e2 James Smart 2012-03-01  10480  	 * LOCAL_REJECT and 0 for a failed ABTS exchange and later OCe and
5c1db2accd4b3e2 James Smart 2012-03-01  10481  	 * LPe FW releases returned LOCAL_REJECT and SEQUENCE_TIMEOUT.
5c1db2accd4b3e2 James Smart 2012-03-01  10482  	 */
e3d2b802ad4f4d4 James Smart 2012-08-14  10483  	ext_status = axri->parameter & IOERR_PARAM_MASK;
5c1db2accd4b3e2 James Smart 2012-03-01  10484  	if ((bf_get(lpfc_wcqe_xa_status, axri) == IOSTAT_LOCAL_REJECT) &&
5c1db2accd4b3e2 James Smart 2012-03-01  10485  	    ((ext_status == IOERR_SEQUENCE_TIMEOUT) || (ext_status == 0)))
e7dab164a9aa457 James Smart 2020-10-20  10486  		lpfc_sli_post_recovery_event(phba, ndlp);
cb69f7decc37778 James Smart 2011-12-13  10487  }
cb69f7decc37778 James Smart 2011-12-13  10488  

:::::: The code at line 10459 was first introduced by commit
:::::: cb69f7decc3777822b240c46890a209df288c7bb [SCSI] lpfc 8.3.28: Add support for ABTS failure handling

:::::: TO: James Smart <james.smart@emulex.com>
:::::: CC: James Bottomley <JBottomley@Parallels.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75986 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread