All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp at intel.com>
To: mptcp at lists.01.org
Subject: [MPTCP] [mptcp:export 776/783] net/core/sock.c:2489:6: warning: no previous prototype for '__lock_sock'
Date: Fri, 20 Nov 2020 07:23:42 +0800	[thread overview]
Message-ID: <202011200739.BD7L9HsC-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]

Hi Paolo,

FYI, the error/warning still remains.

tree:   https://github.com/multipath-tcp/mptcp_net-next.git export
head:   502db67b77b326a9be8f3bb3515a09b83a8a1fd4
commit: 91e9b96e7c81bb06efcbd05a454d61c735f8c519 [776/783] mptcp: open code mptcp variant for lock_sock
config: nds32-randconfig-r032-20201119 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/multipath-tcp/mptcp_net-next/commit/91e9b96e7c81bb06efcbd05a454d61c735f8c519
        git remote add mptcp https://github.com/multipath-tcp/mptcp_net-next.git
        git fetch --no-tags mptcp export
        git checkout 91e9b96e7c81bb06efcbd05a454d61c735f8c519
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>

All warnings (new ones prefixed by >>):

>> net/core/sock.c:2489:6: warning: no previous prototype for '__lock_sock' [-Wmissing-prototypes]
    2489 | void __lock_sock(struct sock *sk)
         |      ^~~~~~~~~~~

vim +/__lock_sock +2489 net/core/sock.c

  2488	
> 2489	void __lock_sock(struct sock *sk)
  2490		__releases(&sk->sk_lock.slock)
  2491		__acquires(&sk->sk_lock.slock)
  2492	{
  2493		DEFINE_WAIT(wait);
  2494	
  2495		for (;;) {
  2496			prepare_to_wait_exclusive(&sk->sk_lock.wq, &wait,
  2497						TASK_UNINTERRUPTIBLE);
  2498			spin_unlock_bh(&sk->sk_lock.slock);
  2499			schedule();
  2500			spin_lock_bh(&sk->sk_lock.slock);
  2501			if (!sock_owned_by_user(sk))
  2502				break;
  2503		}
  2504		finish_wait(&sk->sk_lock.wq, &wait);
  2505	}
  2506	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26543 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [mptcp:export 776/783] net/core/sock.c:2489:6: warning: no previous prototype for '__lock_sock'
Date: Fri, 20 Nov 2020 07:23:42 +0800	[thread overview]
Message-ID: <202011200739.BD7L9HsC-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

Hi Paolo,

FYI, the error/warning still remains.

tree:   https://github.com/multipath-tcp/mptcp_net-next.git export
head:   502db67b77b326a9be8f3bb3515a09b83a8a1fd4
commit: 91e9b96e7c81bb06efcbd05a454d61c735f8c519 [776/783] mptcp: open code mptcp variant for lock_sock
config: nds32-randconfig-r032-20201119 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/multipath-tcp/mptcp_net-next/commit/91e9b96e7c81bb06efcbd05a454d61c735f8c519
        git remote add mptcp https://github.com/multipath-tcp/mptcp_net-next.git
        git fetch --no-tags mptcp export
        git checkout 91e9b96e7c81bb06efcbd05a454d61c735f8c519
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/core/sock.c:2489:6: warning: no previous prototype for '__lock_sock' [-Wmissing-prototypes]
    2489 | void __lock_sock(struct sock *sk)
         |      ^~~~~~~~~~~

vim +/__lock_sock +2489 net/core/sock.c

  2488	
> 2489	void __lock_sock(struct sock *sk)
  2490		__releases(&sk->sk_lock.slock)
  2491		__acquires(&sk->sk_lock.slock)
  2492	{
  2493		DEFINE_WAIT(wait);
  2494	
  2495		for (;;) {
  2496			prepare_to_wait_exclusive(&sk->sk_lock.wq, &wait,
  2497						TASK_UNINTERRUPTIBLE);
  2498			spin_unlock_bh(&sk->sk_lock.slock);
  2499			schedule();
  2500			spin_lock_bh(&sk->sk_lock.slock);
  2501			if (!sock_owned_by_user(sk))
  2502				break;
  2503		}
  2504		finish_wait(&sk->sk_lock.wq, &wait);
  2505	}
  2506	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 26543 bytes --]

             reply	other threads:[~2020-11-19 23:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 23:23 kernel test robot [this message]
2020-11-19 23:23 ` [mptcp:export 776/783] net/core/sock.c:2489:6: warning: no previous prototype for '__lock_sock' kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-11-19 18:56 [MPTCP] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202011200739.BD7L9HsC-lkp@intel.com \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.