* [PATCH] clk: bcm: dvp: drop a variable that is assigned to only
@ 2020-11-20 13:21 Uwe Kleine-König
2020-11-20 15:29 ` Nicolas Saenz Julienne
2020-12-19 19:48 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2020-11-20 13:21 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Nicolas Saenz Julienne
Cc: linux-clk, bcm-kernel-feedback-list, linux-rpi-kernel, kernel
The third parameter to devm_platform_get_and_ioremap_resource() is used
only to provide the used resource. As this variable isn't used
afterwards, switch to the function devm_platform_ioremap_resource()
which doesn't provide this output parameter.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/clk/bcm/clk-bcm2711-dvp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/clk/bcm/clk-bcm2711-dvp.c b/drivers/clk/bcm/clk-bcm2711-dvp.c
index 8333e20dc9d2..6696200ecf7e 100644
--- a/drivers/clk/bcm/clk-bcm2711-dvp.c
+++ b/drivers/clk/bcm/clk-bcm2711-dvp.c
@@ -25,7 +25,6 @@ static const struct clk_parent_data clk_dvp_parent = {
static int clk_dvp_probe(struct platform_device *pdev)
{
struct clk_hw_onecell_data *data;
- struct resource *res;
struct clk_dvp *dvp;
void __iomem *base;
int ret;
@@ -42,7 +41,7 @@ static int clk_dvp_probe(struct platform_device *pdev)
return -ENOMEM;
data = dvp->data;
- base = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: bcm: dvp: drop a variable that is assigned to only
2020-11-20 13:21 [PATCH] clk: bcm: dvp: drop a variable that is assigned to only Uwe Kleine-König
@ 2020-11-20 15:29 ` Nicolas Saenz Julienne
2020-12-19 19:48 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Saenz Julienne @ 2020-11-20 15:29 UTC (permalink / raw)
To: Uwe Kleine-König, Michael Turquette, Stephen Boyd
Cc: linux-clk, bcm-kernel-feedback-list, linux-rpi-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Fri, 2020-11-20 at 14:21 +0100, Uwe Kleine-König wrote:
> The third parameter to devm_platform_get_and_ioremap_resource() is used
> only to provide the used resource. As this variable isn't used
> afterwards, switch to the function devm_platform_ioremap_resource()
> which doesn't provide this output parameter.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: bcm: dvp: drop a variable that is assigned to only
2020-11-20 13:21 [PATCH] clk: bcm: dvp: drop a variable that is assigned to only Uwe Kleine-König
2020-11-20 15:29 ` Nicolas Saenz Julienne
@ 2020-12-19 19:48 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2020-12-19 19:48 UTC (permalink / raw)
To: Michael Turquette, Nicolas Saenz Julienne, Uwe Kleine-König
Cc: linux-clk, bcm-kernel-feedback-list, linux-rpi-kernel, kernel
Quoting Uwe Kleine-König (2020-11-20 05:21:21)
> The third parameter to devm_platform_get_and_ioremap_resource() is used
> only to provide the used resource. As this variable isn't used
> afterwards, switch to the function devm_platform_ioremap_resource()
> which doesn't provide this output parameter.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-19 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 13:21 [PATCH] clk: bcm: dvp: drop a variable that is assigned to only Uwe Kleine-König
2020-11-20 15:29 ` Nicolas Saenz Julienne
2020-12-19 19:48 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.