* [linux-stable-rc:linux-5.4.y 1860/3341] drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: sparse: sparse: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be
@ 2020-11-22 20:40 kernel test robot
2020-11-22 20:40 ` [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static kernel test robot
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2020-11-22 20:40 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 10315 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
head: fc8334619167ce90b6d3f76e3dce9284dbe14fa2
commit: 6b8fbd9b2db056d888dc4f34f61c824faea659b3 [1860/3341] scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs
config: i386-randconfig-s002-20201122 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-134-gb59dbdaf-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=6b8fbd9b2db056d888dc4f34f61c824faea659b3
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc linux-5.4.y
git checkout 6b8fbd9b2db056d888dc4f34f61c824faea659b3
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: sparse: sparse: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be static?
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:460:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:505:23: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:506:24: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1306:26: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1315:31: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:1316:32: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2115:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2117:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2121:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2124:36: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2130:21: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2136:29: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2145:30: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2152:54: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: cast to restricted __be32
drivers/scsi/lpfc/lpfc_nportdisc.c:2164:17: sparse: sparse: too many warnings
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39728 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static
2020-11-22 20:40 [linux-stable-rc:linux-5.4.y 1860/3341] drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: sparse: sparse: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be kernel test robot
@ 2020-11-22 20:40 ` kernel test robot
2020-11-24 14:37 ` James Smart
0 siblings, 1 reply; 5+ messages in thread
From: kernel test robot @ 2020-11-22 20:40 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 818 bytes --]
Fixes: 6b8fbd9b2db0 ("scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
lpfc_nportdisc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
index 2a340624bfc99b..0bd7b2048ec065 100644
--- a/drivers/scsi/lpfc/lpfc_nportdisc.c
+++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
@@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
* This routine is only called if we are SLI3, direct connect pt2pt
* mode and the remote NPort issues the PLOGI after link up.
*/
-void
+static void
lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
{
LPFC_MBOXQ_t *login_mbox;
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static
2020-11-22 20:40 ` [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static kernel test robot
@ 2020-11-24 14:37 ` James Smart
2020-11-24 17:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: James Smart @ 2020-11-24 14:37 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On 11/22/2020 12:40 PM, kernel test robot wrote:
>
> Fixes: 6b8fbd9b2db0 ("scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> lpfc_nportdisc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> index 2a340624bfc99b..0bd7b2048ec065 100644
> --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> @@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
> * This routine is only called if we are SLI3, direct connect pt2pt
> * mode and the remote NPort issues the PLOGI after link up.
> */
> -void
> +static void
> lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> {
> LPFC_MBOXQ_t *login_mbox;
>
Patch was already accepted:
f7cb0d0945eb scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
Please merge.
-- james
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static
2020-11-24 14:37 ` James Smart
@ 2020-11-24 17:08 ` Greg Kroah-Hartman
2020-11-24 23:15 ` Philip Li
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-11-24 17:08 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
On Tue, Nov 24, 2020 at 06:37:55AM -0800, James Smart wrote:
> On 11/22/2020 12:40 PM, kernel test robot wrote:
> >
> > Fixes: 6b8fbd9b2db0 ("scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: kernel test robot <lkp@intel.com>
> > ---
> > lpfc_nportdisc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > index 2a340624bfc99b..0bd7b2048ec065 100644
> > --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> > +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > @@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
> > * This routine is only called if we are SLI3, direct connect pt2pt
> > * mode and the remote NPort issues the PLOGI after link up.
> > */
> > -void
> > +static void
> > lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> > {
> > LPFC_MBOXQ_t *login_mbox;
> >
>
> Patch was already accepted:
>
> f7cb0d0945eb scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
>
> Please merge.
Foolish sparse warnings like this are not needed in stable, I have no
idea why the kernel test bot keeps trying to do stuff like this.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static
2020-11-24 17:08 ` Greg Kroah-Hartman
@ 2020-11-24 23:15 ` Philip Li
0 siblings, 0 replies; 5+ messages in thread
From: Philip Li @ 2020-11-24 23:15 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]
On Tue, Nov 24, 2020 at 06:08:42PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 24, 2020 at 06:37:55AM -0800, James Smart wrote:
> > On 11/22/2020 12:40 PM, kernel test robot wrote:
> > >
> > > Fixes: 6b8fbd9b2db0 ("scsi: lpfc: Fix pt2pt discovery on SLI3 HBAs")
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Signed-off-by: kernel test robot <lkp@intel.com>
> > > ---
> > > lpfc_nportdisc.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > index 2a340624bfc99b..0bd7b2048ec065 100644
> > > --- a/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c
> > > @@ -286,7 +286,7 @@ lpfc_els_abort(struct lpfc_hba *phba, struct lpfc_nodelist *ndlp)
> > > * This routine is only called if we are SLI3, direct connect pt2pt
> > > * mode and the remote NPort issues the PLOGI after link up.
> > > */
> > > -void
> > > +static void
> > > lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
> > > {
> > > LPFC_MBOXQ_t *login_mbox;
> > >
> >
> > Patch was already accepted:
> >
> > f7cb0d0945eb scsi: lpfc: Make function lpfc_defer_pt2pt_acc static
> >
> > Please merge.
>
> Foolish sparse warnings like this are not needed in stable, I have no
> idea why the kernel test bot keeps trying to do stuff like this.
Got it, Greg, we will avoid reporting this type sparse warning on stable.
If any other sparse warnings are also not that meaningful for stable, kindly
let us know and we will continue improve the testing.
Thanks for your feedback.
>
> greg k-h
> _______________________________________________
> kbuild-all mailing list -- kbuild-all(a)lists.01.org
> To unsubscribe send an email to kbuild-all-leave(a)lists.01.org
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-24 23:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-22 20:40 [linux-stable-rc:linux-5.4.y 1860/3341] drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: sparse: sparse: symbol 'lpfc_defer_pt2pt_acc' was not declared. Should it be kernel test robot
2020-11-22 20:40 ` [RFC PATCH linux-stable-rc] scsi: lpfc: lpfc_defer_pt2pt_acc can be static kernel test robot
2020-11-24 14:37 ` James Smart
2020-11-24 17:08 ` Greg Kroah-Hartman
2020-11-24 23:15 ` Philip Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.