[PATCH] xhci-pci: Allow host runtime PM as default for Intel Alpine LP

[PATCH] xhci-pci: Allow host runtime PM as default for Intel Alpine LP

[Hans de Goede]

The xhci controller on Alpine Ridge LP keeps the whole thunderbolt
controller awake if the host controller is not allowed to sleep.
This is the case even if no USB devices are connected to the host.

Add the Intel Alpine LP product-id to the list of product-ids
for which we allow runtime PM by default.

Fixes: 2815ef7fe4d4 ("xhci-pci: allow host runtime PM as default for Intel Alpine and Titan Ridge")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/usb/host/xhci-pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index bf89172c43ca..5f94d7edeb37 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -47,6 +47,7 @@
 #define PCI_DEVICE_ID_INTEL_DNV_XHCI			0x19d0
 #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_XHCI	0x15b5
 #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_XHCI	0x15b6
+#define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_LP_XHCI	0x15c1
 #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_2C_XHCI	0x15db
 #define PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_XHCI	0x15d4
 #define PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_XHCI		0x15e9
@@ -232,6 +233,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
 	    (pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_2C_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_4C_XHCI ||
+	     pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_LP_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_2C_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_ALPINE_RIDGE_C_4C_XHCI ||
 	     pdev->device == PCI_DEVICE_ID_INTEL_TITAN_RIDGE_2C_XHCI ||
-- 
2.28.0

Re: [PATCH] xhci-pci: Allow host runtime PM as default for Intel Alpine LP

[Mika Westerberg]

Hi Hans,

Few minor comments below :)

On Mon, Nov 23, 2020 at 04:11:40PM +0100, Hans de Goede wrote:
> The xhci controller on Alpine Ridge LP keeps the whole thunderbolt
      ^^^^                                               ^^^^^^^^^^^
xHCI                                                     Thunderbolt


> controller awake if the host controller is not allowed to sleep.
> This is the case even if no USB devices are connected to the host.
> 
> Add the Intel Alpine LP product-id to the list of product-ids
                      ^
		      Ridge

> for which we allow runtime PM by default.
> 
> Fixes: 2815ef7fe4d4 ("xhci-pci: allow host runtime PM as default for Intel Alpine and Titan Ridge")
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH] xhci-pci: Allow host runtime PM as default for Intel Alpine LP

[Mika Westerberg]

Forgot to say, $subject also should say "Alpine Ridge LP".

On Mon, Nov 23, 2020 at 05:45:24PM +0200, Mika Westerberg wrote:
> Hi Hans,
> 
> Few minor comments below :)
> 
> On Mon, Nov 23, 2020 at 04:11:40PM +0100, Hans de Goede wrote:
> > The xhci controller on Alpine Ridge LP keeps the whole thunderbolt
>       ^^^^                                               ^^^^^^^^^^^
> xHCI                                                     Thunderbolt
> 
> 
> > controller awake if the host controller is not allowed to sleep.
> > This is the case even if no USB devices are connected to the host.
> > 
> > Add the Intel Alpine LP product-id to the list of product-ids
>                       ^
> 		      Ridge
> 
> > for which we allow runtime PM by default.
> > 
> > Fixes: 2815ef7fe4d4 ("xhci-pci: allow host runtime PM as default for Intel Alpine and Titan Ridge")
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>