All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rtw88: wow: print key type when failing
@ 2020-11-12 18:14 Brian Norris
  2020-11-24  9:18 ` Kalle Valo
  0 siblings, 1 reply; 2+ messages in thread
From: Brian Norris @ 2020-11-12 18:14 UTC (permalink / raw)
  To: linux-wireless; +Cc: Yan-Hsuan Chuang, Brian Norris

It's much easier to spot what went wrong when you print out the
unhandled key type.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
 drivers/net/wireless/realtek/rtw88/wow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/wow.c b/drivers/net/wireless/realtek/rtw88/wow.c
index b419bc28861f..fc9544f4e5e4 100644
--- a/drivers/net/wireless/realtek/rtw88/wow.c
+++ b/drivers/net/wireless/realtek/rtw88/wow.c
@@ -332,7 +332,8 @@ static void rtw_wow_fw_security_type_iter(struct ieee80211_hw *hw,
 		key->flags |= IEEE80211_KEY_FLAG_SW_MGMT_TX;
 		break;
 	default:
-		rtw_err(rtwdev, "Unsupported key type for wowlan mode\n");
+		rtw_err(rtwdev, "Unsupported key type for wowlan mode: %#x\n",
+			key->cipher);
 		hw_key_type = 0;
 		break;
 	}
-- 
2.29.2.222.g5d2a92d10f8-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rtw88: wow: print key type when failing
  2020-11-12 18:14 [PATCH] rtw88: wow: print key type when failing Brian Norris
@ 2020-11-24  9:18 ` Kalle Valo
  0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-11-24  9:18 UTC (permalink / raw)
  To: Brian Norris; +Cc: linux-wireless, Yan-Hsuan Chuang, Brian Norris

Brian Norris <briannorris@chromium.org> wrote:

> It's much easier to spot what went wrong when you print out the
> unhandled key type.
> 
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Patch applied to wireless-drivers-next.git, thanks.

8d201d368aaa rtw88: wow: print key type when failing

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20201112181432.2958021-1-briannorris@chromium.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-24  9:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 18:14 [PATCH] rtw88: wow: print key type when failing Brian Norris
2020-11-24  9:18 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.