From: Jakub Kicinski <kuba@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alex Elder <elder@kernel.org>, Kalle Valo <kvalo@codeaurora.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
Date: Tue, 24 Nov 2020 14:47:21 -0800 [thread overview]
Message-ID: <20201124144721.3e80698c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201122234031.33432-2-rikard.falkeborn@gmail.com>
On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
I can take this one if Alex acks it.
The other patch is probably best handled by Kalle.
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Alex Elder <elder@kernel.org>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
"David S. Miller" <davem@davemloft.net>,
Kalle Valo <kvalo@codeaurora.org>
Subject: Re: [PATCH net-next 1/2] soc: qcom: ipa: Constify static qmi structs
Date: Tue, 24 Nov 2020 14:47:21 -0800 [thread overview]
Message-ID: <20201124144721.3e80698c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201122234031.33432-2-rikard.falkeborn@gmail.com>
On Mon, 23 Nov 2020 00:40:30 +0100 Rikard Falkeborn wrote:
> These are only used as input arguments to qmi_handle_init() which
> accepts const pointers to both qmi_ops and qmi_msg_handler. Make them
> const to allow the compiler to put them in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
I can take this one if Alex acks it.
The other patch is probably best handled by Kalle.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2020-11-24 22:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-22 23:40 [PATCH net-next 0/2] net: Constify static qmi structs Rikard Falkeborn
2020-11-22 23:40 ` Rikard Falkeborn
2020-11-22 23:40 ` [PATCH net-next 1/2] soc: qcom: ipa: " Rikard Falkeborn
2020-11-22 23:40 ` Rikard Falkeborn
2020-11-24 22:47 ` Jakub Kicinski [this message]
2020-11-24 22:47 ` Jakub Kicinski
2020-11-25 5:59 ` Kalle Valo
2020-11-25 5:59 ` Kalle Valo
2020-11-25 21:45 ` Alex Elder
2020-11-25 21:45 ` Alex Elder
2020-11-25 22:49 ` Jakub Kicinski
2020-11-25 22:49 ` Jakub Kicinski
2020-11-22 23:40 ` [PATCH net-next 2/2] ath10k: " Rikard Falkeborn
2020-11-22 23:40 ` Rikard Falkeborn
2020-12-02 18:32 ` Kalle Valo
2020-12-02 18:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124144721.3e80698c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.