All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Auchter <michael.auchter@ni.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
	richard@nod.at, vigneshr@ti.com,
	sergei.shtylyov@cogentembedded.com,
	boris.brezillon@collabora.com, michael@walle.cc,
	j.neuschaefer@gmx.net, linux-mtd@lists.infradead.org,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	joerg.hofrichter@ni.com
Subject: Re: [PATCH 0/3] MTD: SST SPI-NOR fixes
Date: Tue, 24 Nov 2020 14:35:00 -0600	[thread overview]
Message-ID: <20201124203500.GA487864@xaphan> (raw)
In-Reply-To: <20200911144703.25409-1-m.felsch@pengutronix.de>

Hello Marco,

On Fri, Sep 11, 2020 at 04:47:00PM +0200, Marco Felsch wrote:
> Hi,
> 
> Patch 1-2: write path fixes
> The sst write path is completely broken since v5.7-rc1 and in rare cases
> since the support of the sst_write() function (49aac4aec53c).
> 
> Patch 3: cleanup
> 
> I've tested my patches with a small test app to ensure writes starting
> on an odd address and with dd to test even start addresses. My dut was
> an public available imx6q-sabrelite (rev.D).
> Other testers are welcome :)
> 
> Regards,
>   Marco
> 
> Marco Felsch (3):
>   mtd: spi-nor: sst: fix write support for SST_WRITE marked devices
>   mtd: spi-nor: sst: add missing write_enable
>   mtd: spi-nor: sst: move sst_write_second to local driver
> 
>  drivers/mtd/spi-nor/core.c  | 15 +++++++++------
>  drivers/mtd/spi-nor/sst.c   | 15 +++++++++++----
>  include/linux/mtd/spi-nor.h |  2 --
>  3 files changed, 20 insertions(+), 12 deletions(-)
> 
> -- 
> 2.20.1

My colleague, Joerg, has validated that these patches fix an issue we
saw where performing multi-byte writes to a SST25VF016B would fail.

Tested-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

Thanks,
 Michael

WARNING: multiple messages have this Message-ID (diff)
From: Michael Auchter <michael.auchter@ni.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: vigneshr@ti.com, sergei.shtylyov@cogentembedded.com,
	tudor.ambarus@microchip.com, richard@nod.at,
	j.neuschaefer@gmx.net, linux-kernel@vger.kernel.org,
	michael@walle.cc, boris.brezillon@collabora.com,
	linux-mtd@lists.infradead.org, joerg.hofrichter@ni.com,
	kernel@pengutronix.de, miquel.raynal@bootlin.com
Subject: Re: [PATCH 0/3] MTD: SST SPI-NOR fixes
Date: Tue, 24 Nov 2020 14:35:00 -0600	[thread overview]
Message-ID: <20201124203500.GA487864@xaphan> (raw)
In-Reply-To: <20200911144703.25409-1-m.felsch@pengutronix.de>

Hello Marco,

On Fri, Sep 11, 2020 at 04:47:00PM +0200, Marco Felsch wrote:
> Hi,
> 
> Patch 1-2: write path fixes
> The sst write path is completely broken since v5.7-rc1 and in rare cases
> since the support of the sst_write() function (49aac4aec53c).
> 
> Patch 3: cleanup
> 
> I've tested my patches with a small test app to ensure writes starting
> on an odd address and with dd to test even start addresses. My dut was
> an public available imx6q-sabrelite (rev.D).
> Other testers are welcome :)
> 
> Regards,
>   Marco
> 
> Marco Felsch (3):
>   mtd: spi-nor: sst: fix write support for SST_WRITE marked devices
>   mtd: spi-nor: sst: add missing write_enable
>   mtd: spi-nor: sst: move sst_write_second to local driver
> 
>  drivers/mtd/spi-nor/core.c  | 15 +++++++++------
>  drivers/mtd/spi-nor/sst.c   | 15 +++++++++++----
>  include/linux/mtd/spi-nor.h |  2 --
>  3 files changed, 20 insertions(+), 12 deletions(-)
> 
> -- 
> 2.20.1

My colleague, Joerg, has validated that these patches fix an issue we
saw where performing multi-byte writes to a SST25VF016B would fail.

Tested-by: Joerg Hofrichter <joerg.hofrichter@ni.com>

Thanks,
 Michael

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2020-11-24 20:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11 14:47 [PATCH 0/3] MTD: SST SPI-NOR fixes Marco Felsch
2020-09-11 14:47 ` Marco Felsch
2020-09-11 14:47 ` [PATCH 1/3] mtd: spi-nor: sst: fix write support for SST_WRITE marked devices Marco Felsch
2020-09-11 14:47   ` Marco Felsch
2020-09-14 12:00   ` Vignesh Raghavendra
2020-09-14 12:00     ` Vignesh Raghavendra
2020-09-16  9:36     ` Tudor.Ambarus
2020-09-16  9:36       ` Tudor.Ambarus
2020-09-11 14:47 ` [PATCH 2/3] mtd: spi-nor: sst: add missing write_enable Marco Felsch
2020-09-11 14:47   ` Marco Felsch
2020-09-11 14:47 ` [PATCH 3/3] mtd: spi-nor: sst: move sst_write_second to local driver Marco Felsch
2020-09-11 14:47   ` Marco Felsch
2020-11-24 20:35 ` Michael Auchter [this message]
2020-11-24 20:35   ` [PATCH 0/3] MTD: SST SPI-NOR fixes Michael Auchter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124203500.GA487864@xaphan \
    --to=michael.auchter@ni.com \
    --cc=boris.brezillon@collabora.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=joerg.hofrichter@ni.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=tudor.ambarus@microchip.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.