All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Andre Przywara <andre.przywara@arm.com>,
	Dave Martin <Dave.Martin@arm.com>,
	James Clark <james.clark@arm.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Al Grant <Al.Grant@arm.com>, Wei Li <liwei391@huawei.com>,
	John Garry <john.garry@huawei.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow
Date: Wed, 25 Nov 2020 14:17:56 +0000	[thread overview]
Message-ID: <20201125141755.GB16159@willie-the-truck> (raw)
In-Reply-To: <20201119152441.6972-1-leo.yan@linaro.org>

On Thu, Nov 19, 2020 at 11:24:25PM +0800, Leo Yan wrote:
> This is patch set v9 for refactoring Arm SPE trace decoding and dumping.
> 
> According to comments and suggestions from patch set v8, it squashs the
> two patches into single one: "perf arm-spe: Refactor printing string to
> buffer" and "perf arm-spe: Consolidate arm_spe_pkt_desc()'s return
> value".
> 
> In the patch 01/16, it renames the function arm_spe_pkt_snprintf() to
> arm_spe_pkt_out_string(), since the function is not the same semantics
> with snprintf(), the renaming can avoid confusion.
> 
> This patch set is cleanly applied on the top of perf/core branch
> with commit 29396cd573da ("perf expr: Force encapsulation on
> expr_id_data").
> 
> This patch set has been tested on Hisilicon D06 platform with commands
> "perf report -D" and "perf script", compared the decoding results
> between with this patch set and without this patch set, "diff" tool
> shows the result as expected.
> 
> I also manually built the patches for arm/arm64/x86_64 and verfied
> every single patch can build successfully.

I'm unable to test this, so I'm please that you can! Anyway, it all looks
fine from a quick look:

Acked-by: Will Deacon <will@kernel.org>

so I think Arnaldo can pick this up when he's ready.

Cheers,

Will

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will@kernel.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>, Al Grant <Al.Grant@arm.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Andre Przywara <andre.przywara@arm.com>,
	John Garry <john.garry@huawei.com>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>, James Clark <james.clark@arm.com>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Wei Li <liwei391@huawei.com>
Subject: Re: [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow
Date: Wed, 25 Nov 2020 14:17:56 +0000	[thread overview]
Message-ID: <20201125141755.GB16159@willie-the-truck> (raw)
In-Reply-To: <20201119152441.6972-1-leo.yan@linaro.org>

On Thu, Nov 19, 2020 at 11:24:25PM +0800, Leo Yan wrote:
> This is patch set v9 for refactoring Arm SPE trace decoding and dumping.
> 
> According to comments and suggestions from patch set v8, it squashs the
> two patches into single one: "perf arm-spe: Refactor printing string to
> buffer" and "perf arm-spe: Consolidate arm_spe_pkt_desc()'s return
> value".
> 
> In the patch 01/16, it renames the function arm_spe_pkt_snprintf() to
> arm_spe_pkt_out_string(), since the function is not the same semantics
> with snprintf(), the renaming can avoid confusion.
> 
> This patch set is cleanly applied on the top of perf/core branch
> with commit 29396cd573da ("perf expr: Force encapsulation on
> expr_id_data").
> 
> This patch set has been tested on Hisilicon D06 platform with commands
> "perf report -D" and "perf script", compared the decoding results
> between with this patch set and without this patch set, "diff" tool
> shows the result as expected.
> 
> I also manually built the patches for arm/arm64/x86_64 and verfied
> every single patch can build successfully.

I'm unable to test this, so I'm please that you can! Anyway, it all looks
fine from a quick look:

Acked-by: Will Deacon <will@kernel.org>

so I think Arnaldo can pick this up when he's ready.

Cheers,

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-11-25 14:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 15:24 [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow Leo Yan
2020-11-19 15:24 ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 01/16] perf arm-spe: Refactor printing string to buffer Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-26 12:11   ` Arnaldo Carvalho de Melo
2020-11-26 12:11     ` Arnaldo Carvalho de Melo
2020-11-26 14:31     ` Leo Yan
2020-11-26 14:31       ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 02/16] perf arm-spe: Refactor packet header parsing Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 03/16] perf arm-spe: Add new function arm_spe_pkt_desc_addr() Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 04/16] perf arm-spe: Refactor address packet handling Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 05/16] perf arm_spe: Fixup top byte for data virtual address Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 06/16] perf arm-spe: Refactor context packet handling Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 07/16] perf arm-spe: Add new function arm_spe_pkt_desc_counter() Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 08/16] perf arm-spe: Refactor counter packet handling Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 09/16] perf arm-spe: Add new function arm_spe_pkt_desc_event() Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 10/16] perf arm-spe: Refactor event type handling Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 11/16] perf arm-spe: Remove size condition checking for events Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 12/16] perf arm-spe: Add new function arm_spe_pkt_desc_op_type() Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 13/16] perf arm-spe: Refactor operation packet handling Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 14/16] perf arm-spe: Add more sub classes for operation packet Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 15/16] perf arm_spe: Decode memory tagging properties Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-19 15:24 ` [PATCH v9 16/16] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
2020-11-19 15:24   ` Leo Yan
2020-11-25 14:17 ` Will Deacon [this message]
2020-11-25 14:17   ` [PATCH v9 00/16] perf arm-spe: Refactor decoding & dumping flow Will Deacon
2020-11-26 12:10   ` Arnaldo Carvalho de Melo
2020-11-26 12:10     ` Arnaldo Carvalho de Melo
2020-11-26 14:30   ` Leo Yan
2020-11-26 14:30     ` Leo Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201125141755.GB16159@willie-the-truck \
    --to=will@kernel.org \
    --cc=Al.Grant@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andre.przywara@arm.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.