* [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
@ 2020-11-26 11:37 Lad Prabhakar
2020-11-26 17:11 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Lad Prabhakar @ 2020-11-26 11:37 UTC (permalink / raw)
To: cip-dev, Nobuhiro Iwamatsu, Pavel Machek; +Cc: Biju Das
[-- Attachment #1: Type: text/plain, Size: 1337 bytes --]
From: Geert Uytterhoeven <geert+renesas@glider.be>
commit c91dfc9818df5f43c10c727f1cecaebdb5e2fa92 upstream.
According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
used with SYS-DMAC0 on R-Car E3.
Fixes: 62c0056f1c3eb15d ("arm64: dts: renesas: r8a774c0: Add MSIOF nodes")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200917132117.8515-3-geert+renesas@glider.be
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
Patch has been cherry picked from v5.10-rc5.
---
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 44d66fcb412d..4785c486b336 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1214,9 +1214,8 @@
reg = <0 0xe6ea0000 0 0x0064>;
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 210>;
- dmas = <&dmac1 0x43>, <&dmac1 0x42>,
- <&dmac2 0x43>, <&dmac2 0x42>;
- dma-names = "tx", "rx", "tx", "rx";
+ dmas = <&dmac0 0x43>, <&dmac0 0x42>;
+ dma-names = "tx", "rx";
power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
resets = <&cpg 210>;
#address-cells = <1>;
--
2.17.1
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5883): https://lists.cip-project.org/g/cip-dev/message/5883
Mute This Topic: https://lists.cip-project.org/mt/78527519/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-11-26 11:37 [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels Lad Prabhakar
@ 2020-11-26 17:11 ` Pavel Machek
2020-11-27 10:34 ` Lad Prabhakar
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2020-11-26 17:11 UTC (permalink / raw)
To: Lad Prabhakar; +Cc: cip-dev, Nobuhiro Iwamatsu, Pavel Machek, Biju Das
[-- Attachment #1.1: Type: text/plain, Size: 645 bytes --]
Hi!
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> commit c91dfc9818df5f43c10c727f1cecaebdb5e2fa92 upstream.
>
> According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
> used with SYS-DMAC0 on R-Car E3.
Looks good to me, I can apply it if there are no other comments.
(I note you switched from dmac1 + dmac2 to dma_0_ only. I believe you
double checked that's okay, but I wonder how it worked before the
patch?)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5884): https://lists.cip-project.org/g/cip-dev/message/5884
Mute This Topic: https://lists.cip-project.org/mt/78527519/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-11-26 17:11 ` Pavel Machek
@ 2020-11-27 10:34 ` Lad Prabhakar
2020-11-27 23:07 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Lad Prabhakar @ 2020-11-27 10:34 UTC (permalink / raw)
To: Pavel Machek; +Cc: cip-dev, Nobuhiro Iwamatsu, Biju Das
[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]
Hi Pavel,
Thank you for the review.
> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 26 November 2020 17:12
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>; Biju Das <biju.das.jz@bp.renesas.com>
> Subject: Re: [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
>
> Hi!
>
> > From: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > commit c91dfc9818df5f43c10c727f1cecaebdb5e2fa92 upstream.
> >
> > According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
> > used with SYS-DMAC0 on R-Car E3.
>
> Looks good to me, I can apply it if there are no other comments.
>
> (I note you switched from dmac1 + dmac2 to dma_0_ only. I believe you
> double checked that's okay, but I wonder how it worked before the
> patch?)
>
Yes I have cross checked this information. Luckily MSIOF1 wasn't populated on the dev board.
Cheers,
Prabhakar
> Best regards,
> Pavel
>
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5885): https://lists.cip-project.org/g/cip-dev/message/5885
Mute This Topic: https://lists.cip-project.org/mt/78527519/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-11-27 10:34 ` Lad Prabhakar
@ 2020-11-27 23:07 ` Pavel Machek
0 siblings, 0 replies; 4+ messages in thread
From: Pavel Machek @ 2020-11-27 23:07 UTC (permalink / raw)
To: Prabhakar Mahadev Lad; +Cc: Pavel Machek, cip-dev, Nobuhiro Iwamatsu, Biju Das
[-- Attachment #1.1: Type: text/plain, Size: 619 bytes --]
Hi!
> > Looks good to me, I can apply it if there are no other comments.
> >
> > (I note you switched from dmac1 + dmac2 to dma_0_ only. I believe you
> > double checked that's okay, but I wonder how it worked before the
> > patch?)
> >
> Yes I have cross checked this information. Luckily MSIOF1 wasn't populated on the dev board.
>
Aha, MSIOF1 not being on dev board explains things.
Applied and pushed out.
Thanks and best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5887): https://lists.cip-project.org/g/cip-dev/message/5887
Mute This Topic: https://lists.cip-project.org/mt/78527519/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-27 23:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 11:37 [cip-dev] [PATCH 4.19.y-cip] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels Lad Prabhakar
2020-11-26 17:11 ` Pavel Machek
2020-11-27 10:34 ` Lad Prabhakar
2020-11-27 23:07 ` Pavel Machek
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.