* [linux-next:master 6361/8750] drivers/mtd/nand/raw/r852.c:874 r852_probe() error: uninitialized symbol 'dev'.
@ 2020-11-27 1:29 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-11-27 1:29 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 14767 bytes --]
CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Miquel Raynal <miquel.raynal@bootlin.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6147c83fd749d19a0d3ccc2f64d12138ab010b47
commit: 0c2b69f551326b2c30d03a96f2d3f728a6159bf9 [6361/8750] mtd: rawnand: r852: Move the ECC initialization to ->attach_chip()
:::::: branch date: 17 hours ago
:::::: commit date: 7 days ago
config: x86_64-randconfig-m001-20201127 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/mtd/nand/raw/r852.c:874 r852_probe() error: uninitialized symbol 'dev'.
vim +/dev +874 drivers/mtd/nand/raw/r852.c
7ef969a042281bd drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 842
2fffc7982c990f0 drivers/mtd/nand/r852.c Jingoo Han 2013-08-07 843 static int r852_probe(struct pci_dev *pci_dev, const struct pci_device_id *id)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 844 {
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 845 int error;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 846 struct nand_chip *chip;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 847 struct r852_device *dev;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 848
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 849 /* pci initialization */
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 850 error = pci_enable_device(pci_dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 851
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 852 if (error)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 853 goto error1;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 854
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 855 pci_set_master(pci_dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 856
0282fefb1a29d60 drivers/mtd/nand/raw/r852.c Christoph Hellwig 2018-10-18 857 error = dma_set_mask(&pci_dev->dev, DMA_BIT_MASK(32));
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 858 if (error)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 859 goto error2;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 860
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 861 error = pci_request_regions(pci_dev, DRV_NAME);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 862
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 863 if (error)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 864 goto error3;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 865
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 866 error = -ENOMEM;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 867
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 868 /* init nand chip, but register it only on card insert */
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 869 chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 870
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 871 if (!chip)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 872 goto error4;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 873
0c2b69f551326b2 drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 @874 nand_controller_init(&dev->controller);
0c2b69f551326b2 drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 875 dev->controller.ops = &r852_ops;
0c2b69f551326b2 drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 876 chip->controller = &dev->controller;
0c2b69f551326b2 drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 877
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 878 /* commands */
bf6065c6c08fa3e drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 879 chip->legacy.cmd_ctrl = r852_cmdctl;
8395b753d7cad2b drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 880 chip->legacy.waitfunc = r852_wait;
8395b753d7cad2b drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 881 chip->legacy.dev_ready = r852_ready;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 882
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 883 /* I/O */
716bbbabcc68c2b drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 884 chip->legacy.read_byte = r852_read_byte;
716bbbabcc68c2b drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 885 chip->legacy.read_buf = r852_read_buf;
716bbbabcc68c2b drivers/mtd/nand/raw/r852.c Boris Brezillon 2018-09-07 886 chip->legacy.write_buf = r852_write_buf;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 887
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 888 /* init our device structure */
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 889 dev = kzalloc(sizeof(struct r852_device), GFP_KERNEL);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 890
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 891 if (!dev)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 892 goto error5;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 893
d699ed250c07384 drivers/mtd/nand/r852.c Boris Brezillon 2015-12-10 894 nand_set_controller_data(chip, dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 895 dev->chip = chip;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 896 dev->pci_dev = pci_dev;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 897 pci_set_drvdata(pci_dev, dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 898
7ef969a042281bd drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 899 nand_controller_init(&dev->controller);
7ef969a042281bd drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 900 dev->controller.ops = &r852_ops;
7ef969a042281bd drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 901 chip->controller = &dev->controller;
7ef969a042281bd drivers/mtd/nand/raw/r852.c Miquel Raynal 2020-11-13 902
0282fefb1a29d60 drivers/mtd/nand/raw/r852.c Christoph Hellwig 2018-10-18 903 dev->bounce_buffer = dma_alloc_coherent(&pci_dev->dev, R852_DMA_LEN,
0282fefb1a29d60 drivers/mtd/nand/raw/r852.c Christoph Hellwig 2018-10-18 904 &dev->phys_bounce_buffer, GFP_KERNEL);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 905
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 906 if (!dev->bounce_buffer)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 907 goto error6;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 908
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 909
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 910 error = -ENODEV;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 911 dev->mmio = pci_ioremap_bar(pci_dev, 0);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 912
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 913 if (!dev->mmio)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 914 goto error7;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 915
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 916 error = -ENOMEM;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 917 dev->tmp_buffer = kzalloc(SM_SECTOR_SIZE, GFP_KERNEL);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 918
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 919 if (!dev->tmp_buffer)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 920 goto error8;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 921
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 922 init_completion(&dev->dma_done);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 923
58a69cb47ec6991 drivers/mtd/nand/r852.c Tejun Heo 2011-02-16 924 dev->card_workqueue = create_freezable_workqueue(DRV_NAME);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 925
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 926 if (!dev->card_workqueue)
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 927 goto error9;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 928
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 929 INIT_DELAYED_WORK(&dev->card_detect_work, r852_card_detect_work);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 930
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 931 /* shutdown everything - precation */
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 932 r852_engine_disable(dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 933 r852_disable_irqs(dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 934
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 935 r852_dma_test(dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 936
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 937 dev->irq = pci_dev->irq;
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 938 spin_lock_init(&dev->irqlock);
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 939
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 940 dev->card_detected = 0;
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 941 r852_card_update_present(dev);
cc1fed00c9ba84f drivers/mtd/nand/r852.c Maxim Levitsky 2010-06-02 942
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 943 /*register irq handler*/
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 944 error = -ENODEV;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 945 if (request_irq(pci_dev->irq, &r852_irq, IRQF_SHARED,
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 946 DRV_NAME, dev))
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 947 goto error10;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 948
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 949 /* kick initial present test */
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 950 queue_delayed_work(dev->card_workqueue,
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 951 &dev->card_detect_work, 0);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 952
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 953
63fa37f0c512481 drivers/mtd/nand/raw/r852.c Shreeya Patel 2018-02-22 954 pr_notice("driver loaded successfully\n");
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 955 return 0;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 956
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 957 error10:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 958 destroy_workqueue(dev->card_workqueue);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 959 error9:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 960 kfree(dev->tmp_buffer);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 961 error8:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 962 pci_iounmap(pci_dev, dev->mmio);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 963 error7:
0282fefb1a29d60 drivers/mtd/nand/raw/r852.c Christoph Hellwig 2018-10-18 964 dma_free_coherent(&pci_dev->dev, R852_DMA_LEN, dev->bounce_buffer,
0282fefb1a29d60 drivers/mtd/nand/raw/r852.c Christoph Hellwig 2018-10-18 965 dev->phys_bounce_buffer);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 966 error6:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 967 kfree(dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 968 error5:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 969 kfree(chip);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 970 error4:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 971 pci_release_regions(pci_dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 972 error3:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 973 error2:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 974 pci_disable_device(pci_dev);
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 975 error1:
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 976 return error;
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 977 }
67e054e919248fa drivers/mtd/nand/r852.c Maxim Levitsky 2010-02-22 978
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32338 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-27 1:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 1:29 [linux-next:master 6361/8750] drivers/mtd/nand/raw/r852.c:874 r852_probe() error: uninitialized symbol 'dev' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.