* [PATCH] drm/komeda: Remove useless variable assignment
@ 2020-11-27 11:00 carsten.haitzler
2020-11-27 15:51 ` Steven Price
2020-11-27 22:56 ` Liviu Dudau
0 siblings, 2 replies; 3+ messages in thread
From: carsten.haitzler @ 2020-11-27 11:00 UTC (permalink / raw)
To: dri-devel; +Cc: liviu.dudau, Carsten Haitzler
From: Carsten Haitzler <carsten.haitzler@arm.com>
ret is not actually read after this (only written in one case then
returned), so this assign line is useless. This removes that assignment.
Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
index 1d767473ba8a..eea76f51f662 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
@@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
ret = of_reserved_mem_device_init(dev);
if (ret && ret != -ENODEV)
return ret;
- ret = 0;
for_each_available_child_of_node(np, child) {
if (of_node_name_eq(child, "pipeline")) {
--
2.29.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/komeda: Remove useless variable assignment
2020-11-27 11:00 [PATCH] drm/komeda: Remove useless variable assignment carsten.haitzler
@ 2020-11-27 15:51 ` Steven Price
2020-11-27 22:56 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: Steven Price @ 2020-11-27 15:51 UTC (permalink / raw)
To: carsten.haitzler, dri-devel; +Cc: liviu.dudau, Carsten Haitzler
On 27/11/2020 11:00, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> ret is not actually read after this (only written in one case then
> returned), so this assign line is useless. This removes that assignment.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 1d767473ba8a..eea76f51f662 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
> ret = of_reserved_mem_device_init(dev);
> if (ret && ret != -ENODEV)
> return ret;
> - ret = 0;
>
> for_each_available_child_of_node(np, child) {
> if (of_node_name_eq(child, "pipeline")) {
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/komeda: Remove useless variable assignment
2020-11-27 11:00 [PATCH] drm/komeda: Remove useless variable assignment carsten.haitzler
2020-11-27 15:51 ` Steven Price
@ 2020-11-27 22:56 ` Liviu Dudau
1 sibling, 0 replies; 3+ messages in thread
From: Liviu Dudau @ 2020-11-27 22:56 UTC (permalink / raw)
To: carsten.haitzler; +Cc: Carsten Haitzler, dri-devel
On Fri, Nov 27, 2020 at 11:00:27AM +0000, carsten.haitzler@foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler@arm.com>
>
> ret is not actually read after this (only written in one case then
> returned), so this assign line is useless. This removes that assignment.
>
> Signed-off-by: Carsten Haitzler <carsten.haitzler@arm.com>
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index 1d767473ba8a..eea76f51f662 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -163,7 +163,6 @@ static int komeda_parse_dt(struct device *dev, struct komeda_dev *mdev)
> ret = of_reserved_mem_device_init(dev);
> if (ret && ret != -ENODEV)
> return ret;
> - ret = 0;
>
> for_each_available_child_of_node(np, child) {
> if (of_node_name_eq(child, "pipeline")) {
> --
> 2.29.2
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-27 22:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 11:00 [PATCH] drm/komeda: Remove useless variable assignment carsten.haitzler
2020-11-27 15:51 ` Steven Price
2020-11-27 22:56 ` Liviu Dudau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.