* [PATCH v2] i2c: qcom: Fix IRQ error misassignement
@ 2020-11-27 13:39 Robert Foss
2020-11-27 16:06 ` Manivannan Sadhasivam
0 siblings, 1 reply; 3+ messages in thread
From: Robert Foss @ 2020-11-27 13:39 UTC (permalink / raw)
To: loic.poulain, robert.foss, bjorn.andersson, wsa, todor.too,
vkoul, linux-i2c, linux-arm-msm, linux-kernel,
Manivannan Sadhasivam
During cci_isr() errors read from register fields belonging to
i2c master1 are currently assigned to the status field belonging to
i2c master0. This patch corrects this error, and always assigns
master1 errors to the status field of master1.
Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
Reported-by: Loic Poulain <loic.poulain@linaro.org>
Suggested-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
---
drivers/i2c/busses/i2c-qcom-cci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c
index f13735beca58..1c259b5188de 100644
--- a/drivers/i2c/busses/i2c-qcom-cci.c
+++ b/drivers/i2c/busses/i2c-qcom-cci.c
@@ -194,9 +194,9 @@ static irqreturn_t cci_isr(int irq, void *dev)
if (unlikely(val & CCI_IRQ_STATUS_0_I2C_M1_ERROR)) {
if (val & CCI_IRQ_STATUS_0_I2C_M1_Q0_NACK_ERR ||
val & CCI_IRQ_STATUS_0_I2C_M1_Q1_NACK_ERR)
- cci->master[0].status = -ENXIO;
+ cci->master[1].status = -ENXIO;
else
- cci->master[0].status = -EIO;
+ cci->master[1].status = -EIO;
writel(CCI_HALT_REQ_I2C_M1_Q0Q1, cci->base + CCI_HALT_REQ);
ret = IRQ_HANDLED;
--
2.27.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] i2c: qcom: Fix IRQ error misassignement
2020-11-27 13:39 [PATCH v2] i2c: qcom: Fix IRQ error misassignement Robert Foss
@ 2020-11-27 16:06 ` Manivannan Sadhasivam
2020-11-30 10:04 ` Robert Foss
0 siblings, 1 reply; 3+ messages in thread
From: Manivannan Sadhasivam @ 2020-11-27 16:06 UTC (permalink / raw)
To: Robert Foss
Cc: loic.poulain, bjorn.andersson, wsa, todor.too, vkoul, linux-i2c,
linux-arm-msm, linux-kernel
On Fri, Nov 27, 2020 at 02:39:37PM +0100, Robert Foss wrote:
> During cci_isr() errors read from register fields belonging to
> i2c master1 are currently assigned to the status field belonging to
> i2c master0. This patch corrects this error, and always assigns
> master1 errors to the status field of master1.
>
> Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
>
You don't need a new line here.
> Reported-by: Loic Poulain <loic.poulain@linaro.org>
> Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> Signed-off-by: Robert Foss <robert.foss@linaro.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] i2c: qcom: Fix IRQ error misassignement
2020-11-27 16:06 ` Manivannan Sadhasivam
@ 2020-11-30 10:04 ` Robert Foss
0 siblings, 0 replies; 3+ messages in thread
From: Robert Foss @ 2020-11-30 10:04 UTC (permalink / raw)
To: Manivannan Sadhasivam
Cc: Loic Poulain, Bjorn Andersson, wsa, Todor Tomov, Vinod Koul,
linux-i2c, linux-arm-msm, linux-kernel
On Fri, 27 Nov 2020 at 17:06, Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>
> On Fri, Nov 27, 2020 at 02:39:37PM +0100, Robert Foss wrote:
> > During cci_isr() errors read from register fields belonging to
> > i2c master1 are currently assigned to the status field belonging to
> > i2c master0. This patch corrects this error, and always assigns
> > master1 errors to the status field of master1.
> >
> > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
> >
>
> You don't need a new line here.
Ack
>
> > Reported-by: Loic Poulain <loic.poulain@linaro.org>
> > Suggested-by: Loic Poulain <loic.poulain@linaro.org>
> > Signed-off-by: Robert Foss <robert.foss@linaro.org>
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks for the review!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-30 10:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 13:39 [PATCH v2] i2c: qcom: Fix IRQ error misassignement Robert Foss
2020-11-27 16:06 ` Manivannan Sadhasivam
2020-11-30 10:04 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.