From: Borislav Petkov <bp@alien8.de>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: x86@kernel.org, Kim Phillips <kim.phillips@amd.com>,
Yazen Ghannam <yazen.ghannam@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>, Pu Wen <puwen@hygon.cn>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/cpu/amd: Remove dead code for TSEG region remapping
Date: Fri, 27 Nov 2020 18:27:47 +0100 [thread overview]
Message-ID: <20201127172747.GE13163@zn.tnic> (raw)
In-Reply-To: <20201127171324.1846019-1-nivedita@alum.mit.edu>
On Fri, Nov 27, 2020 at 12:13:24PM -0500, Arvind Sankar wrote:
> Commit
> 26bfa5f89486 ("x86, amd: Cleanup init_amd")
> moved the code that remaps the TSEG region using 4k pages from
> init_amd() to bsp_init_amd().
>
> However, bsp_init_amd() is executed well before the direct mapping is
> actually created:
>
> setup_arch()
> -> early_cpu_init()
> -> early_identify_cpu()
> -> this_cpu->c_bsp_init()
> -> bsp_init_amd()
> ...
> -> init_mem_mapping()
>
> So the change effectively disabled the 4k remapping, because
> pfn_range_is_mapped() is always false at this point.
>
> It has been over six years since the commit, and no-one seems to have
> noticed this, so just remove the code. The original code was also
> incomplete, since it doesn't check how large the TSEG address range
> actually is, so it might remap only part of it in any case.
Yah, and the patch which added this:
6c62aa4a3c12 ("x86: make amd.c have 64bit support code")
does not say what for (I'm not surprised, frankly).
So if AMD folks on Cc don't have any need for actually fixing this
properly, yap, we can zap it.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-11-27 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 17:13 [PATCH] x86/cpu/amd: Remove dead code for TSEG region remapping Arvind Sankar
2020-11-27 17:27 ` Borislav Petkov [this message]
2020-12-02 17:58 ` Tom Lendacky
2020-12-02 18:10 ` Borislav Petkov
2020-12-02 22:32 ` Arvind Sankar
2020-12-03 8:48 ` Borislav Petkov
2020-12-03 16:14 ` Arvind Sankar
2020-12-03 16:44 ` Borislav Petkov
2020-12-08 18:12 ` [tip: x86/cpu] " tip-bot2 for Arvind Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201127172747.GE13163@zn.tnic \
--to=bp@alien8.de \
--cc=kim.phillips@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nivedita@alum.mit.edu \
--cc=puwen@hygon.cn \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.