* [PATCH v8 0/5] leds: pwm: Make automatic labels work
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips,
Alexander Dahl, linux-arm-kernel, linux-amlogic, linux-stm32,
linux-leds
Hei hei,
these are the not yet taken patches from a series which originally fixed
a minor issue in the leds pwm driver, then migrated the leds pwm dts
docs to yaml (by request), and then fixed all the dts files triggering
warnings on those new bindings. The remaining five patches now only fix
warnings, the base fix and the yaml conversion is already taken by
subsystem maintainers. Although this is only dts content now, I rebased
it on the current for-next tree of the leds subsystem maintainer,
because that contains the yaml-conversion changeset.
Series changelog below …
Greets
Alex
v8:
- rebased series on recent pavel/for-next (post v5.10-rc1)
- removed already applied patches
- added Acked-by on patch 1/5
- updated patch 3/5 based on comments by Ahmad Fatoum
v7:
- rebased series on recent pavel/for-next
- split up arm dts patch by arm sub arch (suggested by Krzysztof Kozlowski)
- added multiple Reviewed-by tags
- slightly reworded commit messages (suggested by Krzysztof Kozlowski)
- added actual dtbs_check warnings to commit messages
- added Russell King to Cc for binding conversion patch (because license)
v6:
- rebased series on recent pavel/for-next
- added Reviewed-by from Marek to patch 1
- patch 2 from v5 was picked by Pavel and is already in his for-next
branch
- previous patch 3/3 (now 2/7) was reworked based on feedback by Rob
- added more dt patches fixing warnings after binding conversion to yaml
v5:
- replaced patch 1/3 by a new patch removing platform_data support for
the leds-pwm driver
- little rewording of commit message in patch 2/3
- updated patch 3/3 based on feedback by Rob Herring
- added Marek Behún to Cc, because he also works on removing
platform_data support
- rebased series on pavel/for-next
v4:
- added led-class patch handling fwnode passing differently (patch 1/3)
- adapted leds-pwm patch to new led-class (patch 2/3)
- contacted original author of leds-pwm dt binding on license issue
(patch 3/3)
v3:
- series rebased on v5.9-rc4
- changed license of .yaml file to recommended one (patch 2/2)
- added Acked-by to both patches
v2:
- series rebased on v5.9-rc3
- added the dt-bindings update patch (2/2)
v1:
- based on v5.9-rc2
- backport on v5.4.59 tested and working
Cc: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-amlogic@lists.infradead.org
Cc: linux-mips@vger.kernel.org
Alexander Dahl (5):
dt-bindings: mfd: Fix schema warnings for pwm-leds
ARM: dts: berlin: Fix schema warnings for pwm-leds
ARM: dts: stm32: Fix schema warnings for pwm-leds
arm64: dts: meson: Fix schema warnings for pwm-leds
MIPS: DTS: img: Fix schema warnings for pwm-leds
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
.../boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
.../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
7 files changed, 24 insertions(+), 21 deletions(-)
base-commit: 98650b0874171cc443251f7b369d3b1544db9d4e
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v8 0/5] leds: pwm: Make automatic labels work
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips,
Alexander Dahl, linux-arm-kernel, linux-amlogic, linux-stm32,
linux-leds
Hei hei,
these are the not yet taken patches from a series which originally fixed
a minor issue in the leds pwm driver, then migrated the leds pwm dts
docs to yaml (by request), and then fixed all the dts files triggering
warnings on those new bindings. The remaining five patches now only fix
warnings, the base fix and the yaml conversion is already taken by
subsystem maintainers. Although this is only dts content now, I rebased
it on the current for-next tree of the leds subsystem maintainer,
because that contains the yaml-conversion changeset.
Series changelog below …
Greets
Alex
v8:
- rebased series on recent pavel/for-next (post v5.10-rc1)
- removed already applied patches
- added Acked-by on patch 1/5
- updated patch 3/5 based on comments by Ahmad Fatoum
v7:
- rebased series on recent pavel/for-next
- split up arm dts patch by arm sub arch (suggested by Krzysztof Kozlowski)
- added multiple Reviewed-by tags
- slightly reworded commit messages (suggested by Krzysztof Kozlowski)
- added actual dtbs_check warnings to commit messages
- added Russell King to Cc for binding conversion patch (because license)
v6:
- rebased series on recent pavel/for-next
- added Reviewed-by from Marek to patch 1
- patch 2 from v5 was picked by Pavel and is already in his for-next
branch
- previous patch 3/3 (now 2/7) was reworked based on feedback by Rob
- added more dt patches fixing warnings after binding conversion to yaml
v5:
- replaced patch 1/3 by a new patch removing platform_data support for
the leds-pwm driver
- little rewording of commit message in patch 2/3
- updated patch 3/3 based on feedback by Rob Herring
- added Marek Behún to Cc, because he also works on removing
platform_data support
- rebased series on pavel/for-next
v4:
- added led-class patch handling fwnode passing differently (patch 1/3)
- adapted leds-pwm patch to new led-class (patch 2/3)
- contacted original author of leds-pwm dt binding on license issue
(patch 3/3)
v3:
- series rebased on v5.9-rc4
- changed license of .yaml file to recommended one (patch 2/2)
- added Acked-by to both patches
v2:
- series rebased on v5.9-rc3
- added the dt-bindings update patch (2/2)
v1:
- based on v5.9-rc2
- backport on v5.4.59 tested and working
Cc: linux-leds@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-amlogic@lists.infradead.org
Cc: linux-mips@vger.kernel.org
Alexander Dahl (5):
dt-bindings: mfd: Fix schema warnings for pwm-leds
ARM: dts: berlin: Fix schema warnings for pwm-leds
ARM: dts: stm32: Fix schema warnings for pwm-leds
arm64: dts: meson: Fix schema warnings for pwm-leds
MIPS: DTS: img: Fix schema warnings for pwm-leds
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
.../boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
.../boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
7 files changed, 24 insertions(+), 21 deletions(-)
base-commit: 98650b0874171cc443251f7b369d3b1544db9d4e
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v8 1/5] dt-bindings: mfd: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 21:53 ` Alexander Dahl
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Dahl, linux-leds, Alexander Dahl, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, Rob Herring, Lee Jones, Jeff LaBundy
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
/home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Rob Herring <robh@kernel.org>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* added Acked-by (Rob Herring)
v6 -> v7:
* added warning message to commit message (Krzysztof Kozlowski)
v6:
* added this patch to series
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
index 541b06d80e73..92dc48a8dfa7 100644
--- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
+++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
@@ -90,10 +90,11 @@ examples:
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- panel {
+ led-1 {
+ label = "panel";
pwms = <&iqs620a_pwm 0 1000000>;
max-brightness = <255>;
};
--
2.20.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 1/5] dt-bindings: mfd: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
linux-mips, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Jeff LaBundy, Lee Jones, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
/home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Rob Herring <robh@kernel.org>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* added Acked-by (Rob Herring)
v6 -> v7:
* added warning message to commit message (Krzysztof Kozlowski)
v6:
* added this patch to series
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
index 541b06d80e73..92dc48a8dfa7 100644
--- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
+++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
@@ -90,10 +90,11 @@ examples:
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- panel {
+ led-1 {
+ label = "panel";
pwms = <&iqs620a_pwm 0 1000000>;
max-brightness = <255>;
};
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 1/5] dt-bindings: mfd: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Rob Herring, Alexander Dahl, linux-kernel,
linux-mips, Alexander Dahl, linux-arm-kernel, linux-amlogic,
Jeff LaBundy, Lee Jones, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
CHECK Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml
/home/alex/build/linux/Documentation/devicetree/bindings/mfd/iqs62x.example.dt.yaml: pwmleds: 'panel' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
Acked-by: Rob Herring <robh@kernel.org>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* added Acked-by (Rob Herring)
v6 -> v7:
* added warning message to commit message (Krzysztof Kozlowski)
v6:
* added this patch to series
Documentation/devicetree/bindings/mfd/iqs62x.yaml | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mfd/iqs62x.yaml b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
index 541b06d80e73..92dc48a8dfa7 100644
--- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
+++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
@@ -90,10 +90,11 @@ examples:
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- panel {
+ led-1 {
+ label = "panel";
pwms = <&iqs620a_pwm 0 1000000>;
max-brightness = <255>;
};
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v8 2/5] ARM: dts: berlin: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 21:53 ` Alexander Dahl
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Dahl, linux-leds, Alexander Dahl, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, Jisheng Zhang, Sebastian Hesselbarth
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 56fa951bc86f..c1d91424e658 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -34,19 +34,19 @@
linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
};
- leds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-0 = <&ledpwm_pmux>;
pinctrl-names = "default";
- white {
+ led-1 {
label = "white";
pwms = <&pwm 0 600000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-2 {
label = "red";
pwms = <&pwm 1 600000 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 2/5] ARM: dts: berlin: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips,
Jisheng Zhang, Alexander Dahl, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-leds, Sebastian Hesselbarth
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 56fa951bc86f..c1d91424e658 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -34,19 +34,19 @@
linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
};
- leds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-0 = <&ledpwm_pmux>;
pinctrl-names = "default";
- white {
+ led-1 {
label = "white";
pwms = <&pwm 0 600000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-2 {
label = "red";
pwms = <&pwm 1 600000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 2/5] ARM: dts: berlin: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips,
Jisheng Zhang, Alexander Dahl, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-leds, Sebastian Hesselbarth
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
CHECK arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/berlin2cd-google-chromecast.dt.yaml: leds: 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/berlin2cd-google-chromecast.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
index 56fa951bc86f..c1d91424e658 100644
--- a/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
+++ b/arch/arm/boot/dts/berlin2cd-google-chromecast.dts
@@ -34,19 +34,19 @@
linux,usable-memory = <0x00000000 0x20000000>; /* 512 MB */
};
- leds {
+ led-controller {
compatible = "pwm-leds";
pinctrl-0 = <&ledpwm_pmux>;
pinctrl-names = "default";
- white {
+ led-1 {
label = "white";
pwms = <&pwm 0 600000 0>;
max-brightness = <255>;
linux,default-trigger = "default-on";
};
- red {
+ led-2 {
label = "red";
pwms = <&pwm 1 600000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 21:53 ` Alexander Dahl
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Dahl, linux-leds, Alexander Dahl, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, Maxime Coquelin, Alexandre Torgue
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* updated indexes and added comment (Ahmad Fatoum)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 1e5333fd437f..5ed58110d963 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,35 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-0 {
compatible = "gpio-leds";
- led-green {
+ led-0 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-1 {
compatible = "pwm-leds";
- led-red {
+ /* led-1 to led-3 are part of a single RGB led */
+ led-1 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-2 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-3 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexandre Torgue, Alexander Dahl, linux-kernel,
linux-mips, Alexander Dahl, linux-arm-kernel, Maxime Coquelin,
linux-amlogic, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* updated indexes and added comment (Ahmad Fatoum)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 1e5333fd437f..5ed58110d963 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,35 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-0 {
compatible = "gpio-leds";
- led-green {
+ led-0 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-1 {
compatible = "pwm-leds";
- led-red {
+ /* led-1 to led-3 are part of a single RGB led */
+ led-1 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-2 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-3 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Alexandre Torgue, Alexander Dahl, linux-kernel,
linux-mips, Alexander Dahl, linux-arm-kernel, Maxime Coquelin,
linux-amlogic, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
/home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
* updated indexes and added comment (Ahmad Fatoum)
v6 -> v7:
* split up patch (one per sub arch)
* added actual warnings to commit message
arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
index 1e5333fd437f..5ed58110d963 100644
--- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
@@ -36,34 +36,35 @@
stdout-path = &uart4;
};
- led-act {
+ led-controller-0 {
compatible = "gpio-leds";
- led-green {
+ led-0 {
label = "mc1:green:act";
gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
linux,default-trigger = "heartbeat";
};
};
- led-rgb {
+ led-controller-1 {
compatible = "pwm-leds";
- led-red {
+ /* led-1 to led-3 are part of a single RGB led */
+ led-1 {
label = "mc1:red:rgb";
pwms = <&leds_pwm 1 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-green {
+ led-2 {
label = "mc1:green:rgb";
pwms = <&leds_pwm 2 1000000 0>;
max-brightness = <255>;
active-low;
};
- led-blue {
+ led-3 {
label = "mc1:blue:rgb";
pwms = <&leds_pwm 3 1000000 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [Linux-stm32] [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 22:00 ` Ahmad Fatoum
-1 siblings, 0 replies; 24+ messages in thread
From: Ahmad Fatoum @ 2020-11-28 22:00 UTC (permalink / raw)
To: Alexander Dahl, Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips,
linux-arm-kernel, Maxime Coquelin, linux-amlogic, linux-stm32,
linux-leds
On 28.11.20 22:53, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
> * updated indexes and added comment (Ahmad Fatoum)
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 1e5333fd437f..5ed58110d963 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,35 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-0 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-0 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-1 {
> compatible = "pwm-leds";
>
> - led-red {
> + /* led-1 to led-3 are part of a single RGB led */
> + led-1 {
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-2 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-3 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [Linux-stm32] [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
@ 2020-11-28 22:00 ` Ahmad Fatoum
0 siblings, 0 replies; 24+ messages in thread
From: Ahmad Fatoum @ 2020-11-28 22:00 UTC (permalink / raw)
To: Alexander Dahl, Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips, linux-leds,
Maxime Coquelin, linux-amlogic, linux-stm32, linux-arm-kernel
On 28.11.20 22:53, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
> * updated indexes and added comment (Ahmad Fatoum)
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 1e5333fd437f..5ed58110d963 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,35 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-0 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-0 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-1 {
> compatible = "pwm-leds";
>
> - led-red {
> + /* led-1 to led-3 are part of a single RGB led */
> + led-1 {
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-2 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-3 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [Linux-stm32] [PATCH v8 3/5] ARM: dts: stm32: Fix schema warnings for pwm-leds
@ 2020-11-28 22:00 ` Ahmad Fatoum
0 siblings, 0 replies; 24+ messages in thread
From: Ahmad Fatoum @ 2020-11-28 22:00 UTC (permalink / raw)
To: Alexander Dahl, Rob Herring
Cc: devicetree, Alexander Dahl, linux-kernel, linux-mips, linux-leds,
Maxime Coquelin, linux-amlogic, linux-stm32, linux-arm-kernel
On 28.11.20 22:53, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> DTC arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> CHECK arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml
> /home/alex/build/linux/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dt.yaml: led-rgb: 'led-blue', 'led-green', 'led-red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
> From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
> * updated indexes and added comment (Ahmad Fatoum)
Acked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Thanks,
>
> v6 -> v7:
> * split up patch (one per sub arch)
> * added actual warnings to commit message
>
> arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> index 1e5333fd437f..5ed58110d963 100644
> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
> @@ -36,34 +36,35 @@
> stdout-path = &uart4;
> };
>
> - led-act {
> + led-controller-0 {
> compatible = "gpio-leds";
>
> - led-green {
> + led-0 {
> label = "mc1:green:act";
> gpios = <&gpioa 13 GPIO_ACTIVE_LOW>;
> linux,default-trigger = "heartbeat";
> };
> };
>
> - led-rgb {
> + led-controller-1 {
> compatible = "pwm-leds";
>
> - led-red {
> + /* led-1 to led-3 are part of a single RGB led */
> + led-1 {
> label = "mc1:red:rgb";
> pwms = <&leds_pwm 1 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-green {
> + led-2 {
> label = "mc1:green:rgb";
> pwms = <&leds_pwm 2 1000000 0>;
> max-brightness = <255>;
> active-low;
> };
>
> - led-blue {
> + led-3 {
> label = "mc1:blue:rgb";
> pwms = <&leds_pwm 3 1000000 0>;
> max-brightness = <255>;
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v8 4/5] arm64: dts: meson: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 21:53 ` Alexander Dahl
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Dahl, linux-leds, Alexander Dahl, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message
v6:
* added this patch to series
.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 8bcdffdf55d0..adfc72500e66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bff8ec2c1c70..dcb435af4e0b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 4/5] arm64: dts: meson: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Neil Armstrong, Alexander Dahl, Kevin Hilman,
linux-kernel, linux-mips, Martin Blumenstingl, Alexander Dahl,
linux-arm-kernel, linux-amlogic, linux-stm32, linux-leds,
Jerome Brunet
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message
v6:
* added this patch to series
.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 8bcdffdf55d0..adfc72500e66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bff8ec2c1c70..dcb435af4e0b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 4/5] arm64: dts: meson: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Neil Armstrong, Alexander Dahl, Kevin Hilman,
linux-kernel, linux-mips, Martin Blumenstingl, Alexander Dahl,
linux-arm-kernel, linux-amlogic, linux-stm32, linux-leds,
Jerome Brunet
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added Reviewed-by
* added another explaining sentence to commit message
v6:
* added this patch to series
.../arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ++--
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts | 8 ++++----
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
index 8bcdffdf55d0..adfc72500e66 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905x-khadas-vim.dts
@@ -42,10 +42,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index bff8ec2c1c70..dcb435af4e0b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -81,10 +81,10 @@
};
};
- pwmleds {
+ led-controller {
compatible = "pwm-leds";
- power {
+ led-1 {
label = "vim:red:power";
pwms = <&pwm_AO_ab 1 7812500 0>;
max-brightness = <255>;
diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
index 5ab139a34c01..039a8d0d1e9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts
@@ -101,20 +101,20 @@
};
};
- leds {
+ led-controller-1 {
compatible = "gpio-leds";
- led-bluetooth {
+ led-1 {
label = "sei610:blue:bt";
gpios = <&gpio GPIOC_7 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
default-state = "off";
};
};
- pwmleds {
+ led-controller-2 {
compatible = "pwm-leds";
- power {
+ led-2 {
label = "sei610:red:power";
pwms = <&pwm_AO_ab 0 30518 0>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-11-28 21:53 ` Alexander Dahl
-1 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: Alexander Dahl, linux-leds, Alexander Dahl, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, James Hartley, Rahul Bedarkar, Thomas Bogendoerfer
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added another explaining sentence to commit message
v6:
* added this patch to series
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts b/arch/mips/boot/dts/img/pistachio_marduk.dts
index bf69da96dc8b..a8708783f04b 100644
--- a/arch/mips/boot/dts/img/pistachio_marduk.dts
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -46,9 +46,10 @@
regulator-max-microvolt = <1800000>;
};
- leds {
+ led-controller {
compatible = "pwm-leds";
- heartbeat {
+
+ led-1 {
label = "marduk:red:heartbeat";
pwms = <&pwm 3 300000>;
max-brightness = <255>;
--
2.20.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Thomas Bogendoerfer, James Hartley, Alexander Dahl,
linux-kernel, linux-mips, Alexander Dahl, linux-arm-kernel,
Rahul Bedarkar, linux-amlogic, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added another explaining sentence to commit message
v6:
* added this patch to series
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts b/arch/mips/boot/dts/img/pistachio_marduk.dts
index bf69da96dc8b..a8708783f04b 100644
--- a/arch/mips/boot/dts/img/pistachio_marduk.dts
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -46,9 +46,10 @@
regulator-max-microvolt = <1800000>;
};
- leds {
+ led-controller {
compatible = "pwm-leds";
- heartbeat {
+
+ led-1 {
label = "marduk:red:heartbeat";
pwms = <&pwm 3 300000>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
@ 2020-11-28 21:53 ` Alexander Dahl
0 siblings, 0 replies; 24+ messages in thread
From: Alexander Dahl @ 2020-11-28 21:53 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Thomas Bogendoerfer, James Hartley, Alexander Dahl,
linux-kernel, linux-mips, Alexander Dahl, linux-arm-kernel,
Rahul Bedarkar, linux-amlogic, linux-stm32, linux-leds
The node names for devices using the pwm-leds driver follow a certain
naming scheme (now). Parent node name is not enforced, but recommended
by DT project.
Signed-off-by: Alexander Dahl <post@lespocky.de>
---
Notes:
v7 -> v8:
* rebased on v5.10-rc1
v6 -> v7:
* added another explaining sentence to commit message
v6:
* added this patch to series
arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/mips/boot/dts/img/pistachio_marduk.dts b/arch/mips/boot/dts/img/pistachio_marduk.dts
index bf69da96dc8b..a8708783f04b 100644
--- a/arch/mips/boot/dts/img/pistachio_marduk.dts
+++ b/arch/mips/boot/dts/img/pistachio_marduk.dts
@@ -46,9 +46,10 @@
regulator-max-microvolt = <1800000>;
};
- leds {
+ led-controller {
compatible = "pwm-leds";
- heartbeat {
+
+ led-1 {
label = "marduk:red:heartbeat";
pwms = <&pwm 3 300000>;
max-brightness = <255>;
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
2020-11-28 21:53 ` Alexander Dahl
(?)
@ 2020-12-07 10:32 ` Thomas Bogendoerfer
-1 siblings, 0 replies; 24+ messages in thread
From: Thomas Bogendoerfer @ 2020-12-07 10:32 UTC (permalink / raw)
To: Alexander Dahl
Cc: Rob Herring, Alexander Dahl, linux-leds, devicetree,
linux-kernel, linux-arm-kernel, linux-stm32, linux-amlogic,
linux-mips, James Hartley, Rahul Bedarkar
On Sat, Nov 28, 2020 at 10:53:53PM +0100, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
>
> v6 -> v7:
> * added another explaining sentence to commit message
>
> v6:
> * added this patch to series
>
> arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
@ 2020-12-07 10:32 ` Thomas Bogendoerfer
0 siblings, 0 replies; 24+ messages in thread
From: Thomas Bogendoerfer @ 2020-12-07 10:32 UTC (permalink / raw)
To: Alexander Dahl
Cc: devicetree, James Hartley, Alexander Dahl, linux-kernel,
linux-mips, Rob Herring, linux-arm-kernel, Rahul Bedarkar,
linux-amlogic, linux-stm32, linux-leds
On Sat, Nov 28, 2020 at 10:53:53PM +0100, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
>
> v6 -> v7:
> * added another explaining sentence to commit message
>
> v6:
> * added this patch to series
>
> arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v8 5/5] MIPS: DTS: img: Fix schema warnings for pwm-leds
@ 2020-12-07 10:32 ` Thomas Bogendoerfer
0 siblings, 0 replies; 24+ messages in thread
From: Thomas Bogendoerfer @ 2020-12-07 10:32 UTC (permalink / raw)
To: Alexander Dahl
Cc: devicetree, James Hartley, Alexander Dahl, linux-kernel,
linux-mips, Rob Herring, linux-arm-kernel, Rahul Bedarkar,
linux-amlogic, linux-stm32, linux-leds
On Sat, Nov 28, 2020 at 10:53:53PM +0100, Alexander Dahl wrote:
> The node names for devices using the pwm-leds driver follow a certain
> naming scheme (now). Parent node name is not enforced, but recommended
> by DT project.
>
> Signed-off-by: Alexander Dahl <post@lespocky.de>
> ---
>
> Notes:
> v7 -> v8:
> * rebased on v5.10-rc1
>
> v6 -> v7:
> * added another explaining sentence to commit message
>
> v6:
> * added this patch to series
>
> arch/mips/boot/dts/img/pistachio_marduk.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread