All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] thermal: Constify static attribute_group structs
@ 2020-11-28 23:43 Rikard Falkeborn
  2020-12-07 13:47 ` [thermal: thermal/next] thermal: core: " thermal-bot for Rikard Falkeborn
  0 siblings, 1 reply; 2+ messages in thread
From: Rikard Falkeborn @ 2020-11-28 23:43 UTC (permalink / raw)
  To: Daniel Lezcano, Zhang Rui, Amit Kucheria
  Cc: linux-pm, linux-kernel, Rikard Falkeborn

The only usage of these structs is to assign their address to the
thermal_zone_attribute_groups array, which consists of pointers to
const, so make them const to allow the compiler to put them in read-only
memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 drivers/thermal/thermal_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index a6f371fc9af2..0866e949339b 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -425,7 +425,7 @@ static struct attribute *thermal_zone_dev_attrs[] = {
 	NULL,
 };
 
-static struct attribute_group thermal_zone_attribute_group = {
+static const struct attribute_group thermal_zone_attribute_group = {
 	.attrs = thermal_zone_dev_attrs,
 };
 
@@ -434,7 +434,7 @@ static struct attribute *thermal_zone_mode_attrs[] = {
 	NULL,
 };
 
-static struct attribute_group thermal_zone_mode_attribute_group = {
+static const struct attribute_group thermal_zone_mode_attribute_group = {
 	.attrs = thermal_zone_mode_attrs,
 };
 
@@ -468,7 +468,7 @@ static umode_t thermal_zone_passive_is_visible(struct kobject *kobj,
 	return 0;
 }
 
-static struct attribute_group thermal_zone_passive_attribute_group = {
+static const struct attribute_group thermal_zone_passive_attribute_group = {
 	.attrs = thermal_zone_passive_attrs,
 	.is_visible = thermal_zone_passive_is_visible,
 };
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [thermal: thermal/next] thermal: core: Constify static attribute_group structs
  2020-11-28 23:43 [PATCH] thermal: Constify static attribute_group structs Rikard Falkeborn
@ 2020-12-07 13:47 ` thermal-bot for Rikard Falkeborn
  0 siblings, 0 replies; 2+ messages in thread
From: thermal-bot for Rikard Falkeborn @ 2020-12-07 13:47 UTC (permalink / raw)
  To: linux-pm; +Cc: Rikard Falkeborn, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     f74bed6a4e0d7f51da7f624e47f6e9423920e1e0
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//f74bed6a4e0d7f51da7f624e47f6e9423920e1e0
Author:        Rikard Falkeborn <rikard.falkeborn@gmail.com>
AuthorDate:    Sun, 29 Nov 2020 00:43:42 +01:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Mon, 30 Nov 2020 09:09:12 +01:00

thermal: core: Constify static attribute_group structs

The only usage of these structs is to assign their address to the
thermal_zone_attribute_groups array, which consists of pointers to
const, so make them const to allow the compiler to put them in read-only
memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201128234342.36684-1-rikard.falkeborn@gmail.com
---
 drivers/thermal/thermal_sysfs.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
index a6f371f..0866e94 100644
--- a/drivers/thermal/thermal_sysfs.c
+++ b/drivers/thermal/thermal_sysfs.c
@@ -425,7 +425,7 @@ static struct attribute *thermal_zone_dev_attrs[] = {
 	NULL,
 };
 
-static struct attribute_group thermal_zone_attribute_group = {
+static const struct attribute_group thermal_zone_attribute_group = {
 	.attrs = thermal_zone_dev_attrs,
 };
 
@@ -434,7 +434,7 @@ static struct attribute *thermal_zone_mode_attrs[] = {
 	NULL,
 };
 
-static struct attribute_group thermal_zone_mode_attribute_group = {
+static const struct attribute_group thermal_zone_mode_attribute_group = {
 	.attrs = thermal_zone_mode_attrs,
 };
 
@@ -468,7 +468,7 @@ static umode_t thermal_zone_passive_is_visible(struct kobject *kobj,
 	return 0;
 }
 
-static struct attribute_group thermal_zone_passive_attribute_group = {
+static const struct attribute_group thermal_zone_passive_attribute_group = {
 	.attrs = thermal_zone_passive_attrs,
 	.is_visible = thermal_zone_passive_is_visible,
 };

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-07 13:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-28 23:43 [PATCH] thermal: Constify static attribute_group structs Rikard Falkeborn
2020-12-07 13:47 ` [thermal: thermal/next] thermal: core: " thermal-bot for Rikard Falkeborn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.