From: Andrew Lunn <andrew@lunn.ch>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Nicolas Pitre <nico@fluxnic.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Erik Stahlman <erik@vt.edu>,
Peter Cammaert <pc@denkart.be>, Daris A Nevil <dnevil@snmc.com>,
Russell King <rmk@arm.linux.org.uk>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header
Date: Sun, 29 Nov 2020 19:33:09 +0100 [thread overview]
Message-ID: <20201129183309.GH2234159@lunn.ch> (raw)
In-Reply-To: <20201126133853.3213268-2-lee.jones@linaro.org>
On Thu, Nov 26, 2020 at 01:38:46PM +0000, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'dev' not described in 'try_toggle_control_gpio'
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'desc' not described in 'try_toggle_control_gpio'
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'name' not described in 'try_toggle_control_gpio'
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'index' not described in 'try_toggle_control_gpio'
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'value' not described in 'try_toggle_control_gpio'
> drivers/net/ethernet/smsc/smc91x.c:2200: warning: Function parameter or member 'nsdelay' not described in 'try_toggle_control_gpio'
>
> Cc: Nicolas Pitre <nico@fluxnic.net>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Erik Stahlman <erik@vt.edu>
> Cc: Peter Cammaert <pc@denkart.be>
> Cc: Daris A Nevil <dnevil@snmc.com>
> Cc: Russell King <rmk@arm.linux.org.uk>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/net/ethernet/smsc/smc91x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c
> index 56c36798cb111..3b90dc065ff2d 100644
> --- a/drivers/net/ethernet/smsc/smc91x.c
> +++ b/drivers/net/ethernet/smsc/smc91x.c
> @@ -2191,7 +2191,7 @@ static const struct of_device_id smc91x_match[] = {
> MODULE_DEVICE_TABLE(of, smc91x_match);
>
> #if defined(CONFIG_GPIOLIB)
> -/**
> +/*
> * of_try_set_control_gpio - configure a gpio if it exists
> * @dev: net device
> * @desc: where to store the GPIO descriptor, if it exists
Hi Lee
This is the wrong fix. The name of the function in the documentation
should be corrected. The rest looks correct.
Andrew
next prev parent reply other threads:[~2020-11-29 18:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 13:38 [PATCH 0/8] Rid W=1 warnings in Net Lee Jones
2020-11-26 13:38 ` Lee Jones
2020-11-26 13:38 ` [PATCH 1/8] net: ethernet: smsc: smc91x: Demote non-conformant kernel function header Lee Jones
2020-11-29 18:33 ` Andrew Lunn [this message]
2020-11-30 8:59 ` Lee Jones
2020-11-26 13:38 ` [PATCH 2/8] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Lee Jones
2020-11-29 18:34 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 3/8] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Lee Jones
2020-11-29 18:35 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 4/8] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Lee Jones
2020-11-29 18:37 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Lee Jones
2020-11-26 13:38 ` Lee Jones
2020-11-29 18:43 ` Andrew Lunn
2020-11-29 18:43 ` Andrew Lunn
2020-11-30 9:04 ` Lee Jones
2020-11-30 9:04 ` Lee Jones
2020-11-26 13:38 ` [PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: " Lee Jones
2020-11-26 13:38 ` Lee Jones
2020-11-29 18:45 ` Andrew Lunn
2020-11-29 18:45 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 7/8] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Lee Jones
2020-11-29 19:08 ` Andrew Lunn
2020-11-26 13:38 ` [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues Lee Jones
2020-11-26 13:38 ` Lee Jones
2020-11-29 19:10 ` Andrew Lunn
2020-11-29 19:10 ` Andrew Lunn
2020-11-30 8:59 ` Lee Jones
2020-11-30 8:59 ` Lee Jones
2020-11-27 17:39 ` [PATCH 0/8] Rid W=1 warnings in Net Jakub Kicinski
2020-11-27 17:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201129183309.GH2234159@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dnevil@snmc.com \
--cc=erik@vt.edu \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nico@fluxnic.net \
--cc=pc@denkart.be \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.