[PATCH] drm/kmb: Remove an unnecessary NULL check

[PATCH] drm/kmb: Remove an unnecessary NULL check

[Dan Carpenter]

The NULL checking isn't done consistently in this function and it leads
to a static checker warning:

    drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
    error: we previously assumed 'drm' could be null (see line 559)

Fortunately "drm" cannot be NULL at this point so the check can just be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 8c43b136765c..5ff392644603 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
 static int __maybe_unused kmb_pm_suspend(struct device *dev)
 {
 	struct drm_device *drm = dev_get_drvdata(dev);
-	struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
+	struct kmb_drm_private *kmb = to_kmb(drm);
 
 	drm_kms_helper_poll_disable(drm);
 
-- 
2.28.0

[PATCH] drm/kmb: Remove an unnecessary NULL check

[Dan Carpenter]

The NULL checking isn't done consistently in this function and it leads
to a static checker warning:

    drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
    error: we previously assumed 'drm' could be null (see line 559)

Fortunately "drm" cannot be NULL at this point so the check can just be
removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c
index 8c43b136765c..5ff392644603 100644
--- a/drivers/gpu/drm/kmb/kmb_drv.c
+++ b/drivers/gpu/drm/kmb/kmb_drv.c
@@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
 static int __maybe_unused kmb_pm_suspend(struct device *dev)
 {
 	struct drm_device *drm = dev_get_drvdata(dev);
-	struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
+	struct kmb_drm_private *kmb = to_kmb(drm);
 
 	drm_kms_helper_poll_disable(drm);
 
-- 
2.28.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Chrisanthus, Anitha]

Looks good to me.

Anitha

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, November 16, 2020 11:22 PM
> To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>
> Cc: Dea, Edmund J <edmund.j.dea@intel.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH] drm/kmb: Remove an unnecessary NULL check
> 
> The NULL checking isn't done consistently in this function and it leads
> to a static checker warning:
> 
>     drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
>     error: we previously assumed 'drm' could be null (see line 559)
> 
> Fortunately "drm" cannot be NULL at this point so the check can just be
> removed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index 8c43b136765c..5ff392644603 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
>  static int __maybe_unused kmb_pm_suspend(struct device *dev)
>  {
>  	struct drm_device *drm = dev_get_drvdata(dev);
> -	struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
> +	struct kmb_drm_private *kmb = to_kmb(drm);
> 
>  	drm_kms_helper_poll_disable(drm);
> 
> --
> 2.28.0

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Chrisanthus, Anitha]

Looks good to me.

Anitha

> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@oracle.com>
> Sent: Monday, November 16, 2020 11:22 PM
> To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>
> Cc: Dea, Edmund J <edmund.j.dea@intel.com>; David Airlie <airlied@linux.ie>;
> Daniel Vetter <daniel@ffwll.ch>; dri-devel@lists.freedesktop.org; kernel-
> janitors@vger.kernel.org
> Subject: [PATCH] drm/kmb: Remove an unnecessary NULL check
> 
> The NULL checking isn't done consistently in this function and it leads
> to a static checker warning:
> 
>     drivers/gpu/drm/kmb/kmb_drv.c:561 kmb_pm_suspend()
>     error: we previously assumed 'drm' could be null (see line 559)
> 
> Fortunately "drm" cannot be NULL at this point so the check can just be
> removed.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
>  drivers/gpu/drm/kmb/kmb_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/kmb/kmb_drv.c
> b/drivers/gpu/drm/kmb/kmb_drv.c
> index 8c43b136765c..5ff392644603 100644
> --- a/drivers/gpu/drm/kmb/kmb_drv.c
> +++ b/drivers/gpu/drm/kmb/kmb_drv.c
> @@ -557,7 +557,7 @@ MODULE_DEVICE_TABLE(of, kmb_of_match);
>  static int __maybe_unused kmb_pm_suspend(struct device *dev)
>  {
>  	struct drm_device *drm = dev_get_drvdata(dev);
> -	struct kmb_drm_private *kmb = drm ? to_kmb(drm) : NULL;
> +	struct kmb_drm_private *kmb = to_kmb(drm);
> 
>  	drm_kms_helper_poll_disable(drm);
> 
> --
> 2.28.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Sam Ravnborg]

Hi Anitha.

On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> Looks good to me.

Can we get either an "Acked-by:" or "Reviewed-by:"?
Then we can use this while applying.

Any news on gettting commit access yourself?
If not, then try to ping on the open ticket.


	Sam

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Sam Ravnborg]

Hi Anitha.

On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> Looks good to me.

Can we get either an "Acked-by:" or "Reviewed-by:"?
Then we can use this while applying.

Any news on gettting commit access yourself?
If not, then try to ping on the open ticket.


	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Thomas Zimmermann]

[-- Attachment #1.1.1: Type: text/plain, Size: 848 bytes --]

Hi

Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> Hi Anitha.
> 
> On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
>> Looks good to me.
> 
> Can we get either an "Acked-by:" or "Reviewed-by:"?
> Then we can use this while applying.
> 
> Any news on gettting commit access yourself?
> If not, then try to ping on the open ticket.

It's been acked a while ago. I sent out a reminder to Daniel Stone.

Best regards
Thomas

> 
> 
> 	Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 7535 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Thomas Zimmermann]

[-- Attachment #1.1.1.1: Type: text/plain, Size: 848 bytes --]

Hi

Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> Hi Anitha.
> 
> On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
>> Looks good to me.
> 
> Can we get either an "Acked-by:" or "Reviewed-by:"?
> Then we can use this while applying.
> 
> Any news on gettting commit access yourself?
> If not, then try to ping on the open ticket.

It's been acked a while ago. I sent out a reminder to Daniel Stone.

Best regards
Thomas

> 
> 
> 	Sam
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[-- Attachment #1.1.1.2: OpenPGP_0x680DC11D530B7A23.asc --]
[-- Type: application/pgp-keys, Size: 7535 bytes --]

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Chrisanthus, Anitha]

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogVGhvbWFzIFppbW1lcm1h
bm4gPHR6aW1tZXJtYW5uQHN1c2UuZGU+DQo+IFNlbnQ6IEZyaWRheSwgTm92ZW1iZXIgMjAsIDIw
MjAgMTI6MzQgQU0NCj4gVG86IFNhbSBSYXZuYm9yZyA8c2FtQHJhdm5ib3JnLm9yZz47IENocmlz
YW50aHVzLCBBbml0aGENCj4gPGFuaXRoYS5jaHJpc2FudGh1c0BpbnRlbC5jb20+DQo+IENjOiBE
YXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+OyBEZWEsIEVkbXVuZCBKIDxlZG11bmQuai5k
ZWFAaW50ZWwuY29tPjsNCj4ga2VybmVsLWphbml0b3JzQHZnZXIua2VybmVsLm9yZzsgZHJpLWRl
dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsgRGFuDQo+IENhcnBlbnRlciA8ZGFuLmNhcnBlbnRl
ckBvcmFjbGUuY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBkcm0va21iOiBSZW1vdmUgYW4g
dW5uZWNlc3NhcnkgTlVMTCBjaGVjaw0KPiANCj4gSGkNCj4gDQo+IEFtIDIwLjExLjIwIHVtIDA5
OjIxIHNjaHJpZWIgU2FtIFJhdm5ib3JnOg0KPiA+IEhpIEFuaXRoYS4NCj4gPg0KPiA+IE9uIEZy
aSwgTm92IDIwLCAyMDIwIGF0IDAxOjE5OjA2QU0gKzAwMDAsIENocmlzYW50aHVzLCBBbml0aGEg
d3JvdGU6DQo+ID4+IExvb2tzIGdvb2QgdG8gbWUuDQo+ID4NCj4gPiBDYW4gd2UgZ2V0IGVpdGhl
ciBhbiAiQWNrZWQtYnk6IiBvciAiUmV2aWV3ZWQtYnk6Ij8NCj4gPiBUaGVuIHdlIGNhbiB1c2Ug
dGhpcyB3aGlsZSBhcHBseWluZy4NClNvcnJ5LCBmb3Jnb3QgdGhhdC4NClJldmlld2VkLWJ5OiBB
bml0aGEgQ2hyaXNhbnRodXMgPGFuaXRoYS5jaHJpc2FudGh1c0BpbnRlbC5jb20+DQo+ID4NCj4g
PiBBbnkgbmV3cyBvbiBnZXR0dGluZyBjb21taXQgYWNjZXNzIHlvdXJzZWxmPw0KPiA+IElmIG5v
dCwgdGhlbiB0cnkgdG8gcGluZyBvbiB0aGUgb3BlbiB0aWNrZXQuDQo+IA0KPiBJdCdzIGJlZW4g
YWNrZWQgYSB3aGlsZSBhZ28uIEkgc2VudCBvdXQgYSByZW1pbmRlciB0byBEYW5pZWwgU3RvbmUu
DQpJIGRpZCBnZXQgYWNjZXNzIHRvZGF5LCB0aGFuayB5b3UhIEkgd2lsbCBoYXZlIHRvIGdldCBm
YW1pbGlhciB3aXRoIGRpbSBhbmQgdGhlIHdob2xlIHByb2Nlc3MgYmVmb3JlIEkgc3RhcnQgcHVz
aGluZyBwYXRjaGVzLg0KPiANCj4gQmVzdCByZWdhcmRzDQo+IFRob21hcw0KPiANCj4gPg0KPiA+
DQo+ID4gCVNhbQ0KPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fDQo+ID4gZHJpLWRldmVsIG1haWxpbmcgbGlzdA0KPiA+IGRyaS1kZXZlbEBsaXN0cy5m
cmVlZGVza3RvcC5vcmcNCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu
L2xpc3RpbmZvL2RyaS1kZXZlbA0KPiA+DQo+IA0KPiAtLQ0KPiBUaG9tYXMgWmltbWVybWFubg0K
PiBHcmFwaGljcyBEcml2ZXIgRGV2ZWxvcGVyDQo+IFNVU0UgU29mdHdhcmUgU29sdXRpb25zIEdl
cm1hbnkgR21iSA0KPiBNYXhmZWxkc3RyLiA1LCA5MDQwOSBOw7xybmJlcmcsIEdlcm1hbnkNCj4g
KEhSQiAzNjgwOSwgQUcgTsO8cm5iZXJnKQ0KPiBHZXNjaMOkZnRzZsO8aHJlcjogRmVsaXggSW1l
bmTDtnJmZmVyDQo

RE: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Chrisanthus, Anitha]

> -----Original Message-----
> From: Thomas Zimmermann <tzimmermann@suse.de>
> Sent: Friday, November 20, 2020 12:34 AM
> To: Sam Ravnborg <sam@ravnborg.org>; Chrisanthus, Anitha
> <anitha.chrisanthus@intel.com>
> Cc: David Airlie <airlied@linux.ie>; Dea, Edmund J <edmund.j.dea@intel.com>;
> kernel-janitors@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan
> Carpenter <dan.carpenter@oracle.com>
> Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
> 
> Hi
> 
> Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> > Hi Anitha.
> >
> > On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> >> Looks good to me.
> >
> > Can we get either an "Acked-by:" or "Reviewed-by:"?
> > Then we can use this while applying.
Sorry, forgot that.
Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> >
> > Any news on gettting commit access yourself?
> > If not, then try to ping on the open ticket.
> 
> It's been acked a while ago. I sent out a reminder to Daniel Stone.
I did get access today, thank you! I will have to get familiar with dim and the whole process before I start pushing patches.
> 
> Best regards
> Thomas
> 
> >
> >
> > 	Sam
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> 
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Maxfeldstr. 5, 90409 Nürnberg, Germany
> (HRB 36809, AG Nürnberg)
> Geschäftsführer: Felix Imendörffer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Sam Ravnborg]

Hi Anitha,

On Fri, Nov 20, 2020 at 05:28:59PM +0000, Chrisanthus, Anitha wrote:
> 
> 
> > -----Original Message-----
> > From: Thomas Zimmermann <tzimmermann@suse.de>
> > Sent: Friday, November 20, 2020 12:34 AM
> > To: Sam Ravnborg <sam@ravnborg.org>; Chrisanthus, Anitha
> > <anitha.chrisanthus@intel.com>
> > Cc: David Airlie <airlied@linux.ie>; Dea, Edmund J <edmund.j.dea@intel.com>;
> > kernel-janitors@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan
> > Carpenter <dan.carpenter@oracle.com>
> > Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
> > 
> > Hi
> > 
> > Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> > > Hi Anitha.
> > >
> > > On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> > >> Looks good to me.
> > >
> > > Can we get either an "Acked-by:" or "Reviewed-by:"?
> > > Then we can use this while applying.
> Sorry, forgot that.
> Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

Thanks, patch is now pushed to drm-misc-next.

	Sam

Re: [PATCH] drm/kmb: Remove an unnecessary NULL check

[Sam Ravnborg]

Hi Anitha,

On Fri, Nov 20, 2020 at 05:28:59PM +0000, Chrisanthus, Anitha wrote:
> 
> 
> > -----Original Message-----
> > From: Thomas Zimmermann <tzimmermann@suse.de>
> > Sent: Friday, November 20, 2020 12:34 AM
> > To: Sam Ravnborg <sam@ravnborg.org>; Chrisanthus, Anitha
> > <anitha.chrisanthus@intel.com>
> > Cc: David Airlie <airlied@linux.ie>; Dea, Edmund J <edmund.j.dea@intel.com>;
> > kernel-janitors@vger.kernel.org; dri-devel@lists.freedesktop.org; Dan
> > Carpenter <dan.carpenter@oracle.com>
> > Subject: Re: [PATCH] drm/kmb: Remove an unnecessary NULL check
> > 
> > Hi
> > 
> > Am 20.11.20 um 09:21 schrieb Sam Ravnborg:
> > > Hi Anitha.
> > >
> > > On Fri, Nov 20, 2020 at 01:19:06AM +0000, Chrisanthus, Anitha wrote:
> > >> Looks good to me.
> > >
> > > Can we get either an "Acked-by:" or "Reviewed-by:"?
> > > Then we can use this while applying.
> Sorry, forgot that.
> Reviewed-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>

Thanks, patch is now pushed to drm-misc-next.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel