From: Jason Gunthorpe <jgg@ziepe.ca> To: Jianxin Xiong <jianxin.xiong@intel.com> Cc: linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Doug Ledford <dledford@redhat.com>, Leon Romanovsky <leon@kernel.org>, Sumit Semwal <sumit.semwal@linaro.org>, Christian Koenig <christian.koenig@amd.com>, Daniel Vetter <daniel.vetter@intel.com> Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support Date: Mon, 30 Nov 2020 12:08:21 -0400 [thread overview] Message-ID: <20201130160821.GB5487@ziepe.ca> (raw) In-Reply-To: <1606510543-45567-5-git-send-email-jianxin.xiong@intel.com> On Fri, Nov 27, 2020 at 12:55:41PM -0800, Jianxin Xiong wrote: > > +function(rdma_multifile_module PY_MODULE MODULE_NAME LINKER_FLAGS) I think just replace rdma_cython_module with this? No good reason I can see to have two APIs? > + set(ALL_CFILES "") > + foreach(SRC_FILE ${ARGN}) > + get_filename_component(FILENAME ${SRC_FILE} NAME_WE) > + get_filename_component(DIR ${SRC_FILE} DIRECTORY) > + get_filename_component(EXT ${SRC_FILE} EXT) > + if (DIR) > + set(SRC_PATH "${CMAKE_CURRENT_SOURCE_DIR}/${DIR}") > + else() > + set(SRC_PATH "${CMAKE_CURRENT_SOURCE_DIR}") > + endif() > + if (${EXT} STREQUAL ".pyx") > + set(PYX "${SRC_PATH}/${FILENAME}.pyx") > + set(CFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.c") > + include_directories(${PYTHON_INCLUDE_DIRS}) > + add_custom_command( > + OUTPUT "${CFILE}" > + MAIN_DEPENDENCY "${PYX}" > + COMMAND ${CYTHON_EXECUTABLE} "${PYX}" -o "${CFILE}" > + "-I${PYTHON_INCLUDE_DIRS}" > + COMMENT "Cythonizing ${PYX}" > + ) > + set(ALL_CFILES "${ALL_CFILES};${CFILE}") > + elseif(${EXT} STREQUAL ".c") > + set(CFILE_ORIG "${SRC_PATH}/${FILENAME}.c") > + set(CFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.c") > + if (NOT ${CFILE_ORIG} STREQUAL ${CFILE}) > + rdma_create_symlink("${CFILE_ORIG}" "${CFILE}") > + endif() Why does this need the create_symlink? The compiler should work OK from the source file? > + set(ALL_CFILES "${ALL_CFILES};${CFILE}") > + elseif(${EXT} STREQUAL ".h") > + set(HFILE_ORIG "${SRC_PATH}/${FILENAME}.h") > + set(HFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.h") > + if (NOT ${HFILE_ORIG} STREQUAL ${HFILE}) > + rdma_create_symlink("${HFILE_ORIG}" "${HFILE}") Here too? You probably don't need to specify h files at all, at worst they should only be used with publish_internal_headers > + endif() > + else() > + continue() > + endif() > + endforeach() > + string(REGEX REPLACE "\\.so$" "" SONAME "${MODULE_NAME}${CMAKE_PYTHON_SO_SUFFIX}") > + add_library(${SONAME} SHARED ${ALL_CFILES}) > + set_target_properties(${SONAME} PROPERTIES > + COMPILE_FLAGS "${CMAKE_C_FLAGS} -fPIC -fno-strict-aliasing -Wno-unused-function -Wno-redundant-decls -Wno-shadow -Wno-cast-function-type -Wno-implicit-fallthrough -Wno-unknown-warning -Wno-unknown-warning-option -Wno-deprecated-declarations ${NO_VAR_TRACKING_FLAGS}" Ugh, you copy and pasted this, but it shouldn't have existed in the first place. Compiler arguments like this should not be specified manually. I should fix it.. Also you should cc edward on all this pyverbs stuff, he knows it all very well It all looks reasonable to me Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca> To: Jianxin Xiong <jianxin.xiong@intel.com> Cc: Leon Romanovsky <leon@kernel.org>, linux-rdma@vger.kernel.org, dri-devel@lists.freedesktop.org, Doug Ledford <dledford@redhat.com>, Daniel Vetter <daniel.vetter@intel.com>, Christian Koenig <christian.koenig@amd.com> Subject: Re: [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support Date: Mon, 30 Nov 2020 12:08:21 -0400 [thread overview] Message-ID: <20201130160821.GB5487@ziepe.ca> (raw) In-Reply-To: <1606510543-45567-5-git-send-email-jianxin.xiong@intel.com> On Fri, Nov 27, 2020 at 12:55:41PM -0800, Jianxin Xiong wrote: > > +function(rdma_multifile_module PY_MODULE MODULE_NAME LINKER_FLAGS) I think just replace rdma_cython_module with this? No good reason I can see to have two APIs? > + set(ALL_CFILES "") > + foreach(SRC_FILE ${ARGN}) > + get_filename_component(FILENAME ${SRC_FILE} NAME_WE) > + get_filename_component(DIR ${SRC_FILE} DIRECTORY) > + get_filename_component(EXT ${SRC_FILE} EXT) > + if (DIR) > + set(SRC_PATH "${CMAKE_CURRENT_SOURCE_DIR}/${DIR}") > + else() > + set(SRC_PATH "${CMAKE_CURRENT_SOURCE_DIR}") > + endif() > + if (${EXT} STREQUAL ".pyx") > + set(PYX "${SRC_PATH}/${FILENAME}.pyx") > + set(CFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.c") > + include_directories(${PYTHON_INCLUDE_DIRS}) > + add_custom_command( > + OUTPUT "${CFILE}" > + MAIN_DEPENDENCY "${PYX}" > + COMMAND ${CYTHON_EXECUTABLE} "${PYX}" -o "${CFILE}" > + "-I${PYTHON_INCLUDE_DIRS}" > + COMMENT "Cythonizing ${PYX}" > + ) > + set(ALL_CFILES "${ALL_CFILES};${CFILE}") > + elseif(${EXT} STREQUAL ".c") > + set(CFILE_ORIG "${SRC_PATH}/${FILENAME}.c") > + set(CFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.c") > + if (NOT ${CFILE_ORIG} STREQUAL ${CFILE}) > + rdma_create_symlink("${CFILE_ORIG}" "${CFILE}") > + endif() Why does this need the create_symlink? The compiler should work OK from the source file? > + set(ALL_CFILES "${ALL_CFILES};${CFILE}") > + elseif(${EXT} STREQUAL ".h") > + set(HFILE_ORIG "${SRC_PATH}/${FILENAME}.h") > + set(HFILE "${CMAKE_CURRENT_BINARY_DIR}/${FILENAME}.h") > + if (NOT ${HFILE_ORIG} STREQUAL ${HFILE}) > + rdma_create_symlink("${HFILE_ORIG}" "${HFILE}") Here too? You probably don't need to specify h files at all, at worst they should only be used with publish_internal_headers > + endif() > + else() > + continue() > + endif() > + endforeach() > + string(REGEX REPLACE "\\.so$" "" SONAME "${MODULE_NAME}${CMAKE_PYTHON_SO_SUFFIX}") > + add_library(${SONAME} SHARED ${ALL_CFILES}) > + set_target_properties(${SONAME} PROPERTIES > + COMPILE_FLAGS "${CMAKE_C_FLAGS} -fPIC -fno-strict-aliasing -Wno-unused-function -Wno-redundant-decls -Wno-shadow -Wno-cast-function-type -Wno-implicit-fallthrough -Wno-unknown-warning -Wno-unknown-warning-option -Wno-deprecated-declarations ${NO_VAR_TRACKING_FLAGS}" Ugh, you copy and pasted this, but it shouldn't have existed in the first place. Compiler arguments like this should not be specified manually. I should fix it.. Also you should cc edward on all this pyverbs stuff, he knows it all very well It all looks reasonable to me Jason _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-30 16:09 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-27 20:55 [PATCH rdma-core v3 0/6] Add user space dma-buf support Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-11-27 20:55 ` [PATCH rdma-core v3 1/6] Update kernel headers Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-11-27 20:55 ` [PATCH rdma-core v3 2/6] verbs: Support dma-buf based memory region Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-12-02 16:33 ` Yishai Hadas 2020-12-02 16:33 ` Yishai Hadas 2020-11-27 20:55 ` [PATCH rdma-core v3 3/6] mlx5: " Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-11-27 20:55 ` [PATCH rdma-core v3 4/6] pyverbs: Add dma-buf based MR support Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-11-30 14:57 ` Daniel Vetter 2020-11-30 14:57 ` Daniel Vetter 2020-11-30 15:55 ` Jason Gunthorpe 2020-11-30 15:55 ` Jason Gunthorpe 2020-11-30 16:04 ` Daniel Vetter 2020-11-30 16:04 ` Daniel Vetter 2020-11-30 16:36 ` Jason Gunthorpe 2020-11-30 16:36 ` Jason Gunthorpe 2020-11-30 16:55 ` Daniel Vetter 2020-11-30 16:55 ` Daniel Vetter 2020-11-30 18:03 ` Xiong, Jianxin 2020-11-30 18:03 ` Xiong, Jianxin 2020-11-30 18:13 ` Xiong, Jianxin 2020-11-30 18:13 ` Xiong, Jianxin 2020-11-30 16:08 ` Jason Gunthorpe [this message] 2020-11-30 16:08 ` Jason Gunthorpe 2020-11-30 17:53 ` Xiong, Jianxin 2020-11-30 17:53 ` Xiong, Jianxin 2020-12-02 0:39 ` Jason Gunthorpe 2020-12-02 0:39 ` Jason Gunthorpe 2020-12-02 1:12 ` Xiong, Jianxin 2020-12-02 1:12 ` Xiong, Jianxin 2020-11-27 20:55 ` [PATCH rdma-core v3 5/6] tests: Add tests for dma-buf based memory regions Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong 2020-11-30 15:00 ` Daniel Vetter 2020-11-30 15:00 ` Daniel Vetter 2020-11-30 17:35 ` Xiong, Jianxin 2020-11-30 17:35 ` Xiong, Jianxin 2020-11-30 17:46 ` Daniel Vetter 2020-11-30 17:46 ` Daniel Vetter 2020-11-27 20:55 ` [PATCH rdma-core v3 6/6] tests: Bug fix for get_access_flags() Jianxin Xiong 2020-11-27 20:55 ` Jianxin Xiong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201130160821.GB5487@ziepe.ca \ --to=jgg@ziepe.ca \ --cc=christian.koenig@amd.com \ --cc=daniel.vetter@intel.com \ --cc=dledford@redhat.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jianxin.xiong@intel.com \ --cc=leon@kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=sumit.semwal@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.