[Intel-gfx] [PATCH 0/9] drm/i915: Add the missing wakeref tracking for display power references

[Intel-gfx] [PATCH 0/9] drm/i915: Add the missing wakeref tracking for display power references

[Imre Deak]

Add wakeref tracking for display power domain references where this was
still missing.

Cc: Chris Wilson <chris@chris-wilson.co.uk>

Imre Deak (9):
  drm/i915: Make atomic commit get/put power domains symmetric
  drm/i915: Factor out helpers to get/put a set of tracked power domains
  drm/i915: Track power references taken for enabled CRTCs
  drm/i915/ddi: Track power reference taken for encoder DDI IO use
  drm/i915/ddi: Track power reference taken for encoder main lane AUX
    use
  drm/i915: Track power reference taken for eDP VDD
  drm/i915: Rename power_domains.wakeref to init_wakeref
  drm/i915: Track power reference taken to disable power well
    functionality
  drm/i915: Make intel_display_power_put_unchecked() an internal-only
    function

 drivers/gpu/drm/i915/display/intel_ddi.c      |  61 +++++----
 drivers/gpu/drm/i915/display/intel_display.c  | 100 +++++---------
 .../drm/i915/display/intel_display_power.c    | 123 +++++++++++++-----
 .../drm/i915/display/intel_display_power.h    |  37 +++++-
 .../drm/i915/display/intel_display_types.h    |   5 +-
 drivers/gpu/drm/i915/display/intel_dp.c       |  18 ++-
 drivers/gpu/drm/i915/i915_debugfs.c           |   2 +-
 7 files changed, 212 insertions(+), 134 deletions(-)

-- 
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/9] drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

[Imre Deak]

The for_each_oldnew_intel_crtc_in_state() iterator index does match
crtc->pipe, but using the same thing as array index when getting and
putting CRTC power domains makes things clearer.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index ba26545392bc..d812d7ae5e65 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -16376,8 +16376,8 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
 		intel_post_plane_update(state, crtc);
 
-		if (put_domains[i])
-			modeset_put_power_domains(dev_priv, put_domains[i]);
+		if (put_domains[crtc->pipe])
+			modeset_put_power_domains(dev_priv, put_domains[crtc->pipe]);
 
 		intel_modeset_verify_crtc(crtc, state, old_crtc_state, new_crtc_state);
 
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/9] drm/i915: Factor out helpers to get/put a set of tracked power domains

[Imre Deak]

Factor out helper functions to get/put a set of power domains that are
tracked using their wakeref handles. The same is needed by the next
patch adding tracking for enabled CRTC power domains.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c  | 62 +++++--------------
 .../drm/i915/display/intel_display_power.c    | 57 +++++++++++++++++
 .../drm/i915/display/intel_display_power.h    | 29 +++++++++
 3 files changed, 100 insertions(+), 48 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d812d7ae5e65..d80d15d96d4c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -11226,16 +11226,13 @@ static void hsw_get_ddi_pll(struct drm_i915_private *dev_priv, enum port port,
 
 static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 				     struct intel_crtc_state *pipe_config,
-				     u64 *power_domain_mask,
-				     intel_wakeref_t *wakerefs)
+				     struct intel_display_power_domain_set *power_domain_set)
 {
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	enum intel_display_power_domain power_domain;
 	unsigned long panel_transcoder_mask = BIT(TRANSCODER_EDP);
 	unsigned long enabled_panel_transcoders = 0;
 	enum transcoder panel_transcoder;
-	intel_wakeref_t wf;
 	u32 tmp;
 
 	if (INTEL_GEN(dev_priv) >= 11)
@@ -11306,16 +11303,10 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 	drm_WARN_ON(dev, (enabled_panel_transcoders & BIT(TRANSCODER_EDP)) &&
 		    enabled_panel_transcoders != BIT(TRANSCODER_EDP));
 
-	power_domain = POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder);
-	drm_WARN_ON(dev, *power_domain_mask & BIT_ULL(power_domain));
-
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (!wf)
+	if (!intel_display_power_get_in_set_if_enabled(dev_priv, power_domain_set,
+						       POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder)))
 		return false;
 
-	wakerefs[power_domain] = wf;
-	*power_domain_mask |= BIT_ULL(power_domain);
-
 	tmp = intel_de_read(dev_priv, PIPECONF(pipe_config->cpu_transcoder));
 
 	return tmp & PIPECONF_ENABLE;
@@ -11323,14 +11314,11 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 
 static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
 					 struct intel_crtc_state *pipe_config,
-					 u64 *power_domain_mask,
-					 intel_wakeref_t *wakerefs)
+					 struct intel_display_power_domain_set *power_domain_set)
 {
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	enum intel_display_power_domain power_domain;
 	enum transcoder cpu_transcoder;
-	intel_wakeref_t wf;
 	enum port port;
 	u32 tmp;
 
@@ -11340,16 +11328,10 @@ static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
 		else
 			cpu_transcoder = TRANSCODER_DSI_C;
 
-		power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder);
-		drm_WARN_ON(dev, *power_domain_mask & BIT_ULL(power_domain));
-
-		wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-		if (!wf)
+		if (!intel_display_power_get_in_set_if_enabled(dev_priv, power_domain_set,
+							       POWER_DOMAIN_TRANSCODER(cpu_transcoder)))
 			continue;
 
-		wakerefs[power_domain] = wf;
-		*power_domain_mask |= BIT_ULL(power_domain);
-
 		/*
 		 * The PLL needs to be enabled with a valid divider
 		 * configuration, otherwise accessing DSI registers will hang
@@ -11432,30 +11414,22 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 				struct intel_crtc_state *pipe_config)
 {
 	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-	intel_wakeref_t wakerefs[POWER_DOMAIN_NUM], wf;
-	enum intel_display_power_domain power_domain;
-	u64 power_domain_mask;
+	struct intel_display_power_domain_set power_domain_set = { };
 	bool active;
 	u32 tmp;
 
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
-	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (!wf)
+	if (!intel_display_power_get_in_set_if_enabled(dev_priv, &power_domain_set,
+						       POWER_DOMAIN_PIPE(crtc->pipe)))
 		return false;
 
-	wakerefs[power_domain] = wf;
-	power_domain_mask = BIT_ULL(power_domain);
-
 	pipe_config->shared_dpll = NULL;
 
-	active = hsw_get_transcoder_state(crtc, pipe_config,
-					  &power_domain_mask, wakerefs);
+	active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_set);
 
 	if (IS_GEN9_LP(dev_priv) &&
-	    bxt_get_dsi_transcoder_state(crtc, pipe_config,
-					 &power_domain_mask, wakerefs)) {
+	    bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_set)) {
 		drm_WARN_ON(&dev_priv->drm, active);
 		active = true;
 	}
@@ -11519,14 +11493,8 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 		pipe_config->ips_linetime =
 			REG_FIELD_GET(HSW_IPS_LINETIME_MASK, tmp);
 
-	power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe);
-	drm_WARN_ON(&dev_priv->drm, power_domain_mask & BIT_ULL(power_domain));
-
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (wf) {
-		wakerefs[power_domain] = wf;
-		power_domain_mask |= BIT_ULL(power_domain);
-
+	if (intel_display_power_get_in_set_if_enabled(dev_priv, &power_domain_set,
+						      POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe))) {
 		if (INTEL_GEN(dev_priv) >= 9)
 			skl_get_pfit_config(pipe_config);
 		else
@@ -11560,9 +11528,7 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 	}
 
 out:
-	for_each_power_domain(power_domain, power_domain_mask)
-		intel_display_power_put(dev_priv,
-					power_domain, wakerefs[power_domain]);
+	intel_display_power_put_all_in_set(dev_priv, &power_domain_set);
 
 	return active;
 }
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index fe2d90bba536..b48dbb7bdaf4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -2412,6 +2412,63 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 }
 #endif
 
+void
+intel_display_power_get_in_set(struct drm_i915_private *i915,
+			       struct intel_display_power_domain_set *power_domain_set,
+			       enum intel_display_power_domain domain)
+{
+	intel_wakeref_t __maybe_unused wf;
+
+	drm_WARN_ON(&i915->drm, power_domain_set->mask & BIT_ULL(domain));
+
+	wf = intel_display_power_get(i915, domain);
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+	power_domain_set->wakerefs[domain] = wf;
+#endif
+	power_domain_set->mask |= BIT_ULL(domain);
+}
+
+bool
+intel_display_power_get_in_set_if_enabled(struct drm_i915_private *i915,
+					  struct intel_display_power_domain_set *power_domain_set,
+					  enum intel_display_power_domain domain)
+{
+	intel_wakeref_t wf;
+
+	drm_WARN_ON(&i915->drm, power_domain_set->mask & BIT_ULL(domain));
+
+	wf = intel_display_power_get_if_enabled(i915, domain);
+	if (!wf)
+		return false;
+
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+	power_domain_set->wakerefs[domain] = wf;
+#endif
+	power_domain_set->mask |= BIT_ULL(domain);
+
+	return true;
+}
+
+void
+intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
+				    struct intel_display_power_domain_set *power_domain_set,
+				    u64 mask)
+{
+	enum intel_display_power_domain domain;
+
+	drm_WARN_ON(&i915->drm, mask & ~power_domain_set->mask);
+
+	for_each_power_domain(domain, mask) {
+		intel_wakeref_t __maybe_unused wf = -1;
+
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+		wf = fetch_and_zero(&power_domain_set->wakerefs[domain]);
+#endif
+		intel_display_power_put(i915, domain, wf);
+		power_domain_set->mask &= ~BIT_ULL(domain);
+	}
+}
+
 #define I830_PIPES_POWER_DOMAINS (		\
 	BIT_ULL(POWER_DOMAIN_PIPE_A) |		\
 	BIT_ULL(POWER_DOMAIN_PIPE_B) |		\
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 4aa0a09cf14f..64f4d57ff09b 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -224,6 +224,13 @@ struct i915_power_domains {
 	struct i915_power_well *power_wells;
 };
 
+struct intel_display_power_domain_set {
+	uint64_t mask;
+#ifdef CONFIG_DRM_I915_DEBUG_RUNTIME_PM
+	intel_wakeref_t wakerefs[POWER_DOMAIN_NUM];
+#endif
+};
+
 #define for_each_power_domain(domain, mask)				\
 	for ((domain) = 0; (domain) < POWER_DOMAIN_NUM; (domain)++)	\
 		for_each_if(BIT_ULL(domain) & (mask))
@@ -314,6 +321,28 @@ intel_display_power_put_async(struct drm_i915_private *i915,
 }
 #endif
 
+void
+intel_display_power_get_in_set(struct drm_i915_private *i915,
+			       struct intel_display_power_domain_set *power_domain_set,
+			       enum intel_display_power_domain domain);
+
+bool
+intel_display_power_get_in_set_if_enabled(struct drm_i915_private *i915,
+					  struct intel_display_power_domain_set *power_domain_set,
+					  enum intel_display_power_domain domain);
+
+void
+intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
+				    struct intel_display_power_domain_set *power_domain_set,
+				    u64 mask);
+
+static inline void
+intel_display_power_put_all_in_set(struct drm_i915_private *i915,
+				   struct intel_display_power_domain_set *power_domain_set)
+{
+	intel_display_power_put_mask_in_set(i915, power_domain_set, power_domain_set->mask);
+}
+
 enum dbuf_slice {
 	DBUF_S1,
 	DBUF_S2,
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 3/9] drm/i915: Track power references taken for enabled CRTCs

[Imre Deak]

Add wakeref tracking for display power domain references taken for
enabled CRTCs.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c  | 38 ++++++++-----------
 .../drm/i915/display/intel_display_types.h    |  2 +-
 2 files changed, 17 insertions(+), 23 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d80d15d96d4c..a6043197171b 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -7575,25 +7575,25 @@ modeset_get_crtc_power_domains(struct intel_crtc_state *crtc_state)
 	enum intel_display_power_domain domain;
 	u64 domains, new_domains, old_domains;
 
-	old_domains = crtc->enabled_power_domains;
-	crtc->enabled_power_domains = new_domains =
-		get_crtc_power_domains(crtc_state);
+	domains = get_crtc_power_domains(crtc_state);
 
-	domains = new_domains & ~old_domains;
+	new_domains = domains & ~crtc->enabled_power_domains.mask;
+	old_domains = crtc->enabled_power_domains.mask & ~domains;
 
-	for_each_power_domain(domain, domains)
-		intel_display_power_get(dev_priv, domain);
+	for_each_power_domain(domain, new_domains)
+		intel_display_power_get_in_set(dev_priv,
+					       &crtc->enabled_power_domains,
+					       domain);
 
-	return old_domains & ~new_domains;
+	return old_domains;
 }
 
-static void modeset_put_power_domains(struct drm_i915_private *dev_priv,
-				      u64 domains)
+static void modeset_put_crtc_power_domains(struct intel_crtc *crtc,
+					   u64 domains)
 {
-	enum intel_display_power_domain domain;
-
-	for_each_power_domain(domain, domains)
-		intel_display_power_put_unchecked(dev_priv, domain);
+	intel_display_power_put_mask_in_set(to_i915(crtc->base.dev),
+					    &crtc->enabled_power_domains,
+					    domains);
 }
 
 static void valleyview_crtc_enable(struct intel_atomic_state *state,
@@ -7789,12 +7789,10 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
 		to_intel_dbuf_state(dev_priv->dbuf.obj.state);
 	struct intel_crtc_state *crtc_state =
 		to_intel_crtc_state(crtc->base.state);
-	enum intel_display_power_domain domain;
 	struct intel_plane *plane;
 	struct drm_atomic_state *state;
 	struct intel_crtc_state *temp_crtc_state;
 	enum pipe pipe = crtc->pipe;
-	u64 domains;
 	int ret;
 
 	if (!crtc_state->hw.active)
@@ -7850,10 +7848,7 @@ static void intel_crtc_disable_noatomic(struct intel_crtc *crtc,
 	intel_update_watermarks(crtc);
 	intel_disable_shared_dpll(crtc_state);
 
-	domains = crtc->enabled_power_domains;
-	for_each_power_domain(domain, domains)
-		intel_display_power_put_unchecked(dev_priv, domain);
-	crtc->enabled_power_domains = 0;
+	intel_display_power_put_all_in_set(dev_priv, &crtc->enabled_power_domains);
 
 	dev_priv->active_pipes &= ~BIT(pipe);
 	cdclk_state->min_cdclk[pipe] = 0;
@@ -16342,8 +16337,7 @@ static void intel_atomic_commit_tail(struct intel_atomic_state *state)
 	for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
 		intel_post_plane_update(state, crtc);
 
-		if (put_domains[crtc->pipe])
-			modeset_put_power_domains(dev_priv, put_domains[crtc->pipe]);
+		modeset_put_crtc_power_domains(crtc, put_domains[crtc->pipe]);
 
 		intel_modeset_verify_crtc(crtc, state, old_crtc_state, new_crtc_state);
 
@@ -19554,7 +19548,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev,
 
 		put_domains = modeset_get_crtc_power_domains(crtc_state);
 		if (drm_WARN_ON(dev, put_domains))
-			modeset_put_power_domains(dev_priv, put_domains);
+			modeset_put_crtc_power_domains(crtc, put_domains);
 	}
 
 	intel_display_power_put(dev_priv, POWER_DOMAIN_INIT, wakeref);
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index ce82d654d0f2..2dcda480b714 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1160,7 +1160,7 @@ struct intel_crtc {
 	/* I915_MODE_FLAG_* */
 	u8 mode_flags;
 
-	unsigned long long enabled_power_domains;
+	struct intel_display_power_domain_set enabled_power_domains;
 	struct intel_overlay *overlay;
 
 	struct intel_crtc_state *config;
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

[Imre Deak]

Add wakeref tracking for the DDI encoders' DDI_IO display power domain
references.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c      | 38 ++++++++++++-------
 .../drm/i915/display/intel_display_types.h    |  1 +
 2 files changed, 25 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 92940a0c5ef8..9518d298b0f7 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2285,9 +2285,11 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
 	dig_port = enc_to_dig_port(encoder);
 
 	if (!intel_phy_is_tc(dev_priv, phy) ||
-	    dig_port->tc_mode != TC_PORT_TBT_ALT)
-		intel_display_power_get(dev_priv,
-					dig_port->ddi_io_power_domain);
+	    dig_port->tc_mode != TC_PORT_TBT_ALT) {
+		drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
+		dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
+								   dig_port->ddi_io_power_domain);
+	}
 
 	/*
 	 * AUX power is only needed for (e)DP mode, and for HDMI mode on TC
@@ -3577,9 +3579,11 @@ static void tgl_ddi_pre_enable_dp(struct intel_atomic_state *state,
 
 	/* 5. If IO power is controlled through PWR_WELL_CTL, Enable IO Power */
 	if (!intel_phy_is_tc(dev_priv, phy) ||
-	    dig_port->tc_mode != TC_PORT_TBT_ALT)
-		intel_display_power_get(dev_priv,
-					dig_port->ddi_io_power_domain);
+	    dig_port->tc_mode != TC_PORT_TBT_ALT) {
+		drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
+		dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
+								   dig_port->ddi_io_power_domain);
+	}
 
 	/* 6. Program DP_MODE */
 	icl_program_mg_dp_mode(dig_port, crtc_state);
@@ -3698,9 +3702,11 @@ static void hsw_ddi_pre_enable_dp(struct intel_atomic_state *state,
 	intel_ddi_clk_select(encoder, crtc_state);
 
 	if (!intel_phy_is_tc(dev_priv, phy) ||
-	    dig_port->tc_mode != TC_PORT_TBT_ALT)
-		intel_display_power_get(dev_priv,
-					dig_port->ddi_io_power_domain);
+	    dig_port->tc_mode != TC_PORT_TBT_ALT) {
+		drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
+		dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
+								   dig_port->ddi_io_power_domain);
+	}
 
 	icl_program_mg_dp_mode(dig_port, crtc_state);
 
@@ -3778,7 +3784,9 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
 	intel_dp_dual_mode_set_tmds_output(intel_hdmi, true);
 	intel_ddi_clk_select(encoder, crtc_state);
 
-	intel_display_power_get(dev_priv, dig_port->ddi_io_power_domain);
+	drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
+	dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
+							   dig_port->ddi_io_power_domain);
 
 	icl_program_mg_dp_mode(dig_port, crtc_state);
 
@@ -3936,8 +3944,9 @@ static void intel_ddi_post_disable_dp(struct intel_atomic_state *state,
 
 	if (!intel_phy_is_tc(dev_priv, phy) ||
 	    dig_port->tc_mode != TC_PORT_TBT_ALT)
-		intel_display_power_put_unchecked(dev_priv,
-						  dig_port->ddi_io_power_domain);
+		intel_display_power_put(dev_priv,
+					dig_port->ddi_io_power_domain,
+					fetch_and_zero(&dig_port->ddi_io_wakeref));
 
 	intel_ddi_clk_disable(encoder);
 }
@@ -3958,8 +3967,9 @@ static void intel_ddi_post_disable_hdmi(struct intel_atomic_state *state,
 
 	intel_disable_ddi_buf(encoder, old_crtc_state);
 
-	intel_display_power_put_unchecked(dev_priv,
-					  dig_port->ddi_io_power_domain);
+	intel_display_power_put(dev_priv,
+				dig_port->ddi_io_power_domain,
+				fetch_and_zero(&dig_port->ddi_io_wakeref));
 
 	intel_ddi_clk_disable(encoder);
 
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 2dcda480b714..91ed5c445150 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1466,6 +1466,7 @@ struct intel_digital_port {
 	/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */
 	enum aux_ch aux_ch;
 	enum intel_display_power_domain ddi_io_power_domain;
+	intel_wakeref_t ddi_io_wakeref;
 	struct mutex tc_lock;	/* protects the TypeC port mode */
 	intel_wakeref_t tc_lock_wakeref;
 	int tc_link_refcount;
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 5/9] drm/i915/ddi: Track power reference taken for encoder main lane AUX use

[Imre Deak]

Add wakeref tracking for the DDI encoders' main lane AUX display power
domain references.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c      | 23 ++++++++++++-------
 .../drm/i915/display/intel_display_types.h    |  1 +
 2 files changed, 16 insertions(+), 8 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 9518d298b0f7..bfcfe8c3567e 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2296,9 +2296,12 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
 	 * ports.
 	 */
 	if (intel_crtc_has_dp_encoder(crtc_state) ||
-	    intel_phy_is_tc(dev_priv, phy))
-		intel_display_power_get(dev_priv,
-					intel_ddi_main_link_aux_domain(dig_port));
+	    intel_phy_is_tc(dev_priv, phy)) {
+		drm_WARN_ON(&dev_priv->drm, dig_port->aux_wakeref);
+		dig_port->aux_wakeref =
+			intel_display_power_get(dev_priv,
+						intel_ddi_main_link_aux_domain(dig_port));
+	}
 }
 
 void intel_ddi_enable_pipe_clock(struct intel_encoder *encoder,
@@ -4042,8 +4045,9 @@ static void intel_ddi_post_disable(struct intel_atomic_state *state,
 		icl_unmap_plls_to_ports(encoder);
 
 	if (intel_crtc_has_dp_encoder(old_crtc_state) || is_tc_port)
-		intel_display_power_put_unchecked(dev_priv,
-						  intel_ddi_main_link_aux_domain(dig_port));
+		intel_display_power_put(dev_priv,
+					intel_ddi_main_link_aux_domain(dig_port),
+					fetch_and_zero(&dig_port->aux_wakeref));
 
 	if (is_tc_port)
 		intel_tc_port_put_link(dig_port);
@@ -4378,9 +4382,12 @@ intel_ddi_pre_pll_enable(struct intel_atomic_state *state,
 	if (is_tc_port)
 		intel_tc_port_get_link(dig_port, crtc_state->lane_count);
 
-	if (intel_crtc_has_dp_encoder(crtc_state) || is_tc_port)
-		intel_display_power_get(dev_priv,
-					intel_ddi_main_link_aux_domain(dig_port));
+	if (intel_crtc_has_dp_encoder(crtc_state) || is_tc_port) {
+		drm_WARN_ON(&dev_priv->drm, dig_port->aux_wakeref);
+		dig_port->aux_wakeref =
+			intel_display_power_get(dev_priv,
+						intel_ddi_main_link_aux_domain(dig_port));
+	}
 
 	if (is_tc_port && dig_port->tc_mode != TC_PORT_TBT_ALT)
 		/*
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 91ed5c445150..22f7328023a0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1467,6 +1467,7 @@ struct intel_digital_port {
 	enum aux_ch aux_ch;
 	enum intel_display_power_domain ddi_io_power_domain;
 	intel_wakeref_t ddi_io_wakeref;
+	intel_wakeref_t aux_wakeref;
 	struct mutex tc_lock;	/* protects the TypeC port mode */
 	intel_wakeref_t tc_lock_wakeref;
 	int tc_link_refcount;
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 6/9] drm/i915: Track power reference taken for eDP VDD

[Imre Deak]

Add wakeref tracking for the eDP encoders' AUX display power domain
references taken while the panel's VDD is enabled.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../gpu/drm/i915/display/intel_display_types.h |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c        | 18 ++++++++++++------
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 22f7328023a0..4217abddac4c 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1369,6 +1369,7 @@ struct intel_dp {
 	unsigned long last_power_on;
 	unsigned long last_backlight_off;
 	ktime_t panel_power_off_time;
+	intel_wakeref_t vdd_wakeref;
 
 	/*
 	 * Pipe whose power sequencer is currently locked into
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 3896d08c4177..b1a73e8af670 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3094,8 +3094,9 @@ static bool edp_panel_vdd_on(struct intel_dp *intel_dp)
 	if (edp_have_panel_vdd(intel_dp))
 		return need_to_disable;
 
-	intel_display_power_get(dev_priv,
-				intel_aux_power_domain(dig_port));
+	drm_WARN_ON(&dev_priv->drm, intel_dp->vdd_wakeref);
+	intel_dp->vdd_wakeref = intel_display_power_get(dev_priv,
+							intel_aux_power_domain(dig_port));
 
 	drm_dbg_kms(&dev_priv->drm, "Turning [ENCODER:%d:%s] VDD on\n",
 		    dig_port->base.base.base.id,
@@ -3188,8 +3189,9 @@ static void edp_panel_vdd_off_sync(struct intel_dp *intel_dp)
 	if ((pp & PANEL_POWER_ON) == 0)
 		intel_dp->panel_power_off_time = ktime_get_boottime();
 
-	intel_display_power_put_unchecked(dev_priv,
-					  intel_aux_power_domain(dig_port));
+	intel_display_power_put(dev_priv,
+				intel_aux_power_domain(dig_port),
+				fetch_and_zero(&intel_dp->vdd_wakeref));
 }
 
 static void edp_panel_vdd_work(struct work_struct *__work)
@@ -3341,7 +3343,9 @@ static void edp_panel_off(struct intel_dp *intel_dp)
 	intel_dp->panel_power_off_time = ktime_get_boottime();
 
 	/* We got a reference when we enabled the VDD. */
-	intel_display_power_put_unchecked(dev_priv, intel_aux_power_domain(dig_port));
+	intel_display_power_put(dev_priv,
+				intel_aux_power_domain(dig_port),
+				fetch_and_zero(&intel_dp->vdd_wakeref));
 }
 
 void intel_edp_panel_off(struct intel_dp *intel_dp)
@@ -6876,7 +6880,9 @@ static void intel_edp_panel_vdd_sanitize(struct intel_dp *intel_dp)
 	 */
 	drm_dbg_kms(&dev_priv->drm,
 		    "VDD left on by BIOS, adjusting state tracking\n");
-	intel_display_power_get(dev_priv, intel_aux_power_domain(dig_port));
+	drm_WARN_ON(&dev_priv->drm, intel_dp->vdd_wakeref);
+	intel_dp->vdd_wakeref = intel_display_power_get(dev_priv,
+							intel_aux_power_domain(dig_port));
 
 	edp_panel_vdd_schedule_off(intel_dp);
 }
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 7/9] drm/i915: Rename power_domains.wakeref to init_wakeref

[Imre Deak]

Rename power_domains.wakeref to power_domains.init_wakeref to make the
use of this reference clearer. The next patch adds tracking for another
power reference user of the power_domains functionality.

While at it add a missing zero wakeref assert when setting the wakeref.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../gpu/drm/i915/display/intel_display_power.c  | 17 +++++++++--------
 .../gpu/drm/i915/display/intel_display_power.h  |  2 +-
 drivers/gpu/drm/i915/i915_debugfs.c             |  2 +-
 3 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index b48dbb7bdaf4..75e805d11dd9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5658,7 +5658,8 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume)
 	 * resources powered until display HW readout is complete. We drop
 	 * this reference in intel_power_domains_enable().
 	 */
-	power_domains->wakeref =
+	drm_WARN_ON(&i915->drm, power_domains->init_wakeref);
+	power_domains->init_wakeref =
 		intel_display_power_get(i915, POWER_DOMAIN_INIT);
 
 	/* Disable power support if the user asked so. */
@@ -5683,7 +5684,7 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume)
 void intel_power_domains_driver_remove(struct drm_i915_private *i915)
 {
 	intel_wakeref_t wakeref __maybe_unused =
-		fetch_and_zero(&i915->power_domains.wakeref);
+		fetch_and_zero(&i915->power_domains.init_wakeref);
 
 	/* Remove the refcount we took to keep power well support disabled. */
 	if (!i915->params.disable_power_well)
@@ -5712,7 +5713,7 @@ void intel_power_domains_driver_remove(struct drm_i915_private *i915)
 void intel_power_domains_enable(struct drm_i915_private *i915)
 {
 	intel_wakeref_t wakeref __maybe_unused =
-		fetch_and_zero(&i915->power_domains.wakeref);
+		fetch_and_zero(&i915->power_domains.init_wakeref);
 
 	intel_display_power_put(i915, POWER_DOMAIN_INIT, wakeref);
 	intel_power_domains_verify_state(i915);
@@ -5729,8 +5730,8 @@ void intel_power_domains_disable(struct drm_i915_private *i915)
 {
 	struct i915_power_domains *power_domains = &i915->power_domains;
 
-	drm_WARN_ON(&i915->drm, power_domains->wakeref);
-	power_domains->wakeref =
+	drm_WARN_ON(&i915->drm, power_domains->init_wakeref);
+	power_domains->init_wakeref =
 		intel_display_power_get(i915, POWER_DOMAIN_INIT);
 
 	intel_power_domains_verify_state(i915);
@@ -5752,7 +5753,7 @@ void intel_power_domains_suspend(struct drm_i915_private *i915,
 {
 	struct i915_power_domains *power_domains = &i915->power_domains;
 	intel_wakeref_t wakeref __maybe_unused =
-		fetch_and_zero(&power_domains->wakeref);
+		fetch_and_zero(&power_domains->init_wakeref);
 
 	intel_display_power_put(i915, POWER_DOMAIN_INIT, wakeref);
 
@@ -5811,8 +5812,8 @@ void intel_power_domains_resume(struct drm_i915_private *i915)
 		intel_power_domains_init_hw(i915, true);
 		power_domains->display_core_suspended = false;
 	} else {
-		drm_WARN_ON(&i915->drm, power_domains->wakeref);
-		power_domains->wakeref =
+		drm_WARN_ON(&i915->drm, power_domains->init_wakeref);
+		power_domains->init_wakeref =
 			intel_display_power_get(i915, POWER_DOMAIN_INIT);
 	}
 
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 64f4d57ff09b..05e924bd070a 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -212,7 +212,7 @@ struct i915_power_domains {
 	bool display_core_suspended;
 	int power_well_count;
 
-	intel_wakeref_t wakeref;
+	intel_wakeref_t init_wakeref;
 
 	struct mutex lock;
 	int domain_use_count[POWER_DOMAIN_NUM];
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 263074c2c097..924b8f302c0f 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -1281,7 +1281,7 @@ static int i915_runtime_pm_status(struct seq_file *m, void *unused)
 		seq_puts(m, "Runtime power management not supported\n");
 
 	seq_printf(m, "Runtime power status: %s\n",
-		   enableddisabled(!dev_priv->power_domains.wakeref));
+		   enableddisabled(!dev_priv->power_domains.init_wakeref));
 
 	seq_printf(m, "GPU idle: %s\n", yesno(!dev_priv->gt.awake));
 	seq_printf(m, "IRQs disabled: %s\n",
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 8/9] drm/i915: Track power reference taken to disable power well functionality

[Imre Deak]

Add wakeref tracking for the display power domain reference taken to
keep the display power well functionality disabled.

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++++++++----
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 75e805d11dd9..906211a8c9d0 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5663,8 +5663,11 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume)
 		intel_display_power_get(i915, POWER_DOMAIN_INIT);
 
 	/* Disable power support if the user asked so. */
-	if (!i915->params.disable_power_well)
-		intel_display_power_get(i915, POWER_DOMAIN_INIT);
+	if (!i915->params.disable_power_well) {
+		drm_WARN_ON(&i915->drm, power_domains->disable_wakeref);
+		i915->power_domains.disable_wakeref = intel_display_power_get(i915,
+									      POWER_DOMAIN_INIT);
+	}
 	intel_power_domains_sync_hw(i915);
 
 	power_domains->initializing = false;
@@ -5688,7 +5691,8 @@ void intel_power_domains_driver_remove(struct drm_i915_private *i915)
 
 	/* Remove the refcount we took to keep power well support disabled. */
 	if (!i915->params.disable_power_well)
-		intel_display_power_put_unchecked(i915, POWER_DOMAIN_INIT);
+		intel_display_power_put(i915, POWER_DOMAIN_INIT,
+					i915->power_domains.disable_wakeref);
 
 	intel_display_power_flush_work_sync(i915);
 
@@ -5777,7 +5781,8 @@ void intel_power_domains_suspend(struct drm_i915_private *i915,
 	 * power wells if power domains must be deinitialized for suspend.
 	 */
 	if (!i915->params.disable_power_well)
-		intel_display_power_put_unchecked(i915, POWER_DOMAIN_INIT);
+		intel_display_power_put(i915, POWER_DOMAIN_INIT,
+					fetch_and_zero(&i915->power_domains.disable_wakeref));
 
 	intel_display_power_flush_work(i915);
 	intel_power_domains_verify_state(i915);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 05e924bd070a..70c2806d8f63 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -213,6 +213,7 @@ struct i915_power_domains {
 	int power_well_count;
 
 	intel_wakeref_t init_wakeref;
+	intel_wakeref_t disable_wakeref;
 
 	struct mutex lock;
 	int domain_use_count[POWER_DOMAIN_NUM];
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Imre Deak]

All the display power domain references are wakeref tracked now, so we
can mark intel_display_power_put_unchecked() as an internal function
(for suppressing wakeref tracking in non-debug builds).

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 .../drm/i915/display/intel_display_power.c    | 40 +++++++++----------
 .../drm/i915/display/intel_display_power.h    |  5 ++-
 2 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 906211a8c9d0..a6226bb4b643 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -2184,26 +2184,6 @@ static void __intel_display_power_put(struct drm_i915_private *dev_priv,
 	mutex_unlock(&power_domains->lock);
 }
 
-/**
- * intel_display_power_put_unchecked - release an unchecked power domain reference
- * @dev_priv: i915 device instance
- * @domain: power domain to reference
- *
- * This function drops the power domain reference obtained by
- * intel_display_power_get() and might power down the corresponding hardware
- * block right away if this is the last reference.
- *
- * This function exists only for historical reasons and should be avoided in
- * new code, as the correctness of its use cannot be checked. Always use
- * intel_display_power_put() instead.
- */
-void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
-				       enum intel_display_power_domain domain)
-{
-	__intel_display_power_put(dev_priv, domain);
-	intel_runtime_pm_put_unchecked(&dev_priv->runtime_pm);
-}
-
 static void
 queue_async_put_domains_work(struct i915_power_domains *power_domains,
 			     intel_wakeref_t wakeref)
@@ -2410,6 +2390,26 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 	__intel_display_power_put(dev_priv, domain);
 	intel_runtime_pm_put(&dev_priv->runtime_pm, wakeref);
 }
+#else
+/**
+ * intel_display_power_put_unchecked - release an unchecked power domain reference
+ * @dev_priv: i915 device instance
+ * @domain: power domain to reference
+ *
+ * This function drops the power domain reference obtained by
+ * intel_display_power_get() and might power down the corresponding hardware
+ * block right away if this is the last reference.
+ *
+ * This function is only for the power domain code's internal use to suppress wakeref
+ * tracking when the correspondig debug kconfig option is disabled, should not
+ * be used otherwise.
+ */
+void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
+				       enum intel_display_power_domain domain)
+{
+	__intel_display_power_put(dev_priv, domain);
+	intel_runtime_pm_put_unchecked(&dev_priv->runtime_pm);
+}
 #endif
 
 void
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 70c2806d8f63..c0590dbccc46 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -287,8 +287,6 @@ intel_wakeref_t intel_display_power_get(struct drm_i915_private *dev_priv,
 intel_wakeref_t
 intel_display_power_get_if_enabled(struct drm_i915_private *dev_priv,
 				   enum intel_display_power_domain domain);
-void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
-				       enum intel_display_power_domain domain);
 void __intel_display_power_put_async(struct drm_i915_private *i915,
 				     enum intel_display_power_domain domain,
 				     intel_wakeref_t wakeref);
@@ -305,6 +303,9 @@ intel_display_power_put_async(struct drm_i915_private *i915,
 	__intel_display_power_put_async(i915, domain, wakeref);
 }
 #else
+void intel_display_power_put_unchecked(struct drm_i915_private *dev_priv,
+				       enum intel_display_power_domain domain);
+
 static inline void
 intel_display_power_put(struct drm_i915_private *i915,
 			enum intel_display_power_domain domain,
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Factor out helpers to get/put a set of tracked power domains

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:21:53)
> Factor out helper functions to get/put a set of power domains that are
> tracked using their wakeref handles. The same is needed by the next
> patch adding tracking for enabled CRTC power domains.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

> diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
> index 4aa0a09cf14f..64f4d57ff09b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_power.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_power.h
> @@ -224,6 +224,13 @@ struct i915_power_domains {
>         struct i915_power_well *power_wells;
>  };
>  
> +struct intel_display_power_domain_set {
> +       uint64_t mask;

u64 mask
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/9] drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:21:52)
> The for_each_oldnew_intel_crtc_in_state() iterator index does match
> crtc->pipe, but using the same thing as array index when getting and
> putting CRTC power domains makes things clearer.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

crtc->pipe appears favoured.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Track power references taken for enabled CRTCs

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:21:54)
> Add wakeref tracking for display power domain references taken for
> enabled CRTCs.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c  | 38 ++++++++-----------
>  .../drm/i915/display/intel_display_types.h    |  2 +-
>  2 files changed, 17 insertions(+), 23 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index d80d15d96d4c..a6043197171b 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -7575,25 +7575,25 @@ modeset_get_crtc_power_domains(struct intel_crtc_state *crtc_state)
>         enum intel_display_power_domain domain;
>         u64 domains, new_domains, old_domains;
>  
> -       old_domains = crtc->enabled_power_domains;
> -       crtc->enabled_power_domains = new_domains =
> -               get_crtc_power_domains(crtc_state);
> +       domains = get_crtc_power_domains(crtc_state);
>  
> -       domains = new_domains & ~old_domains;
> +       new_domains = domains & ~crtc->enabled_power_domains.mask;
> +       old_domains = crtc->enabled_power_domains.mask & ~domains;

new / old denote the changes.

>  
> -       for_each_power_domain(domain, domains)
> -               intel_display_power_get(dev_priv, domain);
> +       for_each_power_domain(domain, new_domains)
> +               intel_display_power_get_in_set(dev_priv,
> +                                              &crtc->enabled_power_domains,
> +                                              domain);
>  
> -       return old_domains & ~new_domains;
> +       return old_domains;

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:21:55)
> Add wakeref tracking for the DDI encoders' DDI_IO display power domain
> references.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c      | 38 ++++++++++++-------
>  .../drm/i915/display/intel_display_types.h    |  1 +
>  2 files changed, 25 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 92940a0c5ef8..9518d298b0f7 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2285,9 +2285,11 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
>         dig_port = enc_to_dig_port(encoder);
>  
>         if (!intel_phy_is_tc(dev_priv, phy) ||
> -           dig_port->tc_mode != TC_PORT_TBT_ALT)
> -               intel_display_power_get(dev_priv,
> -                                       dig_port->ddi_io_power_domain);
> +           dig_port->tc_mode != TC_PORT_TBT_ALT) {
> +               drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
> +               dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
> +                                                                  dig_port->ddi_io_power_domain);
> +       }

> @@ -3958,8 +3967,9 @@ static void intel_ddi_post_disable_hdmi(struct intel_atomic_state *state,
>  
>         intel_disable_ddi_buf(encoder, old_crtc_state);
>  
> -       intel_display_power_put_unchecked(dev_priv,
> -                                         dig_port->ddi_io_power_domain);
> +       intel_display_power_put(dev_priv,
> +                               dig_port->ddi_io_power_domain,
> +                               fetch_and_zero(&dig_port->ddi_io_wakeref));

I remember that once we had trouble with this being a macro and not
evaluating the fetch_and_zero() when used as an argument.

Looks like we still have the same trouble with

#if !IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
static inline void
intel_display_power_put(struct drm_i915_private *i915,
                        enum intel_display_power_domain domain,
                        intel_wakeref_t wakeref)
{
        intel_display_power_put_unchecked(i915, domain);
}
#endif

will cause the ddi_io_wakeref to not be cleared, and the warn on to be
hit in non-debug builds.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Rename power_domains.wakeref to init_wakeref

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:21:58)
> Rename power_domains.wakeref to power_domains.init_wakeref to make the
> use of this reference clearer. The next patch adds tracking for another
> power reference user of the power_domains functionality.
> 
> While at it add a missing zero wakeref assert when setting the wakeref.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Chris Wilson]

Quoting Imre Deak (2020-11-30 21:22:00)
> All the display power domain references are wakeref tracked now, so we
> can mark intel_display_power_put_unchecked() as an internal function
> (for suppressing wakeref tracking in non-debug builds).
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Imre Deak <imre.deak@intel.com>

Ok, after all previous patches it will only be called from the header
after throwing away the wakeref.

I have a sneaky suspicion you might take another path after reviewing
the danger caused by the debug build, but if you want to keep this patch,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

[Imre Deak]

On Mon, Nov 30, 2020 at 10:00:33PM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-11-30 21:21:55)
> > Add wakeref tracking for the DDI encoders' DDI_IO display power domain
> > references.
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  drivers/gpu/drm/i915/display/intel_ddi.c      | 38 ++++++++++++-------
> >  .../drm/i915/display/intel_display_types.h    |  1 +
> >  2 files changed, 25 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > index 92940a0c5ef8..9518d298b0f7 100644
> > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > @@ -2285,9 +2285,11 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
> >         dig_port = enc_to_dig_port(encoder);
> >  
> >         if (!intel_phy_is_tc(dev_priv, phy) ||
> > -           dig_port->tc_mode != TC_PORT_TBT_ALT)
> > -               intel_display_power_get(dev_priv,
> > -                                       dig_port->ddi_io_power_domain);
> > +           dig_port->tc_mode != TC_PORT_TBT_ALT) {
> > +               drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
> > +               dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
> > +                                                                  dig_port->ddi_io_power_domain);
> > +       }
> 
> > @@ -3958,8 +3967,9 @@ static void intel_ddi_post_disable_hdmi(struct intel_atomic_state *state,
> >  
> >         intel_disable_ddi_buf(encoder, old_crtc_state);
> >  
> > -       intel_display_power_put_unchecked(dev_priv,
> > -                                         dig_port->ddi_io_power_domain);
> > +       intel_display_power_put(dev_priv,
> > +                               dig_port->ddi_io_power_domain,
> > +                               fetch_and_zero(&dig_port->ddi_io_wakeref));
> 
> I remember that once we had trouble with this being a macro and not
> evaluating the fetch_and_zero() when used as an argument.
> 
> Looks like we still have the same trouble with
> 
> #if !IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> static inline void
> intel_display_power_put(struct drm_i915_private *i915,
>                         enum intel_display_power_domain domain,
>                         intel_wakeref_t wakeref)
> {
>         intel_display_power_put_unchecked(i915, domain);
> }
> #endif
> 
> will cause the ddi_io_wakeref to not be cleared, and the warn on to be
> hit in non-debug builds.

Arg, screwed it again.

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Imre Deak]

On Mon, Nov 30, 2020 at 10:07:01PM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-11-30 21:22:00)
> > All the display power domain references are wakeref tracked now, so we
> > can mark intel_display_power_put_unchecked() as an internal function
> > (for suppressing wakeref tracking in non-debug builds).
> > 
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> Ok, after all previous patches it will only be called from the header
> after throwing away the wakeref.
> 
> I have a sneaky suspicion you might take another path after reviewing
> the danger caused by the debug build, 

Yes, how about also adding:

+static inline void
+____intel_display_power_put(struct drm_i915_private *i915,
+                           enum intel_display_power_domain domain,
+                           intel_wakeref_t wakeref)
+{
+       intel_display_power_put_unchecked(i915, domain);
+}
+
 static inline void
 intel_display_power_put(struct drm_i915_private *i915,
                        enum intel_display_power_domain domain,
                        intel_wakeref_t wakeref)
 {
-       intel_display_power_put_unchecked(i915, domain);
+       ____intel_display_power_put(i915, domain, wakeref);
 }

(and similar change for intel_display_power_put_async()) ?

> but if you want to keep this patch,

> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

[Imre Deak]

On Tue, Dec 01, 2020 at 12:07:21AM +0200, Imre Deak wrote:
> On Mon, Nov 30, 2020 at 10:00:33PM +0000, Chris Wilson wrote:
> > Quoting Imre Deak (2020-11-30 21:21:55)
> > > Add wakeref tracking for the DDI encoders' DDI_IO display power domain
> > > references.
> > > 
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/display/intel_ddi.c      | 38 ++++++++++++-------
> > >  .../drm/i915/display/intel_display_types.h    |  1 +
> > >  2 files changed, 25 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > index 92940a0c5ef8..9518d298b0f7 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > @@ -2285,9 +2285,11 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
> > >         dig_port = enc_to_dig_port(encoder);
> > >  
> > >         if (!intel_phy_is_tc(dev_priv, phy) ||
> > > -           dig_port->tc_mode != TC_PORT_TBT_ALT)
> > > -               intel_display_power_get(dev_priv,
> > > -                                       dig_port->ddi_io_power_domain);
> > > +           dig_port->tc_mode != TC_PORT_TBT_ALT) {
> > > +               drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
> > > +               dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
> > > +                                                                  dig_port->ddi_io_power_domain);
> > > +       }
> > 
> > > @@ -3958,8 +3967,9 @@ static void intel_ddi_post_disable_hdmi(struct intel_atomic_state *state,
> > >  
> > >         intel_disable_ddi_buf(encoder, old_crtc_state);
> > >  
> > > -       intel_display_power_put_unchecked(dev_priv,
> > > -                                         dig_port->ddi_io_power_domain);
> > > +       intel_display_power_put(dev_priv,
> > > +                               dig_port->ddi_io_power_domain,
> > > +                               fetch_and_zero(&dig_port->ddi_io_wakeref));
> > 
> > I remember that once we had trouble with this being a macro and not
> > evaluating the fetch_and_zero() when used as an argument.
> > 
> > Looks like we still have the same trouble with
> > 
> > #if !IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> > static inline void
> > intel_display_power_put(struct drm_i915_private *i915,
> >                         enum intel_display_power_domain domain,
> >                         intel_wakeref_t wakeref)
> > {
> >         intel_display_power_put_unchecked(i915, domain);
> > }
> > #endif
> > 
> > will cause the ddi_io_wakeref to not be cleared, and the warn on to be
> > hit in non-debug builds.

Actually, this would be the case only if intel_display_power_put() was a
macro (which it was at one point, but we've changed it to be an inline
function just to avoid the same issue).

So I think the wakeref zeroing is still ok.

> 
> Arg, screwed it again.
> 
> > -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add the missing wakeref tracking for display power references

[Patchwork]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references
URL   : https://patchwork.freedesktop.org/series/84418/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
166a87e7d161 drm/i915: Use CRTC index consistently during getting/putting CRTC power domains
b5663daf72c3 drm/i915: Factor out helpers to get/put a set of tracked power domains
-:47: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#47: FILE: drivers/gpu/drm/i915/display/intel_display.c:11307:
+						       POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder)))

-:82: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#82: FILE: drivers/gpu/drm/i915/display/intel_display.c:11332:
+							       POWER_DOMAIN_TRANSCODER(cpu_transcoder)))

-:232: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u64' over 'uint64_t'
#232: FILE: drivers/gpu/drm/i915/display/intel_display_power.h:228:
+	uint64_t mask;

total: 0 errors, 2 warnings, 1 checks, 233 lines checked
4e695be16ef4 drm/i915: Track power references taken for enabled CRTCs
7de246bcd781 drm/i915/ddi: Track power reference taken for encoder DDI IO use
5cbb83de90bc drm/i915/ddi: Track power reference taken for encoder main lane AUX use
d38d69d2d622 drm/i915: Track power reference taken for eDP VDD
09ecbd78a0c2 drm/i915: Rename power_domains.wakeref to init_wakeref
8da47ce1eac2 drm/i915: Track power reference taken to disable power well functionality
e003304a95df drm/i915: Make intel_display_power_put_unchecked() an internal-only function


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add the missing wakeref tracking for display power references

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 4976 bytes --]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references
URL   : https://patchwork.freedesktop.org/series/84418/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9411 -> Patchwork_19020
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/index.html

New tests
---------

  New tests have been introduced between CI_DRM_9411 and Patchwork_19020:

### New CI tests (1) ###

  * boot:
    - Statuses : 1 fail(s) 40 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_19020 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@read_all_entries:
    - fi-tgl-y:           [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-tgl-y/igt@debugfs_test@read_all_entries.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-tgl-y/igt@debugfs_test@read_all_entries.html

  * igt@kms_busy@basic@flip:
    - fi-tgl-y:           [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-tgl-y/igt@kms_busy@basic@flip.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-tgl-y/igt@kms_busy@basic@flip.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-icl-u2:          [PASS][5] -> [DMESG-WARN][6] ([i915#1982])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  
#### Possible fixes ####

  * igt@gem_close_race@basic-threads:
    - fi-tgl-y:           [DMESG-WARN][7] ([i915#402]) -> [PASS][8] +2 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-tgl-y/igt@gem_close_race@basic-threads.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-tgl-y/igt@gem_close_race@basic-threads.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-kefka:       [DMESG-WARN][9] ([i915#1982]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@kms_busy@basic@flip:
    - {fi-kbl-7560u}:     [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-kbl-7560u/igt@kms_busy@basic@flip.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-kbl-7560u/igt@kms_busy@basic@flip.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-byt-j1900:       [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/fi-byt-j1900/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402


Participating hosts (45 -> 41)
------------------------------

  Missing    (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_9411 -> Patchwork_19020

  CI-20190529: 20190529
  CI_DRM_9411: fab5bb55dda8498ba4a672b5d38791341e4852f8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5877: c36f7973d1ee7886ec65fa16c7b1fd8dc5a33caa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19020: e003304a95dfa1a178e1f079626eddd5f5e50366 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

e003304a95df drm/i915: Make intel_display_power_put_unchecked() an internal-only function
8da47ce1eac2 drm/i915: Track power reference taken to disable power well functionality
09ecbd78a0c2 drm/i915: Rename power_domains.wakeref to init_wakeref
d38d69d2d622 drm/i915: Track power reference taken for eDP VDD
5cbb83de90bc drm/i915/ddi: Track power reference taken for encoder main lane AUX use
7de246bcd781 drm/i915/ddi: Track power reference taken for encoder DDI IO use
4e695be16ef4 drm/i915: Track power references taken for enabled CRTCs
b5663daf72c3 drm/i915: Factor out helpers to get/put a set of tracked power domains
166a87e7d161 drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/index.html

[-- Attachment #1.2: Type: text/html, Size: 6175 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Chris Wilson]

Quoting Imre Deak (2020-11-30 22:47:08)
> On Mon, Nov 30, 2020 at 10:07:01PM +0000, Chris Wilson wrote:
> > Quoting Imre Deak (2020-11-30 21:22:00)
> > > All the display power domain references are wakeref tracked now, so we
> > > can mark intel_display_power_put_unchecked() as an internal function
> > > (for suppressing wakeref tracking in non-debug builds).
> > > 
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > 
> > Ok, after all previous patches it will only be called from the header
> > after throwing away the wakeref.
> > 
> > I have a sneaky suspicion you might take another path after reviewing
> > the danger caused by the debug build, 
> 
> Yes, how about also adding:
> 
> +static inline void
> +____intel_display_power_put(struct drm_i915_private *i915,
> +                           enum intel_display_power_domain domain,
> +                           intel_wakeref_t wakeref)
> +{
> +       intel_display_power_put_unchecked(i915, domain);
> +}
> +
>  static inline void
>  intel_display_power_put(struct drm_i915_private *i915,
>                         enum intel_display_power_domain domain,
>                         intel_wakeref_t wakeref)
>  {
> -       intel_display_power_put_unchecked(i915, domain);
> +       ____intel_display_power_put(i915, domain, wakeref);
>  }
> 
> (and similar change for intel_display_power_put_async()) ?

Hmm. The compiler shouldn't DCE the wakeref since it has a side-effect.
We can but see.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Imre Deak]

On Tue, Dec 01, 2020 at 08:14:40AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-11-30 22:47:08)
> > On Mon, Nov 30, 2020 at 10:07:01PM +0000, Chris Wilson wrote:
> > > Quoting Imre Deak (2020-11-30 21:22:00)
> > > > All the display power domain references are wakeref tracked now, so we
> > > > can mark intel_display_power_put_unchecked() as an internal function
> > > > (for suppressing wakeref tracking in non-debug builds).
> > > > 
> > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > 
> > > Ok, after all previous patches it will only be called from the header
> > > after throwing away the wakeref.
> > > 
> > > I have a sneaky suspicion you might take another path after reviewing
> > > the danger caused by the debug build, 
> > 
> > Yes, how about also adding:
> > 
> > +static inline void
> > +____intel_display_power_put(struct drm_i915_private *i915,
> > +                           enum intel_display_power_domain domain,
> > +                           intel_wakeref_t wakeref)
> > +{
> > +       intel_display_power_put_unchecked(i915, domain);
> > +}
> > +
> >  static inline void
> >  intel_display_power_put(struct drm_i915_private *i915,
> >                         enum intel_display_power_domain domain,
> >                         intel_wakeref_t wakeref)
> >  {
> > -       intel_display_power_put_unchecked(i915, domain);
> > +       ____intel_display_power_put(i915, domain, wakeref);
> >  }
> > 
> > (and similar change for intel_display_power_put_async()) ?
> 
> Hmm. The compiler shouldn't DCE the wakeref since it has a side-effect.
> We can but see.

Yes, arguments passed to functions are evaluated exactly once. The above
extra call doesn't make sense anyway.

Are you ok with patch 4 then?

--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 4/9] drm/i915/ddi: Track power reference taken for encoder DDI IO use

[Chris Wilson]

Quoting Imre Deak (2020-11-30 23:39:02)
> On Tue, Dec 01, 2020 at 12:07:21AM +0200, Imre Deak wrote:
> > On Mon, Nov 30, 2020 at 10:00:33PM +0000, Chris Wilson wrote:
> > > Quoting Imre Deak (2020-11-30 21:21:55)
> > > > Add wakeref tracking for the DDI encoders' DDI_IO display power domain
> > > > references.
> > > > 
> > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > ---
> > > >  drivers/gpu/drm/i915/display/intel_ddi.c      | 38 ++++++++++++-------
> > > >  .../drm/i915/display/intel_display_types.h    |  1 +
> > > >  2 files changed, 25 insertions(+), 14 deletions(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > index 92940a0c5ef8..9518d298b0f7 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> > > > @@ -2285,9 +2285,11 @@ static void intel_ddi_get_power_domains(struct intel_encoder *encoder,
> > > >         dig_port = enc_to_dig_port(encoder);
> > > >  
> > > >         if (!intel_phy_is_tc(dev_priv, phy) ||
> > > > -           dig_port->tc_mode != TC_PORT_TBT_ALT)
> > > > -               intel_display_power_get(dev_priv,
> > > > -                                       dig_port->ddi_io_power_domain);
> > > > +           dig_port->tc_mode != TC_PORT_TBT_ALT) {
> > > > +               drm_WARN_ON(&dev_priv->drm, dig_port->ddi_io_wakeref);
> > > > +               dig_port->ddi_io_wakeref = intel_display_power_get(dev_priv,
> > > > +                                                                  dig_port->ddi_io_power_domain);
> > > > +       }
> > > 
> > > > @@ -3958,8 +3967,9 @@ static void intel_ddi_post_disable_hdmi(struct intel_atomic_state *state,
> > > >  
> > > >         intel_disable_ddi_buf(encoder, old_crtc_state);
> > > >  
> > > > -       intel_display_power_put_unchecked(dev_priv,
> > > > -                                         dig_port->ddi_io_power_domain);
> > > > +       intel_display_power_put(dev_priv,
> > > > +                               dig_port->ddi_io_power_domain,
> > > > +                               fetch_and_zero(&dig_port->ddi_io_wakeref));
> > > 
> > > I remember that once we had trouble with this being a macro and not
> > > evaluating the fetch_and_zero() when used as an argument.
> > > 
> > > Looks like we still have the same trouble with
> > > 
> > > #if !IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
> > > static inline void
> > > intel_display_power_put(struct drm_i915_private *i915,
> > >                         enum intel_display_power_domain domain,
> > >                         intel_wakeref_t wakeref)
> > > {
> > >         intel_display_power_put_unchecked(i915, domain);
> > > }
> > > #endif
> > > 
> > > will cause the ddi_io_wakeref to not be cleared, and the warn on to be
> > > hit in non-debug builds.
> 
> Actually, this would be the case only if intel_display_power_put() was a
> macro (which it was at one point, but we've changed it to be an inline
> function just to avoid the same issue).
> 
> So I think the wakeref zeroing is still ok.

Yeah, I think it was previously broken by being a macro whereas the
inline function should be ok. A pair of non-debug modesets would bery
quickly confirm whether or not there is an issue :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Chris Wilson]

Quoting Imre Deak (2020-12-01 10:52:22)
> On Tue, Dec 01, 2020 at 08:14:40AM +0000, Chris Wilson wrote:
> > Quoting Imre Deak (2020-11-30 22:47:08)
> > > On Mon, Nov 30, 2020 at 10:07:01PM +0000, Chris Wilson wrote:
> > > > Quoting Imre Deak (2020-11-30 21:22:00)
> > > > > All the display power domain references are wakeref tracked now, so we
> > > > > can mark intel_display_power_put_unchecked() as an internal function
> > > > > (for suppressing wakeref tracking in non-debug builds).
> > > > > 
> > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > 
> > > > Ok, after all previous patches it will only be called from the header
> > > > after throwing away the wakeref.
> > > > 
> > > > I have a sneaky suspicion you might take another path after reviewing
> > > > the danger caused by the debug build, 
> > > 
> > > Yes, how about also adding:
> > > 
> > > +static inline void
> > > +____intel_display_power_put(struct drm_i915_private *i915,
> > > +                           enum intel_display_power_domain domain,
> > > +                           intel_wakeref_t wakeref)
> > > +{
> > > +       intel_display_power_put_unchecked(i915, domain);
> > > +}
> > > +
> > >  static inline void
> > >  intel_display_power_put(struct drm_i915_private *i915,
> > >                         enum intel_display_power_domain domain,
> > >                         intel_wakeref_t wakeref)
> > >  {
> > > -       intel_display_power_put_unchecked(i915, domain);
> > > +       ____intel_display_power_put(i915, domain, wakeref);
> > >  }
> > > 
> > > (and similar change for intel_display_power_put_async()) ?
> > 
> > Hmm. The compiler shouldn't DCE the wakeref since it has a side-effect.
> > We can but see.
> 
> Yes, arguments passed to functions are evaluated exactly once. The above
> extra call doesn't make sense anyway.
> 
> Are you ok with patch 4 then?

If you've done a quick non-debug test run, then I'm convinced I was
barking up the wrong tree.

The remaining patches are
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
(since they were all blocked by the uncertainty in behaviour of the
fetch_and_zero).
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Make intel_display_power_put_unchecked() an internal-only function

[Imre Deak]

On Tue, Dec 01, 2020 at 11:13:38AM +0000, Chris Wilson wrote:
> Quoting Imre Deak (2020-12-01 10:52:22)
> > On Tue, Dec 01, 2020 at 08:14:40AM +0000, Chris Wilson wrote:
> > > Quoting Imre Deak (2020-11-30 22:47:08)
> > > > On Mon, Nov 30, 2020 at 10:07:01PM +0000, Chris Wilson wrote:
> > > > > Quoting Imre Deak (2020-11-30 21:22:00)
> > > > > > All the display power domain references are wakeref tracked now, so we
> > > > > > can mark intel_display_power_put_unchecked() as an internal function
> > > > > > (for suppressing wakeref tracking in non-debug builds).
> > > > > > 
> > > > > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > > > > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > > > > 
> > > > > Ok, after all previous patches it will only be called from the header
> > > > > after throwing away the wakeref.
> > > > > 
> > > > > I have a sneaky suspicion you might take another path after reviewing
> > > > > the danger caused by the debug build, 
> > > > 
> > > > Yes, how about also adding:
> > > > 
> > > > +static inline void
> > > > +____intel_display_power_put(struct drm_i915_private *i915,
> > > > +                           enum intel_display_power_domain domain,
> > > > +                           intel_wakeref_t wakeref)
> > > > +{
> > > > +       intel_display_power_put_unchecked(i915, domain);
> > > > +}
> > > > +
> > > >  static inline void
> > > >  intel_display_power_put(struct drm_i915_private *i915,
> > > >                         enum intel_display_power_domain domain,
> > > >                         intel_wakeref_t wakeref)
> > > >  {
> > > > -       intel_display_power_put_unchecked(i915, domain);
> > > > +       ____intel_display_power_put(i915, domain, wakeref);
> > > >  }
> > > > 
> > > > (and similar change for intel_display_power_put_async()) ?
> > > 
> > > Hmm. The compiler shouldn't DCE the wakeref since it has a side-effect.
> > > We can but see.
> > 
> > Yes, arguments passed to functions are evaluated exactly once. The above
> > extra call doesn't make sense anyway.
> > 
> > Are you ok with patch 4 then?
> 
> If you've done a quick non-debug test run, then I'm convinced I was
> barking up the wrong tree.

Yes, I was testing w/o CONFIG_DRM_I915_DEBUG_RUNTIME_PM, it worked as
expected.

> The remaining patches are
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> (since they were all blocked by the uncertainty in behaviour of the
> fetch_and_zero).

Thanks. After this discussion, still pondering about a generic policy
wrt. allowing side-effects in function arguments. I decided that
put_ref(..., fetch_and_zero(&wakeref)) is practical and frequent enough
to allow it there.

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add the missing wakeref tracking for display power references

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 19777 bytes --]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references
URL   : https://patchwork.freedesktop.org/series/84418/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9411_full -> Patchwork_19020_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

New tests
---------

  New tests have been introduced between CI_DRM_9411_full and Patchwork_19020_full:

### New CI tests (1) ###

  * boot:
    - Statuses : 175 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_19020_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_whisper@basic-queues:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([i915#118] / [i915#95])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-glk9/igt@gem_exec_whisper@basic-queues.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-glk4/igt@gem_exec_whisper@basic-queues.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - shard-apl:          [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-apl1/igt@i915_pm_rpm@basic-pci-d3-state.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-apl7/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_pm_rpm@system-suspend-modeset:
    - shard-skl:          [PASS][5] -> [INCOMPLETE][6] ([i915#151])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl9/igt@i915_pm_rpm@system-suspend-modeset.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl6/igt@i915_pm_rpm@system-suspend-modeset.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
    - shard-apl:          [PASS][7] -> [FAIL][8] ([i915#54])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
    - shard-kbl:          [PASS][9] -> [FAIL][10] ([i915#54])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html

  * igt@kms_cursor_crc@pipe-c-cursor-suspend:
    - shard-skl:          [PASS][11] -> [FAIL][12] ([i915#54]) +2 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html

  * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
    - shard-tglb:         [PASS][13] -> [FAIL][14] ([i915#2346])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-tglb7/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html

  * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
    - shard-glk:          [PASS][15] -> [DMESG-WARN][16] ([i915#1982]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-glk5/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-glk1/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
    - shard-skl:          [PASS][17] -> [DMESG-WARN][18] ([i915#1982]) +4 similar issues
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl9/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1:
    - shard-kbl:          [PASS][19] -> [DMESG-WARN][20] ([i915#1982]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl3/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl6/igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@a-dp1.html

  * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
    - shard-tglb:         [PASS][21] -> [FAIL][22] ([i915#2598]) +1 similar issue
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-tglb8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
    - shard-kbl:          [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +1 similar issue
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html

  * igt@kms_flip@plain-flip-fb-recreate@b-edp1:
    - shard-skl:          [PASS][25] -> [FAIL][26] ([i915#2122]) +1 similar issue
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc:
    - shard-tglb:         [PASS][27] -> [DMESG-WARN][28] ([i915#1982])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [PASS][29] -> [SKIP][30] ([fdo#109642] / [fdo#111068])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb4/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_sprite_mmap_cpu:
    - shard-iclb:         [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb7/igt@kms_psr@psr2_sprite_mmap_cpu.html

  * igt@perf@polling-parameterized:
    - shard-skl:          [PASS][33] -> [FAIL][34] ([i915#1542])
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl1/igt@perf@polling-parameterized.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl3/igt@perf@polling-parameterized.html

  
#### Possible fixes ####

  * igt@gem_sync@basic-store-all:
    - shard-glk:          [DMESG-WARN][35] ([i915#118] / [i915#262] / [i915#95]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-glk4/igt@gem_sync@basic-store-all.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-glk5/igt@gem_sync@basic-store-all.html

  * igt@i915_module_load@reload:
    - shard-tglb:         [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] +1 similar issue
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-tglb5/igt@i915_module_load@reload.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-tglb2/igt@i915_module_load@reload.html

  * igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
    - shard-skl:          [FAIL][39] ([i915#54]) -> [PASS][40] +2 similar issues
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl1/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl5/igt@kms_cursor_crc@pipe-a-cursor-128x128-random.html

  * igt@kms_cursor_crc@pipe-b-cursor-suspend:
    - shard-skl:          [INCOMPLETE][41] ([i915#2405] / [i915#300]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html

  * igt@kms_cursor_edge_walk@pipe-c-256x256-top-edge:
    - shard-kbl:          [DMESG-WARN][43] ([i915#78]) -> [PASS][44]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl2/igt@kms_cursor_edge_walk@pipe-c-256x256-top-edge.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl3/igt@kms_cursor_edge_walk@pipe-c-256x256-top-edge.html

  * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
    - shard-apl:          [DMESG-WARN][45] ([i915#1982]) -> [PASS][46]
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-apl2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-apl2/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html

  * igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1:
    - shard-glk:          [FAIL][47] ([i915#79]) -> [PASS][48] +1 similar issue
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-glk2/igt@kms_flip@flip-vs-expired-vblank@b-hdmi-a1.html

  * {igt@kms_flip_tiling@flip-to-x-tiled@hdmi-a-1-pipe-a}:
    - shard-glk:          [DMESG-WARN][49] ([i915#1982]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-glk8/igt@kms_flip_tiling@flip-to-x-tiled@hdmi-a-1-pipe-a.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-glk7/igt@kms_flip_tiling@flip-to-x-tiled@hdmi-a-1-pipe-a.html

  * {igt@kms_flip_tiling@flip-to-yf-tiled@dp-1-pipe-a}:
    - shard-kbl:          [DMESG-WARN][51] ([i915#1982]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl6/igt@kms_flip_tiling@flip-to-yf-tiled@dp-1-pipe-a.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl7/igt@kms_flip_tiling@flip-to-yf-tiled@dp-1-pipe-a.html

  * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc:
    - shard-skl:          [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl4/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-wc.html

  * igt@kms_hdr@bpc-switch:
    - shard-skl:          [FAIL][55] ([i915#1188]) -> [PASS][56]
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl6/igt@kms_hdr@bpc-switch.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl10/igt@kms_hdr@bpc-switch.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-skl:          [FAIL][57] ([fdo#108145] / [i915#265]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html

  * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
    - shard-iclb:         [FAIL][59] -> [PASS][60]
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb6/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

  * igt@kms_plane_cursor@pipe-b-viewport-size-128:
    - shard-iclb:         [FAIL][61] ([i915#2657]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb6/igt@kms_plane_cursor@pipe-b-viewport-size-128.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb2/igt@kms_plane_cursor@pipe-b-viewport-size-128.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [SKIP][63] ([fdo#109642] / [fdo#111068]) -> [PASS][64]
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb6/igt@kms_psr2_su@page_flip.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb2/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [SKIP][65] ([fdo#109441]) -> [PASS][66] +1 similar issue
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb1/igt@kms_psr@psr2_sprite_plane_move.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][67] ([i915#2681] / [i915#2684]) -> [WARN][68] ([i915#2684])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][69] ([i915#2684]) -> [WARN][70] ([i915#1804] / [i915#2684])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
    - shard-skl:          [DMESG-FAIL][71] ([i915#1982]) -> [DMESG-WARN][72] ([i915#1982])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
    - shard-skl:          [FAIL][73] ([i915#2346]) -> [DMESG-FAIL][74] ([i915#1982])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl5/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy.html

  * igt@kms_vblank@pipe-a-ts-continuation-suspend:
    - shard-kbl:          [DMESG-WARN][75] ([i915#295]) -> [INCOMPLETE][76] ([i915#155] / [i915#2295])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html

  * igt@runner@aborted:
    - shard-iclb:         ([FAIL][77], [FAIL][78], [FAIL][79]) ([i915#1814] / [i915#2295] / [i915#2426] / [i915#2722]) -> ([FAIL][80], [FAIL][81]) ([i915#1814] / [i915#2295] / [i915#2722])
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb7/igt@runner@aborted.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb4/igt@runner@aborted.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-iclb3/igt@runner@aborted.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb2/igt@runner@aborted.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-iclb3/igt@runner@aborted.html
    - shard-skl:          ([FAIL][82], [FAIL][83]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#2722] / [i915#483]) -> ([FAIL][84], [FAIL][85], [FAIL][86]) ([i915#1436] / [i915#2029] / [i915#2295] / [i915#2426] / [i915#2722])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl3/igt@runner@aborted.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9411/shard-skl4/igt@runner@aborted.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl9/igt@runner@aborted.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl6/igt@runner@aborted.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/shard-skl2/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2657]: https://gitlab.freedesktop.org/drm/intel/issues/2657
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
  [i915#300]: https://gitlab.freedesktop.org/drm/intel/issues/300
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#78]: https://gitlab.freedesktop.org/drm/intel/issues/78
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9411 -> Patchwork_19020

  CI-20190529: 20190529
  CI_DRM_9411: fab5bb55dda8498ba4a672b5d38791341e4852f8 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5877: c36f7973d1ee7886ec65fa16c7b1fd8dc5a33caa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19020: e003304a95dfa1a178e1f079626eddd5f5e50366 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19020/index.html

[-- Attachment #1.2: Type: text/html, Size: 23986 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 2/9] drm/i915: Factor out helpers to get/put a set of tracked power domains

[Imre Deak]

Factor out helper functions to get/put a set of power domains that are
tracked using their wakeref handles. The same is needed by the next
patch adding tracking for enabled CRTC power domains.

v2: s/uint64_t/u64/ (Chris)

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/display/intel_display.c  | 62 +++++--------------
 .../drm/i915/display/intel_display_power.c    | 57 +++++++++++++++++
 .../drm/i915/display/intel_display_power.h    | 29 +++++++++
 3 files changed, 100 insertions(+), 48 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d812d7ae5e65..d80d15d96d4c 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -11226,16 +11226,13 @@ static void hsw_get_ddi_pll(struct drm_i915_private *dev_priv, enum port port,
 
 static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 				     struct intel_crtc_state *pipe_config,
-				     u64 *power_domain_mask,
-				     intel_wakeref_t *wakerefs)
+				     struct intel_display_power_domain_set *power_domain_set)
 {
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	enum intel_display_power_domain power_domain;
 	unsigned long panel_transcoder_mask = BIT(TRANSCODER_EDP);
 	unsigned long enabled_panel_transcoders = 0;
 	enum transcoder panel_transcoder;
-	intel_wakeref_t wf;
 	u32 tmp;
 
 	if (INTEL_GEN(dev_priv) >= 11)
@@ -11306,16 +11303,10 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 	drm_WARN_ON(dev, (enabled_panel_transcoders & BIT(TRANSCODER_EDP)) &&
 		    enabled_panel_transcoders != BIT(TRANSCODER_EDP));
 
-	power_domain = POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder);
-	drm_WARN_ON(dev, *power_domain_mask & BIT_ULL(power_domain));
-
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (!wf)
+	if (!intel_display_power_get_in_set_if_enabled(dev_priv, power_domain_set,
+						       POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder)))
 		return false;
 
-	wakerefs[power_domain] = wf;
-	*power_domain_mask |= BIT_ULL(power_domain);
-
 	tmp = intel_de_read(dev_priv, PIPECONF(pipe_config->cpu_transcoder));
 
 	return tmp & PIPECONF_ENABLE;
@@ -11323,14 +11314,11 @@ static bool hsw_get_transcoder_state(struct intel_crtc *crtc,
 
 static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
 					 struct intel_crtc_state *pipe_config,
-					 u64 *power_domain_mask,
-					 intel_wakeref_t *wakerefs)
+					 struct intel_display_power_domain_set *power_domain_set)
 {
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = to_i915(dev);
-	enum intel_display_power_domain power_domain;
 	enum transcoder cpu_transcoder;
-	intel_wakeref_t wf;
 	enum port port;
 	u32 tmp;
 
@@ -11340,16 +11328,10 @@ static bool bxt_get_dsi_transcoder_state(struct intel_crtc *crtc,
 		else
 			cpu_transcoder = TRANSCODER_DSI_C;
 
-		power_domain = POWER_DOMAIN_TRANSCODER(cpu_transcoder);
-		drm_WARN_ON(dev, *power_domain_mask & BIT_ULL(power_domain));
-
-		wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-		if (!wf)
+		if (!intel_display_power_get_in_set_if_enabled(dev_priv, power_domain_set,
+							       POWER_DOMAIN_TRANSCODER(cpu_transcoder)))
 			continue;
 
-		wakerefs[power_domain] = wf;
-		*power_domain_mask |= BIT_ULL(power_domain);
-
 		/*
 		 * The PLL needs to be enabled with a valid divider
 		 * configuration, otherwise accessing DSI registers will hang
@@ -11432,30 +11414,22 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 				struct intel_crtc_state *pipe_config)
 {
 	struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
-	intel_wakeref_t wakerefs[POWER_DOMAIN_NUM], wf;
-	enum intel_display_power_domain power_domain;
-	u64 power_domain_mask;
+	struct intel_display_power_domain_set power_domain_set = { };
 	bool active;
 	u32 tmp;
 
 	pipe_config->master_transcoder = INVALID_TRANSCODER;
 
-	power_domain = POWER_DOMAIN_PIPE(crtc->pipe);
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (!wf)
+	if (!intel_display_power_get_in_set_if_enabled(dev_priv, &power_domain_set,
+						       POWER_DOMAIN_PIPE(crtc->pipe)))
 		return false;
 
-	wakerefs[power_domain] = wf;
-	power_domain_mask = BIT_ULL(power_domain);
-
 	pipe_config->shared_dpll = NULL;
 
-	active = hsw_get_transcoder_state(crtc, pipe_config,
-					  &power_domain_mask, wakerefs);
+	active = hsw_get_transcoder_state(crtc, pipe_config, &power_domain_set);
 
 	if (IS_GEN9_LP(dev_priv) &&
-	    bxt_get_dsi_transcoder_state(crtc, pipe_config,
-					 &power_domain_mask, wakerefs)) {
+	    bxt_get_dsi_transcoder_state(crtc, pipe_config, &power_domain_set)) {
 		drm_WARN_ON(&dev_priv->drm, active);
 		active = true;
 	}
@@ -11519,14 +11493,8 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 		pipe_config->ips_linetime =
 			REG_FIELD_GET(HSW_IPS_LINETIME_MASK, tmp);
 
-	power_domain = POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe);
-	drm_WARN_ON(&dev_priv->drm, power_domain_mask & BIT_ULL(power_domain));
-
-	wf = intel_display_power_get_if_enabled(dev_priv, power_domain);
-	if (wf) {
-		wakerefs[power_domain] = wf;
-		power_domain_mask |= BIT_ULL(power_domain);
-
+	if (intel_display_power_get_in_set_if_enabled(dev_priv, &power_domain_set,
+						      POWER_DOMAIN_PIPE_PANEL_FITTER(crtc->pipe))) {
 		if (INTEL_GEN(dev_priv) >= 9)
 			skl_get_pfit_config(pipe_config);
 		else
@@ -11560,9 +11528,7 @@ static bool hsw_get_pipe_config(struct intel_crtc *crtc,
 	}
 
 out:
-	for_each_power_domain(power_domain, power_domain_mask)
-		intel_display_power_put(dev_priv,
-					power_domain, wakerefs[power_domain]);
+	intel_display_power_put_all_in_set(dev_priv, &power_domain_set);
 
 	return active;
 }
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index fe2d90bba536..b48dbb7bdaf4 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -2412,6 +2412,63 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
 }
 #endif
 
+void
+intel_display_power_get_in_set(struct drm_i915_private *i915,
+			       struct intel_display_power_domain_set *power_domain_set,
+			       enum intel_display_power_domain domain)
+{
+	intel_wakeref_t __maybe_unused wf;
+
+	drm_WARN_ON(&i915->drm, power_domain_set->mask & BIT_ULL(domain));
+
+	wf = intel_display_power_get(i915, domain);
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+	power_domain_set->wakerefs[domain] = wf;
+#endif
+	power_domain_set->mask |= BIT_ULL(domain);
+}
+
+bool
+intel_display_power_get_in_set_if_enabled(struct drm_i915_private *i915,
+					  struct intel_display_power_domain_set *power_domain_set,
+					  enum intel_display_power_domain domain)
+{
+	intel_wakeref_t wf;
+
+	drm_WARN_ON(&i915->drm, power_domain_set->mask & BIT_ULL(domain));
+
+	wf = intel_display_power_get_if_enabled(i915, domain);
+	if (!wf)
+		return false;
+
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+	power_domain_set->wakerefs[domain] = wf;
+#endif
+	power_domain_set->mask |= BIT_ULL(domain);
+
+	return true;
+}
+
+void
+intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
+				    struct intel_display_power_domain_set *power_domain_set,
+				    u64 mask)
+{
+	enum intel_display_power_domain domain;
+
+	drm_WARN_ON(&i915->drm, mask & ~power_domain_set->mask);
+
+	for_each_power_domain(domain, mask) {
+		intel_wakeref_t __maybe_unused wf = -1;
+
+#if IS_ENABLED(CONFIG_DRM_I915_DEBUG_RUNTIME_PM)
+		wf = fetch_and_zero(&power_domain_set->wakerefs[domain]);
+#endif
+		intel_display_power_put(i915, domain, wf);
+		power_domain_set->mask &= ~BIT_ULL(domain);
+	}
+}
+
 #define I830_PIPES_POWER_DOMAINS (		\
 	BIT_ULL(POWER_DOMAIN_PIPE_A) |		\
 	BIT_ULL(POWER_DOMAIN_PIPE_B) |		\
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 4aa0a09cf14f..583d3df57fb2 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -224,6 +224,13 @@ struct i915_power_domains {
 	struct i915_power_well *power_wells;
 };
 
+struct intel_display_power_domain_set {
+	u64 mask;
+#ifdef CONFIG_DRM_I915_DEBUG_RUNTIME_PM
+	intel_wakeref_t wakerefs[POWER_DOMAIN_NUM];
+#endif
+};
+
 #define for_each_power_domain(domain, mask)				\
 	for ((domain) = 0; (domain) < POWER_DOMAIN_NUM; (domain)++)	\
 		for_each_if(BIT_ULL(domain) & (mask))
@@ -314,6 +321,28 @@ intel_display_power_put_async(struct drm_i915_private *i915,
 }
 #endif
 
+void
+intel_display_power_get_in_set(struct drm_i915_private *i915,
+			       struct intel_display_power_domain_set *power_domain_set,
+			       enum intel_display_power_domain domain);
+
+bool
+intel_display_power_get_in_set_if_enabled(struct drm_i915_private *i915,
+					  struct intel_display_power_domain_set *power_domain_set,
+					  enum intel_display_power_domain domain);
+
+void
+intel_display_power_put_mask_in_set(struct drm_i915_private *i915,
+				    struct intel_display_power_domain_set *power_domain_set,
+				    u64 mask);
+
+static inline void
+intel_display_power_put_all_in_set(struct drm_i915_private *i915,
+				   struct intel_display_power_domain_set *power_domain_set)
+{
+	intel_display_power_put_mask_in_set(i915, power_domain_set, power_domain_set->mask);
+}
+
 enum dbuf_slice {
 	DBUF_S1,
 	DBUF_S2,
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH v2 8/9] drm/i915: Track power reference taken to disable power well functionality

[Imre Deak]

Add wakeref tracking for the display power domain reference taken to
keep the display power well functionality disabled.

v2: Add missing wakeref zeroing to intel_power_domains_driver_remove()

Cc: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/display/intel_display_power.c | 13 +++++++++----
 drivers/gpu/drm/i915/display/intel_display_power.h |  1 +
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c b/drivers/gpu/drm/i915/display/intel_display_power.c
index 75e805d11dd9..1b3b2de9158f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.c
+++ b/drivers/gpu/drm/i915/display/intel_display_power.c
@@ -5663,8 +5663,11 @@ void intel_power_domains_init_hw(struct drm_i915_private *i915, bool resume)
 		intel_display_power_get(i915, POWER_DOMAIN_INIT);
 
 	/* Disable power support if the user asked so. */
-	if (!i915->params.disable_power_well)
-		intel_display_power_get(i915, POWER_DOMAIN_INIT);
+	if (!i915->params.disable_power_well) {
+		drm_WARN_ON(&i915->drm, power_domains->disable_wakeref);
+		i915->power_domains.disable_wakeref = intel_display_power_get(i915,
+									      POWER_DOMAIN_INIT);
+	}
 	intel_power_domains_sync_hw(i915);
 
 	power_domains->initializing = false;
@@ -5688,7 +5691,8 @@ void intel_power_domains_driver_remove(struct drm_i915_private *i915)
 
 	/* Remove the refcount we took to keep power well support disabled. */
 	if (!i915->params.disable_power_well)
-		intel_display_power_put_unchecked(i915, POWER_DOMAIN_INIT);
+		intel_display_power_put(i915, POWER_DOMAIN_INIT,
+					fetch_and_zero(&i915->power_domains.disable_wakeref));
 
 	intel_display_power_flush_work_sync(i915);
 
@@ -5777,7 +5781,8 @@ void intel_power_domains_suspend(struct drm_i915_private *i915,
 	 * power wells if power domains must be deinitialized for suspend.
 	 */
 	if (!i915->params.disable_power_well)
-		intel_display_power_put_unchecked(i915, POWER_DOMAIN_INIT);
+		intel_display_power_put(i915, POWER_DOMAIN_INIT,
+					fetch_and_zero(&i915->power_domains.disable_wakeref));
 
 	intel_display_power_flush_work(i915);
 	intel_power_domains_verify_state(i915);
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 34de5487d8fc..2ef95ce17f60 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -213,6 +213,7 @@ struct i915_power_domains {
 	int power_well_count;
 
 	intel_wakeref_t init_wakeref;
+	intel_wakeref_t disable_wakeref;
 
 	struct mutex lock;
 	int domain_use_count[POWER_DOMAIN_NUM];
-- 
2.25.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add the missing wakeref tracking for display power references (rev3)

[Patchwork]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references (rev3)
URL   : https://patchwork.freedesktop.org/series/84418/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
a960388b294b drm/i915: Use CRTC index consistently during getting/putting CRTC power domains
124b1113405e drm/i915: Factor out helpers to get/put a set of tracked power domains
-:49: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#49: FILE: drivers/gpu/drm/i915/display/intel_display.c:11307:
+						       POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder)))

-:84: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#84: FILE: drivers/gpu/drm/i915/display/intel_display.c:11332:
+							       POWER_DOMAIN_TRANSCODER(cpu_transcoder)))

total: 0 errors, 2 warnings, 0 checks, 233 lines checked
fc0def725f9b drm/i915: Track power references taken for enabled CRTCs
b26d265885ef drm/i915/ddi: Track power reference taken for encoder DDI IO use
094282ec0880 drm/i915/ddi: Track power reference taken for encoder main lane AUX use
1c8414e0d665 drm/i915: Track power reference taken for eDP VDD
22c0ba746b62 drm/i915: Rename power_domains.wakeref to init_wakeref
7d278c7ad277 drm/i915: Track power reference taken to disable power well functionality
b99962e692f3 drm/i915: Make intel_display_power_put_unchecked() an internal-only function
-:14: WARNING:BAD_SIGN_OFF: Duplicate signature
#14: 
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

total: 0 errors, 1 warnings, 0 checks, 69 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add the missing wakeref tracking for display power references (rev3)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 6491 bytes --]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references (rev3)
URL   : https://patchwork.freedesktop.org/series/84418/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9415 -> Patchwork_19027
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/index.html

New tests
---------

  New tests have been introduced between CI_DRM_9415 and Patchwork_19027:

### New CI tests (1) ###

  * boot:
    - Statuses : 1 fail(s) 40 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_19027 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_create@basic:
    - fi-icl-u2:          [PASS][1] -> [INCOMPLETE][2] ([i915#2502])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-icl-u2/igt@gem_exec_create@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-icl-u2/igt@gem_exec_create@basic.html

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-bsw-n3050:       [PASS][3] -> [DMESG-WARN][4] ([i915#1982])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-bsw-n3050/igt@i915_pm_rpm@basic-pci-d3-state.html
    - fi-tgl-y:           [PASS][5] -> [DMESG-WARN][6] ([i915#1982] / [i915#2411])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-tgl-y:           [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html

  * igt@prime_self_import@basic-with_one_bo_two_files:
    - fi-tgl-y:           [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@prime_self_import@basic-with_one_bo_two_files.html

  
#### Possible fixes ####

  * igt@core_hotunplug@unbind-rebind:
    - fi-tgl-u2:          [DMESG-WARN][11] ([i915#1982]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-u2/igt@core_hotunplug@unbind-rebind.html
    - fi-blb-e6850:       [INCOMPLETE][13] ([i915#2540]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-blb-e6850/igt@core_hotunplug@unbind-rebind.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-blb-e6850/igt@core_hotunplug@unbind-rebind.html

  * {igt@fbdev@read}:
    - fi-tgl-y:           [DMESG-WARN][15] ([i915#402]) -> [PASS][16] +2 similar issues
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@fbdev@read.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@fbdev@read.html

  * igt@gem_exec_suspend@basic-s3:
    - fi-tgl-y:           [DMESG-WARN][17] ([i915#2411] / [i915#402]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@gem_exec_suspend@basic-s3.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - fi-bsw-kefka:       [DMESG-WARN][19] ([i915#1982]) -> [PASS][20] +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_force_connector_basic@force-connector-state:
    - fi-tgl-y:           [DMESG-WARN][21] ([i915#1982]) -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/fi-tgl-y/igt@kms_force_connector_basic@force-connector-state.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/fi-tgl-y/igt@kms_force_connector_basic@force-connector-state.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
  [i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
  [i915#2540]: https://gitlab.freedesktop.org/drm/intel/issues/2540
  [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402


Participating hosts (45 -> 41)
------------------------------

  Missing    (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u 


Build changes
-------------

  * Linux: CI_DRM_9415 -> Patchwork_19027

  CI-20190529: 20190529
  CI_DRM_9415: 7170e8ad5a8764257c383c8b677ca6398ba6b1af @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5877: c36f7973d1ee7886ec65fa16c7b1fd8dc5a33caa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19027: b99962e692f3da02763f28fff9031b718a4fb745 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

b99962e692f3 drm/i915: Make intel_display_power_put_unchecked() an internal-only function
7d278c7ad277 drm/i915: Track power reference taken to disable power well functionality
22c0ba746b62 drm/i915: Rename power_domains.wakeref to init_wakeref
1c8414e0d665 drm/i915: Track power reference taken for eDP VDD
094282ec0880 drm/i915/ddi: Track power reference taken for encoder main lane AUX use
b26d265885ef drm/i915/ddi: Track power reference taken for encoder DDI IO use
fc0def725f9b drm/i915: Track power references taken for enabled CRTCs
124b1113405e drm/i915: Factor out helpers to get/put a set of tracked power domains
a960388b294b drm/i915: Use CRTC index consistently during getting/putting CRTC power domains

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/index.html

[-- Attachment #1.2: Type: text/html, Size: 7975 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add the missing wakeref tracking for display power references (rev4)

[Patchwork]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references (rev4)
URL   : https://patchwork.freedesktop.org/series/84418/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fb819322d6eb drm/i915: Use CRTC index consistently during getting/putting CRTC power domains
19b477095143 drm/i915: Factor out helpers to get/put a set of tracked power domains
-:49: WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#49: FILE: drivers/gpu/drm/i915/display/intel_display.c:11307:
+						       POWER_DOMAIN_TRANSCODER(pipe_config->cpu_transcoder)))

-:84: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#84: FILE: drivers/gpu/drm/i915/display/intel_display.c:11332:
+							       POWER_DOMAIN_TRANSCODER(cpu_transcoder)))

total: 0 errors, 2 warnings, 0 checks, 233 lines checked
b4836e197d91 drm/i915: Track power references taken for enabled CRTCs
4b7e131ec9db drm/i915/ddi: Track power reference taken for encoder DDI IO use
f5be4a930c9e drm/i915/ddi: Track power reference taken for encoder main lane AUX use
2e2b87f626ed drm/i915: Track power reference taken for eDP VDD
3ac87db07e57 drm/i915: Rename power_domains.wakeref to init_wakeref
761e6e0ca141 drm/i915: Track power reference taken to disable power well functionality
213ec14dfacb drm/i915: Make intel_display_power_put_unchecked() an internal-only function
-:14: WARNING:BAD_SIGN_OFF: Duplicate signature
#14: 
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

total: 0 errors, 1 warnings, 0 checks, 69 lines checked


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add the missing wakeref tracking for display power references (rev4)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 21033 bytes --]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references (rev4)
URL   : https://patchwork.freedesktop.org/series/84418/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9423_full -> Patchwork_19040_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

New tests
---------

  New tests have been introduced between CI_DRM_9423_full and Patchwork_19040_full:

### New CI tests (1) ###

  * boot:
    - Statuses : 199 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_19040_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_reloc@basic-gtt-wc:
    - shard-skl:          [PASS][1] -> [DMESG-WARN][2] ([i915#1982])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl8/igt@gem_exec_reloc@basic-gtt-wc.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl4/igt@gem_exec_reloc@basic-gtt-wc.html

  * igt@gem_exec_whisper@basic-forked-all:
    - shard-glk:          [PASS][3] -> [DMESG-WARN][4] ([i915#118] / [i915#95]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk1/igt@gem_exec_whisper@basic-forked-all.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk3/igt@gem_exec_whisper@basic-forked-all.html

  * igt@gem_workarounds@suspend-resume-fd:
    - shard-skl:          [PASS][5] -> [INCOMPLETE][6] ([i915#198] / [i915#2405])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl7/igt@gem_workarounds@suspend-resume-fd.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl9/igt@gem_workarounds@suspend-resume-fd.html

  * igt@i915_pm_rpm@pm-tiling:
    - shard-apl:          [PASS][7] -> [DMESG-WARN][8] ([i915#1982])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-apl1/igt@i915_pm_rpm@pm-tiling.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-apl2/igt@i915_pm_rpm@pm-tiling.html

  * igt@i915_selftest@live@gt_heartbeat:
    - shard-skl:          [PASS][9] -> [DMESG-FAIL][10] ([i915#2291] / [i915#541])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl4/igt@i915_selftest@live@gt_heartbeat.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl4/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_suspend@fence-restore-untiled:
    - shard-kbl:          [PASS][11] -> [INCOMPLETE][12] ([i915#155] / [i915#180])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-kbl7/igt@i915_suspend@fence-restore-untiled.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-kbl6/igt@i915_suspend@fence-restore-untiled.html

  * igt@kms_big_fb@y-tiled-16bpp-rotate-0:
    - shard-kbl:          [PASS][13] -> [DMESG-WARN][14] ([i915#1982])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-kbl2/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-kbl4/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-random:
    - shard-tglb:         [PASS][15] -> [FAIL][16] ([i915#2124])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb1/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb3/igt@kms_cursor_crc@pipe-b-cursor-128x42-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen:
    - shard-skl:          [PASS][17] -> [FAIL][18] ([i915#54])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-128x128-offscreen.html

  * igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
    - shard-glk:          [PASS][19] -> [FAIL][20] ([i915#72])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk9/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html

  * igt@kms_cursor_legacy@cursor-vs-flip-toggle:
    - shard-hsw:          [PASS][21] -> [FAIL][22] ([i915#2370])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-hsw1/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [PASS][23] -> [FAIL][24] ([i915#2346] / [i915#533])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_flip@flip-vs-expired-vblank@a-edp1:
    - shard-tglb:         [PASS][25] -> [FAIL][26] ([i915#2598])
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
    - shard-skl:          [PASS][27] -> [INCOMPLETE][28] ([i915#198]) +1 similar issue
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl2/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render:
    - shard-tglb:         [PASS][29] -> [DMESG-WARN][30] ([i915#1982])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb3/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-render.html

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-glk:          [PASS][31] -> [DMESG-WARN][32] ([i915#1982])
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk4/igt@kms_plane@plane-position-covered-pipe-a-planes.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk5/igt@kms_plane@plane-position-covered-pipe-a-planes.html

  * igt@kms_psr@psr2_sprite_plane_move:
    - shard-iclb:         [PASS][33] -> [SKIP][34] ([fdo#109441]) +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html

  * igt@perf@blocking:
    - shard-skl:          [PASS][35] -> [FAIL][36] ([i915#1542])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl6/igt@perf@blocking.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl6/igt@perf@blocking.html

  
#### Possible fixes ####

  * igt@device_reset@unbind-reset-rebind:
    - shard-tglb:         [DMESG-WARN][37] ([i915#1982]) -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb6/igt@device_reset@unbind-reset-rebind.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb5/igt@device_reset@unbind-reset-rebind.html

  * igt@drm_import_export@prime:
    - shard-tglb:         [INCOMPLETE][39] ([i915#750]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb2/igt@drm_import_export@prime.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb7/igt@drm_import_export@prime.html

  * igt@gem_exec_whisper@basic-queues-forked:
    - shard-glk:          [DMESG-WARN][41] ([i915#118] / [i915#95]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk3/igt@gem_exec_whisper@basic-queues-forked.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk4/igt@gem_exec_whisper@basic-queues-forked.html

  * igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding:
    - shard-skl:          [FAIL][43] ([i915#54]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-64x21-sliding.html

  * igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1:
    - shard-apl:          [DMESG-WARN][45] ([i915#1982]) -> [PASS][46] +1 similar issue
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-apl3/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-apl4/igt@kms_flip@absolute-wf_vblank-interruptible@a-dp1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
    - shard-skl:          [FAIL][47] ([i915#79]) -> [PASS][48]
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1:
    - shard-apl:          [FAIL][49] ([i915#79]) -> [PASS][50] +1 similar issue
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-apl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp1.html

  * igt@kms_flip@flip-vs-suspend@b-edp1:
    - shard-skl:          [INCOMPLETE][51] ([i915#198]) -> [PASS][52]
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl1/igt@kms_flip@flip-vs-suspend@b-edp1.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl6/igt@kms_flip@flip-vs-suspend@b-edp1.html

  * igt@kms_flip@nonexisting-fb@a-vga1:
    - shard-hsw:          [DMESG-WARN][53] ([i915#1982]) -> [PASS][54]
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-hsw6/igt@kms_flip@nonexisting-fb@a-vga1.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-hsw2/igt@kms_flip@nonexisting-fb@a-vga1.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
    - shard-skl:          [FAIL][55] ([i915#2122]) -> [PASS][56] +1 similar issue
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl5/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html

  * igt@kms_hdr@bpc-switch-suspend:
    - shard-skl:          [FAIL][57] ([i915#1188]) -> [PASS][58]
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl3/igt@kms_hdr@bpc-switch-suspend.html

  * igt@kms_plane@plane-panning-bottom-right-pipe-a-planes:
    - shard-skl:          [DMESG-WARN][59] ([i915#1982]) -> [PASS][60] +3 similar issues
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl1/igt@kms_plane@plane-panning-bottom-right-pipe-a-planes.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl6/igt@kms_plane@plane-panning-bottom-right-pipe-a-planes.html

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
    - shard-skl:          [FAIL][61] ([fdo#108145] / [i915#265]) -> [PASS][62]
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html

  * igt@kms_psr@psr2_basic:
    - shard-iclb:         [SKIP][63] ([fdo#109441]) -> [PASS][64] +2 similar issues
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-iclb1/igt@kms_psr@psr2_basic.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-iclb2/igt@kms_psr@psr2_basic.html

  * igt@perf_pmu@module-unload:
    - shard-skl:          [DMESG-WARN][65] ([i915#1982] / [i915#262]) -> [PASS][66]
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl4/igt@perf_pmu@module-unload.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl1/igt@perf_pmu@module-unload.html

  * igt@sysfs_heartbeat_interval@mixed@bcs0:
    - shard-skl:          [INCOMPLETE][67] ([i915#1731] / [i915#198]) -> [PASS][68]
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl10/igt@sysfs_heartbeat_interval@mixed@bcs0.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl2/igt@sysfs_heartbeat_interval@mixed@bcs0.html

  
#### Warnings ####

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-iclb:         [WARN][69] ([i915#1804] / [i915#2684]) -> [WARN][70] ([i915#2681] / [i915#2684])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-iclb3/igt@i915_pm_rc6_residency@rc6-fence.html
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-iclb8/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [FAIL][71] ([i915#2680]) -> [WARN][72] ([i915#1804] / [i915#2684])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [DMESG-WARN][73] ([i915#1226]) -> [SKIP][74] ([fdo#109349])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-iclb3/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@runner@aborted:
    - shard-kbl:          ([FAIL][75], [FAIL][76]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#2505] / [i915#2722] / [i915#483]) -> ([FAIL][77], [FAIL][78], [FAIL][79]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#2722] / [i915#483])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-kbl6/igt@runner@aborted.html
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-kbl6/igt@runner@aborted.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-kbl6/igt@runner@aborted.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-kbl1/igt@runner@aborted.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-kbl2/igt@runner@aborted.html
    - shard-glk:          ([FAIL][80], [FAIL][81], [FAIL][82]) ([i915#2295] / [i915#2426] / [i915#2722] / [i915#483] / [k.org#202321]) -> ([FAIL][83], [FAIL][84], [FAIL][85]) ([i915#2295] / [i915#2426] / [i915#2722] / [k.org#202321])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk5/igt@runner@aborted.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk3/igt@runner@aborted.html
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-glk1/igt@runner@aborted.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk7/igt@runner@aborted.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk4/igt@runner@aborted.html
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-glk1/igt@runner@aborted.html
    - shard-tglb:         ([FAIL][86], [FAIL][87], [FAIL][88]) ([i915#1602] / [i915#2295] / [i915#2426] / [i915#2722]) -> ([FAIL][89], [FAIL][90], [FAIL][91]) ([i915#1602] / [i915#1764] / [i915#2295] / [i915#2426] / [i915#2722])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb7/igt@runner@aborted.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb6/igt@runner@aborted.html
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-tglb3/igt@runner@aborted.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb3/igt@runner@aborted.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb2/igt@runner@aborted.html
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-tglb2/igt@runner@aborted.html
    - shard-skl:          [FAIL][92] ([i915#2295] / [i915#2722] / [i915#483]) -> ([FAIL][93], [FAIL][94]) ([i915#1436] / [i915#2295] / [i915#2426] / [i915#2722])
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9423/shard-skl3/igt@runner@aborted.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl1/igt@runner@aborted.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/shard-skl1/igt@runner@aborted.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
  [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
  [i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
  [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
  [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
  [i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
  [i915#1602]: https://gitlab.freedesktop.org/drm/intel/issues/1602
  [i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
  [i915#1764]: https://gitlab.freedesktop.org/drm/intel/issues/1764
  [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
  [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
  [i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
  [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
  [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
  [i915#2124]: https://gitlab.freedesktop.org/drm/intel/issues/2124
  [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
  [i915#2295]: https://gitlab.freedesktop.org/drm/intel/issues/2295
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
  [i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
  [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
  [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
  [i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
  [i915#2598]: https://gitlab.freedesktop.org/drm/intel/issues/2598
  [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
  [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
  [i915#2680]: https://gitlab.freedesktop.org/drm/intel/issues/2680
  [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
  [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
  [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
  [i915#483]: https://gitlab.freedesktop.org/drm/intel/issues/483
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
  [i915#541]: https://gitlab.freedesktop.org/drm/intel/issues/541
  [i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
  [i915#750]: https://gitlab.freedesktop.org/drm/intel/issues/750
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
  [k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321


Participating hosts (10 -> 10)
------------------------------

  No changes in participating hosts


Build changes
-------------

  * Linux: CI_DRM_9423 -> Patchwork_19040

  CI-20190529: 20190529
  CI_DRM_9423: d50bb3f1c5a19bb80a40897651fd4d8d1585994e @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5878: e96c0d8e6952d892bcbbcdf004999880a4dfb42e @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_19040: 213ec14dfacb40094a8cf0fb2f598667f5f65141 @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19040/index.html

[-- Attachment #1.2: Type: text/html, Size: 25927 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add the missing wakeref tracking for display power references (rev3)

[Patchwork]

[-- Attachment #1.1: Type: text/plain, Size: 30297 bytes --]

== Series Details ==

Series: drm/i915: Add the missing wakeref tracking for display power references (rev3)
URL   : https://patchwork.freedesktop.org/series/84418/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9415_full -> Patchwork_19027_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with Patchwork_19027_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_19027_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_19027_full:

### IGT changes ###

#### Warnings ####

  * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
    - shard-iclb:         [FAIL][1] -> ([FAIL][2], [PASS][3])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

  
New tests
---------

  New tests have been introduced between CI_DRM_9415_full and Patchwork_19027_full:

### New CI tests (1) ###

  * boot:
    - Statuses : 351 pass(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in Patchwork_19027_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@core_hotunplug@unbind-rebind:
    - shard-iclb:         [PASS][4] -> ([PASS][5], [DMESG-WARN][6]) ([i915#1982])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb5/igt@core_hotunplug@unbind-rebind.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb5/igt@core_hotunplug@unbind-rebind.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb8/igt@core_hotunplug@unbind-rebind.html

  * igt@debugfs_test@read_all_entries_display_on:
    - shard-skl:          [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@debugfs_test@read_all_entries_display_on.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@debugfs_test@read_all_entries_display_on.html

  * igt@drm_read@empty-block:
    - shard-glk:          [PASS][9] -> ([DMESG-WARN][10], [PASS][11]) ([i915#1982])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@drm_read@empty-block.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@drm_read@empty-block.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@drm_read@empty-block.html

  * igt@feature_discovery@psr2:
    - shard-iclb:         [PASS][12] -> ([PASS][13], [SKIP][14]) ([i915#658])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@feature_discovery@psr2.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@feature_discovery@psr2.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@feature_discovery@psr2.html

  * igt@gem_exec_endless@dispatch@rcs0:
    - shard-iclb:         [PASS][15] -> ([PASS][16], [INCOMPLETE][17]) ([i915#2502])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb1/igt@gem_exec_endless@dispatch@rcs0.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb8/igt@gem_exec_endless@dispatch@rcs0.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb4/igt@gem_exec_endless@dispatch@rcs0.html

  * igt@gem_exec_whisper@basic-queues-forked-all:
    - shard-glk:          [PASS][18] -> ([DMESG-WARN][19], [PASS][20]) ([i915#118] / [i915#95])
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk1/igt@gem_exec_whisper@basic-queues-forked-all.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@gem_exec_whisper@basic-queues-forked-all.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@gem_exec_whisper@basic-queues-forked-all.html

  * igt@gem_huc_copy@huc-copy:
    - shard-tglb:         [PASS][21] -> ([SKIP][22], [PASS][23]) ([i915#2190])
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb3/igt@gem_huc_copy@huc-copy.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@gem_huc_copy@huc-copy.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@gem_huc_copy@huc-copy.html

  * igt@gen9_exec_parse@allowed-all:
    - shard-skl:          [PASS][24] -> ([DMESG-WARN][25], [PASS][26]) ([i915#1436] / [i915#716])
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@gen9_exec_parse@allowed-all.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@gen9_exec_parse@allowed-all.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@gen9_exec_parse@allowed-all.html

  * igt@i915_selftest@live@client:
    - shard-skl:          [PASS][27] -> ([INCOMPLETE][28], [INCOMPLETE][29]) ([i915#2295])
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@i915_selftest@live@client.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@i915_selftest@live@client.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@i915_selftest@live@client.html

  * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b:
    - shard-skl:          [PASS][30] -> ([PASS][31], [DMESG-WARN][32]) ([i915#1982]) +3 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html

  * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
    - shard-skl:          [PASS][33] -> [FAIL][34] ([i915#54]) +1 similar issue
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html

  * igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
    - shard-apl:          [PASS][35] -> ([FAIL][36], [PASS][37]) ([i915#54])
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html

  * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
    - shard-apl:          [PASS][38] -> ([FAIL][39], [FAIL][40]) ([i915#54])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
    - shard-kbl:          [PASS][41] -> ([FAIL][42], [FAIL][43]) ([i915#54])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic:
    - shard-skl:          [PASS][44] -> ([PASS][45], [FAIL][46]) ([i915#2346])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html

  * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
    - shard-tglb:         [PASS][47] -> ([PASS][48], [FAIL][49]) ([i915#2346])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html

  * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
    - shard-glk:          [PASS][50] -> ([DMESG-WARN][51], [DMESG-WARN][52]) ([i915#1982])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
    - shard-tglb:         [PASS][53] -> ([PASS][54], [DMESG-WARN][55]) ([i915#1982]) +1 similar issue
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb5/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html

  * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
    - shard-skl:          [PASS][56] -> ([DMESG-WARN][57], [DMESG-WARN][58]) ([i915#1982]) +1 similar issue
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl4/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html

  * igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
    - shard-apl:          [PASS][59] -> ([DMESG-WARN][60], [DMESG-WARN][61]) ([i915#1982])
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl7/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-glk:          [PASS][62] -> ([FAIL][63], [PASS][64]) ([i915#64])
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk1/igt@kms_fbcon_fbt@fbc-suspend.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@kms_fbcon_fbt@fbc-suspend.html
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1:
    - shard-hsw:          [PASS][65] -> [DMESG-WARN][66] ([i915#1982])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw1/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1.html
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw1/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
    - shard-tglb:         [PASS][67] -> ([PASS][68], [FAIL][69]) ([i915#2598])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html

  * igt@kms_flip@flip-vs-expired-vblank@c-edp1:
    - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72]) ([i915#79])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html

  * igt@kms_flip@flip-vs-suspend@c-dp1:
    - shard-apl:          [PASS][73] -> ([PASS][74], [DMESG-WARN][75]) ([i915#180])
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html

  * igt@kms_flip@plain-flip-ts-check@a-edp1:
    - shard-skl:          [PASS][76] -> ([FAIL][77], [PASS][78]) ([i915#2122])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl9/igt@kms_flip@plain-flip-ts-check@a-edp1.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_flip@plain-flip-ts-check@a-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
    - shard-tglb:         [PASS][79] -> ([DMESG-WARN][80], [DMESG-WARN][81]) ([i915#1982])
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html

  * igt@kms_hdr@bpc-switch-dpms:
    - shard-skl:          [PASS][82] -> ([FAIL][83], [FAIL][84]) ([i915#1188])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-skl:          [PASS][85] -> ([FAIL][86], [FAIL][87]) ([fdo#108145] / [i915#265])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html

  * igt@kms_plane_cursor@pipe-b-viewport-size-256:
    - shard-apl:          [PASS][88] -> ([DMESG-WARN][89], [PASS][90]) ([i915#1982]) +4 similar issues
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl1/igt@kms_plane_cursor@pipe-b-viewport-size-256.html
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl6/igt@kms_plane_cursor@pipe-b-viewport-size-256.html
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl7/igt@kms_plane_cursor@pipe-b-viewport-size-256.html

  * igt@kms_psr2_su@page_flip:
    - shard-iclb:         [PASS][91] -> ([SKIP][92], [PASS][93]) ([fdo#109642] / [fdo#111068])
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_psr2_su@page_flip.html
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_psr2_su@page_flip.html
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_psr2_su@page_flip.html

  * igt@kms_psr@psr2_sprite_render:
    - shard-iclb:         [PASS][94] -> ([SKIP][95], [PASS][96]) ([fdo#109441])
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
   [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
   [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

  * igt@perf@polling:
    - shard-skl:          [PASS][97] -> ([FAIL][98], [PASS][99]) ([i915#1542])
   [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@perf@polling.html
   [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl5/igt@perf@polling.html
   [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@perf@polling.html

  * igt@perf_pmu@module-unload:
    - shard-skl:          [PASS][100] -> ([PASS][101], [DMESG-WARN][102]) ([i915#1982] / [i915#262])
   [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl4/igt@perf_pmu@module-unload.html
   [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@perf_pmu@module-unload.html
   [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@perf_pmu@module-unload.html

  
#### Possible fixes ####

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [INCOMPLETE][103] -> ([PASS][104], [PASS][105])
   [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl4/igt@gem_workarounds@suspend-resume.html
   [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl2/igt@gem_workarounds@suspend-resume.html
   [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@gem_workarounds@suspend-resume.html

  * igt@i915_pm_rc6_residency@rc6-fence:
    - shard-hsw:          [WARN][106] ([i915#1519]) -> [PASS][107]
   [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html
   [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html

  * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
    - shard-skl:          [FAIL][108] ([i915#54]) -> [PASS][109] +1 similar issue
   [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
   [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html

  * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
    - shard-skl:          [FAIL][110] ([i915#54]) -> ([PASS][111], [PASS][112]) +1 similar issue
   [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
   [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
   [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          [FAIL][113] ([i915#96]) -> [PASS][114]
   [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
   [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - shard-skl:          [DMESG-WARN][115] ([i915#1982]) -> ([PASS][116], [PASS][117]) +1 similar issue
   [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
   [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
    - shard-skl:          [FAIL][118] ([i915#79]) -> ([PASS][119], [PASS][120])
   [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
   [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
   [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html

  * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
    - shard-skl:          [INCOMPLETE][121] ([i915#198]) -> ([PASS][122], [PASS][123])
   [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
   [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
   [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html

  * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
    - shard-skl:          [FAIL][124] ([i915#2122]) -> ([PASS][125], [PASS][126])
   [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
   [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
   [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html

  * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc:
    - shard-tglb:         [DMESG-WARN][127] ([i915#1982]) -> ([PASS][128], [PASS][129])
   [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
   [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
   [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html

  * igt@kms_lease@simple_lease:
    - shard-glk:          [DMESG-WARN][130] ([i915#1982]) -> ([PASS][131], [PASS][132])
   [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk5/igt@kms_lease@simple_lease.html
   [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk5/igt@kms_lease@simple_lease.html
   [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk2/igt@kms_lease@simple_lease.html

  * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
    - shard-iclb:         [FAIL][133] ([i915#53]) -> ([PASS][134], [PASS][135])
   [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
   [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
   [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
    - shard-snb:          [DMESG-WARN][136] ([i915#42]) -> [PASS][137]
   [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-snb5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
   [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-snb4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html

  * igt@perf@blocking:
    - shard-skl:          [FAIL][138] ([i915#1542]) -> ([PASS][139], [PASS][140])
   [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@perf@blocking.html
   [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@perf@blocking.html
   [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@perf@blocking.html

  * igt@perf@polling-parameterized:
    - shard-glk:          [FAIL][141] ([i915#1542]) -> ([PASS][142], [PASS][143])
   [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk2/igt@perf@polling-parameterized.html
   [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk5/igt@perf@polling-parameterized.html
   [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk8/igt@perf@polling-parameterized.html

  
#### Warnings ####

  * igt@drm_read@fault-buffer:
    - shard-glk:          [DMESG-WARN][144] ([i915#1982]) -> ([DMESG-WARN][145], [PASS][146]) ([i915#1982])
   [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@drm_read@fault-buffer.html
   [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk8/igt@drm_read@fault-buffer.html
   [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk6/igt@drm_read@fault-buffer.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-skl:          [DMESG-WARN][147] ([i915#1436] / [i915#716]) -> ([DMESG-WARN][148], [PASS][149]) ([i915#1436] / [i915#716])
   [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl9/igt@gen9_exec_parse@allowed-single.html
   [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@gen9_exec_parse@allowed-single.html
   [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_rc6_residency@rc6-idle:
    - shard-iclb:         [WARN][150] ([i915#2684]) -> ([WARN][151], [WARN][152]) ([i915#1804] / [i915#2684])
   [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
   [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
   [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html

  * igt@i915_selftest@mock@memory_region:
    - shard-skl:          [INCOMPLETE][153] ([i915#2753]) -> ([INCOMPLETE][154], [INCOMPLETE][155]) ([i915#2753] / [i915#2756])
   [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@i915_selftest@mock@memory_region.html
   [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@i915_selftest@mock@memory_region.html
   [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@i915_selftest@mock@memory_region.html
    - shard-glk:          [INCOMPLETE][156] ([i915#2753]) -> ([INCOMPLETE][157], [INCOMPLETE][158]) ([i915#2753] / [i915#2756])
   [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk6/igt@i915_selftest@mock@memory_region.html
   [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@i915_selftest@mock@memory_region.html
   [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk1/igt@i915_selftest@mock@memory_region.html
    - shard-apl:          [INCOMPLETE][159] ([i915#2753]) -> ([INCOMPLETE][160], [INCOMPLETE][161]) ([i915#2753] / [i915#2756])
   [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl7/igt@i915_selftest@mock@memory_region.html
   [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl6/igt@i915_selftest@mock@memory_region.html
   [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl3/igt@i915_selftest@mock@memory_region.html
    - shard-iclb:         [INCOMPLETE][162] ([i915#2753]) -> ([INCOMPLETE][163], [INCOMPLETE][164]) ([i915#2753] / [i915#2756])
   [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb7/igt@i915_selftest@mock@memory_region.html
   [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb1/igt@i915_selftest@mock@memory_region.html
   [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@i915_selftest@mock@memory_region.html
    - shard-kbl:          [INCOMPLETE][165] ([i915#2753]) -> ([INCOMPLETE][166], [INCOMPLETE][167]) ([i915#2753] / [i915#2756])
   [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-kbl6/igt@i915_selftest@mock@memory_region.html
   [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl4/igt@i915_selftest@mock@memory_region.html
   [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl2/igt@i915_selftest@mock@memory_region.html
    - shard-hsw:          [INCOMPLETE][168] ([i915#2753]) -> [INCOMPLETE][169] ([i915#2753] / [i915#2756])
   [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw7/igt@i915_selftest@mock@memory_region.html
   [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw7/igt@i915_selftest@mock@memory_region.html
    - shard-snb:

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/index.html

[-- Attachment #1.2: Type: text/html, Size: 32302 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add the missing wakeref tracking for display power references (rev3)

[Imre Deak]

On Thu, Dec 03, 2020 at 10:44:12AM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Add the missing wakeref tracking for display power references (rev3)
> URL   : https://patchwork.freedesktop.org/series/84418/
> State : success

Pushed to -dinq, thanks for the review.

> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_9415_full -> Patchwork_19027_full
> ====================================================
> 
> Summary
> -------
> 
>   **WARNING**
> 
>   Minor unknown changes coming with Patchwork_19027_full need to be verified
>   manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_19027_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_19027_full:
> 
> ### IGT changes ###
> 
> #### Warnings ####
> 
>   * igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
>     - shard-iclb:         [FAIL][1] -> ([FAIL][2], [PASS][3])
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html
> 
>   
> New tests
> ---------
> 
>   New tests have been introduced between CI_DRM_9415_full and Patchwork_19027_full:
> 
> ### New CI tests (1) ###
> 
>   * boot:
>     - Statuses : 351 pass(s)
>     - Exec time: [0.0] s
> 
>   
> 
> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_19027_full that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@core_hotunplug@unbind-rebind:
>     - shard-iclb:         [PASS][4] -> ([PASS][5], [DMESG-WARN][6]) ([i915#1982])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb5/igt@core_hotunplug@unbind-rebind.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb5/igt@core_hotunplug@unbind-rebind.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb8/igt@core_hotunplug@unbind-rebind.html
> 
>   * igt@debugfs_test@read_all_entries_display_on:
>     - shard-skl:          [PASS][7] -> [DMESG-WARN][8] ([i915#1982]) +1 similar issue
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@debugfs_test@read_all_entries_display_on.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@debugfs_test@read_all_entries_display_on.html
> 
>   * igt@drm_read@empty-block:
>     - shard-glk:          [PASS][9] -> ([DMESG-WARN][10], [PASS][11]) ([i915#1982])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@drm_read@empty-block.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@drm_read@empty-block.html
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@drm_read@empty-block.html
> 
>   * igt@feature_discovery@psr2:
>     - shard-iclb:         [PASS][12] -> ([PASS][13], [SKIP][14]) ([i915#658])
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@feature_discovery@psr2.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@feature_discovery@psr2.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@feature_discovery@psr2.html
> 
>   * igt@gem_exec_endless@dispatch@rcs0:
>     - shard-iclb:         [PASS][15] -> ([PASS][16], [INCOMPLETE][17]) ([i915#2502])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb1/igt@gem_exec_endless@dispatch@rcs0.html
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb8/igt@gem_exec_endless@dispatch@rcs0.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb4/igt@gem_exec_endless@dispatch@rcs0.html
> 
>   * igt@gem_exec_whisper@basic-queues-forked-all:
>     - shard-glk:          [PASS][18] -> ([DMESG-WARN][19], [PASS][20]) ([i915#118] / [i915#95])
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk1/igt@gem_exec_whisper@basic-queues-forked-all.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@gem_exec_whisper@basic-queues-forked-all.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@gem_exec_whisper@basic-queues-forked-all.html
> 
>   * igt@gem_huc_copy@huc-copy:
>     - shard-tglb:         [PASS][21] -> ([SKIP][22], [PASS][23]) ([i915#2190])
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb3/igt@gem_huc_copy@huc-copy.html
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@gem_huc_copy@huc-copy.html
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@gem_huc_copy@huc-copy.html
> 
>   * igt@gen9_exec_parse@allowed-all:
>     - shard-skl:          [PASS][24] -> ([DMESG-WARN][25], [PASS][26]) ([i915#1436] / [i915#716])
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@gen9_exec_parse@allowed-all.html
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@gen9_exec_parse@allowed-all.html
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@gen9_exec_parse@allowed-all.html
> 
>   * igt@i915_selftest@live@client:
>     - shard-skl:          [PASS][27] -> ([INCOMPLETE][28], [INCOMPLETE][29]) ([i915#2295])
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@i915_selftest@live@client.html
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@i915_selftest@live@client.html
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@i915_selftest@live@client.html
> 
>   * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b:
>     - shard-skl:          [PASS][30] -> ([PASS][31], [DMESG-WARN][32]) ([i915#1982]) +3 similar issues
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@edp-1-pipe-b.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding:
>     - shard-skl:          [PASS][33] -> [FAIL][34] ([i915#54]) +1 similar issue
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_cursor_crc@pipe-b-cursor-128x42-sliding.html
> 
>   * igt@kms_cursor_crc@pipe-b-cursor-256x256-random:
>     - shard-apl:          [PASS][35] -> ([FAIL][36], [PASS][37]) ([i915#54])
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl3/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-256x256-random.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding:
>     - shard-apl:          [PASS][38] -> ([FAIL][39], [FAIL][40]) ([i915#54])
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl8/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>     - shard-kbl:          [PASS][41] -> ([FAIL][42], [FAIL][43]) ([i915#54])
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl1/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-256x256-sliding.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-atomic:
>     - shard-skl:          [PASS][44] -> ([PASS][45], [FAIL][46]) ([i915#2346])
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
> 
>   * igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
>     - shard-tglb:         [PASS][47] -> ([PASS][48], [FAIL][49]) ([i915#2346])
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb1/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
> 
>   * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions:
>     - shard-glk:          [PASS][50] -> ([DMESG-WARN][51], [DMESG-WARN][52]) ([i915#1982])
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
>     - shard-tglb:         [PASS][53] -> ([PASS][54], [DMESG-WARN][55]) ([i915#1982]) +1 similar issue
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb5/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions.html
> 
>   * igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size:
>     - shard-skl:          [PASS][56] -> ([DMESG-WARN][57], [DMESG-WARN][58]) ([i915#1982]) +1 similar issue
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl4/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_cursor_legacy@short-flip-after-cursor-atomic-transitions-varying-size.html
> 
>   * igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
>     - shard-apl:          [PASS][59] -> ([DMESG-WARN][60], [DMESG-WARN][61]) ([i915#1982])
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl7/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl1/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
> 
>   * igt@kms_fbcon_fbt@fbc-suspend:
>     - shard-glk:          [PASS][62] -> ([FAIL][63], [PASS][64]) ([i915#64])
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk1/igt@kms_fbcon_fbt@fbc-suspend.html
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@kms_fbcon_fbt@fbc-suspend.html
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk9/igt@kms_fbcon_fbt@fbc-suspend.html
> 
>   * igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1:
>     - shard-hsw:          [PASS][65] -> [DMESG-WARN][66] ([i915#1982])
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw1/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1.html
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw1/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible@ab-vga1-hdmi-a1.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
>     - shard-tglb:         [PASS][67] -> ([PASS][68], [FAIL][69]) ([i915#2598])
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank@c-edp1:
>     - shard-skl:          [PASS][70] -> ([PASS][71], [FAIL][72]) ([i915#79])
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
> 
>   * igt@kms_flip@flip-vs-suspend@c-dp1:
>     - shard-apl:          [PASS][73] -> ([PASS][74], [DMESG-WARN][75]) ([i915#180])
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
>    [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl7/igt@kms_flip@flip-vs-suspend@c-dp1.html
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
> 
>   * igt@kms_flip@plain-flip-ts-check@a-edp1:
>     - shard-skl:          [PASS][76] -> ([FAIL][77], [PASS][78]) ([i915#2122])
>    [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl9/igt@kms_flip@plain-flip-ts-check@a-edp1.html
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@kms_flip@plain-flip-ts-check@a-edp1.html
>    [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_flip@plain-flip-ts-check@a-edp1.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu:
>     - shard-tglb:         [PASS][79] -> ([DMESG-WARN][80], [DMESG-WARN][81]) ([i915#1982])
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-cpu.html
> 
>   * igt@kms_hdr@bpc-switch-dpms:
>     - shard-skl:          [PASS][82] -> ([FAIL][83], [FAIL][84]) ([i915#1188])
>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_hdr@bpc-switch-dpms.html
>    [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_hdr@bpc-switch-dpms.html
>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_hdr@bpc-switch-dpms.html
> 
>   * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
>     - shard-skl:          [PASS][85] -> ([FAIL][86], [FAIL][87]) ([fdo#108145] / [i915#265])
>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>    [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
> 
>   * igt@kms_plane_cursor@pipe-b-viewport-size-256:
>     - shard-apl:          [PASS][88] -> ([DMESG-WARN][89], [PASS][90]) ([i915#1982]) +4 similar issues
>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl1/igt@kms_plane_cursor@pipe-b-viewport-size-256.html
>    [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl6/igt@kms_plane_cursor@pipe-b-viewport-size-256.html
>    [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl7/igt@kms_plane_cursor@pipe-b-viewport-size-256.html
> 
>   * igt@kms_psr2_su@page_flip:
>     - shard-iclb:         [PASS][91] -> ([SKIP][92], [PASS][93]) ([fdo#109642] / [fdo#111068])
>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_psr2_su@page_flip.html
>    [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_psr2_su@page_flip.html
>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_psr2_su@page_flip.html
> 
>   * igt@kms_psr@psr2_sprite_render:
>     - shard-iclb:         [PASS][94] -> ([SKIP][95], [PASS][96]) ([fdo#109441])
>    [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
>    [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@kms_psr@psr2_sprite_render.html
>    [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
> 
>   * igt@perf@polling:
>     - shard-skl:          [PASS][97] -> ([FAIL][98], [PASS][99]) ([i915#1542])
>    [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@perf@polling.html
>    [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl5/igt@perf@polling.html
>    [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@perf@polling.html
> 
>   * igt@perf_pmu@module-unload:
>     - shard-skl:          [PASS][100] -> ([PASS][101], [DMESG-WARN][102]) ([i915#1982] / [i915#262])
>    [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl4/igt@perf_pmu@module-unload.html
>    [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@perf_pmu@module-unload.html
>    [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@perf_pmu@module-unload.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@gem_workarounds@suspend-resume:
>     - shard-apl:          [INCOMPLETE][103] -> ([PASS][104], [PASS][105])
>    [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl4/igt@gem_workarounds@suspend-resume.html
>    [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl2/igt@gem_workarounds@suspend-resume.html
>    [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl4/igt@gem_workarounds@suspend-resume.html
> 
>   * igt@i915_pm_rc6_residency@rc6-fence:
>     - shard-hsw:          [WARN][106] ([i915#1519]) -> [PASS][107]
>    [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html
>    [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html
> 
>   * igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen:
>     - shard-skl:          [FAIL][108] ([i915#54]) -> [PASS][109] +1 similar issue
>    [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl2/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
>    [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-64x64-onscreen.html
> 
>   * igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen:
>     - shard-skl:          [FAIL][110] ([i915#54]) -> ([PASS][111], [PASS][112]) +1 similar issue
>    [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl3/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
>    [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl6/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
>    [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-64x21-offscreen.html
> 
>   * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
>     - shard-hsw:          [FAIL][113] ([i915#96]) -> [PASS][114]
>    [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw1/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
>    [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
> 
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - shard-skl:          [DMESG-WARN][115] ([i915#1982]) -> ([PASS][116], [PASS][117]) +1 similar issue
>    [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>    [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>    [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
> 
>   * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
>     - shard-skl:          [FAIL][118] ([i915#79]) -> ([PASS][119], [PASS][120])
>    [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>    [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
>    [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
> 
>   * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
>     - shard-skl:          [INCOMPLETE][121] ([i915#198]) -> ([PASS][122], [PASS][123])
>    [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl7/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
>    [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl1/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
>    [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl5/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
> 
>   * igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1:
>     - shard-skl:          [FAIL][124] ([i915#2122]) -> ([PASS][125], [PASS][126])
>    [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl6/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
>    [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
>    [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@b-edp1.html
> 
>   * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc:
>     - shard-tglb:         [DMESG-WARN][127] ([i915#1982]) -> ([PASS][128], [PASS][129])
>    [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
>    [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
>    [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-wc.html
> 
>   * igt@kms_lease@simple_lease:
>     - shard-glk:          [DMESG-WARN][130] ([i915#1982]) -> ([PASS][131], [PASS][132])
>    [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk5/igt@kms_lease@simple_lease.html
>    [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk5/igt@kms_lease@simple_lease.html
>    [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk2/igt@kms_lease@simple_lease.html
> 
>   * igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
>     - shard-iclb:         [FAIL][133] ([i915#53]) -> ([PASS][134], [PASS][135])
>    [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb2/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
>    [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb6/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
>    [135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb2/igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence.html
> 
>   * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
>     - shard-snb:          [DMESG-WARN][136] ([i915#42]) -> [PASS][137]
>    [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-snb5/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
>    [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-snb4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
> 
>   * igt@perf@blocking:
>     - shard-skl:          [FAIL][138] ([i915#1542]) -> ([PASS][139], [PASS][140])
>    [138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@perf@blocking.html
>    [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@perf@blocking.html
>    [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@perf@blocking.html
> 
>   * igt@perf@polling-parameterized:
>     - shard-glk:          [FAIL][141] ([i915#1542]) -> ([PASS][142], [PASS][143])
>    [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk2/igt@perf@polling-parameterized.html
>    [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk5/igt@perf@polling-parameterized.html
>    [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk8/igt@perf@polling-parameterized.html
> 
>   
> #### Warnings ####
> 
>   * igt@drm_read@fault-buffer:
>     - shard-glk:          [DMESG-WARN][144] ([i915#1982]) -> ([DMESG-WARN][145], [PASS][146]) ([i915#1982])
>    [144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk9/igt@drm_read@fault-buffer.html
>    [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk8/igt@drm_read@fault-buffer.html
>    [146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk6/igt@drm_read@fault-buffer.html
> 
>   * igt@gen9_exec_parse@allowed-single:
>     - shard-skl:          [DMESG-WARN][147] ([i915#1436] / [i915#716]) -> ([DMESG-WARN][148], [PASS][149]) ([i915#1436] / [i915#716])
>    [147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl9/igt@gen9_exec_parse@allowed-single.html
>    [148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl8/igt@gen9_exec_parse@allowed-single.html
>    [149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl3/igt@gen9_exec_parse@allowed-single.html
> 
>   * igt@i915_pm_rc6_residency@rc6-idle:
>     - shard-iclb:         [WARN][150] ([i915#2684]) -> ([WARN][151], [WARN][152]) ([i915#1804] / [i915#2684])
>    [150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
>    [151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
>    [152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb7/igt@i915_pm_rc6_residency@rc6-idle.html
> 
>   * igt@i915_selftest@mock@memory_region:
>     - shard-skl:          [INCOMPLETE][153] ([i915#2753]) -> ([INCOMPLETE][154], [INCOMPLETE][155]) ([i915#2753] / [i915#2756])
>    [153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-skl10/igt@i915_selftest@mock@memory_region.html
>    [154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl9/igt@i915_selftest@mock@memory_region.html
>    [155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-skl10/igt@i915_selftest@mock@memory_region.html
>     - shard-glk:          [INCOMPLETE][156] ([i915#2753]) -> ([INCOMPLETE][157], [INCOMPLETE][158]) ([i915#2753] / [i915#2756])
>    [156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-glk6/igt@i915_selftest@mock@memory_region.html
>    [157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk3/igt@i915_selftest@mock@memory_region.html
>    [158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-glk1/igt@i915_selftest@mock@memory_region.html
>     - shard-apl:          [INCOMPLETE][159] ([i915#2753]) -> ([INCOMPLETE][160], [INCOMPLETE][161]) ([i915#2753] / [i915#2756])
>    [159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-apl7/igt@i915_selftest@mock@memory_region.html
>    [160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl6/igt@i915_selftest@mock@memory_region.html
>    [161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-apl3/igt@i915_selftest@mock@memory_region.html
>     - shard-iclb:         [INCOMPLETE][162] ([i915#2753]) -> ([INCOMPLETE][163], [INCOMPLETE][164]) ([i915#2753] / [i915#2756])
>    [162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-iclb7/igt@i915_selftest@mock@memory_region.html
>    [163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb1/igt@i915_selftest@mock@memory_region.html
>    [164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-iclb3/igt@i915_selftest@mock@memory_region.html
>     - shard-kbl:          [INCOMPLETE][165] ([i915#2753]) -> ([INCOMPLETE][166], [INCOMPLETE][167]) ([i915#2753] / [i915#2756])
>    [165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-kbl6/igt@i915_selftest@mock@memory_region.html
>    [166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl4/igt@i915_selftest@mock@memory_region.html
>    [167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-kbl2/igt@i915_selftest@mock@memory_region.html
>     - shard-hsw:          [INCOMPLETE][168] ([i915#2753]) -> [INCOMPLETE][169] ([i915#2753] / [i915#2756])
>    [168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9415/shard-hsw7/igt@i915_selftest@mock@memory_region.html
>    [169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/shard-hsw7/igt@i915_selftest@mock@memory_region.html
>     - shard-snb:
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19027/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx