* [PATCH net-next] net: delete __dev_getfirstbyhwtype
@ 2020-11-29 20:05 Vladimir Oltean
2020-11-30 9:38 ` David Howells
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Oltean @ 2020-11-29 20:05 UTC (permalink / raw)
To: Jakub Kicinski, netdev; +Cc: Arnd Bergmann, David Howells, Eric Dumazet
The last user of the RTNL brother of dev_getfirstbyhwtype (the latter
being synchronized under RCU) has been deleted in commit b4db2b35fc44
("afs: Use core kernel UUID generation").
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: David Howells <dhowells@redhat.com>
Cc: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
include/linux/netdevice.h | 1 -
net/core/dev.c | 13 -------------
2 files changed, 14 deletions(-)
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 08ee2e90c822..7f85c23d52ab 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2815,7 +2815,6 @@ unsigned long netdev_boot_base(const char *prefix, int unit);
struct net_device *dev_getbyhwaddr_rcu(struct net *net, unsigned short type,
const char *hwaddr);
struct net_device *dev_getfirstbyhwtype(struct net *net, unsigned short type);
-struct net_device *__dev_getfirstbyhwtype(struct net *net, unsigned short type);
void dev_add_pack(struct packet_type *pt);
void dev_remove_pack(struct packet_type *pt);
void __dev_remove_pack(struct packet_type *pt);
diff --git a/net/core/dev.c b/net/core/dev.c
index 916186e7bc56..78fa284225c6 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1069,19 +1069,6 @@ struct net_device *dev_getbyhwaddr_rcu(struct net *net, unsigned short type,
}
EXPORT_SYMBOL(dev_getbyhwaddr_rcu);
-struct net_device *__dev_getfirstbyhwtype(struct net *net, unsigned short type)
-{
- struct net_device *dev;
-
- ASSERT_RTNL();
- for_each_netdev(net, dev)
- if (dev->type == type)
- return dev;
-
- return NULL;
-}
-EXPORT_SYMBOL(__dev_getfirstbyhwtype);
-
struct net_device *dev_getfirstbyhwtype(struct net *net, unsigned short type)
{
struct net_device *dev, *ret = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: delete __dev_getfirstbyhwtype
2020-11-29 20:05 [PATCH net-next] net: delete __dev_getfirstbyhwtype Vladimir Oltean
@ 2020-11-30 9:38 ` David Howells
2020-12-01 23:41 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: David Howells @ 2020-11-30 9:38 UTC (permalink / raw)
To: Vladimir Oltean
Cc: dhowells, Jakub Kicinski, netdev, Arnd Bergmann, Eric Dumazet
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> The last user of the RTNL brother of dev_getfirstbyhwtype (the latter
> being synchronized under RCU) has been deleted in commit b4db2b35fc44
> ("afs: Use core kernel UUID generation").
>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Fine by me. I thought it had already been removed.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: delete __dev_getfirstbyhwtype
2020-11-30 9:38 ` David Howells
@ 2020-12-01 23:41 ` Jakub Kicinski
0 siblings, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2020-12-01 23:41 UTC (permalink / raw)
To: David Howells, Vladimir Oltean; +Cc: netdev, Arnd Bergmann, Eric Dumazet
On Mon, 30 Nov 2020 09:38:42 +0000 David Howells wrote:
> Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> > The last user of the RTNL brother of dev_getfirstbyhwtype (the latter
> > being synchronized under RCU) has been deleted in commit b4db2b35fc44
> > ("afs: Use core kernel UUID generation").
> >
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: David Howells <dhowells@redhat.com>
> > Cc: Eric Dumazet <eric.dumazet@gmail.com>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> Fine by me. I thought it had already been removed.
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 23:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-29 20:05 [PATCH net-next] net: delete __dev_getfirstbyhwtype Vladimir Oltean
2020-11-30 9:38 ` David Howells
2020-12-01 23:41 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.