* [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c
@ 2020-12-01 15:41 Vicente Bergas
2020-12-01 15:41 ` [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4 Vicente Bergas
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Vicente Bergas @ 2020-12-01 15:41 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Johan Jonker, Chen-Yu Tsai,
Douglas Anderson, Carlos de Paula, Sugar Zhang, Shunqian Zheng,
Boris Brezillon, Robin Murphy, linux-rockchip
Cc: Vicente Bergas
This patch series fix several issues found on rk3399-rock-pi-4c
Vicente Bergas (3):
arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4
arm64: dts: rockchip: fix I2S conflict on rk3399-rock-pi-4
arm64: dts: rockchip: use USB host by default on rk3399-rock-pi-4
.../arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
@ 2020-12-01 15:41 ` Vicente Bergas
2020-12-01 15:41 ` [PATCH 2/3] arm64: dts: rockchip: fix I2S conflict " Vicente Bergas
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Vicente Bergas @ 2020-12-01 15:41 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Johan Jonker, Chen-Yu Tsai,
Douglas Anderson, Carlos de Paula, Sugar Zhang, Shunqian Zheng,
Boris Brezillon, Robin Murphy, linux-rockchip
Cc: Vicente Bergas
Based on the board schematics at
https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi_4c_v12_sch_20200620.pdf
on page 18:
vcc_lan is not controllable by software, it is just an analog LC filter.
Because of this, it can not be turned off-in-suspend.
and on page 17:
vcc_cam and vcc_mipi are not voltage regulators, they are just switches.
So, the voltage range is not applicable.
This silences an error message about not being able to adjust the voltage.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 8 --------
1 file changed, 8 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 678a33601..06df2397b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -111,10 +111,6 @@ vcc_lan: vcc3v3-phy-regulator {
regulator-boot-on;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
-
- regulator-state-mem {
- regulator-off-in-suspend;
- };
};
vdd_log: vdd-log {
@@ -362,8 +358,6 @@ vcc_cam: SWITCH_REG1 {
regulator-name = "vcc_cam";
regulator-always-on;
regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-off-in-suspend;
};
@@ -373,8 +367,6 @@ vcc_mipi: SWITCH_REG2 {
regulator-name = "vcc_mipi";
regulator-always-on;
regulator-boot-on;
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-off-in-suspend;
};
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] arm64: dts: rockchip: fix I2S conflict on rk3399-rock-pi-4
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
2020-12-01 15:41 ` [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4 Vicente Bergas
@ 2020-12-01 15:41 ` Vicente Bergas
2020-12-01 15:41 ` [PATCH 3/3] arm64: dts: rockchip: use USB host by default " Vicente Bergas
2020-12-04 11:01 ` [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: Vicente Bergas @ 2020-12-01 15:41 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Johan Jonker, Chen-Yu Tsai,
Douglas Anderson, Carlos de Paula, Sugar Zhang, Shunqian Zheng,
Boris Brezillon, Robin Murphy, linux-rockchip
Cc: Vicente Bergas
Based on the board schematics at
https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi_4c_v12_sch_20200620.pdf
on page 14:
Only two channels of I2S are connected and the extra
I2S pins are in conflict with other functions like USB power.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 06df2397b..63b029a54 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -432,8 +432,9 @@ &i2c4 {
};
&i2s0 {
- rockchip,playback-channels = <8>;
- rockchip,capture-channels = <8>;
+ pinctrl-0 = <&i2s0_2ch_bus>;
+ rockchip,capture-channels = <2>;
+ rockchip,playback-channels = <2>;
status = "okay";
};
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] arm64: dts: rockchip: use USB host by default on rk3399-rock-pi-4
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
2020-12-01 15:41 ` [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4 Vicente Bergas
2020-12-01 15:41 ` [PATCH 2/3] arm64: dts: rockchip: fix I2S conflict " Vicente Bergas
@ 2020-12-01 15:41 ` Vicente Bergas
2020-12-04 11:01 ` [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: Vicente Bergas @ 2020-12-01 15:41 UTC (permalink / raw)
To: Rob Herring, Heiko Stuebner, Johan Jonker, Chen-Yu Tsai,
Douglas Anderson, Carlos de Paula, Sugar Zhang, Shunqian Zheng,
Boris Brezillon, Robin Murphy, linux-rockchip
Cc: Vicente Bergas
Based on the board schematics at
https://dl.radxa.com/rockpi4/docs/hw/rockpi4/rockpi_4c_v12_sch_20200620.pdf
on page 19 there is an USB Type-A receptacle being used as an USB-OTG port.
But the Type-A connector is not valid for OTG operation, for this reason
there is a switch to select host or device role.
This is non-compliant and error prone because switching is manual.
So, use host mode as it corresponds for a Type-A receptacle.
Signed-off-by: Vicente Bergas <vicencb@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
index 63b029a54..fb7599f07 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4.dtsi
@@ -673,7 +673,7 @@ &usbdrd3_0 {
&usbdrd_dwc3_0 {
status = "okay";
- dr_mode = "otg";
+ dr_mode = "host";
};
&usbdrd3_1 {
--
2.29.2
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
` (2 preceding siblings ...)
2020-12-01 15:41 ` [PATCH 3/3] arm64: dts: rockchip: use USB host by default " Vicente Bergas
@ 2020-12-04 11:01 ` Heiko Stuebner
3 siblings, 0 replies; 5+ messages in thread
From: Heiko Stuebner @ 2020-12-04 11:01 UTC (permalink / raw)
To: Johan Jonker, Vicente Bergas, Shunqian Zheng, Sugar Zhang,
Rob Herring, Douglas Anderson, linux-rockchip, Boris Brezillon,
Carlos de Paula, Robin Murphy, Chen-Yu Tsai
Cc: Heiko Stuebner
On Tue, 1 Dec 2020 16:41:29 +0100, Vicente Bergas wrote:
> This patch series fix several issues found on rk3399-rock-pi-4c
>
> Vicente Bergas (3):
> arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4
> arm64: dts: rockchip: fix I2S conflict on rk3399-rock-pi-4
> arm64: dts: rockchip: use USB host by default on rk3399-rock-pi-4
>
> [...]
Applied, thanks!
[1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4
commit: 328c6112787bf7562dbea638840366cd197868d6
[2/3] arm64: dts: rockchip: fix I2S conflict on rk3399-rock-pi-4
commit: eff57d38b546b3a50588e447a41ff3571a407c9f
[3/3] arm64: dts: rockchip: use USB host by default on rk3399-rock-pi-4
commit: e12f67fe83446432ef16704c22ec23bd1dbcd094
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-12-04 11:02 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 15:41 [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Vicente Bergas
2020-12-01 15:41 ` [PATCH 1/3] arm64: dts: rockchip: fix supplies on rk3399-rock-pi-4 Vicente Bergas
2020-12-01 15:41 ` [PATCH 2/3] arm64: dts: rockchip: fix I2S conflict " Vicente Bergas
2020-12-01 15:41 ` [PATCH 3/3] arm64: dts: rockchip: use USB host by default " Vicente Bergas
2020-12-04 11:01 ` [PATCH 0/3] arm64: dts: rockchip: miscellaneous fixes for rk3399-rock-pi-4c Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.