linux-next: build failure after merge of the phy-next tree

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 430 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
   17 | #include <mt7621.h>
      |          ^~~~~~~~~~

Caused by commit

  d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")

I have reverted that commit for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Sergio Paracuellos]

Hi Stephen,

On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
>    17 | #include <mt7621.h>
>       |          ^~~~~~~~~~
>
> Caused by commit
>
>   d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")

This driver has two includes which are in
"arch/mips/include/asm/mach-ralink" and are directly included in the
driver:
* mt7621.h
* ralink_regs.h

This is because this path is directly included in
arch/mips/ralink/Platform for "ralink":

#
# Ralink SoC common stuff
#
cflags-$(CONFIG_RALINK)     += -I$(srctree)/arch/mips/include/asm/mach-ralink

and this driver directly depends on RALINK or COMPILE_TEST (which
might be the problem here):


and this driver directly depends
on RALINK or COMPILE_TEST:

config PHY_MT7621_PCI
    tristate "MediaTek MT7621 PCI PHY Driver"
    depends on (RALINK || COMPILE_TEST) && OF
    select GENERIC_PHY
    select REGMAP_MMIO
    help
      Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver

>
> I have reverted that commit for today.

What is the correct way of fixing this? Include complete path for both
of them like this?

index db79088d5362..cebd53f5a797 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -14,8 +14,8 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/sys_soc.h>
-#include <mt7621.h>
-#include <ralink_regs.h>
+#include <asm/mach-ralink/mt7621.h>
+#include <asm/mach-ralink/ralink_regs.h>

Vinod, please let me know if you want me to send anything for fixing this.

>
> --
> Cheers,
> Stephen Rothwell

Best regards,
    Sergio Paracuellos

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 01-12-20, 07:45, Sergio Paracuellos wrote:
> Hi Stephen,
> 
> On Tue, Dec 1, 2020 at 7:07 AM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Hi all,
> >
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > drivers/phy/ralink/phy-mt7621-pci.c:17:10: fatal error: mt7621.h: No such file or directory
> >    17 | #include <mt7621.h>
> >       |          ^~~~~~~~~~
> >
> > Caused by commit
> >
> >   d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> 
> This driver has two includes which are in
> "arch/mips/include/asm/mach-ralink" and are directly included in the
> driver:
> * mt7621.h
> * ralink_regs.h
> 
> This is because this path is directly included in
> arch/mips/ralink/Platform for "ralink":
> 
> #
> # Ralink SoC common stuff
> #
> cflags-$(CONFIG_RALINK)     += -I$(srctree)/arch/mips/include/asm/mach-ralink
> 
> and this driver directly depends on RALINK or COMPILE_TEST (which
> might be the problem here):
> 
> 
> and this driver directly depends
> on RALINK or COMPILE_TEST:
> 
> config PHY_MT7621_PCI
>     tristate "MediaTek MT7621 PCI PHY Driver"
>     depends on (RALINK || COMPILE_TEST) && OF
>     select GENERIC_PHY
>     select REGMAP_MMIO
>     help
>       Say 'Y' here to add support for MediaTek MT7621 PCI PHY driver
> 
> >
> > I have reverted that commit for today.
> 
> What is the correct way of fixing this? Include complete path for both
> of them like this?
> 
> index db79088d5362..cebd53f5a797 100644
> --- a/drivers/phy/ralink/phy-mt7621-pci.c
> +++ b/drivers/phy/ralink/phy-mt7621-pci.c
> @@ -14,8 +14,8 @@
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
>  #include <linux/sys_soc.h>
> -#include <mt7621.h>
> -#include <ralink_regs.h>
> +#include <asm/mach-ralink/mt7621.h>
> +#include <asm/mach-ralink/ralink_regs.h>
> 
> Vinod, please let me know if you want me to send anything for fixing this.

Yes this makes sense. this will ensure it gets picked up and doesn't
depend in arch specific stuff

-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:2378:38: error: redefinition of 'qmp_pcie_offsets_v5_20'
 2378 | static const struct qmp_pcie_offsets qmp_pcie_offsets_v5_20 = {
      |                                      ^~~~~~~~~~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:2357:38: note: previous definition of 'qmp_pcie_offsets_v5_20' with type 'const struct qmp_pcie_offsets'
 2357 | static const struct qmp_pcie_offsets qmp_pcie_offsets_v5_20 = {
      |                                      ^~~~~~~~~~~~~~~~~~~~~~

Caused by commits

  a05b6d5135ec ("phy: qcom-qmp-pcie: add support for sa8775p")
  64adc0bf06ad ("phy: qcom-qmp-pcie: populate offsets configuration")

I have used the phy-next tree from next-20230817 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 18-08-23, 15:40, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:2378:38: error: redefinition of 'qmp_pcie_offsets_v5_20'
>  2378 | static const struct qmp_pcie_offsets qmp_pcie_offsets_v5_20 = {
>       |                                      ^~~~~~~~~~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-qmp-pcie.c:2357:38: note: previous definition of 'qmp_pcie_offsets_v5_20' with type 'const struct qmp_pcie_offsets'
>  2357 | static const struct qmp_pcie_offsets qmp_pcie_offsets_v5_20 = {
>       |                                      ^~~~~~~~~~~~~~~~~~~~~~
> 
> Caused by commits
> 
>   a05b6d5135ec ("phy: qcom-qmp-pcie: add support for sa8775p")
>   64adc0bf06ad ("phy: qcom-qmp-pcie: populate offsets configuration")

It is fixed now, (commits dropped), sorry for the delay though

-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_snps_eusb2_hsphy_write_mask':
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:147:15: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
  147 |         reg = readl_relaxed(base + offset);
      |               ^~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:150:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
  150 |         writel_relaxed(reg, base + offset);
      |         ^~~~~~~~~~~~~~
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_eusb2_default_parameters':
drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:161:42: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
  161 |                                          FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0));
      |                                          ^~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")

I have used the phy-next tree from next-20230210 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 13-02-23, 13:55, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_snps_eusb2_hsphy_write_mask':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:147:15: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
>   147 |         reg = readl_relaxed(base + offset);
>       |               ^~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:150:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
>   150 |         writel_relaxed(reg, base + offset);
>       |         ^~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_eusb2_default_parameters':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:161:42: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>   161 |                                          FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0));
>       |                                          ^~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")

Thanks Stephen for the report, I have fixed it up by adding the missing
headers:

-- >8 --

From: Vinod Koul <vkoul@kernel.org>
Date: Mon, 13 Feb 2023 10:39:26 +0530
Subject: [PATCH] phy: qcom: snps-eusb2: Add missing headers

The driver was missing to include couple of headers explictly which
causes build to fail on other archs

Fix this by adding bitfield.h and iopoll.h explictly

Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 40a421cf3dd9..64e835b7ef53 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -3,8 +3,10 @@
  * Copyright (c) 2023, Linaro Limited
  */
 
+#include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/delay.h>
+#include <linux/iopoll.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
-- 
2.39.0

-- 
~Vinod

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 13-02-23, 13:55, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_snps_eusb2_hsphy_write_mask':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:147:15: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
>   147 |         reg = readl_relaxed(base + offset);
>       |               ^~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:150:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
>   150 |         writel_relaxed(reg, base + offset);
>       |         ^~~~~~~~~~~~~~
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c: In function 'qcom_eusb2_default_parameters':
> drivers/phy/qualcomm/phy-qcom-snps-eusb2.c:161:42: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
>   161 |                                          FIELD_PREP(PHY_CFG_TX_PREEMP_TUNE_MASK, 0));
>       |                                          ^~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")

Thanks Stephen for the report, I have fixed it up by adding the missing
headers:

-- >8 --

From: Vinod Koul <vkoul@kernel.org>
Date: Mon, 13 Feb 2023 10:39:26 +0530
Subject: [PATCH] phy: qcom: snps-eusb2: Add missing headers

The driver was missing to include couple of headers explictly which
causes build to fail on other archs

Fix this by adding bitfield.h and iopoll.h explictly

Fixes: 80090810f5d3 ("phy: qcom: Add QCOM SNPS eUSB2 driver")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-snps-eusb2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
index 40a421cf3dd9..64e835b7ef53 100644
--- a/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
+++ b/drivers/phy/qualcomm/phy-qcom-snps-eusb2.c
@@ -3,8 +3,10 @@
  * Copyright (c) 2023, Linaro Limited
  */
 
+#include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/delay.h>
+#include <linux/iopoll.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
-- 
2.39.0

-- 
~Vinod

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/qualcomm/phy-qcom-qmp-combo.c: In function 'qcom_qmp_phy_combo_vreg_init':
drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:9: error: 'Return' undeclared (first use in this function)
 2004 |         Return 0;
      |         ^~~~~~
drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:9: note: each undeclared identifier is reported only once for each function it appears in
drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:15: error: expected ';' before numeric constant
 2004 |         Return 0;
      |               ^~
      |               ;
drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2005:1: error: control reaches end of non-void function [-Werror=return-type]
 2005 | }
      | ^
cc1: all warnings being treated as errors

Caused by commit

  6bd9a9be5d73 ("phy: qcom-qmp: add regulator_set_load to dp phy")

I have used the phy-next tree from next-20220706 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 07-07-22, 15:39, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c: In function 'qcom_qmp_phy_combo_vreg_init':
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:9: error: 'Return' undeclared (first use in this function)
>  2004 |         Return 0;
>       |         ^~~~~~
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:9: note: each undeclared identifier is reported only once for each function it appears in
> drivers/phy/qualcomm/phy-qcom-qmp-combo.c:2004:15: error: expected ';' before numeric constant
>  2004 |         Return 0;

Thanks I have fixed that up and pushed updated tree



-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_power_on':
drivers/phy/phy-can-transceiver.c:35:9: error: implicit declaration of function 'mux_state_select'; did you mean 'mux_control_select'? [-Werror=implicit-function-declaration]
   35 |   ret = mux_state_select(can_transceiver_phy->mux_state);
      |         ^~~~~~~~~~~~~~~~
      |         mux_control_select
drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_power_off':
drivers/phy/phy-can-transceiver.c:59:3: error: implicit declaration of function 'mux_state_deselect'; did you mean 'mux_control_deselect'? [-Werror=implicit-function-declaration]
   59 |   mux_state_deselect(can_transceiver_phy->mux_state);
      |   ^~~~~~~~~~~~~~~~~~
      |   mux_control_deselect
drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_probe':
drivers/phy/phy-can-transceiver.c:113:15: error: implicit declaration of function 'devm_mux_state_get'; did you mean 'devm_mux_control_get'? [-Werror=implicit-function-declaration]
  113 |   mux_state = devm_mux_state_get(dev, NULL);
      |               ^~~~~~~~~~~~~~~~~~
      |               devm_mux_control_get
drivers/phy/phy-can-transceiver.c:113:13: error: assignment to 'struct mux_state *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
  113 |   mux_state = devm_mux_state_get(dev, NULL);
      |             ^
cc1: all warnings being treated as errors

Caused by commit

  1e68cd3ff73e ("phy: phy-can-transceiver: Add support for setting mux")

I have used the phy-next tree from next-20211223 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 24-12-21, 14:03, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_power_on':
> drivers/phy/phy-can-transceiver.c:35:9: error: implicit declaration of function 'mux_state_select'; did you mean 'mux_control_select'? [-Werror=implicit-function-declaration]
>    35 |   ret = mux_state_select(can_transceiver_phy->mux_state);
>       |         ^~~~~~~~~~~~~~~~
>       |         mux_control_select
> drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_power_off':
> drivers/phy/phy-can-transceiver.c:59:3: error: implicit declaration of function 'mux_state_deselect'; did you mean 'mux_control_deselect'? [-Werror=implicit-function-declaration]
>    59 |   mux_state_deselect(can_transceiver_phy->mux_state);
>       |   ^~~~~~~~~~~~~~~~~~
>       |   mux_control_deselect
> drivers/phy/phy-can-transceiver.c: In function 'can_transceiver_phy_probe':
> drivers/phy/phy-can-transceiver.c:113:15: error: implicit declaration of function 'devm_mux_state_get'; did you mean 'devm_mux_control_get'? [-Werror=implicit-function-declaration]
>   113 |   mux_state = devm_mux_state_get(dev, NULL);
>       |               ^~~~~~~~~~~~~~~~~~
>       |               devm_mux_control_get
> drivers/phy/phy-can-transceiver.c:113:13: error: assignment to 'struct mux_state *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>   113 |   mux_state = devm_mux_state_get(dev, NULL);
>       |             ^
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   1e68cd3ff73e ("phy: phy-can-transceiver: Add support for setting mux")
> 
> I have used the phy-next tree from next-20211223 for today.

Thanks for letting me know. I have dropped the offending commit


-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[broonie]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

/tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c: In function 'imx8_pcie_phy_init':
/tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
   41 | #define IMX8MM_GPR_PCIE_REF_CLK_EXT FIELD_PREP(IMX8MM_GPR_PCIE_REF_CLK_SEL, 0x2)
      |                                     ^~~~~~~~~~
/tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:85:7: note: in expansion of macro 'IMX8MM_GPR_PCIE_REF_CLK_EXT'
   85 |       IMX8MM_GPR_PCIE_REF_CLK_EXT :
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  1aa97b002258a190d77 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")

I have used the phy-next tree from yesterday.

Re: linux-next: build failure after merge of the phy-next tree

[Marcel Ziswiler]

On Wed, 2021-12-15 at 13:49 +0000, broonie@kernel.org wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:

I admit I never tried building any of this as a module. I assume neither did Richard (now on CC) or anybody
else.

> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c: In function 'imx8_pcie_phy_init':
> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function
> 'FIELD_PREP' [-Werror=implicit-function-declaration]

Hm, that should come from include/linux/bitfield.h. However, that seems not explicitly included. Likely, in the
module case it no longer finds it. That's a problem.

>    41 | #define IMX8MM_GPR_PCIE_REF_CLK_EXT FIELD_PREP(IMX8MM_GPR_PCIE_REF_CLK_SEL, 0x2)
>       |                                     ^~~~~~~~~~
> /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:85:7: note: in expansion of macro
> 'IMX8MM_GPR_PCIE_REF_CLK_EXT'
>    85 |       IMX8MM_GPR_PCIE_REF_CLK_EXT :
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   1aa97b002258a190d77 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
> 
> I have used the phy-next tree from yesterday.

Yes, I also noticed it having been applied there now.

Anyway, let me cook up a fix for this. Thanks for reporting.

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 15-12-21, 14:14, Marcel Ziswiler wrote:
> On Wed, 2021-12-15 at 13:49 +0000, broonie@kernel.org wrote:
> > Hi all,
> > 
> > After merging the phy-next tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> 
> I admit I never tried building any of this as a module. I assume neither did Richard (now on CC) or anybody
> else.
> 
> > /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c: In function 'imx8_pcie_phy_init':
> > /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:41:37: error: implicit declaration of function
> > 'FIELD_PREP' [-Werror=implicit-function-declaration]
> 
> Hm, that should come from include/linux/bitfield.h. However, that seems not explicitly included. Likely, in the
> module case it no longer finds it. That's a problem.
> 
> >    41 | #define IMX8MM_GPR_PCIE_REF_CLK_EXT FIELD_PREP(IMX8MM_GPR_PCIE_REF_CLK_SEL, 0x2)
> >       |                                     ^~~~~~~~~~
> > /tmp/next/build/drivers/phy/freescale/phy-fsl-imx8m-pcie.c:85:7: note: in expansion of macro
> > 'IMX8MM_GPR_PCIE_REF_CLK_EXT'
> >    85 |       IMX8MM_GPR_PCIE_REF_CLK_EXT :
> >       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> > cc1: all warnings being treated as errors
> > 
> > Caused by commit
> > 
> >   1aa97b002258a190d77 ("phy: freescale: pcie: Initialize the imx8 pcie standalone phy driver")
> > 
> > I have used the phy-next tree from yesterday.
> 
> Yes, I also noticed it having been applied there now.
> 
> Anyway, let me cook up a fix for this. Thanks for reporting.

I have fixed it up: https://lore.kernel.org/all/20211215060834.921617-1-vkoul@kernel.org/

will push now

-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
  416 |   dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev)
      |                                                                 ^
      |                                                                 ;
  417 |   if (IS_ERR(dom->rstc))
      |   ~~                                                             

Caused by commit

  3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")

I have used the phy-next tree from next-20201116 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

Hello Stephen,

On 17-11-20, 13:40, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the phy-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
> 
> drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
> drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
>   416 |   dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev)
>       |                                                                 ^
>       |                                                                 ;
>   417 |   if (IS_ERR(dom->rstc))
>       |   ~~                                                             
> 
> Caused by commit
> 
>   3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
> 
> I have used the phy-next tree from next-20201116 for today.

I have reverted this commit

Thanks for the report

-- 
~Vinod

Re: linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

Hi Vinod,

On Tue, 17 Nov 2020 15:30:56 +0530 Vinod Koul <vkoul@kernel.org> wrote:
>
> On 17-11-20, 13:40, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the phy-next tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> > 
> > drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
> > drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
> >   416 |   dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev)
> >       |                                                                 ^
> >       |                                                                 ;
> >   417 |   if (IS_ERR(dom->rstc))
> >       |   ~~                                                             
> > 
> > Caused by commit
> > 
> >   3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
> > 
> > I have used the phy-next tree from next-20201116 for today.  
> 
> I have reverted this commit

Thanks, but forgot to push out?

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the phy-next tree

[Vinod Koul]

On 18-11-20, 13:56, Stephen Rothwell wrote:
> Hi Vinod,
> 
> On Tue, 17 Nov 2020 15:30:56 +0530 Vinod Koul <vkoul@kernel.org> wrote:
> >
> > On 17-11-20, 13:40, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > After merging the phy-next tree, today's linux-next build (arm
> > > multi_v7_defconfig) failed like this:
> > > 
> > > drivers/soc/amlogic/meson-ee-pwrc.c: In function 'meson_ee_pwrc_init_domain':
> > > drivers/soc/amlogic/meson-ee-pwrc.c:416:65: error: expected ';' before 'if'
> > >   416 |   dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev)
> > >       |                                                                 ^
> > >       |                                                                 ;
> > >   417 |   if (IS_ERR(dom->rstc))
> > >       |   ~~                                                             
> > > 
> > > Caused by commit
> > > 
> > >   3cc8e86721ad ("phy: amlogic: Replace devm_reset_control_array_get()")
> > > 
> > > I have used the phy-next tree from next-20201116 for today.  
> > 
> > I have reverted this commit
> 
> Thanks, but forgot to push out?

Precisely :( Fixed now, sorry for the trouble

-- 
~Vinod

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

Hi all,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

ERROR: "__arm_smccc_smc" [drivers/phy/marvell/phy-mvebu-cp110-comphy.ko] undefined!

Caused by commit

  ccee80654309 ("phy: mvebu-cp110-comphy: Add SMC call support")

I have used the phy-next tree from next-20190826 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build failure after merge of the phy-next tree

[Stephen Rothwell]

Hi Kishon,

After merging the phy-next tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field 'phy_tuning' specified in initializer
   .phy_tuning = rk3328_usb2phy_tuning,
   ^
drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning' undeclared here (not in a function)
   .phy_tuning = rk3328_usb2phy_tuning,
                 ^

Caused by commit

  ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")

I have used the phy-next tree from next-20170329 for today.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the phy-next tree

[Kishon Vijay Abraham I]

Hi,

On Thursday 30 March 2017 09:17 AM, Stephen Rothwell wrote:
> Hi Kishon,
> 
> After merging the phy-next tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/phy/phy-rockchip-inno-usb2.c:1148:3: error: unknown field 'phy_tuning' specified in initializer
>    .phy_tuning = rk3328_usb2phy_tuning,
>    ^
> drivers/phy/phy-rockchip-inno-usb2.c:1148:17: error: 'rk3328_usb2phy_tuning' undeclared here (not in a function)
>    .phy_tuning = rk3328_usb2phy_tuning,
>                  ^
> 
> Caused by commit
> 
>   ffa0c278e89c ("phy: rockchip-inno-usb2: add support of u2phy for rk3328")
> 
> I have used the phy-next tree from next-20170329 for today.

Thanks for reporting this. Will fix it in my tree.

-Kishon