* linux-next: Fixes tag needs some work in the mailbox tree
@ 2020-12-02 1:39 Stephen Rothwell
2020-12-02 2:43 ` Steven Rostedt
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2020-12-02 1:39 UTC (permalink / raw)
To: Jassi Brar
Cc: Sami Tolvanen, Steven Rostedt (VMware),
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 518 bytes --]
Hi all,
In commit
983df5f2699f ("samples/ftrace: Mark my_tramp[12]? global")
Fixes tag
Fixes: 9d907f1ae80b8 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
has these problem(s):
- Subject does not match target commit subject
Maybe you meant
Fixes: 9d907f1ae80b ("samples/ftrace: Fix asm function ELF annotations")
or
Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Fixes tag needs some work in the mailbox tree
2020-12-02 1:39 linux-next: Fixes tag needs some work in the mailbox tree Stephen Rothwell
@ 2020-12-02 2:43 ` Steven Rostedt
0 siblings, 0 replies; 3+ messages in thread
From: Steven Rostedt @ 2020-12-02 2:43 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Jassi Brar, Sami Tolvanen, Linux Kernel Mailing List,
Linux Next Mailing List
On Wed, 2 Dec 2020 12:39:39 +1100
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi all,
>
> In commit
>
> 983df5f2699f ("samples/ftrace: Mark my_tramp[12]? global")
>
> Fixes tag
>
> Fixes: 9d907f1ae80b8 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
>
> has these problem(s):
>
> - Subject does not match target commit subject
>
> Maybe you meant
>
> Fixes: 9d907f1ae80b ("samples/ftrace: Fix asm function ELF annotations")
>
> or
>
> Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
>
Bah! Too late, it already made it into Linus's tree.
I goofed. I was looking at both commits to see which one to apply it
for, and ended up mixing the two.
It was meant for:
Fixes: ae0cc3b7e7f5 ("ftrace/samples: Add a sample module that implements modify_ftrace_direct()")
I'll have to add a script to my tests that makes sure the Fixes tag
matches the description.
-- Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
* linux-next: Fixes tag needs some work in the mailbox tree
@ 2021-10-17 21:11 Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2021-10-17 21:11 UTC (permalink / raw)
To: Jassi Brar; +Cc: Fei Shao, Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 694 bytes --]
Hi all,
In commit
0ff9a987584f ("mailbox: mtk-cmdq: Fix local clock ID usage")
Fixes tag
Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
In commit
a657b4ba4fd9 ("mailbox: mtk-cmdq: Validate alias_id on probe")
Fixes tag
Fixes: 85dfdbfc13ea ("mailbox: cmdq: add multi-gce clocks support for
has these problem(s):
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
Please do not split Fixes tags over more than one line.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-17 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02 1:39 linux-next: Fixes tag needs some work in the mailbox tree Stephen Rothwell
2020-12-02 2:43 ` Steven Rostedt
2021-10-17 21:11 Stephen Rothwell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.