* [PATCH for-rc] RDMA/efa: Use the correct current and new states in modify QP
@ 2020-12-01 9:17 Gal Pressman
2020-12-02 0:54 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Gal Pressman @ 2020-12-01 9:17 UTC (permalink / raw)
To: Jason Gunthorpe, Doug Ledford
Cc: linux-rdma, Gal Pressman, Firas JahJah, Yossi Leybovich
The local variables cur_state and new_state hold the state that should
be used for the modify QP operation instead of the ones in the
ib_qp_attr struct.
Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
Reviewed-by: Firas JahJah <firasj@amazon.com>
Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
Signed-off-by: Gal Pressman <galpress@amazon.com>
---
drivers/infiniband/hw/efa/efa_verbs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/efa/efa_verbs.c b/drivers/infiniband/hw/efa/efa_verbs.c
index 191e0843f090..4e940fc50bba 100644
--- a/drivers/infiniband/hw/efa/efa_verbs.c
+++ b/drivers/infiniband/hw/efa/efa_verbs.c
@@ -940,8 +940,8 @@ int efa_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,
1);
EFA_SET(¶ms.modify_mask,
EFA_ADMIN_MODIFY_QP_CMD_CUR_QP_STATE, 1);
- params.cur_qp_state = qp_attr->cur_qp_state;
- params.qp_state = qp_attr->qp_state;
+ params.cur_qp_state = cur_state;
+ params.qp_state = new_state;
}
if (qp_attr_mask & IB_QP_EN_SQD_ASYNC_NOTIFY) {
base-commit: 17475e104dcb74217c282781817f8f52b46130d3
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-rc] RDMA/efa: Use the correct current and new states in modify QP
2020-12-01 9:17 [PATCH for-rc] RDMA/efa: Use the correct current and new states in modify QP Gal Pressman
@ 2020-12-02 0:54 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2020-12-02 0:54 UTC (permalink / raw)
To: Gal Pressman; +Cc: Doug Ledford, linux-rdma, Firas JahJah, Yossi Leybovich
On Tue, Dec 01, 2020 at 11:17:24AM +0200, Gal Pressman wrote:
> The local variables cur_state and new_state hold the state that should
> be used for the modify QP operation instead of the ones in the
> ib_qp_attr struct.
>
> Fixes: 40909f664d27 ("RDMA/efa: Add EFA verbs implementation")
> Reviewed-by: Firas JahJah <firasj@amazon.com>
> Reviewed-by: Yossi Leybovich <sleybo@amazon.com>
> Signed-off-by: Gal Pressman <galpress@amazon.com>
> ---
> drivers/infiniband/hw/efa/efa_verbs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-02 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 9:17 [PATCH for-rc] RDMA/efa: Use the correct current and new states in modify QP Gal Pressman
2020-12-02 0:54 ` Jason Gunthorpe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.