All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	jim.cromie@gmail.com, "Heiner Kallweit" <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Wed, 2 Dec 2020 09:18:52 -0800	[thread overview]
Message-ID: <20201202091852.69a02069@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <dleftj8sageb97.fsf%l.stelmach@samsung.com>

On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote:
> >> +	status = netif_rx(skb);  
> >
> > If I'm reading things right this is in process context, so netif_rx_ni()
> >  
> 
> Is it? The stack looks as follows
> 
>     ax88796c_skb_return()
>     ax88796c_rx_fixup()
>     ax88796c_receive()
>     ax88796c_process_isr()
>     ax88796c_work()
> 
> and ax88796c_work() is a scheduled in the system_wq.

Are you asking if work queue gets run in process context? It does.

> >> +	if (status != NET_RX_SUCCESS)
> >> +		netif_info(ax_local, rx_err, ndev,
> >> +			   "netif_rx status %d\n", status);  
> >
> > Again, it's inadvisable to put per packet prints without any rate
> > limiting in the data path.  
> 
> Even if limmited by the msglvl flag, which is off by default?

I'd err on the side of caution, but up to you.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	jim.cromie@gmail.com, netdev@vger.kernel.org,
	"Bartłomiej Żolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, "Kukjin Kim" <kgene@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org,
	"Heiner Kallweit" <hkallweit1@gmail.com>
Subject: Re: [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Wed, 2 Dec 2020 09:18:52 -0800	[thread overview]
Message-ID: <20201202091852.69a02069@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com> (raw)
In-Reply-To: <dleftj8sageb97.fsf%l.stelmach@samsung.com>

On Wed, 02 Dec 2020 11:46:28 +0100 Lukasz Stelmach wrote:
> >> +	status = netif_rx(skb);  
> >
> > If I'm reading things right this is in process context, so netif_rx_ni()
> >  
> 
> Is it? The stack looks as follows
> 
>     ax88796c_skb_return()
>     ax88796c_rx_fixup()
>     ax88796c_receive()
>     ax88796c_process_isr()
>     ax88796c_work()
> 
> and ax88796c_work() is a scheduled in the system_wq.

Are you asking if work queue gets run in process context? It does.

> >> +	if (status != NET_RX_SUCCESS)
> >> +		netif_info(ax_local, rx_err, ndev,
> >> +			   "netif_rx status %d\n", status);  
> >
> > Again, it's inadvisable to put per packet prints without any rate
> > limiting in the data path.  
> 
> Even if limmited by the msglvl flag, which is off by default?

I'd err on the side of caution, but up to you.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-12-02 17:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201124120336eucas1p20710fdff8434428ea0f011b02249b8a8@eucas1p2.samsung.com>
2020-11-24 12:03 ` [PATCH v7 0/3] AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-11-24 12:03   ` Łukasz Stelmach
     [not found]   ` <CGME20201124120336eucas1p2df4e6cc5f456a48f19a5c0e8ea91c662@eucas1p2.samsung.com>
2020-11-24 12:03     ` [PATCH v7 1/3] dt-bindings: vendor-prefixes: Add asix prefix Łukasz Stelmach
2020-11-24 12:03       ` Łukasz Stelmach
     [not found]   ` <CGME20201124120336eucas1p2982f8a4e16a9357e1354cde77333f695@eucas1p2.samsung.com>
2020-11-24 12:03     ` [PATCH v7 2/3] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter Łukasz Stelmach
2020-11-24 12:03       ` Łukasz Stelmach
     [not found]   ` <CGME20201124120337eucas1p268c7e3147ea36e62d40d252278c5dcb7@eucas1p2.samsung.com>
2020-11-24 12:03     ` [PATCH v7 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver Łukasz Stelmach
2020-11-24 12:03       ` Łukasz Stelmach
2020-11-24 12:17       ` Krzysztof Kozlowski
2020-11-24 12:17         ` Krzysztof Kozlowski
     [not found]         ` <CGME20201124143011eucas1p182d53a872283904341ed4038d457d817@eucas1p1.samsung.com>
2020-11-24 14:29           ` Lukasz Stelmach
2020-11-24 14:29             ` Lukasz Stelmach
2020-11-24 22:33       ` Andrew Lunn
2020-11-24 22:33         ` Andrew Lunn
2020-11-25 21:26       ` Jakub Kicinski
2020-11-25 21:26         ` Jakub Kicinski
     [not found]         ` <CGME20201202104645eucas1p25335c0b07b106f932006f2a5bce88b6e@eucas1p2.samsung.com>
2020-12-02 10:46           ` Lukasz Stelmach
2020-12-02 10:46             ` Lukasz Stelmach
2020-12-02 17:18             ` Jakub Kicinski [this message]
2020-12-02 17:18               ` Jakub Kicinski
     [not found]               ` <CGME20201202200727eucas1p18311ed19904e8a0c7b8c28cde87f155b@eucas1p1.samsung.com>
2020-12-02 20:07                 ` Lukasz Stelmach
2020-12-02 20:07                   ` Lukasz Stelmach
2020-11-25 21:27       ` Jakub Kicinski
2020-11-25 21:27         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202091852.69a02069@kicinski-fedora-pc1c0hjn.DHCP.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=b.zolnierkie@samsung.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=jim.cromie@gmail.com \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=l.stelmach@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=m.szyprowski@samsung.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.