All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicola Mazzucato <nicola.mazzucato@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, sudeep.holla@arm.com,
	rjw@rjwysocki.net, vireshk@kernel.org, robh+dt@kernel.org,
	sboyd@kernel.org, nm@ti.com
Cc: daniel.lezcano@linaro.org, morten.rasmussen@arm.com,
	chris.redpath@arm.com, nicola.mazzucato@arm.com
Subject: [PATCH v4 2/4] opp/of: Allow empty opp-table with opp-shared
Date: Wed,  2 Dec 2020 17:23:54 +0000	[thread overview]
Message-ID: <20201202172356.10508-3-nicola.mazzucato@arm.com> (raw)
In-Reply-To: <20201202172356.10508-1-nicola.mazzucato@arm.com>

The opp binding now allows to have an empty opp table and shared-opp to
still describe that devices share v/f lines.

When initialising an empty opp table, allow such case by:
- treating such conditions with warnings in place of errors
- don't fail on empty table

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
---
 drivers/opp/of.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index ffd937af8089..03cb387236c4 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -170,7 +170,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
 	/* Traversing the first OPP node is all we need */
 	np = of_get_next_available_child(opp_np, NULL);
 	if (!np) {
-		dev_err(dev, "Empty OPP table\n");
+		dev_warn(dev, "Empty OPP table\n");
+
 		return;
 	}
 
@@ -378,7 +379,9 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
 	struct icc_path **paths;
 
 	ret = _bandwidth_supported(dev, opp_table);
-	if (ret <= 0)
+	if (ret == -EINVAL)
+		return 0; /* Empty OPP table is a valid corner-case, let's not fail */
+	else if (ret <= 0)
 		return ret;
 
 	ret = 0;
-- 
2.27.0


WARNING: multiple messages have this Message-ID (diff)
From: Nicola Mazzucato <nicola.mazzucato@arm.com>
To: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, sudeep.holla@arm.com,
	rjw@rjwysocki.net, vireshk@kernel.org, robh+dt@kernel.org,
	sboyd@kernel.org, nm@ti.com
Cc: chris.redpath@arm.com, daniel.lezcano@linaro.org,
	morten.rasmussen@arm.com, nicola.mazzucato@arm.com
Subject: [PATCH v4 2/4] opp/of: Allow empty opp-table with opp-shared
Date: Wed,  2 Dec 2020 17:23:54 +0000	[thread overview]
Message-ID: <20201202172356.10508-3-nicola.mazzucato@arm.com> (raw)
In-Reply-To: <20201202172356.10508-1-nicola.mazzucato@arm.com>

The opp binding now allows to have an empty opp table and shared-opp to
still describe that devices share v/f lines.

When initialising an empty opp table, allow such case by:
- treating such conditions with warnings in place of errors
- don't fail on empty table

Signed-off-by: Nicola Mazzucato <nicola.mazzucato@arm.com>
---
 drivers/opp/of.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index ffd937af8089..03cb387236c4 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -170,7 +170,8 @@ static void _opp_table_alloc_required_tables(struct opp_table *opp_table,
 	/* Traversing the first OPP node is all we need */
 	np = of_get_next_available_child(opp_np, NULL);
 	if (!np) {
-		dev_err(dev, "Empty OPP table\n");
+		dev_warn(dev, "Empty OPP table\n");
+
 		return;
 	}
 
@@ -378,7 +379,9 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
 	struct icc_path **paths;
 
 	ret = _bandwidth_supported(dev, opp_table);
-	if (ret <= 0)
+	if (ret == -EINVAL)
+		return 0; /* Empty OPP table is a valid corner-case, let's not fail */
+	else if (ret <= 0)
 		return ret;
 
 	ret = 0;
-- 
2.27.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-02 17:23 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 17:23 [PATCH v4 0/4] CPUFreq: Add support for opp-sharing cpus Nicola Mazzucato
2020-12-02 17:23 ` Nicola Mazzucato
2020-12-02 17:23 ` [PATCH v4 1/4] dt-bindings/opp: Update documentation for opp-shared Nicola Mazzucato
2020-12-02 17:23   ` Nicola Mazzucato
2020-12-08  4:29   ` Viresh Kumar
2020-12-08  4:29     ` Viresh Kumar
2020-12-08  7:15     ` Nicola Mazzucato
2020-12-08  7:15       ` Nicola Mazzucato
2020-12-02 17:23 ` Nicola Mazzucato [this message]
2020-12-02 17:23   ` [PATCH v4 2/4] opp/of: Allow empty opp-table with opp-shared Nicola Mazzucato
2020-12-02 17:23 ` [PATCH v4 3/4] scmi-cpufreq: get opp_shared_cpus from opp-v2 for EM Nicola Mazzucato
2020-12-02 17:23   ` Nicola Mazzucato
2020-12-08  5:50   ` Viresh Kumar
2020-12-08  5:50     ` Viresh Kumar
2020-12-08  7:22     ` Nicola Mazzucato
2020-12-08  7:22       ` Nicola Mazzucato
2020-12-08  7:26       ` Viresh Kumar
2020-12-08  7:26         ` Viresh Kumar
2020-12-08 10:58         ` Nicola Mazzucato
2020-12-08 10:58           ` Nicola Mazzucato
2020-12-08 11:01           ` Viresh Kumar
2020-12-08 11:01             ` Viresh Kumar
2020-12-08 11:21             ` Sudeep Holla
2020-12-08 11:21               ` Sudeep Holla
2020-12-08 11:20         ` Sudeep Holla
2020-12-08 11:20           ` Sudeep Holla
2020-12-08 11:34           ` Lukasz Luba
2020-12-08 11:34             ` Lukasz Luba
2020-12-08 12:22             ` Sudeep Holla
2020-12-08 12:22               ` Sudeep Holla
2020-12-08 13:17               ` Nicola Mazzucato
2020-12-08 13:17                 ` Nicola Mazzucato
2020-12-09  5:45           ` Viresh Kumar
2020-12-09  5:45             ` Viresh Kumar
2020-12-09  9:20             ` Nicola Mazzucato
2020-12-09  9:20               ` Nicola Mazzucato
2020-12-09  9:41             ` Sudeep Holla
2020-12-09  9:41               ` Sudeep Holla
2020-12-02 17:23 ` [PATCH v4 4/4] cpufreq: blacklist Arm Vexpress platforms in cpufreq-dt-platdev Nicola Mazzucato
2020-12-02 17:23   ` Nicola Mazzucato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201202172356.10508-3-nicola.mazzucato@arm.com \
    --to=nicola.mazzucato@arm.com \
    --cc=chris.redpath@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=morten.rasmussen@arm.com \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.