From: Stephen Boyd <swboyd@chromium.org>
To: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, Simon Glass <sjg@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Alexandru M Stan <amstan@chromium.org>
Subject: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment
Date: Wed, 2 Dec 2020 17:16:49 -0800 [thread overview]
Message-ID: <20201203011649.1405292-3-swboyd@chromium.org> (raw)
In-Reply-To: <20201203011649.1405292-1-swboyd@chromium.org>
This is already handed by default in spi_setup() if the bits_per_word is
0, so just drop it to shave off a line.
Cc: Simon Glass <sjg@chromium.org>
Cc: Gwendal Grignou <gwendal@chromium.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
drivers/platform/chrome/cros_ec_spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
index f9df218fc2bb..14c4046fa04d 100644
--- a/drivers/platform/chrome/cros_ec_spi.c
+++ b/drivers/platform/chrome/cros_ec_spi.c
@@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
struct cros_ec_spi *ec_spi;
int err;
- spi->bits_per_word = 8;
spi->rt = true;
err = spi_setup(spi);
if (err < 0)
--
https://chromeos.dev
next prev parent reply other threads:[~2020-12-03 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 1:16 [PATCH 0/2] cros_ec_spi: Work better with CS GPIO descriptors Stephen Boyd
2020-12-03 1:16 ` [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode Stephen Boyd
2020-12-03 1:17 ` Doug Anderson
2020-12-04 9:15 ` Enric Balletbo i Serra
2020-12-03 1:16 ` Stephen Boyd [this message]
2020-12-03 1:18 ` [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment Doug Anderson
2020-12-04 9:15 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203011649.1405292-3-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=dianders@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sjg@chromium.org \
--subject='Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.