All of lore.kernel.org
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Stephen Boyd <swboyd@chromium.org>, Benson Leung <bleung@chromium.org>
Cc: linux-kernel@vger.kernel.org, Simon Glass <sjg@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Douglas Anderson <dianders@chromium.org>,
	Alexandru M Stan <amstan@chromium.org>
Subject: Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment
Date: Fri, 4 Dec 2020 10:15:48 +0100	[thread overview]
Message-ID: <e195f8fa-b5f0-d4bd-2d75-adbd702bc95d@collabora.com> (raw)
In-Reply-To: <20201203011649.1405292-3-swboyd@chromium.org>

Hi Stephen,

Thank you for your patch.

On 3/12/20 2:16, Stephen Boyd wrote:
> This is already handed by default in spi_setup() if the bits_per_word is
> 0, so just drop it to shave off a line.
> 
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Gwendal Grignou <gwendal@chromium.org>
> Cc: Douglas Anderson <dianders@chromium.org>
> Cc: Alexandru M Stan <amstan@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  drivers/platform/chrome/cros_ec_spi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index f9df218fc2bb..14c4046fa04d 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -741,7 +741,6 @@ static int cros_ec_spi_probe(struct spi_device *spi)
>  	struct cros_ec_spi *ec_spi;
>  	int err;
>  
> -	spi->bits_per_word = 8;
>  	spi->rt = true;
>  	err = spi_setup(spi);
>  	if (err < 0)
> 

      parent reply	other threads:[~2020-12-04  9:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03  1:16 [PATCH 0/2] cros_ec_spi: Work better with CS GPIO descriptors Stephen Boyd
2020-12-03  1:16 ` [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode Stephen Boyd
2020-12-03  1:17   ` Doug Anderson
2020-12-04  9:15   ` Enric Balletbo i Serra
2020-12-03  1:16 ` [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment Stephen Boyd
2020-12-03  1:18   ` Doug Anderson
2020-12-04  9:15   ` Enric Balletbo i Serra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e195f8fa-b5f0-d4bd-2d75-adbd702bc95d@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=amstan@chromium.org \
    --cc=bleung@chromium.org \
    --cc=dianders@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjg@chromium.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.