* [PATCH 0/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
@ 2020-12-03 3:37 ` zhouliangya
0 siblings, 0 replies; 8+ messages in thread
From: zhouliangya @ 2020-12-03 3:37 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, lzhou
From: lzhou <zhouliangya@126.com>
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
@ 2020-12-03 3:37 ` zhouliangya
0 siblings, 0 replies; 8+ messages in thread
From: zhouliangya @ 2020-12-03 3:37 UTC (permalink / raw)
To: ath10k; +Cc: lzhou, linux-wireless
From: lzhou <zhouliangya@126.com>
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
2020-12-03 3:37 ` zhouliangya
@ 2020-12-03 3:37 ` zhouliangya
-1 siblings, 0 replies; 8+ messages in thread
From: zhouliangya @ 2020-12-03 3:37 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, lzhou
From: lzhou <zhouliangya@126.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 8ab262931dce..2941fbb6a412 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3309,7 +3309,7 @@ int ath10k_pci_wait_for_target_init(struct ath10k *ar)
/* Fix potential race by repeating CORE_BASE writes */
ath10k_pci_enable_legacy_irq(ar);
- mdelay(10);
+ schedule_timeout_interruptible(msecs_to_jiffies(10));
} while (time_before(jiffies, timeout));
ath10k_pci_disable_and_clear_legacy_irq(ar);
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 1/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
@ 2020-12-03 3:37 ` zhouliangya
0 siblings, 0 replies; 8+ messages in thread
From: zhouliangya @ 2020-12-03 3:37 UTC (permalink / raw)
To: ath10k; +Cc: lzhou, linux-wireless
From: lzhou <zhouliangya@126.com>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 8ab262931dce..2941fbb6a412 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -3309,7 +3309,7 @@ int ath10k_pci_wait_for_target_init(struct ath10k *ar)
/* Fix potential race by repeating CORE_BASE writes */
ath10k_pci_enable_legacy_irq(ar);
- mdelay(10);
+ schedule_timeout_interruptible(msecs_to_jiffies(10));
} while (time_before(jiffies, timeout));
ath10k_pci_disable_and_clear_legacy_irq(ar);
--
2.17.1
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
2020-12-03 3:37 ` zhouliangya
(?)
@ 2020-12-07 15:56 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-12-07 15:56 UTC (permalink / raw)
To: zhouliangya; +Cc: linux-wireless, ath10k
zhouliangya@126.com wrote:
> From: lzhou <zhouliangya@126.com>
The subject and commit log is badly formatted, see patchwork link below.
But how is schedule_timeout_interruptible() better than msleep()?
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201203033729.382088-2-zhouliangya@126.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
2020-12-03 3:37 ` zhouliangya
(?)
(?)
@ 2020-12-07 15:56 ` Kalle Valo
-1 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2020-12-07 15:56 UTC (permalink / raw)
To: zhouliangya; +Cc: ath10k, linux-wireless, lzhou
zhouliangya@126.com wrote:
> From: lzhou <zhouliangya@126.com>
The subject and commit log is badly formatted, see patchwork link below.
But how is schedule_timeout_interruptible() better than msleep()?
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20201203033729.382088-2-zhouliangya@126.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 0/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> ---
@ 2020-12-03 3:36 ` zhouliangya
0 siblings, 0 replies; 8+ messages in thread
From: zhouliangya @ 2020-12-03 3:36 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, lzhou
From: lzhou <zhouliangya@126.com>
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-12-07 15:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-03 3:37 [PATCH 0/1] ath10k_pci_wait_for_target_init() should relax cpu for other task instead of calling medelay() so that cpu can run other tasks. Signed-off-by: lzhou <lzhou@sonicwall.com> --- zhouliangya
2020-12-03 3:37 ` zhouliangya
2020-12-03 3:37 ` [PATCH 1/1] " zhouliangya
2020-12-03 3:37 ` zhouliangya
2020-12-07 15:56 ` Kalle Valo
2020-12-07 15:56 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2020-12-03 3:36 [PATCH 0/1] " zhouliangya
2020-12-03 3:36 ` zhouliangya
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.