* [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical
purpose. For in-tree drivers, the kernel version matters.
The drivers have received lots of changes, without the module version
(or the underlying DRV_VERSION macro) ever changed, since the code
landed in the kernel tree. So, it doesn't seem to have any practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/accessibility/speakup/main.c | 1 -
drivers/accessibility/speakup/speakup_acntpc.c | 1 -
drivers/accessibility/speakup/speakup_acntsa.c | 1 -
drivers/accessibility/speakup/speakup_apollo.c | 2 --
drivers/accessibility/speakup/speakup_audptr.c | 2 --
drivers/accessibility/speakup/speakup_bns.c | 2 --
drivers/accessibility/speakup/speakup_decext.c | 1 -
drivers/accessibility/speakup/speakup_decpc.c | 1 -
drivers/accessibility/speakup/speakup_dectlk.c | 1 -
drivers/accessibility/speakup/speakup_dtlk.c | 2 --
drivers/accessibility/speakup/speakup_dummy.c | 2 --
drivers/accessibility/speakup/speakup_keypc.c | 1 -
drivers/accessibility/speakup/speakup_ltlk.c | 2 --
drivers/accessibility/speakup/speakup_soft.c | 1 -
drivers/accessibility/speakup/speakup_spkout.c | 2 --
drivers/accessibility/speakup/speakup_txprt.c | 2 --
16 files changed, 24 deletions(-)
diff --git a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
index 48019660a096..d512f4775ae1 100644
--- a/drivers/accessibility/speakup/main.c
+++ b/drivers/accessibility/speakup/main.c
@@ -46,7 +46,6 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("Daniel Drake <dsd@gentoo.org>");
MODULE_DESCRIPTION("Speakup console speech");
MODULE_LICENSE("GPL");
-MODULE_VERSION(SPEAKUP_VERSION);
char *synth_name;
module_param_named(synth, synth_name, charp, 0444);
diff --git a/drivers/accessibility/speakup/speakup_acntpc.c b/drivers/accessibility/speakup/speakup_acntpc.c
index c94328a5bd4a..4d9ebf8b3460 100644
--- a/drivers/accessibility/speakup/speakup_acntpc.c
+++ b/drivers/accessibility/speakup/speakup_acntpc.c
@@ -315,5 +315,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Accent PC synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_acntsa.c b/drivers/accessibility/speakup/speakup_acntsa.c
index 3a863dc61286..1dc2fd99043f 100644
--- a/drivers/accessibility/speakup/speakup_acntsa.c
+++ b/drivers/accessibility/speakup/speakup_acntsa.c
@@ -140,5 +140,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Accent SA synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_apollo.c b/drivers/accessibility/speakup/speakup_apollo.c
index 0877b4044c28..ce215fb3f7ff 100644
--- a/drivers/accessibility/speakup/speakup_apollo.c
+++ b/drivers/accessibility/speakup/speakup_apollo.c
@@ -204,5 +204,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Apollo II synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_audptr.c b/drivers/accessibility/speakup/speakup_audptr.c
index e6a6a9665d8f..e4733215b5a9 100644
--- a/drivers/accessibility/speakup/speakup_audptr.c
+++ b/drivers/accessibility/speakup/speakup_audptr.c
@@ -167,5 +167,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Audapter synthesizer");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_bns.c b/drivers/accessibility/speakup/speakup_bns.c
index 76dfa3f7c058..6783b007c020 100644
--- a/drivers/accessibility/speakup/speakup_bns.c
+++ b/drivers/accessibility/speakup/speakup_bns.c
@@ -124,5 +124,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Braille 'n Speak synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_decext.c b/drivers/accessibility/speakup/speakup_decext.c
index 7408eb29cf38..efe7ccbfbf05 100644
--- a/drivers/accessibility/speakup/speakup_decext.c
+++ b/drivers/accessibility/speakup/speakup_decext.c
@@ -236,5 +236,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk External synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_decpc.c b/drivers/accessibility/speakup/speakup_decpc.c
index 96f24c848cc5..60da9ec9949c 100644
--- a/drivers/accessibility/speakup/speakup_decpc.c
+++ b/drivers/accessibility/speakup/speakup_decpc.c
@@ -492,4 +492,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_dectlk.c b/drivers/accessibility/speakup/speakup_dectlk.c
index 780214b5ca16..dc5e91c7a2c9 100644
--- a/drivers/accessibility/speakup/speakup_dectlk.c
+++ b/drivers/accessibility/speakup/speakup_dectlk.c
@@ -307,5 +307,4 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DECtalk Express synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_dtlk.c b/drivers/accessibility/speakup/speakup_dtlk.c
index dbebed0eeeec..265ab003627e 100644
--- a/drivers/accessibility/speakup/speakup_dtlk.c
+++ b/drivers/accessibility/speakup/speakup_dtlk.c
@@ -386,5 +386,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DoubleTalk PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_dummy.c b/drivers/accessibility/speakup/speakup_dummy.c
index e393438af81b..f3b38dc04499 100644
--- a/drivers/accessibility/speakup/speakup_dummy.c
+++ b/drivers/accessibility/speakup/speakup_dummy.c
@@ -130,5 +130,3 @@ module_spk_synth(synth_dummy);
MODULE_AUTHOR("Samuel Thibault <samuel.thibault@ens-lyon.org>");
MODULE_DESCRIPTION("Speakup support for text console");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_keypc.c b/drivers/accessibility/speakup/speakup_keypc.c
index 414827e888fc..8110ddea8ef3 100644
--- a/drivers/accessibility/speakup/speakup_keypc.c
+++ b/drivers/accessibility/speakup/speakup_keypc.c
@@ -314,5 +314,4 @@ module_spk_synth(synth_keypc);
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Keynote Gold PC synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_ltlk.c b/drivers/accessibility/speakup/speakup_ltlk.c
index 3c59519a871f..d506380d7235 100644
--- a/drivers/accessibility/speakup/speakup_ltlk.c
+++ b/drivers/accessibility/speakup/speakup_ltlk.c
@@ -171,5 +171,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for DoubleTalk LT/LiteTalk synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c
index 9a7029539f35..7c97444744ea 100644
--- a/drivers/accessibility/speakup/speakup_soft.c
+++ b/drivers/accessibility/speakup/speakup_soft.c
@@ -427,4 +427,3 @@ module_spk_synth(synth_soft);
MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_DESCRIPTION("Speakup userspace software synthesizer support");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
diff --git a/drivers/accessibility/speakup/speakup_spkout.c b/drivers/accessibility/speakup/speakup_spkout.c
index 6e933bf1de2e..dbaec515d94e 100644
--- a/drivers/accessibility/speakup/speakup_spkout.c
+++ b/drivers/accessibility/speakup/speakup_spkout.c
@@ -135,5 +135,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Speak Out synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
diff --git a/drivers/accessibility/speakup/speakup_txprt.c b/drivers/accessibility/speakup/speakup_txprt.c
index a7326f226a5e..687efe2f02e6 100644
--- a/drivers/accessibility/speakup/speakup_txprt.c
+++ b/drivers/accessibility/speakup/speakup_txprt.c
@@ -123,5 +123,3 @@ MODULE_AUTHOR("Kirk Reiser <kirk@braille.uwo.ca>");
MODULE_AUTHOR("David Borowski");
MODULE_DESCRIPTION("Speakup support for Transport synthesizers");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
-
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code has received lots
of changes, w/o the versions being actively maintained, so it doesn't seem
to have much practical meaning.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/gasket/apex_driver.c | 1 -
drivers/staging/gasket/gasket_core.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index f12f81c8dd2f..66ae99bebfd8 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -718,7 +718,6 @@ static void apex_exit(void)
gasket_unregister_device(&apex_desc);
}
MODULE_DESCRIPTION("Google Apex driver");
-MODULE_VERSION(APEX_DRIVER_VERSION);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("John Joseph <jnjoseph@google.com>");
MODULE_DEVICE_TABLE(pci, apex_pci_ids);
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index 28dab302183b..763d5ea45e68 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1809,7 +1809,6 @@ static int __init gasket_init(void)
}
MODULE_DESCRIPTION("Google Gasket driver framework");
-MODULE_VERSION(GASKET_FRAMEWORK_VERSION);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Rob Springer <rspringer@google.com>");
module_init(gasket_init);
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 02/11] drivers: staging: gasket: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code has received lots
of changes, w/o the versions being actively maintained, so it doesn't seem
to have much practical meaning.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/gasket/apex_driver.c | 1 -
drivers/staging/gasket/gasket_core.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c b/drivers/staging/gasket/apex_driver.c
index f12f81c8dd2f..66ae99bebfd8 100644
--- a/drivers/staging/gasket/apex_driver.c
+++ b/drivers/staging/gasket/apex_driver.c
@@ -718,7 +718,6 @@ static void apex_exit(void)
gasket_unregister_device(&apex_desc);
}
MODULE_DESCRIPTION("Google Apex driver");
-MODULE_VERSION(APEX_DRIVER_VERSION);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("John Joseph <jnjoseph@google.com>");
MODULE_DEVICE_TABLE(pci, apex_pci_ids);
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index 28dab302183b..763d5ea45e68 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1809,7 +1809,6 @@ static int __init gasket_init(void)
}
MODULE_DESCRIPTION("Google Gasket driver framework");
-MODULE_VERSION(GASKET_FRAMEWORK_VERSION);
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("Rob Springer <rspringer@google.com>");
module_init(gasket_init);
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-kernel drivers, the kernel version matters. And the code has received
lots of changes, without the version ever been touched (remained constant
since landing in the mainline tree), so it doesn't seem to have any practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/gdm724x/gdm_lte.h | 1 -
drivers/staging/gdm724x/gdm_usb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
index f2143a6e0e99..bf6478ab05dd 100644
--- a/drivers/staging/gdm724x/gdm_lte.h
+++ b/drivers/staging/gdm724x/gdm_lte.h
@@ -11,7 +11,6 @@
#define MAX_NIC_TYPE 4
#define MAX_RX_SUBMIT_COUNT 3
-#define DRIVER_VERSION "3.7.17.0"
enum TX_ERROR_CODE {
TX_NO_ERROR = 0,
diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index dc4da66c3695..aa6f08396396 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -1003,6 +1003,5 @@ static void __exit gdm_usb_lte_exit(void)
module_init(gdm_usb_lte_init);
module_exit(gdm_usb_lte_exit);
-MODULE_VERSION(DRIVER_VERSION);
MODULE_DESCRIPTION("GCT LTE USB Device Driver");
MODULE_LICENSE("GPL");
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 03/11] drivers: staging: gdm724x: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-kernel drivers, the kernel version matters. And the code has received
lots of changes, without the version ever been touched (remained constant
since landing in the mainline tree), so it doesn't seem to have any practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/gdm724x/gdm_lte.h | 1 -
drivers/staging/gdm724x/gdm_usb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.h b/drivers/staging/gdm724x/gdm_lte.h
index f2143a6e0e99..bf6478ab05dd 100644
--- a/drivers/staging/gdm724x/gdm_lte.h
+++ b/drivers/staging/gdm724x/gdm_lte.h
@@ -11,7 +11,6 @@
#define MAX_NIC_TYPE 4
#define MAX_RX_SUBMIT_COUNT 3
-#define DRIVER_VERSION "3.7.17.0"
enum TX_ERROR_CODE {
TX_NO_ERROR = 0,
diff --git a/drivers/staging/gdm724x/gdm_usb.c b/drivers/staging/gdm724x/gdm_usb.c
index dc4da66c3695..aa6f08396396 100644
--- a/drivers/staging/gdm724x/gdm_usb.c
+++ b/drivers/staging/gdm724x/gdm_usb.c
@@ -1003,6 +1003,5 @@ static void __exit gdm_usb_lte_exit(void)
module_init(gdm_usb_lte_init);
module_exit(gdm_usb_lte_exit);
-MODULE_VERSION(DRIVER_VERSION);
MODULE_DESCRIPTION("GCT LTE USB Device Driver");
MODULE_LICENSE("GPL");
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
For in-kernel drivers, the kernel version matters. The driver received lots
of changes, but version number has remained the same since it's introducing
into mainline, seven years ago. So, it doesn't seem to have much practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/goldfish/goldfish_audio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index 0c65a0121dde..4a23f40e549a 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -24,7 +24,6 @@
MODULE_AUTHOR("Google, Inc.");
MODULE_DESCRIPTION("Android QEMU Audio Driver");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
struct goldfish_audio {
char __iomem *reg_base;
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
For in-kernel drivers, the kernel version matters. The driver received lots
of changes, but version number has remained the same since it's introducing
into mainline, seven years ago. So, it doesn't seem to have much practical
meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/goldfish/goldfish_audio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index 0c65a0121dde..4a23f40e549a 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -24,7 +24,6 @@
MODULE_AUTHOR("Google, Inc.");
MODULE_DESCRIPTION("Android QEMU Audio Driver");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
struct goldfish_audio {
char __iomem *reg_base;
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-04 15:47 ` Greg KH
-1 siblings, 0 replies; 28+ messages in thread
From: Greg KH @ 2020-12-04 15:47 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, devel, toddpoynor, sbranden, rjui, speakup, rcy,
f.fainelli, rspringer, laurent.pinchart, netdev,
bcm-kernel-feedback-list, mchehab, nsaenzjulienne, linux-media
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since it's introducing
> into mainline, seven years ago. So, it doesn't seem to have much practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index 0c65a0121dde..4a23f40e549a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -24,7 +24,6 @@
> MODULE_AUTHOR("Google, Inc.");
> MODULE_DESCRIPTION("Android QEMU Audio Driver");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
>
> struct goldfish_audio {
> char __iomem *reg_base;
This file isn't even in my tree, are you sure you made this patch series
against the correct branch/tree?
Please fix this series up and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH 04/11] drivers: staging: goldfish: remove unneeded MODULE_VERSION() call
@ 2020-12-04 15:47 ` Greg KH
0 siblings, 0 replies; 28+ messages in thread
From: Greg KH @ 2020-12-04 15:47 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: devel, f.fainelli, sbranden, rjui, mchehab, speakup,
linux-kernel, rcy, rspringer, laurent.pinchart, netdev,
bcm-kernel-feedback-list, toddpoynor, nsaenzjulienne,
linux-media
On Thu, Dec 03, 2020 at 01:47:56PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to have much practical purpose.
> For in-kernel drivers, the kernel version matters. The driver received lots
> of changes, but version number has remained the same since it's introducing
> into mainline, seven years ago. So, it doesn't seem to have much practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/staging/goldfish/goldfish_audio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
> index 0c65a0121dde..4a23f40e549a 100644
> --- a/drivers/staging/goldfish/goldfish_audio.c
> +++ b/drivers/staging/goldfish/goldfish_audio.c
> @@ -24,7 +24,6 @@
> MODULE_AUTHOR("Google, Inc.");
> MODULE_DESCRIPTION("Android QEMU Audio Driver");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
>
> struct goldfish_audio {
> char __iomem *reg_base;
This file isn't even in my tree, are you sure you made this patch series
against the correct branch/tree?
Please fix this series up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code received lots of
changes, but module version remained constant, since the driver landed in
mainline. So, this version doesn't seem have any practical meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/media/omap4iss/iss.c | 1 -
drivers/staging/media/omap4iss/iss_video.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index e06ea7ea1e50..dae9073e7d3c 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1349,4 +1349,3 @@ module_platform_driver(iss_driver);
MODULE_DESCRIPTION("TI OMAP4 ISS driver");
MODULE_AUTHOR("Sergio Aguirre <sergio.a.aguirre@gmail.com>");
MODULE_LICENSE("GPL");
-MODULE_VERSION(ISS_VIDEO_DRIVER_VERSION);
diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h
index 8b3dd92021e1..526281bf0051 100644
--- a/drivers/staging/media/omap4iss/iss_video.h
+++ b/drivers/staging/media/omap4iss/iss_video.h
@@ -18,7 +18,6 @@
#include <media/videobuf2-dma-contig.h>
#define ISS_VIDEO_DRIVER_NAME "issvideo"
-#define ISS_VIDEO_DRIVER_VERSION "0.0.2"
struct iss_device;
struct iss_video;
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 05/11] drivers: staging: media: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version matters. The code received lots of
changes, but module version remained constant, since the driver landed in
mainline. So, this version doesn't seem have any practical meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/media/omap4iss/iss.c | 1 -
drivers/staging/media/omap4iss/iss_video.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index e06ea7ea1e50..dae9073e7d3c 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1349,4 +1349,3 @@ module_platform_driver(iss_driver);
MODULE_DESCRIPTION("TI OMAP4 ISS driver");
MODULE_AUTHOR("Sergio Aguirre <sergio.a.aguirre@gmail.com>");
MODULE_LICENSE("GPL");
-MODULE_VERSION(ISS_VIDEO_DRIVER_VERSION);
diff --git a/drivers/staging/media/omap4iss/iss_video.h b/drivers/staging/media/omap4iss/iss_video.h
index 8b3dd92021e1..526281bf0051 100644
--- a/drivers/staging/media/omap4iss/iss_video.h
+++ b/drivers/staging/media/omap4iss/iss_video.h
@@ -18,7 +18,6 @@
#include <media/videobuf2-dma-contig.h>
#define ISS_VIDEO_DRIVER_NAME "issvideo"
-#define ISS_VIDEO_DRIVER_VERSION "0.0.2"
struct iss_device;
struct iss_video;
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 06/11] drivers: staging: qlge: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version really matters. The module version
doesn't seem to be maintained and having much practical meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/qlge/qlge_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 27da386f9d87..a98ee325ff32 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -49,7 +49,6 @@ const char qlge_driver_version[] = DRV_VERSION;
MODULE_AUTHOR("Ron Mercer <ron.mercer@qlogic.com>");
MODULE_DESCRIPTION(DRV_STRING " ");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
static const u32 default_msg =
NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 06/11] drivers: staging: qlge: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-tree drivers, the kernel version really matters. The module version
doesn't seem to be maintained and having much practical meaning anymore.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/qlge/qlge_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
index 27da386f9d87..a98ee325ff32 100644
--- a/drivers/staging/qlge/qlge_main.c
+++ b/drivers/staging/qlge/qlge_main.c
@@ -49,7 +49,6 @@ const char qlge_driver_version[] = DRV_VERSION;
MODULE_AUTHOR("Ron Mercer <ron.mercer@qlogic.com>");
MODULE_DESCRIPTION(DRV_STRING " ");
MODULE_LICENSE("GPL");
-MODULE_VERSION(DRV_VERSION);
static const u32 default_msg =
NETIF_MSG_DRV | NETIF_MSG_PROBE | NETIF_MSG_LINK |
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 07/11] drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose.
For in-tree drivers, the kernel version really matters. OTOH, the module
version doesn't seem to be actively maintained - the code received changes
while the version remained constant.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
index df90c1f9d148..0b20dd51c340 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
@@ -2011,5 +2011,4 @@ module_platform_driver(bcm2835_camera_driver)
MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture");
MODULE_AUTHOR("Vincent Sanders");
MODULE_LICENSE("GPL");
-MODULE_VERSION(BM2835_MMAL_VERSION);
MODULE_ALIAS("platform:bcm2835-camera");
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 07/11] drivers: staging: vc04_services: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:47 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose.
For in-tree drivers, the kernel version really matters. OTOH, the module
version doesn't seem to be actively maintained - the code received changes
while the version remained constant.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
index df90c1f9d148..0b20dd51c340 100644
--- a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
+++ b/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c
@@ -2011,5 +2011,4 @@ module_platform_driver(bcm2835_camera_driver)
MODULE_DESCRIPTION("Broadcom 2835 MMAL video capture");
MODULE_AUTHOR("Vincent Sanders");
MODULE_LICENSE("GPL");
-MODULE_VERSION(BM2835_MMAL_VERSION);
MODULE_ALIAS("platform:bcm2835-camera");
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 08/11] drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-kernel drivers, the kernel version matters most. The driver received
lots of changes, while module version remained constant, since it landed
in mainline, back 7 years ago.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index e291df87f620..258d7a13467a 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -18,7 +18,6 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
MODULE_AUTHOR("Realtek Semiconductor Corp.");
-MODULE_VERSION(DRIVERVERSION);
MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
#define RTW_NOTCH_FILTER 0 /* 0:Disable, 1:Enable, */
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 08/11] drivers: staging: rtl8188eu: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
For in-kernel drivers, the kernel version matters most. The driver received
lots of changes, while module version remained constant, since it landed
in mainline, back 7 years ago.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8188eu/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index e291df87f620..258d7a13467a 100644
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -18,7 +18,6 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
MODULE_AUTHOR("Realtek Semiconductor Corp.");
-MODULE_VERSION(DRIVERVERSION);
MODULE_FIRMWARE("rtlwifi/rtl8188eufw.bin");
#define RTW_NOTCH_FILTER 0 /* 0:Disable, 1:Enable, */
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 09/11] drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose:
the driver has received lots of changes, while the module version remained
constant. Unmaintained version numbers aren't actually useful.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 663675efcfe4..e316f920657b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2635,7 +2635,6 @@ void rtl92e_check_rfctrl_gpio_timer(struct timer_list *t)
***************************************************************************/
MODULE_DESCRIPTION("Linux driver for Realtek RTL819x WiFi cards");
MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR);
-MODULE_VERSION(DRV_VERSION);
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(RTL8192E_BOOT_IMG_FW);
MODULE_FIRMWARE(RTL8192E_MAIN_IMG_FW);
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 09/11] drivers: staging: rtl8192e: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to have any practical purpose:
the driver has received lots of changes, while the module version remained
constant. Unmaintained version numbers aren't actually useful.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 663675efcfe4..e316f920657b 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -2635,7 +2635,6 @@ void rtl92e_check_rfctrl_gpio_timer(struct timer_list *t)
***************************************************************************/
MODULE_DESCRIPTION("Linux driver for Realtek RTL819x WiFi cards");
MODULE_AUTHOR(DRV_COPYRIGHT " " DRV_AUTHOR);
-MODULE_VERSION(DRV_VERSION);
MODULE_LICENSE("GPL");
MODULE_FIRMWARE(RTL8192E_BOOT_IMG_FW);
MODULE_FIRMWARE(RTL8192E_MAIN_IMG_FW);
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to have any pratical purpose.
The code received lots of huge changes, but module version remained constant,
since it landed in mainline tree, back 11 years go. Unmaintained version
numbers aren't actually useful. For in-tree drivers, the kernel version
really matters.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8192u/r8192U_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 27dc181c4c9b..da871f45042a 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -90,7 +90,6 @@ static const struct usb_device_id rtl8192_usb_id_tbl[] = {
};
MODULE_LICENSE("GPL");
-MODULE_VERSION("V 1.1");
MODULE_DEVICE_TABLE(usb, rtl8192_usb_id_tbl);
MODULE_DESCRIPTION("Linux driver for Realtek RTL8192 USB WiFi cards");
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 10/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to have any pratical purpose.
The code received lots of huge changes, but module version remained constant,
since it landed in mainline tree, back 11 years go. Unmaintained version
numbers aren't actually useful. For in-tree drivers, the kernel version
really matters.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8192u/r8192U_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
index 27dc181c4c9b..da871f45042a 100644
--- a/drivers/staging/rtl8192u/r8192U_core.c
+++ b/drivers/staging/rtl8192u/r8192U_core.c
@@ -90,7 +90,6 @@ static const struct usb_device_id rtl8192_usb_id_tbl[] = {
};
MODULE_LICENSE("GPL");
-MODULE_VERSION("V 1.1");
MODULE_DEVICE_TABLE(usb, rtl8192_usb_id_tbl);
MODULE_DESCRIPTION("Linux driver for Realtek RTL8192 USB WiFi cards");
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
-1 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: rspringer, toddpoynor, benchan, rcy, laurent.pinchart, mchehab,
f.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
nsaenzjulienne, speakup, devel, linux-media, netdev
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
The driver received lots of changes, but module remained constant since
it landed in mainline, several years ago.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 27f990a01a23..0a94bab4fdcb 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -13,7 +13,6 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
MODULE_AUTHOR("Realtek Semiconductor Corp.");
-MODULE_VERSION(DRIVERVERSION);
/* module param defaults */
static int rtw_chip_version;
--
2.11.0
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH 11/11] drivers: staging: rtl8723bs: remove unneeded MODULE_VERSION() call
@ 2020-12-03 12:48 ` Enrico Weigelt, metux IT consult
0 siblings, 0 replies; 28+ messages in thread
From: Enrico Weigelt, metux IT consult @ 2020-12-03 12:48 UTC (permalink / raw)
To: linux-kernel
Cc: devel, toddpoynor, sbranden, rjui, speakup, rcy, f.fainelli,
rspringer, laurent.pinchart, netdev, bcm-kernel-feedback-list,
mchehab, nsaenzjulienne, linux-media
Remove MODULE_VERSION(), as it doesn't seem to serve any practical purpose.
The driver received lots of changes, but module remained constant since
it landed in mainline, several years ago.
Signed-off-by: Enrico Weigelt <info@metux.net>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 27f990a01a23..0a94bab4fdcb 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -13,7 +13,6 @@
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Realtek Wireless Lan Driver");
MODULE_AUTHOR("Realtek Semiconductor Corp.");
-MODULE_VERSION(DRIVERVERSION);
/* module param defaults */
static int rtw_chip_version;
--
2.11.0
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 28+ messages in thread
* Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
2020-12-03 12:47 ` Enrico Weigelt, metux IT consult
@ 2020-12-03 13:25 ` Greg KH
-1 siblings, 0 replies; 28+ messages in thread
From: Greg KH @ 2020-12-03 13:25 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: linux-kernel, devel, toddpoynor, sbranden, rjui, speakup, rcy,
f.fainelli, rspringer, laurent.pinchart, netdev,
bcm-kernel-feedback-list, mchehab, nsaenzjulienne, linux-media
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
>
> The drivers have received lots of changes, without the module version
> (or the underlying DRV_VERSION macro) ever changed, since the code
> landed in the kernel tree. So, it doesn't seem to have any practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/accessibility/speakup/main.c | 1 -
<snip>
Yous subject line is odd, these are not "staging" drivers anymore, so
why do you say they are there?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
@ 2020-12-03 13:25 ` Greg KH
0 siblings, 0 replies; 28+ messages in thread
From: Greg KH @ 2020-12-03 13:25 UTC (permalink / raw)
To: Enrico Weigelt, metux IT consult
Cc: devel, f.fainelli, sbranden, rjui, mchehab, speakup,
linux-kernel, rcy, rspringer, laurent.pinchart, netdev,
bcm-kernel-feedback-list, toddpoynor, nsaenzjulienne,
linux-media
On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> purpose. For in-tree drivers, the kernel version matters.
>
> The drivers have received lots of changes, without the module version
> (or the underlying DRV_VERSION macro) ever changed, since the code
> landed in the kernel tree. So, it doesn't seem to have any practical
> meaning anymore.
>
> Signed-off-by: Enrico Weigelt <info@metux.net>
> ---
> drivers/accessibility/speakup/main.c | 1 -
<snip>
Yous subject line is odd, these are not "staging" drivers anymore, so
why do you say they are there?
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
2020-12-03 13:25 ` Greg KH
@ 2020-12-03 13:56 ` Dan Carpenter
-1 siblings, 0 replies; 28+ messages in thread
From: Dan Carpenter @ 2020-12-03 13:56 UTC (permalink / raw)
To: Greg KH
Cc: Enrico Weigelt, metux IT consult, devel, f.fainelli, sbranden,
rjui, mchehab, speakup, linux-kernel, rcy, rspringer,
laurent.pinchart, netdev, bcm-kernel-feedback-list, toddpoynor,
nsaenzjulienne, linux-media
On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> >
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> >
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> > ---
> > drivers/accessibility/speakup/main.c | 1 -
>
> <snip>
>
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?
Also putting "drivers:" in the subject always seems superfluous.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH 01/11] drivers: staging: speakup: remove unneeded MODULE_VERSION() call
@ 2020-12-03 13:56 ` Dan Carpenter
0 siblings, 0 replies; 28+ messages in thread
From: Dan Carpenter @ 2020-12-03 13:56 UTC (permalink / raw)
To: Greg KH
Cc: devel, f.fainelli, sbranden, rjui, speakup, linux-kernel, rcy,
toddpoynor, rspringer, laurent.pinchart, netdev,
bcm-kernel-feedback-list, mchehab, Enrico Weigelt,
metux IT consult, nsaenzjulienne, linux-media
On Thu, Dec 03, 2020 at 02:25:15PM +0100, Greg KH wrote:
> On Thu, Dec 03, 2020 at 01:47:53PM +0100, Enrico Weigelt, metux IT consult wrote:
> > Remove MODULE_VERSION(), as it doesn't seem to serve any practical
> > purpose. For in-tree drivers, the kernel version matters.
> >
> > The drivers have received lots of changes, without the module version
> > (or the underlying DRV_VERSION macro) ever changed, since the code
> > landed in the kernel tree. So, it doesn't seem to have any practical
> > meaning anymore.
> >
> > Signed-off-by: Enrico Weigelt <info@metux.net>
> > ---
> > drivers/accessibility/speakup/main.c | 1 -
>
> <snip>
>
> Yous subject line is odd, these are not "staging" drivers anymore, so
> why do you say they are there?
Also putting "drivers:" in the subject always seems superfluous.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 28+ messages in thread