All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org,
	kraxel@redhat.com, tzimmermann@suse.de,
	alexander.deucher@amd.com, tglx@linutronix.de
Subject: Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq
Date: Thu, 3 Dec 2020 22:33:34 +0100	[thread overview]
Message-ID: <20201203213334.GB81406@ravnborg.org> (raw)
In-Reply-To: <20201203200711.GA74163@ravnborg.org>

Hi Tian,

> > +	ret = devm_add_action_or_reset(dev->dev, devm_drm_irq_uninstall, dev);
> > +	if (ret)
> > +		devm_drm_irq_uninstall(dev);
> devm_add_action_or_reset() will call devm_drm_irq_uninstall() if ret is
> != 0. See include/device.h.
> 
> I guess that is the "_or_reset" part of the name that can tell us that.
> So you can drop the if condition as it just will cause the code to call
> drm_irq_uninstall() twice.

Noticed this was fixed in v2 - so all is fine here.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: airlied@linux.ie, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, xinliang.liu@linaro.org,
	kraxel@redhat.com, tzimmermann@suse.de,
	alexander.deucher@amd.com, tglx@linutronix.de
Subject: Re: [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq
Date: Thu, 3 Dec 2020 22:33:34 +0100	[thread overview]
Message-ID: <20201203213334.GB81406@ravnborg.org> (raw)
In-Reply-To: <20201203200711.GA74163@ravnborg.org>

Hi Tian,

> > +	ret = devm_add_action_or_reset(dev->dev, devm_drm_irq_uninstall, dev);
> > +	if (ret)
> > +		devm_drm_irq_uninstall(dev);
> devm_add_action_or_reset() will call devm_drm_irq_uninstall() if ret is
> != 0. See include/device.h.
> 
> I guess that is the "_or_reset" part of the name that can tell us that.
> So you can drop the if condition as it just will cause the code to call
> drm_irq_uninstall() twice.

Noticed this was fixed in v2 - so all is fine here.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-12-03 21:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  8:47 [PATCH drm/hisilicon 0/3] Add the new api to install irq Tian Tao
2020-12-02  8:47 ` Tian Tao
2020-12-02  8:47 ` [PATCH drm/hisilicon 1/3] drm/hisilicon: Code refactoring for hibmc_drm_drv Tian Tao
2020-12-02  8:47   ` Tian Tao
2020-12-02  9:02   ` Thomas Zimmermann
2020-12-02  9:02     ` Thomas Zimmermann
2020-12-02  9:27     ` tiantao (H)
2020-12-02  9:27       ` tiantao (H)
2020-12-21 22:03     ` Daniel Vetter
2020-12-21 22:03       ` Daniel Vetter
2020-12-02  8:47 ` [PATCH drm/hisilicon 2/3] drm/irq: Add the new api to install irq Tian Tao
2020-12-02  8:47   ` Tian Tao
2020-12-02  8:59   ` Thomas Zimmermann
2020-12-02  8:59     ` Thomas Zimmermann
2020-12-03 20:07   ` Sam Ravnborg
2020-12-03 20:07     ` Sam Ravnborg
2020-12-03 21:33     ` Sam Ravnborg [this message]
2020-12-03 21:33       ` Sam Ravnborg
2020-12-02  8:47 ` [PATCH drm/hisilicon 3/3] drm/hisilicon: Use the new api devm_drm_irq_install Tian Tao
2020-12-02  8:47   ` Tian Tao
  -- strict thread matches above, loose matches on Subject: below --
2020-11-26 12:02 [PATCH drm/hisilicon 0/3] Add the new api to install irq Tian Tao
2020-11-26 12:02 ` [PATCH drm/hisilicon 2/3] drm/irq: " Tian Tao
2020-11-26 12:02   ` Tian Tao
2020-11-26 13:12   ` Thomas Zimmermann
2020-11-26 13:12     ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203213334.GB81406@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=alexander.deucher@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tiantao6@hisilicon.com \
    --cc=tzimmermann@suse.de \
    --cc=xinliang.liu@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.