* + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
@ 2020-11-26 5:47 akpm
2020-12-03 22:04 ` Hugh Dickins
0 siblings, 1 reply; 6+ messages in thread
From: akpm @ 2020-11-26 5:47 UTC (permalink / raw)
To: akpm, dchinner, hannes, hch, hughd, jack, kirill.shutemov,
mm-commits, william.kucharski, willy, yang.shi
The patch titled
Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
has been added to the -mm tree. Its filename is
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
fix page unlocking, per Hugh
Link: https://lkml.kernel.org/r/CANsGZ6a95WK7+2H4Zyg5FwDxhdJQqR8nKND1Cn6r6e3QxWeW4Q@mail.gmail.com
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/shmem.c | 3 +++
1 file changed, 3 insertions(+)
--- a/mm/shmem.c~mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
+++ a/mm/shmem.c
@@ -961,8 +961,11 @@ static void shmem_undo_range(struct inod
page, lstart, lend);
if (index > end)
end = indices[i] - 1;
+ } else {
+ unlock_page(page);
}
}
+
index = indices[i - 1] + 1;
pagevec_remove_exceptionals(&pvec);
pagevec_reinit(&pvec);
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
kthread_worker-document-cpu-hotplug-handling-fix.patch
mm.patch
mm-prevent-gup_fast-from-racing-with-cow-during-fork-checkpatch-fixes.patch
mm-swap_state-skip-meaningless-swap-cache-readahead-when-ra_infowin-==-0-fix.patch
mm-vmallocc-__vmalloc_area_node-avoid-32-bit-overflow.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch
lib-cmdline_kunit-add-a-new-test-suite-for-cmdline-api-fix.patch
ilog2-improve-ilog2-for-constant-arguments-checkpatch-fixes.patch
lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes.patch
resource-fix-kernel-doc-markups-checkpatch-fixes.patch
linux-next-rejects.patch
linux-next-git-rejects.patch
kernel-forkc-export-kernel_thread-to-modules.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
2020-11-26 5:47 + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree akpm
@ 2020-12-03 22:04 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2020-12-03 22:04 UTC (permalink / raw)
To: Andrew Morton, Stephen Rothwell
Cc: m.szyprowski, qcai, dchinner, hannes, hch, hughd, jack,
kirill.shutemov, mm-commits, linux-mm, linux-kernel,
linux-fsdevel, william.kucharski, willy, yang.shi
On Wed, 25 Nov 2020, akpm@linux-foundation.org wrote:
>
> The patch titled
> Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
> has been added to the -mm tree. Its filename is
> mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
Andrew, Stephen,
This lot is proving to be a work in progress,
the current state breaks booting on 32-bit, livelocks trinity,
and breaks shmem in more ways than I can quickly explain.
Please revert (in reverse order):
mm-truncateshmem-handle-truncates-that-split-thps.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
mm-filemap-return-only-head-pages-from-find_get_entries.patch
(I don't think there's any problem with that last patch, but
assume that it relies on ..split-thpfs.patch being in already.)
Thanks,
Hugh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
@ 2020-12-03 22:04 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2020-12-03 22:04 UTC (permalink / raw)
To: Andrew Morton, Stephen Rothwell
Cc: m.szyprowski, qcai, dchinner, hannes, hch, hughd, jack,
kirill.shutemov, mm-commits, linux-mm, linux-kernel,
linux-fsdevel, william.kucharski, willy, yang.shi
On Wed, 25 Nov 2020, akpm@linux-foundation.org wrote:
>
> The patch titled
> Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
> has been added to the -mm tree. Its filename is
> mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
Andrew, Stephen,
This lot is proving to be a work in progress,
the current state breaks booting on 32-bit, livelocks trinity,
and breaks shmem in more ways than I can quickly explain.
Please revert (in reverse order):
mm-truncateshmem-handle-truncates-that-split-thps.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
mm-filemap-return-only-head-pages-from-find_get_entries.patch
(I don't think there's any problem with that last patch, but
assume that it relies on ..split-thpfs.patch being in already.)
Thanks,
Hugh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
2020-12-03 22:04 ` Hugh Dickins
(?)
@ 2020-12-03 22:34 ` Stephen Rothwell
-1 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-12-03 22:34 UTC (permalink / raw)
To: Hugh Dickins
Cc: Andrew Morton, m.szyprowski, qcai, dchinner, hannes, hch, jack,
kirill.shutemov, mm-commits, linux-mm, linux-kernel,
linux-fsdevel, william.kucharski, willy, yang.shi
[-- Attachment #1: Type: text/plain, Size: 955 bytes --]
Hi Hugh,
On Thu, 3 Dec 2020 14:04:18 -0800 (PST) Hugh Dickins <hughd@google.com> wrote:
>
> On Wed, 25 Nov 2020, akpm@linux-foundation.org wrote:
> >
> > The patch titled
> > Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
> > has been added to the -mm tree. Its filename is
> > mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
>
> This lot is proving to be a work in progress,
> the current state breaks booting on 32-bit, livelocks trinity,
> and breaks shmem in more ways than I can quickly explain.
> Please revert (in reverse order):
>
> mm-truncateshmem-handle-truncates-that-split-thps.patch
> mm-truncateshmem-handle-truncates-that-split-thps-fix.patch
> mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
> mm-filemap-return-only-head-pages-from-find_get_entries.patch
I have removed all 4 patches from linux-next for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
2020-11-26 0:16 akpm
@ 2020-11-26 0:57 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2020-11-26 0:57 UTC (permalink / raw)
To: Andrew Morton
Cc: dchinner, Johannes Weiner, Christoph Hellwig, Jan Kara,
Kirill A. Shutemov, mm-commits, William Kucharski,
Matthew Wilcox, Yang Shi
On Wed, Nov 25, 2020 at 4:16 PM <akpm@linux-foundation.org> wrote:
>
>
> The patch titled
> Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
> has been added to the -mm tree. Its filename is
> mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
>
> This patch should soon appear at
> https://ozlabs.org/~akpm/mmots/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
> and later at
> https://ozlabs.org/~akpm/mmotm/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
>
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
>
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
>
> fix page unlocking, per Hugh
>
> Link: https://lkml.kernel.org/r/CANsGZ6a95WK7+2H4Zyg5FwDxhdJQqR8nKND1Cn6r6e3QxWeW4Q@mail.gmail.com
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Dave Chinner <dchinner@redhat.com>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Cc: Matthew Wilcox <willy@infradead.org>
> Cc: William Kucharski <william.kucharski@oracle.com>
> Cc: Yang Shi <yang.shi@linux.alibaba.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> mm/shmem.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> --- a/mm/shmem.c~mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
> +++ a/mm/shmem.c
> @@ -962,7 +962,10 @@ static void shmem_undo_range(struct inod
> if (index > end)
> end = indices[i] - 1;
> }
> + } else {
> + unlock_page(page);
> }
> +
Thanks for bearing with the gmail, and I can't read this clearly in gmail,
but I think I have deceived you into misplacing that:
it should end up as
if (!unfalloc || !PageUptodate(page)) {
blah blah blah
} else {
unlock_page(page);
}
> index = indices[i - 1] + 1;
> pagevec_remove_exceptionals(&pvec);
> pagevec_reinit(&pvec);
> _
>
> Patches currently in -mm which might be from akpm@linux-foundation.org are
>
> kthread_worker-document-cpu-hotplug-handling-fix.patch
> mm.patch
> mm-prevent-gup_fast-from-racing-with-cow-during-fork-checkpatch-fixes.patch
> mm-swap_state-skip-meaningless-swap-cache-readahead-when-ra_infowin-==-0-fix.patch
> mm-vmallocc-__vmalloc_area_node-avoid-32-bit-overflow.patch
> mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
> mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch
> lib-cmdline_kunit-add-a-new-test-suite-for-cmdline-api-fix.patch
> ilog2-improve-ilog2-for-constant-arguments-checkpatch-fixes.patch
> lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes.patch
> resource-fix-kernel-doc-markups-checkpatch-fixes.patch
> linux-next-rejects.patch
> linux-next-git-rejects.patch
> kernel-forkc-export-kernel_thread-to-modules.patch
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree
@ 2020-11-26 0:16 akpm
2020-11-26 0:57 ` Hugh Dickins
0 siblings, 1 reply; 6+ messages in thread
From: akpm @ 2020-11-26 0:16 UTC (permalink / raw)
To: akpm, dchinner, hannes, hch, hughd, jack, kirill.shutemov,
mm-commits, william.kucharski, willy, yang.shi
The patch titled
Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
has been added to the -mm tree. Its filename is
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
fix page unlocking, per Hugh
Link: https://lkml.kernel.org/r/CANsGZ6a95WK7+2H4Zyg5FwDxhdJQqR8nKND1Cn6r6e3QxWeW4Q@mail.gmail.com
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dave Chinner <dchinner@redhat.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: Yang Shi <yang.shi@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/shmem.c | 3 +++
1 file changed, 3 insertions(+)
--- a/mm/shmem.c~mm-truncateshmem-handle-truncates-that-split-thps-fix-fix
+++ a/mm/shmem.c
@@ -962,7 +962,10 @@ static void shmem_undo_range(struct inod
if (index > end)
end = indices[i] - 1;
}
+ } else {
+ unlock_page(page);
}
+
index = indices[i - 1] + 1;
pagevec_remove_exceptionals(&pvec);
pagevec_reinit(&pvec);
_
Patches currently in -mm which might be from akpm@linux-foundation.org are
kthread_worker-document-cpu-hotplug-handling-fix.patch
mm.patch
mm-prevent-gup_fast-from-racing-with-cow-during-fork-checkpatch-fixes.patch
mm-swap_state-skip-meaningless-swap-cache-readahead-when-ra_infowin-==-0-fix.patch
mm-vmallocc-__vmalloc_area_node-avoid-32-bit-overflow.patch
mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch
mm-vmstat-fix-proc-sys-vm-stat_refresh-generating-false-warnings-fix-2.patch
lib-cmdline_kunit-add-a-new-test-suite-for-cmdline-api-fix.patch
ilog2-improve-ilog2-for-constant-arguments-checkpatch-fixes.patch
lib-test_bitmapc-add-for_each_set_clump-test-cases-checkpatch-fixes.patch
resource-fix-kernel-doc-markups-checkpatch-fixes.patch
linux-next-rejects.patch
linux-next-git-rejects.patch
kernel-forkc-export-kernel_thread-to-modules.patch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-03 22:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-26 5:47 + mm-truncateshmem-handle-truncates-that-split-thps-fix-fix.patch added to -mm tree akpm
2020-12-03 22:04 ` Hugh Dickins
2020-12-03 22:04 ` Hugh Dickins
2020-12-03 22:34 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2020-11-26 0:16 akpm
2020-11-26 0:57 ` Hugh Dickins
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.