* [PATCH] greybus: Add TODO item about modernizing the pwm code
@ 2020-12-04 18:33 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-12-04 18:33 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: Thierry Reding, Lee Jones, linux-pwm, greybus-dev, devel
drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
should stick to the atomic API instead.
---
drivers/staging/greybus/TODO | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
index 31f1f2cb401c..6461e0132fe3 100644
--- a/drivers/staging/greybus/TODO
+++ b/drivers/staging/greybus/TODO
@@ -1,3 +1,5 @@
* Convert all uses of the old GPIO API from <linux/gpio.h> to the
GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
lines from device tree or ACPI.
+* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
+ ::enable and ::disable.
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] greybus: Add TODO item about modernizing the pwm code
@ 2020-12-04 18:33 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2020-12-04 18:33 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman
Cc: devel, linux-pwm, Thierry Reding, Lee Jones, greybus-dev
drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
should stick to the atomic API instead.
---
drivers/staging/greybus/TODO | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
index 31f1f2cb401c..6461e0132fe3 100644
--- a/drivers/staging/greybus/TODO
+++ b/drivers/staging/greybus/TODO
@@ -1,3 +1,5 @@
* Convert all uses of the old GPIO API from <linux/gpio.h> to the
GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
lines from device tree or ACPI.
+* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
+ ::enable and ::disable.
--
2.29.2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] greybus: Add TODO item about modernizing the pwm code
2020-12-04 18:33 ` Uwe Kleine-König
@ 2020-12-08 9:39 ` Johan Hovold
-1 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2020-12-08 9:39 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, Thierry Reding,
Lee Jones, linux-pwm, greybus-dev, devel
On Fri, Dec 04, 2020 at 07:33:35PM +0100, Uwe Kleine-König wrote:
> drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
> should stick to the atomic API instead.
> ---
No sign off?
Please also add a staging prefix since this part of greybus still lives
there.
> drivers/staging/greybus/TODO | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
> index 31f1f2cb401c..6461e0132fe3 100644
> --- a/drivers/staging/greybus/TODO
> +++ b/drivers/staging/greybus/TODO
> @@ -1,3 +1,5 @@
> * Convert all uses of the old GPIO API from <linux/gpio.h> to the
> GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
> lines from device tree or ACPI.
> +* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
> + ::enable and ::disable.
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] greybus: Add TODO item about modernizing the pwm code
@ 2020-12-08 9:39 ` Johan Hovold
0 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2020-12-08 9:39 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: devel, linux-pwm, Alex Elder, Greg Kroah-Hartman, Johan Hovold,
greybus-dev, Thierry Reding, Lee Jones
On Fri, Dec 04, 2020 at 07:33:35PM +0100, Uwe Kleine-König wrote:
> drivers/staging/greybus/pwm.c uses the old style PWM callbacks, new drivers
> should stick to the atomic API instead.
> ---
No sign off?
Please also add a staging prefix since this part of greybus still lives
there.
> drivers/staging/greybus/TODO | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/greybus/TODO b/drivers/staging/greybus/TODO
> index 31f1f2cb401c..6461e0132fe3 100644
> --- a/drivers/staging/greybus/TODO
> +++ b/drivers/staging/greybus/TODO
> @@ -1,3 +1,5 @@
> * Convert all uses of the old GPIO API from <linux/gpio.h> to the
> GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
> lines from device tree or ACPI.
> +* Make pwm.c use the struct pwm_ops::apply instead of ::config, ::set_polarity,
> + ::enable and ::disable.
Johan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-08 9:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-04 18:33 [PATCH] greybus: Add TODO item about modernizing the pwm code Uwe Kleine-König
2020-12-04 18:33 ` Uwe Kleine-König
2020-12-08 9:39 ` Johan Hovold
2020-12-08 9:39 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.