[PATCH] drm: Remove drmm_add_final_kfree() declaration from public headers

[PATCH] drm: Remove drmm_add_final_kfree() declaration from public headers

[Laurent Pinchart]

The drmm_add_final_kfree() function is declared in the
include/drm/drm_managed.h public header, but has become an internal API
not exposed to drivers. Drop it from drm_managed.h as it's already
declared in drm_internal.h.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 include/drm/drm_managed.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
index ca4114633bf9..b45c6fbf53ac 100644
--- a/include/drm/drm_managed.h
+++ b/include/drm/drm_managed.h
@@ -44,8 +44,6 @@ int __must_check __drmm_add_action_or_reset(struct drm_device *dev,
 					    drmres_release_t action,
 					    void *data, const char *name);
 
-void drmm_add_final_kfree(struct drm_device *dev, void *container);
-
 void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc;
 
 /**
-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: Remove drmm_add_final_kfree() declaration from public headers

[Thomas Zimmermann]

[-- Attachment #1.1.1: Type: text/plain, Size: 1249 bytes --]



Am 04.12.20 um 10:29 schrieb Laurent Pinchart:
> The drmm_add_final_kfree() function is declared in the
> include/drm/drm_managed.h public header, but has become an internal API
> not exposed to drivers. Drop it from drm_managed.h as it's already
> declared in drm_internal.h.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   include/drm/drm_managed.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
> index ca4114633bf9..b45c6fbf53ac 100644
> --- a/include/drm/drm_managed.h
> +++ b/include/drm/drm_managed.h
> @@ -44,8 +44,6 @@ int __must_check __drmm_add_action_or_reset(struct drm_device *dev,
>   					    drmres_release_t action,
>   					    void *data, const char *name);
>   
> -void drmm_add_final_kfree(struct drm_device *dev, void *container);
> -
>   void *drmm_kmalloc(struct drm_device *dev, size_t size, gfp_t gfp) __malloc;
>   
>   /**
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm: Remove drmm_add_final_kfree() declaration from public headers

[Sam Ravnborg]

Hi Laurent,

On Fri, Dec 04, 2020 at 11:29:32AM +0200, Laurent Pinchart wrote:
> The drmm_add_final_kfree() function is declared in the
> include/drm/drm_managed.h public header, but has become an internal API
> not exposed to drivers. Drop it from drm_managed.h as it's already
> declared in drm_internal.h.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Applied to drm-misc-next, thanks.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel