[congwang:timeout_map 2/3] kernel/bpf/hashtab.c:2318:17: sparse: sparse: context imbalance in 'htab_gc_idle' - unexpected unlock

[congwang:timeout_map 2/3] kernel/bpf/hashtab.c:2318:17: sparse: sparse: context imbalance in 'htab_gc_idle' - unexpected unlock

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 5397 bytes --]

CC: kbuild-all(a)lists.01.org
TO: Cong Wang <cong.wang@bytedance.com>

tree:   https://github.com/congwang/linux.git timeout_map
head:   e4f1523371f1bf9d572601ef8a359abdbee4941d
commit: 06fd50cc2a66536dda8a84bae1a2868f4534aea6 [2/3] bpf: introduce timeout map
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-s002-20201207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/congwang/linux/commit/06fd50cc2a66536dda8a84bae1a2868f4534aea6
        git remote add congwang https://github.com/congwang/linux.git
        git fetch --no-tags congwang timeout_map
        git checkout 06fd50cc2a66536dda8a84bae1a2868f4534aea6
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
   kernel/bpf/hashtab.c:672:19: sparse: sparse: subtraction of functions? Share your drugs
   kernel/bpf/hashtab.c:713:19: sparse: sparse: subtraction of functions? Share your drugs
   kernel/bpf/hashtab.c:1493:24: sparse: sparse: incorrect type in initializer (different address spaces) @@     expected void *ubatch @@     got void [noderef] __user * @@
   kernel/bpf/hashtab.c:1493:24: sparse:     expected void *ubatch
   kernel/bpf/hashtab.c:1493:24: sparse:     got void [noderef] __user *
   kernel/bpf/hashtab.c:1522:46: sparse: sparse: incorrect type in argument 2 (different address spaces) @@     expected void const [noderef] __user *from @@     got void *ubatch @@
   kernel/bpf/hashtab.c:1522:46: sparse:     expected void const [noderef] __user *from
   kernel/bpf/hashtab.c:1522:46: sparse:     got void *ubatch
   kernel/bpf/hashtab.c:1686:16: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *ubatch @@     got void [noderef] __user * @@
   kernel/bpf/hashtab.c:1686:16: sparse:     expected void *ubatch
   kernel/bpf/hashtab.c:1686:16: sparse:     got void [noderef] __user *
   kernel/bpf/hashtab.c:1687:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __user *to @@     got void *ubatch @@
   kernel/bpf/hashtab.c:1687:26: sparse:     expected void [noderef] __user *to
   kernel/bpf/hashtab.c:1687:26: sparse:     got void *ubatch
   kernel/bpf/hashtab.c:2226:19: sparse: sparse: subtraction of functions? Share your drugs
   kernel/bpf/hashtab.c:2364:19: sparse: sparse: subtraction of functions? Share your drugs
   kernel/bpf/hashtab.c: note: in included file (through include/linux/workqueue.h, include/linux/bpf.h):
   include/linux/rcupdate.h:693:9: sparse: sparse: context imbalance in '__htab_map_lookup_and_delete_batch' - unexpected unlock
   include/linux/rcupdate.h:693:9: sparse: sparse: context imbalance in 'bpf_hash_map_seq_find_next' - unexpected unlock
   include/linux/rcupdate.h:693:9: sparse: sparse: context imbalance in 'bpf_hash_map_seq_stop' - unexpected unlock
>> kernel/bpf/hashtab.c:2318:17: sparse: sparse: context imbalance in 'htab_gc_idle' - unexpected unlock

vim +/htab_gc_idle +2318 kernel/bpf/hashtab.c

06fd50cc2a6653 Cong Wang 2020-11-20  2297  
06fd50cc2a6653 Cong Wang 2020-11-20  2298  static void htab_gc_idle(struct work_struct *work)
06fd50cc2a6653 Cong Wang 2020-11-20  2299  {
06fd50cc2a6653 Cong Wang 2020-11-20  2300  	struct bpf_htab *htab;
06fd50cc2a6653 Cong Wang 2020-11-20  2301  	int i;
06fd50cc2a6653 Cong Wang 2020-11-20  2302  
06fd50cc2a6653 Cong Wang 2020-11-20  2303  	htab = container_of(work, struct bpf_htab, gc_idle_work.work);
06fd50cc2a6653 Cong Wang 2020-11-20  2304  
06fd50cc2a6653 Cong Wang 2020-11-20  2305  	for (i = 0; i < htab->n_buckets; i++) {
06fd50cc2a6653 Cong Wang 2020-11-20  2306  		unsigned long flags;
06fd50cc2a6653 Cong Wang 2020-11-20  2307  		struct bucket *b;
06fd50cc2a6653 Cong Wang 2020-11-20  2308  		int ret;
06fd50cc2a6653 Cong Wang 2020-11-20  2309  
06fd50cc2a6653 Cong Wang 2020-11-20  2310  		b = __select_bucket(htab, i);
06fd50cc2a6653 Cong Wang 2020-11-20  2311  		if (hlist_nulls_empty(&b->head))
06fd50cc2a6653 Cong Wang 2020-11-20  2312  			continue;
06fd50cc2a6653 Cong Wang 2020-11-20  2313  		if (atomic_read(&b->pending))
06fd50cc2a6653 Cong Wang 2020-11-20  2314  			continue;
06fd50cc2a6653 Cong Wang 2020-11-20  2315  		ret = htab_lock_bucket(htab, b, &flags);
06fd50cc2a6653 Cong Wang 2020-11-20  2316  		if (ret)
06fd50cc2a6653 Cong Wang 2020-11-20  2317  			continue;
06fd50cc2a6653 Cong Wang 2020-11-20 @2318  		__htab_gc_bucket(htab, b);
06fd50cc2a6653 Cong Wang 2020-11-20  2319  		htab_unlock_bucket(htab, b, flags);
06fd50cc2a6653 Cong Wang 2020-11-20  2320  		cond_resched();
06fd50cc2a6653 Cong Wang 2020-11-20  2321  	}
06fd50cc2a6653 Cong Wang 2020-11-20  2322  
06fd50cc2a6653 Cong Wang 2020-11-20  2323  	queue_delayed_work(system_power_efficient_wq, &htab->gc_idle_work, HZ);
06fd50cc2a6653 Cong Wang 2020-11-20  2324  }
06fd50cc2a6653 Cong Wang 2020-11-20  2325  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33514 bytes --]