All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] docs: fix documentation about default scheduler
@ 2020-11-17  9:32 Roger Pau Monne
  2020-12-07 15:40 ` Wei Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2020-11-17  9:32 UTC (permalink / raw)
  To: xen-devel
  Cc: Roger Pau Monne, Andrew Cooper, George Dunlap, Ian Jackson,
	Jan Beulich, Julien Grall, Stefano Stabellini, Wei Liu

Fix the command line document to account for the default scheduler in
Kconfig being credit2 now, and the fact that it's selectable at build
time and thus different builds could end up with different default
schedulers.

Fixes: dafd936dddbd ('Make credit2 the default scheduler')
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Changes since v2:
 - List credit2 as the default scheduler.
 - Note that default scheduler can be set from Kconfig.

Changes since v1:
 - Point that the default scheduler is being selected by Kconfig,
   don't mention the default Kconfig selection.
---
 docs/misc/xen-command-line.pandoc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc
index 4ae9391fcd..803243c3fa 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1876,9 +1876,11 @@ with read and write permissions.
 ### sched
 > `= credit | credit2 | arinc653 | rtds | null`
 
-> Default: `sched=credit`
+> Default: `sched=credit2`
 
-Choose the default scheduler.
+Choose the default scheduler. Note the default scheduler is selectable via
+Kconfig and depends on enabled schedulers. Check
+`CONFIG_SCHED_DEFAULT` to see which scheduler is the default.
 
 ### sched_credit2_max_cpus_runqueue
 > `= <integer>`
-- 
2.29.2



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] docs: fix documentation about default scheduler
  2020-11-17  9:32 [PATCH v3] docs: fix documentation about default scheduler Roger Pau Monne
@ 2020-12-07 15:40 ` Wei Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2020-12-07 15:40 UTC (permalink / raw)
  To: Roger Pau Monne
  Cc: xen-devel, Andrew Cooper, George Dunlap, Ian Jackson,
	Jan Beulich, Julien Grall, Stefano Stabellini, Wei Liu

On Tue, Nov 17, 2020 at 10:32:58AM +0100, Roger Pau Monne wrote:
> Fix the command line document to account for the default scheduler in
> Kconfig being credit2 now, and the fact that it's selectable at build
> time and thus different builds could end up with different default
> schedulers.
> 
> Fixes: dafd936dddbd ('Make credit2 the default scheduler')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Well I have not seen an explicit agreement on the text from the v1
thread, and I don't have v2 in my inbox, but this patch is definitely an
improvement over the old text in that it shows the correct scheduler. In
the interest of making progress:

Acked-by: Wei Liu <wl@xen.org>

Wei.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-07 15:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17  9:32 [PATCH v3] docs: fix documentation about default scheduler Roger Pau Monne
2020-12-07 15:40 ` Wei Liu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.