All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
To: linux-kernel@vger.kernel.org
Cc: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>,
	linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
	mchehab@kernel.org, sakari.ailus@linux.intel.com,
	gregkh@linuxfoundation.org,
	ij72uhux@stud.informatik.uni-erlangen.de,
	linux-kernel@i4.cs.fau.de
Subject: [PATCH 02/12] media: atomisp: Fix Block Comments
Date: Mon,  7 Dec 2020 20:26:29 +0100	[thread overview]
Message-ID: <20201207192638.15219-3-Philipp.Gerlesberger@fau.de> (raw)
In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de>

Block comments should use * on subsequent lines and
should use a trailing */ on a separate line.

Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
---
 .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
index af61d05e88d3..4ba5b8f88a7d 100644
--- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
+++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
@@ -98,7 +98,7 @@ void ia_css_rmgr_refcount_retain_vbuf(struct ia_css_rmgr_vbuf_handle **handle)
 			}
 		}
 		/* if the loop dus not break and *handle == NULL
-		   this is an error handle and report it.
+		 * this is an error handle and report it.
 		 */
 		if (!*handle) {
 			ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR,
@@ -253,7 +253,8 @@ void rmgr_pop_handle(struct ia_css_rmgr_vbuf_pool *pool,
 			*handle = pool->handles[i];
 			pool->handles[i] = NULL;
 			/* dont release, we are returning it...
-			   ia_css_rmgr_refcount_release_vbuf(handle); */
+			 * ia_css_rmgr_refcount_release_vbuf(handle);
+			 */
 			return;
 		}
 	}
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de,
	gregkh@linuxfoundation.org,
	ij72uhux@stud.informatik.uni-erlangen.de,
	Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>,
	sakari.ailus@linux.intel.com, mchehab@kernel.org,
	linux-media@vger.kernel.org
Subject: [PATCH 02/12] media: atomisp: Fix Block Comments
Date: Mon,  7 Dec 2020 20:26:29 +0100	[thread overview]
Message-ID: <20201207192638.15219-3-Philipp.Gerlesberger@fau.de> (raw)
In-Reply-To: <20201207192638.15219-1-Philipp.Gerlesberger@fau.de>

Block comments should use * on subsequent lines and
should use a trailing */ on a separate line.

Co-developed-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Andrey Khlopkov <ij72uhux@stud.informatik.uni-erlangen.de>
Signed-off-by: Philipp Gerlesberger <Philipp.Gerlesberger@fau.de>
---
 .../staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
index af61d05e88d3..4ba5b8f88a7d 100644
--- a/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
+++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c
@@ -98,7 +98,7 @@ void ia_css_rmgr_refcount_retain_vbuf(struct ia_css_rmgr_vbuf_handle **handle)
 			}
 		}
 		/* if the loop dus not break and *handle == NULL
-		   this is an error handle and report it.
+		 * this is an error handle and report it.
 		 */
 		if (!*handle) {
 			ia_css_debug_dtrace(IA_CSS_DEBUG_ERROR,
@@ -253,7 +253,8 @@ void rmgr_pop_handle(struct ia_css_rmgr_vbuf_pool *pool,
 			*handle = pool->handles[i];
 			pool->handles[i] = NULL;
 			/* dont release, we are returning it...
-			   ia_css_rmgr_refcount_release_vbuf(handle); */
+			 * ia_css_rmgr_refcount_release_vbuf(handle);
+			 */
 			return;
 		}
 	}
-- 
2.20.1

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2020-12-07 19:31 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-07 19:26 [PATCH 00/12] media: atomisp: Codingstyle Philipp Gerlesberger
2020-12-07 19:26 ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 01/12] media: atomsip: Convert comments to C99 initializers Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-08 10:21   ` Dan Carpenter
2020-12-08 10:21     ` Dan Carpenter
2020-12-07 19:26 ` Philipp Gerlesberger [this message]
2020-12-07 19:26   ` [PATCH 02/12] media: atomisp: Fix Block Comments Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 03/12] media: atomisp: Fix EMBEDDED_FUNCTION_NAME warning Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 04/12] media: atomisp: Fix OPEN_ENDED_LINE Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 05/12] media: atomisp: Fix overlong line Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 06/12] media: atomisp: Add parentheses Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-08 11:30   ` Dan Carpenter
2020-12-08 11:30     ` Dan Carpenter
2020-12-07 19:26 ` [PATCH 07/12] media: atomisp: Fix funciton decleration Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 08/12] media: atomisp: Delete braces Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 09/12] media: atomisp: Fix PARENTHESIS_ALIGNMENT Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 10/12] media: atomisp: Fix BLOCK_COMMENT_STYLE Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 11/12] media: atomisp: Write function decleration in one line Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger
2020-12-07 19:26 ` [PATCH 12/12] media: atomisp: Fix LOGICAL_CONTINUATIONS Philipp Gerlesberger
2020-12-07 19:26   ` Philipp Gerlesberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201207192638.15219-3-Philipp.Gerlesberger@fau.de \
    --to=philipp.gerlesberger@fau.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=ij72uhux@stud.informatik.uni-erlangen.de \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.