All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] quota: Fix error handling path of dquot_resume()
@ 2020-12-08 14:22 Jan Kara
  0 siblings, 0 replies; only message in thread
From: Jan Kara @ 2020-12-08 14:22 UTC (permalink / raw)
  To: linux-fsdevel; +Cc: Jan Kara, stable

When reloading of quota failed we tried to cleanup using
vfs_cleanup_quota_inode() however we passed wrong 'type' argument. Fix
that.

Fixes: ae45f07d47cc ("quota: Simplify dquot_resume()")
Reported-by: syzbot+2643e825238d7aabb37f@syzkaller.appspotmail.com
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/quota/dquot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I plan to queue this patch to my tree for the merge window.

								Honza

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index bb02989d92b6..4f1373463766 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -2455,7 +2455,7 @@ int dquot_resume(struct super_block *sb, int type)
 		ret = dquot_load_quota_sb(sb, cnt, dqopt->info[cnt].dqi_fmt_id,
 					  flags);
 		if (ret < 0)
-			vfs_cleanup_quota_inode(sb, type);
+			vfs_cleanup_quota_inode(sb, cnt);
 	}
 
 	return ret;
-- 
2.16.4


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-12-08 14:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 14:22 [PATCH] quota: Fix error handling path of dquot_resume() Jan Kara

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.