* [PATCH] media: ccs: Remove uninitialized, unused variable
@ 2020-12-09 6:52 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-12-09 6:52 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
The "reg" value isn't used any more but it's still printed in the
debug code. Delete it.
Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/i2c/ccs/ccs-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 4447ca367a84..7a461c0a730d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -268,7 +268,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
u32 pixels;
char *which;
char *what;
- u32 reg;
if (fmt_model_type == CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) {
desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i);
@@ -322,7 +321,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
}
dev_dbg(&client->dev,
- "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+ "%s pixels: %d %s (pixelcode %u)\n",
what, pixels, which, pixelcode);
if (i < ncol_desc) {
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] media: ccs: Remove uninitialized, unused variable
@ 2020-12-09 6:52 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2020-12-09 6:52 UTC (permalink / raw)
To: Sakari Ailus; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
The "reg" value isn't used any more but it's still printed in the
debug code. Delete it.
Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/media/i2c/ccs/ccs-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ccs/ccs-core.c b/drivers/media/i2c/ccs/ccs-core.c
index 4447ca367a84..7a461c0a730d 100644
--- a/drivers/media/i2c/ccs/ccs-core.c
+++ b/drivers/media/i2c/ccs/ccs-core.c
@@ -268,7 +268,6 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
u32 pixels;
char *which;
char *what;
- u32 reg;
if (fmt_model_type = CCS_FRAME_FORMAT_MODEL_TYPE_2_BYTE) {
desc = CCS_LIM_AT(sensor, FRAME_FORMAT_DESCRIPTOR, i);
@@ -322,7 +321,7 @@ static int ccs_read_frame_fmt(struct ccs_sensor *sensor)
}
dev_dbg(&client->dev,
- "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+ "%s pixels: %d %s (pixelcode %u)\n",
what, pixels, which, pixelcode);
if (i < ncol_desc) {
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ccs: Remove uninitialized, unused variable
2020-12-09 6:52 ` Dan Carpenter
@ 2020-12-09 9:50 ` Sakari Ailus
-1 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2020-12-09 9:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
Hi Dan,
On Wed, Dec 09, 2020 at 09:52:36AM +0300, Dan Carpenter wrote:
> The "reg" value isn't used any more but it's still printed in the
> debug code. Delete it.
>
> Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch. This has been already fixed by another patch:
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20201203222828.1029943-1-arnd@kernel.org/>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: ccs: Remove uninitialized, unused variable
@ 2020-12-09 9:50 ` Sakari Ailus
0 siblings, 0 replies; 4+ messages in thread
From: Sakari Ailus @ 2020-12-09 9:50 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, linux-media, kernel-janitors
Hi Dan,
On Wed, Dec 09, 2020 at 09:52:36AM +0300, Dan Carpenter wrote:
> The "reg" value isn't used any more but it's still printed in the
> debug code. Delete it.
>
> Fixes: fd9065812c7b ("media: smiapp: Obtain frame descriptor from CCS limits")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you for the patch. This has been already fixed by another patch:
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20201203222828.1029943-1-arnd@kernel.org/>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-09 9:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 6:52 [PATCH] media: ccs: Remove uninitialized, unused variable Dan Carpenter
2020-12-09 6:52 ` Dan Carpenter
2020-12-09 9:50 ` Sakari Ailus
2020-12-09 9:50 ` Sakari Ailus
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.