* [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-09 18:13 ` Anant Thazhemadam
0 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-09 18:13 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, linux-kernel, Anant Thazhemadam,
syzbot+ca9a785f8ac472085994
In sanity_check_raw_super(), if
1 << le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE, then the
block size is deemed to be invalid.
syzbot triggered a shift-out-of-bounds bug by assigning a value of 59 to
le32_to_cpu(raw_super->log_blocksize).
Although the value assigned itself isn't of much significance, this goes
to show that even if the block size is invalid,
le32_to_cpu(raw_super->log_blocksize) can be potentially evaluated to a
value for which the shift exponent becomes too large for the unsigned
int.
Since 1 << le32_to_cpu(raw_super->log_blocksize) must be = 4096 for a
valid block size, le32_to_cpu(raw_super->log_blocksize) must equal 12.
Replacing the existing check with the more direct sanity check
resolves this bug.
Reported-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
Tested-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
fs/f2fs/super.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 33808c397580..4bc7372af43f 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2775,7 +2775,6 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
block_t total_sections, blocks_per_seg;
struct f2fs_super_block *raw_super = (struct f2fs_super_block *)
(bh->b_data + F2FS_SUPER_OFFSET);
- unsigned int blocksize;
size_t crc_offset = 0;
__u32 crc = 0;
@@ -2802,10 +2801,8 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
}
/* Currently, support only 4KB block size */
- blocksize = 1 << le32_to_cpu(raw_super->log_blocksize);
- if (blocksize != F2FS_BLKSIZE) {
- f2fs_info(sbi, "Invalid blocksize (%u), supports only 4KB",
- blocksize);
+ if (le32_to_cpu(raw_super->log_blocksize) != 12) {
+ f2fs_info(sbi, "Invalid blocksize. Only 4KB supported");
return -EFSCORRUPTED;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-09 18:13 ` Anant Thazhemadam
0 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-09 18:13 UTC (permalink / raw)
To: Jaegeuk Kim, Chao Yu
Cc: syzbot+ca9a785f8ac472085994, Anant Thazhemadam, linux-kernel,
linux-f2fs-devel
In sanity_check_raw_super(), if
1 << le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE, then the
block size is deemed to be invalid.
syzbot triggered a shift-out-of-bounds bug by assigning a value of 59 to
le32_to_cpu(raw_super->log_blocksize).
Although the value assigned itself isn't of much significance, this goes
to show that even if the block size is invalid,
le32_to_cpu(raw_super->log_blocksize) can be potentially evaluated to a
value for which the shift exponent becomes too large for the unsigned
int.
Since 1 << le32_to_cpu(raw_super->log_blocksize) must be = 4096 for a
valid block size, le32_to_cpu(raw_super->log_blocksize) must equal 12.
Replacing the existing check with the more direct sanity check
resolves this bug.
Reported-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
Tested-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
---
fs/f2fs/super.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 33808c397580..4bc7372af43f 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -2775,7 +2775,6 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
block_t total_sections, blocks_per_seg;
struct f2fs_super_block *raw_super = (struct f2fs_super_block *)
(bh->b_data + F2FS_SUPER_OFFSET);
- unsigned int blocksize;
size_t crc_offset = 0;
__u32 crc = 0;
@@ -2802,10 +2801,8 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
}
/* Currently, support only 4KB block size */
- blocksize = 1 << le32_to_cpu(raw_super->log_blocksize);
- if (blocksize != F2FS_BLKSIZE) {
- f2fs_info(sbi, "Invalid blocksize (%u), supports only 4KB",
- blocksize);
+ if (le32_to_cpu(raw_super->log_blocksize) != 12) {
+ f2fs_info(sbi, "Invalid blocksize. Only 4KB supported");
return -EFSCORRUPTED;
}
--
2.25.1
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-09 18:13 ` [f2fs-dev] " Anant Thazhemadam
@ 2020-12-10 1:46 ` Chao Yu
-1 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 1:46 UTC (permalink / raw)
To: Anant Thazhemadam, Jaegeuk Kim, Chao Yu
Cc: syzbot+ca9a785f8ac472085994, linux-kernel, linux-f2fs-devel
Hi Anant,
I've posted a patch a little earlier. :P
https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
Thanks,
On 2020/12/10 2:13, Anant Thazhemadam wrote:
> In sanity_check_raw_super(), if
> 1 << le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE, then the
> block size is deemed to be invalid.
>
> syzbot triggered a shift-out-of-bounds bug by assigning a value of 59 to
> le32_to_cpu(raw_super->log_blocksize).
> Although the value assigned itself isn't of much significance, this goes
> to show that even if the block size is invalid,
> le32_to_cpu(raw_super->log_blocksize) can be potentially evaluated to a
> value for which the shift exponent becomes too large for the unsigned
> int.
>
> Since 1 << le32_to_cpu(raw_super->log_blocksize) must be = 4096 for a
> valid block size, le32_to_cpu(raw_super->log_blocksize) must equal 12.
> Replacing the existing check with the more direct sanity check
> resolves this bug.
>
> Reported-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
> Tested-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> fs/f2fs/super.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 33808c397580..4bc7372af43f 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2775,7 +2775,6 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
> block_t total_sections, blocks_per_seg;
> struct f2fs_super_block *raw_super = (struct f2fs_super_block *)
> (bh->b_data + F2FS_SUPER_OFFSET);
> - unsigned int blocksize;
> size_t crc_offset = 0;
> __u32 crc = 0;
>
> @@ -2802,10 +2801,8 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
> }
>
> /* Currently, support only 4KB block size */
> - blocksize = 1 << le32_to_cpu(raw_super->log_blocksize);
> - if (blocksize != F2FS_BLKSIZE) {
> - f2fs_info(sbi, "Invalid blocksize (%u), supports only 4KB",
> - blocksize);
> + if (le32_to_cpu(raw_super->log_blocksize) != 12) {
> + f2fs_info(sbi, "Invalid blocksize. Only 4KB supported");
> return -EFSCORRUPTED;
> }
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 1:46 ` Chao Yu
0 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 1:46 UTC (permalink / raw)
To: Anant Thazhemadam, Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, syzbot+ca9a785f8ac472085994, linux-kernel
Hi Anant,
I've posted a patch a little earlier. :P
https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
Thanks,
On 2020/12/10 2:13, Anant Thazhemadam wrote:
> In sanity_check_raw_super(), if
> 1 << le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE, then the
> block size is deemed to be invalid.
>
> syzbot triggered a shift-out-of-bounds bug by assigning a value of 59 to
> le32_to_cpu(raw_super->log_blocksize).
> Although the value assigned itself isn't of much significance, this goes
> to show that even if the block size is invalid,
> le32_to_cpu(raw_super->log_blocksize) can be potentially evaluated to a
> value for which the shift exponent becomes too large for the unsigned
> int.
>
> Since 1 << le32_to_cpu(raw_super->log_blocksize) must be = 4096 for a
> valid block size, le32_to_cpu(raw_super->log_blocksize) must equal 12.
> Replacing the existing check with the more direct sanity check
> resolves this bug.
>
> Reported-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
> Tested-by: syzbot+ca9a785f8ac472085994@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> fs/f2fs/super.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 33808c397580..4bc7372af43f 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -2775,7 +2775,6 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
> block_t total_sections, blocks_per_seg;
> struct f2fs_super_block *raw_super = (struct f2fs_super_block *)
> (bh->b_data + F2FS_SUPER_OFFSET);
> - unsigned int blocksize;
> size_t crc_offset = 0;
> __u32 crc = 0;
>
> @@ -2802,10 +2801,8 @@ static int sanity_check_raw_super(struct f2fs_sb_info *sbi,
> }
>
> /* Currently, support only 4KB block size */
> - blocksize = 1 << le32_to_cpu(raw_super->log_blocksize);
> - if (blocksize != F2FS_BLKSIZE) {
> - f2fs_info(sbi, "Invalid blocksize (%u), supports only 4KB",
> - blocksize);
> + if (le32_to_cpu(raw_super->log_blocksize) != 12) {
> + f2fs_info(sbi, "Invalid blocksize. Only 4KB supported");
> return -EFSCORRUPTED;
> }
>
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-10 1:46 ` Chao Yu
@ 2020-12-10 2:00 ` Anant Thazhemadam
-1 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-10 2:00 UTC (permalink / raw)
To: Chao Yu, Jaegeuk Kim, Chao Yu
Cc: syzbot+ca9a785f8ac472085994, linux-kernel, linux-f2fs-devel
On 10/12/20 7:16 am, Chao Yu wrote:
> Hi Anant,
>
> I've posted a patch a little earlier. :P
>
> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>
Ah well, that's alright, especially considering that your patch looks better.
Glad that bug has been fixed nonetheless. :)
Cheers,
Anant
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 2:00 ` Anant Thazhemadam
0 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-10 2:00 UTC (permalink / raw)
To: Chao Yu, Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, syzbot+ca9a785f8ac472085994, linux-kernel
On 10/12/20 7:16 am, Chao Yu wrote:
> Hi Anant,
>
> I've posted a patch a little earlier. :P
>
> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>
Ah well, that's alright, especially considering that your patch looks better.
Glad that bug has been fixed nonetheless. :)
Cheers,
Anant
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-10 2:00 ` Anant Thazhemadam
@ 2020-12-10 2:10 ` Chao Yu
-1 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 2:10 UTC (permalink / raw)
To: Anant Thazhemadam, Jaegeuk Kim, Chao Yu
Cc: syzbot+ca9a785f8ac472085994, linux-kernel, linux-f2fs-devel
On 2020/12/10 10:00, Anant Thazhemadam wrote:
>
> On 10/12/20 7:16 am, Chao Yu wrote:
>> Hi Anant,
>>
>> I've posted a patch a little earlier. :P
>>
>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>
> Ah well, that's alright, especially considering that your patch looks better.
> Glad that bug has been fixed nonetheless. :)
Anyway, thanks a lot for taking time to fix f2fs bug. :)
I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
in sanity_check_raw_super()" if you don't mind.
Thanks,
>
> Cheers,
> Anant
> .
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 2:10 ` Chao Yu
0 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 2:10 UTC (permalink / raw)
To: Anant Thazhemadam, Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, syzbot+ca9a785f8ac472085994, linux-kernel
On 2020/12/10 10:00, Anant Thazhemadam wrote:
>
> On 10/12/20 7:16 am, Chao Yu wrote:
>> Hi Anant,
>>
>> I've posted a patch a little earlier. :P
>>
>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>
> Ah well, that's alright, especially considering that your patch looks better.
> Glad that bug has been fixed nonetheless. :)
Anyway, thanks a lot for taking time to fix f2fs bug. :)
I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
in sanity_check_raw_super()" if you don't mind.
Thanks,
>
> Cheers,
> Anant
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-10 2:10 ` Chao Yu
@ 2020-12-10 2:14 ` Anant Thazhemadam
-1 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-10 2:14 UTC (permalink / raw)
To: Chao Yu, Jaegeuk Kim, Chao Yu
Cc: syzbot+ca9a785f8ac472085994, linux-kernel, linux-f2fs-devel
On 10/12/20 7:40 am, Chao Yu wrote:
> On 2020/12/10 10:00, Anant Thazhemadam wrote:
>>
>> On 10/12/20 7:16 am, Chao Yu wrote:
>>> Hi Anant,
>>>
>>> I've posted a patch a little earlier. :P
>>>
>>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>>
>> Ah well, that's alright, especially considering that your patch looks better.
>> Glad that bug has been fixed nonetheless. :)
>
> Anyway, thanks a lot for taking time to fix f2fs bug. :)
>
> I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
> in sanity_check_raw_super()" if you don't mind.
>
>
Sure, I'd appreciate that. Thank you! :D
Thanks,
Anant
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 2:14 ` Anant Thazhemadam
0 siblings, 0 replies; 14+ messages in thread
From: Anant Thazhemadam @ 2020-12-10 2:14 UTC (permalink / raw)
To: Chao Yu, Jaegeuk Kim, Chao Yu
Cc: linux-f2fs-devel, syzbot+ca9a785f8ac472085994, linux-kernel
On 10/12/20 7:40 am, Chao Yu wrote:
> On 2020/12/10 10:00, Anant Thazhemadam wrote:
>>
>> On 10/12/20 7:16 am, Chao Yu wrote:
>>> Hi Anant,
>>>
>>> I've posted a patch a little earlier. :P
>>>
>>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>>
>> Ah well, that's alright, especially considering that your patch looks better.
>> Glad that bug has been fixed nonetheless. :)
>
> Anyway, thanks a lot for taking time to fix f2fs bug. :)
>
> I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
> in sanity_check_raw_super()" if you don't mind.
>
>
Sure, I'd appreciate that. Thank you! :D
Thanks,
Anant
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-10 2:14 ` Anant Thazhemadam
@ 2020-12-10 5:57 ` Chao Yu
-1 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 5:57 UTC (permalink / raw)
To: Jaegeuk Kim
Cc: Anant Thazhemadam, Chao Yu, syzbot+ca9a785f8ac472085994,
linux-kernel, linux-f2fs-devel
Jaegeuk,
Could you please help to add signed-off of Anant manually in
f2fs: fix shift-out-of-bounds in sanity_check_raw_super()
Thanks,
On 2020/12/10 10:14, Anant Thazhemadam wrote:
>
> On 10/12/20 7:40 am, Chao Yu wrote:
>> On 2020/12/10 10:00, Anant Thazhemadam wrote:
>>>
>>> On 10/12/20 7:16 am, Chao Yu wrote:
>>>> Hi Anant,
>>>>
>>>> I've posted a patch a little earlier. :P
>>>>
>>>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>>>
>>> Ah well, that's alright, especially considering that your patch looks better.
>>> Glad that bug has been fixed nonetheless. :)
>>
>> Anyway, thanks a lot for taking time to fix f2fs bug. :)
>>
>> I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
>> in sanity_check_raw_super()" if you don't mind.
>>
>>
>
> Sure, I'd appreciate that. Thank you! :D
>
> Thanks,
> Anant
>
> .
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 5:57 ` Chao Yu
0 siblings, 0 replies; 14+ messages in thread
From: Chao Yu @ 2020-12-10 5:57 UTC (permalink / raw)
To: Jaegeuk Kim
Cc: Anant Thazhemadam, linux-f2fs-devel, syzbot+ca9a785f8ac472085994,
linux-kernel
Jaegeuk,
Could you please help to add signed-off of Anant manually in
f2fs: fix shift-out-of-bounds in sanity_check_raw_super()
Thanks,
On 2020/12/10 10:14, Anant Thazhemadam wrote:
>
> On 10/12/20 7:40 am, Chao Yu wrote:
>> On 2020/12/10 10:00, Anant Thazhemadam wrote:
>>>
>>> On 10/12/20 7:16 am, Chao Yu wrote:
>>>> Hi Anant,
>>>>
>>>> I've posted a patch a little earlier. :P
>>>>
>>>> https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
>>>>
>>> Ah well, that's alright, especially considering that your patch looks better.
>>> Glad that bug has been fixed nonetheless. :)
>>
>> Anyway, thanks a lot for taking time to fix f2fs bug. :)
>>
>> I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
>> in sanity_check_raw_super()" if you don't mind.
>>
>>
>
> Sure, I'd appreciate that. Thank you! :D
>
> Thanks,
> Anant
>
> .
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
2020-12-10 5:57 ` Chao Yu
@ 2020-12-10 17:14 ` Jaegeuk Kim
-1 siblings, 0 replies; 14+ messages in thread
From: Jaegeuk Kim @ 2020-12-10 17:14 UTC (permalink / raw)
To: Chao Yu
Cc: Anant Thazhemadam, Chao Yu, syzbot+ca9a785f8ac472085994,
linux-kernel, linux-f2fs-devel
On 12/10, Chao Yu wrote:
> Jaegeuk,
>
> Could you please help to add signed-off of Anant manually in
>
> f2fs: fix shift-out-of-bounds in sanity_check_raw_super()
Done. Thank you guys. :)
>
> Thanks,
>
> On 2020/12/10 10:14, Anant Thazhemadam wrote:
> >
> > On 10/12/20 7:40 am, Chao Yu wrote:
> > > On 2020/12/10 10:00, Anant Thazhemadam wrote:
> > > >
> > > > On 10/12/20 7:16 am, Chao Yu wrote:
> > > > > Hi Anant,
> > > > >
> > > > > I've posted a patch a little earlier. :P
> > > > >
> > > > > https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
> > > > >
> > > > Ah well, that's alright, especially considering that your patch looks better.
> > > > Glad that bug has been fixed nonetheless. :)
> > >
> > > Anyway, thanks a lot for taking time to fix f2fs bug. :)
> > >
> > > I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
> > > in sanity_check_raw_super()" if you don't mind.
> > >
> > >
> >
> > Sure, I'd appreciate that. Thank you! :D
> >
> > Thanks,
> > Anant
> >
> > .
> >
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [f2fs-dev] [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super()
@ 2020-12-10 17:14 ` Jaegeuk Kim
0 siblings, 0 replies; 14+ messages in thread
From: Jaegeuk Kim @ 2020-12-10 17:14 UTC (permalink / raw)
To: Chao Yu
Cc: Anant Thazhemadam, linux-f2fs-devel, syzbot+ca9a785f8ac472085994,
linux-kernel
On 12/10, Chao Yu wrote:
> Jaegeuk,
>
> Could you please help to add signed-off of Anant manually in
>
> f2fs: fix shift-out-of-bounds in sanity_check_raw_super()
Done. Thank you guys. :)
>
> Thanks,
>
> On 2020/12/10 10:14, Anant Thazhemadam wrote:
> >
> > On 10/12/20 7:40 am, Chao Yu wrote:
> > > On 2020/12/10 10:00, Anant Thazhemadam wrote:
> > > >
> > > > On 10/12/20 7:16 am, Chao Yu wrote:
> > > > > Hi Anant,
> > > > >
> > > > > I've posted a patch a little earlier. :P
> > > > >
> > > > > https://lore.kernel.org/linux-f2fs-devel/20201209084936.31711-1-yuchao0@huawei.com/T/#u
> > > > >
> > > > Ah well, that's alright, especially considering that your patch looks better.
> > > > Glad that bug has been fixed nonetheless. :)
> > >
> > > Anyway, thanks a lot for taking time to fix f2fs bug. :)
> > >
> > > I prefer to add your Signed-off-by into "f2fs: fix shift-out-of-bounds
> > > in sanity_check_raw_super()" if you don't mind.
> > >
> > >
> >
> > Sure, I'd appreciate that. Thank you! :D
> >
> > Thanks,
> > Anant
> >
> > .
> >
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2020-12-10 17:15 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 18:13 [PATCH] fs: f2fs: fix potential shift-out-of-bounds error in sanity_check_raw_super() Anant Thazhemadam
2020-12-09 18:13 ` [f2fs-dev] " Anant Thazhemadam
2020-12-10 1:46 ` Chao Yu
2020-12-10 1:46 ` Chao Yu
2020-12-10 2:00 ` Anant Thazhemadam
2020-12-10 2:00 ` Anant Thazhemadam
2020-12-10 2:10 ` Chao Yu
2020-12-10 2:10 ` Chao Yu
2020-12-10 2:14 ` Anant Thazhemadam
2020-12-10 2:14 ` Anant Thazhemadam
2020-12-10 5:57 ` Chao Yu
2020-12-10 5:57 ` Chao Yu
2020-12-10 17:14 ` Jaegeuk Kim
2020-12-10 17:14 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.