* [ebiggers:mmc-crypto-testing 65/134] drivers/media/platform/qcom/venus/pm_helpers.c:496:12: warning: address of array 'core->vcodec1_clks' will always evaluate to 'true'
@ 2020-12-09 12:13 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2020-12-09 12:13 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3464 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git mmc-crypto-testing
head: 59de920e6312f7cf742790b1aa61a1385493d66e
commit: 460c48b4bc5b927be00c9b839386f3a91055242d [65/134] media: venus: pm_helper: Commonize v3/v4 pmdomains and clocks management
config: x86_64-randconfig-a004-20201209 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1968804ac726e7674d5de22bc2204b45857da344)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/commit/?id=460c48b4bc5b927be00c9b839386f3a91055242d
git remote add ebiggers https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git
git fetch --no-tags ebiggers mmc-crypto-testing
git checkout 460c48b4bc5b927be00c9b839386f3a91055242d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/media/platform/qcom/venus/pm_helpers.c:496:12: warning: address of array 'core->vcodec1_clks' will always evaluate to 'true' [-Wpointer-bool-conversion]
if (core->vcodec1_clks) {
~~ ~~~~~~^~~~~~~~~~~~
1 warning generated.
vim +496 drivers/media/platform/qcom/venus/pm_helpers.c
476
477 static int core_get_v4(struct device *dev)
478 {
479 struct venus_core *core = dev_get_drvdata(dev);
480 const struct venus_resources *res = core->res;
481 int ret;
482
483 ret = core_clks_get(core);
484 if (ret)
485 return ret;
486
487 if (!res->vcodec_pmdomains_num)
488 legacy_binding = true;
489
490 dev_info(dev, "%s legacy binding\n", legacy_binding ? "" : "non");
491
492 ret = vcodec_clks_get(core, dev, core->vcodec0_clks, res->vcodec0_clks);
493 if (ret)
494 return ret;
495
> 496 if (core->vcodec1_clks) {
497 ret = vcodec_clks_get(core, dev,
498 core->vcodec1_clks, res->vcodec1_clks);
499 if (ret)
500 return ret;
501 }
502
503 if (legacy_binding)
504 return 0;
505
506 core->opp_table = dev_pm_opp_set_clkname(dev, "core");
507 if (IS_ERR(core->opp_table))
508 return PTR_ERR(core->opp_table);
509
510 if (core->res->opp_pmdomain) {
511 ret = dev_pm_opp_of_add_table(dev);
512 if (!ret) {
513 core->has_opp_table = true;
514 } else if (ret != -ENODEV) {
515 dev_err(dev, "invalid OPP table in device tree\n");
516 dev_pm_opp_put_clkname(core->opp_table);
517 return ret;
518 }
519 }
520
521 ret = vcodec_domains_get(dev);
522 if (ret) {
523 if (core->has_opp_table)
524 dev_pm_opp_of_remove_table(dev);
525 dev_pm_opp_put_clkname(core->opp_table);
526 return ret;
527 }
528
529 return 0;
530 }
531
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 40550 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-09 12:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 12:13 [ebiggers:mmc-crypto-testing 65/134] drivers/media/platform/qcom/venus/pm_helpers.c:496:12: warning: address of array 'core->vcodec1_clks' will always evaluate to 'true' kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.