* [PATCH -next] c6x: fix build of signal.c using _TIF_SIGNALs
@ 2020-12-10 3:17 Randy Dunlap
2020-12-12 16:17 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-12-10 3:17 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, linux-c6x-dev, Jens Axboe, Mark Salter, Aurelien Jacquiot
kernel/signal.c in arch/c6x/ needs <asm/asm-offsets.h> to build
since it contains _TIF_SIGNALfoobar #defines, so add it.
Placates these build errors:
../arch/c6x/kernel/signal.c: In function 'do_notify_resume':
../arch/c6x/kernel/signal.c:316:27: error: '_TIF_SIGPENDING' undeclared (first use in this function); did you mean 'TIF_SIGPENDING'?
316 | if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
| ^~~~~~~~~~~~~~~
../arch/c6x/kernel/signal.c:316:27: note: each undeclared identifier is reported only once for each function it appears in
../arch/c6x/kernel/signal.c:316:45: error: '_TIF_NOTIFY_SIGNAL' undeclared (first use in this function); did you mean 'TIF_NOTIFY_SIGNAL'?
316 | if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
| ^~~~~~~~~~~~~~~~~~
Fixes: b7560cfc3f8a ("c6x: add support for TIF_NOTIFY_SIGNAL")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-c6x-dev@linux-c6x.org
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Mark Salter <msalter@redhat.com>
Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
---
arch/c6x/kernel/signal.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20201209.orig/arch/c6x/kernel/signal.c
+++ linux-next-20201209/arch/c6x/kernel/signal.c
@@ -13,6 +13,7 @@
#include <linux/syscalls.h>
#include <linux/tracehook.h>
+#include <asm/asm-offsets.h>
#include <asm/ucontext.h>
#include <asm/cacheflush.h>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] c6x: fix build of signal.c using _TIF_SIGNALs
2020-12-10 3:17 [PATCH -next] c6x: fix build of signal.c using _TIF_SIGNALs Randy Dunlap
@ 2020-12-12 16:17 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-12-12 16:17 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: linux-c6x-dev, Mark Salter, Aurelien Jacquiot
On 12/9/20 8:17 PM, Randy Dunlap wrote:
> kernel/signal.c in arch/c6x/ needs <asm/asm-offsets.h> to build
> since it contains _TIF_SIGNALfoobar #defines, so add it.
>
> Placates these build errors:
>
> ../arch/c6x/kernel/signal.c: In function 'do_notify_resume':
> ../arch/c6x/kernel/signal.c:316:27: error: '_TIF_SIGPENDING' undeclared (first use in this function); did you mean 'TIF_SIGPENDING'?
> 316 | if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
> | ^~~~~~~~~~~~~~~
> ../arch/c6x/kernel/signal.c:316:27: note: each undeclared identifier is reported only once for each function it appears in
> ../arch/c6x/kernel/signal.c:316:45: error: '_TIF_NOTIFY_SIGNAL' undeclared (first use in this function); did you mean 'TIF_NOTIFY_SIGNAL'?
> 316 | if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
> | ^~~~~~~~~~~~~~~~~~
Thanks Randy, folded in.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-12 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 3:17 [PATCH -next] c6x: fix build of signal.c using _TIF_SIGNALs Randy Dunlap
2020-12-12 16:17 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.