* [PATCH] drivers/iommu: fix a null-ptr-deref bug in msm_iommu.c
@ 2020-12-06 9:43 tangzhenhao
2020-12-10 9:13 ` Will Deacon
0 siblings, 1 reply; 2+ messages in thread
From: tangzhenhao @ 2020-12-06 9:43 UTC (permalink / raw)
To: iommu; +Cc: tangzhenhao
At line 600 in drivers/iommu/msm_iommu.c, the ret-val of kzalloc should be checked to avoid null-ptr-deref bug.
Signed-off-by: tangzhenhao <tzh18@mails.tsinghua.edu.cn>
---
drivers/iommu/msm_iommu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 3615cd6241c4..e3c576e5babb 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -598,6 +598,10 @@ static void insert_iommu_master(struct device *dev,
if (list_empty(&(*iommu)->ctx_list)) {
master = kzalloc(sizeof(*master), GFP_ATOMIC);
+ if (!master) {
+ dev_err(dev, "Failed to allocate IOMMU context bank instance\n");
+ return;
+ }
master->of_node = dev->of_node;
list_add(&master->list, &(*iommu)->ctx_list);
dev_iommu_priv_set(dev, master);
--
2.17.1
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/iommu: fix a null-ptr-deref bug in msm_iommu.c
2020-12-06 9:43 [PATCH] drivers/iommu: fix a null-ptr-deref bug in msm_iommu.c tangzhenhao
@ 2020-12-10 9:13 ` Will Deacon
0 siblings, 0 replies; 2+ messages in thread
From: Will Deacon @ 2020-12-10 9:13 UTC (permalink / raw)
To: tangzhenhao; +Cc: iommu
On Sun, Dec 06, 2020 at 01:43:51AM -0800, tangzhenhao wrote:
> At line 600 in drivers/iommu/msm_iommu.c, the ret-val of kzalloc should be checked to avoid null-ptr-deref bug.
There's no need to mention the line number of the file name in the commit
message -- that information is already available in the diff. Instead,
please try to describe the problem that you're solving.
Have a look at Documentation/process/submitting-patches.rst.
> Signed-off-by: tangzhenhao <tzh18@mails.tsinghua.edu.cn>
> ---
> drivers/iommu/msm_iommu.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
> index 3615cd6241c4..e3c576e5babb 100644
> --- a/drivers/iommu/msm_iommu.c
> +++ b/drivers/iommu/msm_iommu.c
> @@ -598,6 +598,10 @@ static void insert_iommu_master(struct device *dev,
>
> if (list_empty(&(*iommu)->ctx_list)) {
> master = kzalloc(sizeof(*master), GFP_ATOMIC);
> + if (!master) {
> + dev_err(dev, "Failed to allocate IOMMU context bank instance\n");
No need to print an error here -- kzalloc should be plenty noisy enough
if an atomic allocation fails.
> + return;
Hmm, and then what? We haven't propagated the error, so how much further do
we get?
Will
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-10 9:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-06 9:43 [PATCH] drivers/iommu: fix a null-ptr-deref bug in msm_iommu.c tangzhenhao
2020-12-10 9:13 ` Will Deacon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.