Re: [PATCH 1/2] Add support for Cadence XSPI controller

From: kernel test robot <lkp@intel.com>
To: Jayshri Pawar <jpawar@cadence.com>, linux-spi@vger.kernel.org
Cc: kbuild-all@lists.01.org, miquel.raynal@bootlin.com,
	richard@nod.at, vigneshr@ti.com, linux-kernel@vger.kernel.org,
	dkangude@cadence.com, mparab@cadence.com, sjakhade@cadence.com,
	jpawar@cadence.com, Konrad Kociolek <konrad@cadence.com>
Subject: Re: [PATCH 1/2] Add support for Cadence XSPI controller
Date: Thu, 10 Dec 2020 18:33:22 +0800	[thread overview]
Message-ID: <202012101849.GkeCyuSL-lkp@intel.com> (raw)
In-Reply-To: <1607500678-23862-2-git-send-email-jpawar@cadence.com>

[-- Attachment #1: Type: text/plain, Size: 2693 bytes --]

Hi Jayshri,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on spi/for-next]
[also build test WARNING on v5.10-rc7 next-20201209]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Jayshri-Pawar/Driver-for-Cadence-xSPI-flash-controller/20201209-160406
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
config: arm-randconfig-r006-20201210 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/5b258ff21564ca007e3b54d865c3cfb9851ed00a
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Jayshri-Pawar/Driver-for-Cadence-xSPI-flash-controller/20201209-160406
        git checkout 5b258ff21564ca007e3b54d865c3cfb9851ed00a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/io.h:13,
                    from drivers/spi/spi-cadence-xspi.c:15:
   drivers/spi/spi-cadence-xspi.c: In function 'cdns_xspi_send_stig_command':
>> arch/arm/include/asm/io.h:95:2: warning: '*((void *)&cmd_regs+20)' is used uninitialized in this function [-Wuninitialized]
      95 |  asm volatile("str %1, %0"
         |  ^~~
   drivers/spi/spi-cadence-xspi.c:521:6: note: '*((void *)&cmd_regs+20)' was declared here
     521 |  u32 cmd_regs[5] = {0};
         |      ^~~~~~~~

vim +95 arch/arm/include/asm/io.h

195bbcac2e5c12f Will Deacon    2012-08-24  91  
84c4d3a6d438f59 Thierry Reding 2014-07-28  92  #define __raw_writel __raw_writel
195bbcac2e5c12f Will Deacon    2012-08-24  93  static inline void __raw_writel(u32 val, volatile void __iomem *addr)
195bbcac2e5c12f Will Deacon    2012-08-24  94  {
195bbcac2e5c12f Will Deacon    2012-08-24 @95  	asm volatile("str %1, %0"
5bb5d66d89041b7 Peter Hurley   2015-04-13  96  		     : : "Qo" (*(volatile u32 __force *)addr), "r" (val));
195bbcac2e5c12f Will Deacon    2012-08-24  97  }
195bbcac2e5c12f Will Deacon    2012-08-24  98  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28313 bytes --]