* [PATCH -next] fs/omfs: convert comma to semicolon
@ 2020-12-11 8:40 Zheng Yongjun
2020-12-11 12:22 ` Jeff Layton
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-11 8:40 UTC (permalink / raw)
To: jlayton, idryomov; +Cc: ceph-devel, linux-kernel, Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
fs/omfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/omfs/file.c b/fs/omfs/file.c
index 2c7b70ee1388..fc6828f30f60 100644
--- a/fs/omfs/file.c
+++ b/fs/omfs/file.c
@@ -22,8 +22,8 @@ void omfs_make_empty_table(struct buffer_head *bh, int offset)
struct omfs_extent *oe = (struct omfs_extent *) &bh->b_data[offset];
oe->e_next = ~cpu_to_be64(0ULL);
- oe->e_extent_count = cpu_to_be32(1),
- oe->e_fill = cpu_to_be32(0x22),
+ oe->e_extent_count = cpu_to_be32(1);
+ oe->e_fill = cpu_to_be32(0x22);
oe->e_entry.e_cluster = ~cpu_to_be64(0ULL);
oe->e_entry.e_blocks = ~cpu_to_be64(0ULL);
}
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] fs/omfs: convert comma to semicolon
2020-12-11 8:40 [PATCH -next] fs/omfs: convert comma to semicolon Zheng Yongjun
@ 2020-12-11 12:22 ` Jeff Layton
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Layton @ 2020-12-11 12:22 UTC (permalink / raw)
To: Zheng Yongjun, idryomov; +Cc: ceph-devel, linux-kernel, me, linux-karma-devel
On Fri, 2020-12-11 at 16:40 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> fs/omfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/omfs/file.c b/fs/omfs/file.c
> index 2c7b70ee1388..fc6828f30f60 100644
> --- a/fs/omfs/file.c
> +++ b/fs/omfs/file.c
> @@ -22,8 +22,8 @@ void omfs_make_empty_table(struct buffer_head *bh, int offset)
> struct omfs_extent *oe = (struct omfs_extent *) &bh->b_data[offset];
>
>
> oe->e_next = ~cpu_to_be64(0ULL);
> - oe->e_extent_count = cpu_to_be32(1),
> - oe->e_fill = cpu_to_be32(0x22),
> + oe->e_extent_count = cpu_to_be32(1);
> + oe->e_fill = cpu_to_be32(0x22);
> oe->e_entry.e_cluster = ~cpu_to_be64(0ULL);
> oe->e_entry.e_blocks = ~cpu_to_be64(0ULL);
> }
(cc'ing Bob Copeland and linux-karma mailing list)
Looks fine, but this patch isn't related to ceph in any way. See
Documentation/filesystems/omfs.rst for a description of OMFS.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] fs/omfs: convert comma to semicolon
2020-12-11 8:39 Zheng Yongjun
@ 2020-12-13 21:30 ` Bob Copeland
0 siblings, 0 replies; 4+ messages in thread
From: Bob Copeland @ 2020-12-13 21:30 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: linux-fsdevel
On Fri, Dec 11, 2020 at 04:39:30PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
As I do not run a git tree specifically for OMFS, this should
probably go through vfs tree.
> ---
> fs/omfs/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/omfs/file.c b/fs/omfs/file.c
> index 2c7b70ee1388..fc6828f30f60 100644
> --- a/fs/omfs/file.c
> +++ b/fs/omfs/file.c
> @@ -22,8 +22,8 @@ void omfs_make_empty_table(struct buffer_head *bh, int offset)
> struct omfs_extent *oe = (struct omfs_extent *) &bh->b_data[offset];
>
> oe->e_next = ~cpu_to_be64(0ULL);
> - oe->e_extent_count = cpu_to_be32(1),
> - oe->e_fill = cpu_to_be32(0x22),
> + oe->e_extent_count = cpu_to_be32(1);
> + oe->e_fill = cpu_to_be32(0x22);
> oe->e_entry.e_cluster = ~cpu_to_be64(0ULL);
> oe->e_entry.e_blocks = ~cpu_to_be64(0ULL);
> }
> --
> 2.22.0
--
Bob Copeland %% https://bobcopeland.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] fs/omfs: convert comma to semicolon
@ 2020-12-11 8:39 Zheng Yongjun
2020-12-13 21:30 ` Bob Copeland
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Yongjun @ 2020-12-11 8:39 UTC (permalink / raw)
To: me; +Cc: linux-karma-devel, linux-kernel, Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
fs/omfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/omfs/file.c b/fs/omfs/file.c
index 2c7b70ee1388..fc6828f30f60 100644
--- a/fs/omfs/file.c
+++ b/fs/omfs/file.c
@@ -22,8 +22,8 @@ void omfs_make_empty_table(struct buffer_head *bh, int offset)
struct omfs_extent *oe = (struct omfs_extent *) &bh->b_data[offset];
oe->e_next = ~cpu_to_be64(0ULL);
- oe->e_extent_count = cpu_to_be32(1),
- oe->e_fill = cpu_to_be32(0x22),
+ oe->e_extent_count = cpu_to_be32(1);
+ oe->e_fill = cpu_to_be32(0x22);
oe->e_entry.e_cluster = ~cpu_to_be64(0ULL);
oe->e_entry.e_blocks = ~cpu_to_be64(0ULL);
}
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-13 21:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 8:40 [PATCH -next] fs/omfs: convert comma to semicolon Zheng Yongjun
2020-12-11 12:22 ` Jeff Layton
-- strict thread matches above, loose matches on Subject: below --
2020-12-11 8:39 Zheng Yongjun
2020-12-13 21:30 ` Bob Copeland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.