* [PATCH -next] usb: typec: tcpm: convert comma to semicolon
@ 2020-12-11 8:55 Zheng Yongjun
2020-12-11 9:07 ` Heikki Krogerus
2020-12-11 15:10 ` Guenter Roeck
0 siblings, 2 replies; 3+ messages in thread
From: Zheng Yongjun @ 2020-12-11 8:55 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh, linux-usb, linux-kernel; +Cc: Zheng Yongjun
Replace a comma between expression statements by a semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/usb/typec/tcpm/tcpm.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index a6fae1f86505..4451507d600c 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -5024,14 +5024,14 @@ static int devm_tcpm_psy_register(struct tcpm_port *port)
snprintf(psy_name, psy_name_len, "%s%s", tcpm_psy_name_prefix,
port_dev_name);
port->psy_desc.name = psy_name;
- port->psy_desc.type = POWER_SUPPLY_TYPE_USB,
+ port->psy_desc.type = POWER_SUPPLY_TYPE_USB;
port->psy_desc.usb_types = tcpm_psy_usb_types;
port->psy_desc.num_usb_types = ARRAY_SIZE(tcpm_psy_usb_types);
- port->psy_desc.properties = tcpm_psy_props,
- port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props),
- port->psy_desc.get_property = tcpm_psy_get_prop,
- port->psy_desc.set_property = tcpm_psy_set_prop,
- port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable,
+ port->psy_desc.properties = tcpm_psy_props;
+ port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props);
+ port->psy_desc.get_property = tcpm_psy_get_prop;
+ port->psy_desc.set_property = tcpm_psy_set_prop;
+ port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable;
port->usb_type = POWER_SUPPLY_USB_TYPE_C;
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: tcpm: convert comma to semicolon
2020-12-11 8:55 [PATCH -next] usb: typec: tcpm: convert comma to semicolon Zheng Yongjun
@ 2020-12-11 9:07 ` Heikki Krogerus
2020-12-11 15:10 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Heikki Krogerus @ 2020-12-11 9:07 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: linux, gregkh, linux-usb, linux-kernel
On Fri, Dec 11, 2020 at 04:55:53PM +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index a6fae1f86505..4451507d600c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5024,14 +5024,14 @@ static int devm_tcpm_psy_register(struct tcpm_port *port)
> snprintf(psy_name, psy_name_len, "%s%s", tcpm_psy_name_prefix,
> port_dev_name);
> port->psy_desc.name = psy_name;
> - port->psy_desc.type = POWER_SUPPLY_TYPE_USB,
> + port->psy_desc.type = POWER_SUPPLY_TYPE_USB;
> port->psy_desc.usb_types = tcpm_psy_usb_types;
> port->psy_desc.num_usb_types = ARRAY_SIZE(tcpm_psy_usb_types);
> - port->psy_desc.properties = tcpm_psy_props,
> - port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props),
> - port->psy_desc.get_property = tcpm_psy_get_prop,
> - port->psy_desc.set_property = tcpm_psy_set_prop,
> - port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable,
> + port->psy_desc.properties = tcpm_psy_props;
> + port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props);
> + port->psy_desc.get_property = tcpm_psy_get_prop;
> + port->psy_desc.set_property = tcpm_psy_set_prop;
> + port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable;
>
> port->usb_type = POWER_SUPPLY_USB_TYPE_C;
>
> --
> 2.22.0
thanks,
--
heikki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] usb: typec: tcpm: convert comma to semicolon
2020-12-11 8:55 [PATCH -next] usb: typec: tcpm: convert comma to semicolon Zheng Yongjun
2020-12-11 9:07 ` Heikki Krogerus
@ 2020-12-11 15:10 ` Guenter Roeck
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2020-12-11 15:10 UTC (permalink / raw)
To: Zheng Yongjun, heikki.krogerus, gregkh, linux-usb, linux-kernel
On 12/11/20 12:55 AM, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index a6fae1f86505..4451507d600c 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -5024,14 +5024,14 @@ static int devm_tcpm_psy_register(struct tcpm_port *port)
> snprintf(psy_name, psy_name_len, "%s%s", tcpm_psy_name_prefix,
> port_dev_name);
> port->psy_desc.name = psy_name;
> - port->psy_desc.type = POWER_SUPPLY_TYPE_USB,
> + port->psy_desc.type = POWER_SUPPLY_TYPE_USB;
> port->psy_desc.usb_types = tcpm_psy_usb_types;
> port->psy_desc.num_usb_types = ARRAY_SIZE(tcpm_psy_usb_types);
> - port->psy_desc.properties = tcpm_psy_props,
> - port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props),
> - port->psy_desc.get_property = tcpm_psy_get_prop,
> - port->psy_desc.set_property = tcpm_psy_set_prop,
> - port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable,
> + port->psy_desc.properties = tcpm_psy_props;
> + port->psy_desc.num_properties = ARRAY_SIZE(tcpm_psy_props);
> + port->psy_desc.get_property = tcpm_psy_get_prop;
> + port->psy_desc.set_property = tcpm_psy_set_prop;
> + port->psy_desc.property_is_writeable = tcpm_psy_prop_writeable;
>
> port->usb_type = POWER_SUPPLY_USB_TYPE_C;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-11 15:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 8:55 [PATCH -next] usb: typec: tcpm: convert comma to semicolon Zheng Yongjun
2020-12-11 9:07 ` Heikki Krogerus
2020-12-11 15:10 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.