[linux-next:master 347/12554] drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:511:39-44: WARNING: conversion to bool not needed here

[linux-next:master 347/12554] drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:511:39-44: WARNING: conversion to bool not needed here

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Huang Rui <ray.huang@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   14240d4c5b25d087529691ccf4d7ea256f26cfdf
commit: 4d8d75a45c7ce7f6a0b9dff510be5be8e34febb4 [347/12554] drm/amdgpu: add mmhub v2.3 for vangogh (v4)
:::::: branch date: 17 hours ago
:::::: commit date: 9 weeks ago
config: i386-randconfig-c001-20201209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>


"coccinelle warnings: (new ones prefixed by >>)"
>> drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:511:39-44: WARNING: conversion to bool not needed here
   drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:513:39-44: WARNING: conversion to bool not needed here

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38815 bytes --]

[PATCH] drm/amdgpu: fix boolconv.cocci warnings

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 2092 bytes --]

CC: kbuild-all(a)lists.01.org
CC: Linux Memory Management List <linux-mm@kvack.org>
TO: Huang Rui <ray.huang@amd.com>
CC: Alex Deucher <alexander.deucher@amd.com>
CC: "Christian König" <christian.koenig@amd.com>
CC: David Airlie <airlied@linux.ie>
CC: Daniel Vetter <daniel@ffwll.ch>
CC: Luben Tuikov <luben.tuikov@amd.com>
CC: Hawking Zhang <Hawking.Zhang@amd.com>
CC: Liu ChengZhe <ChengZhe.Liu@amd.com>
CC: Likun Gao <Likun.Gao@amd.com>
CC: Jiansong Chen <Jiansong.Chen@amd.com>

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:511:39-44: WARNING: conversion to bool not needed here
drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c:513:39-44: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

Fixes: 4d8d75a45c7c ("drm/amdgpu: add mmhub v2.3 for vangogh (v4)")
CC: Huang Rui <ray.huang@amd.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   14240d4c5b25d087529691ccf4d7ea256f26cfdf
commit: 4d8d75a45c7ce7f6a0b9dff510be5be8e34febb4 [347/12554] drm/amdgpu: add mmhub v2.3 for vangogh (v4)
:::::: branch date: 17 hours ago
:::::: commit date: 9 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 mmhub_v2_3.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v2_3.c
@@ -508,9 +508,9 @@ static int mmhub_v2_3_set_clockgating(st
 		return 0;
 
 	mmhub_v2_3_update_medium_grain_clock_gating(adev,
-			state == AMD_CG_STATE_GATE ? true : false);
+			state == AMD_CG_STATE_GATE);
 	mmhub_v2_3_update_medium_grain_light_sleep(adev,
-			state == AMD_CG_STATE_GATE ? true : false);
+			state == AMD_CG_STATE_GATE);
 
 	return 0;
 }